157102 2016-04-27 14:25:55 -0700 Remove download message receiver when NetworkProcess crashes 2016-04-27 14:39:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1187954 0 achristensen 2016-04-27 14:25:55 -0700 Remove download message receiver when NetworkProcess crashes 1187956 1 277534 achristensen 2016-04-27 14:29:46 -0700 Created attachment 277534 Patch 1187957 2 277534 andersca 2016-04-27 14:34:23 -0700 Comment on attachment 277534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277534&action=review > Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp:75 > + for (auto it = m_downloads.begin(), end = m_downloads.end(); it != end; ++it) { > + it->value->processDidClose(); > + it->value->invalidate(); > + m_process->removeMessageReceiver(Messages::DownloadProxy::messageReceiverName(), it->key.downloadID()); > } You can get the a download ID from the download itself, no need to iterate both the keys and the values. Also, please use a modern for loop. 1187960 3 achristensen 2016-04-27 14:39:31 -0700 http://trac.webkit.org/changeset/200152 277534 2016-04-27 14:29:46 -0700 2016-04-27 14:34:23 -0700 Patch bug-157102-20160427143020.patch text/plain 1944 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDE1MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA0LTI3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGRv d25sb2FkIG1lc3NhZ2UgcmVjZWl2ZXIgd2hlbiBOZXR3b3JrUHJvY2VzcyBjcmFzaGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcxMDIKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzI1NTUwMTA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5 TWFwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQcm94eU1hcDo6cHJvY2Vzc0RpZENs b3NlKToKKyAgICAgICAgV2hlbiB0aGUgTmV0d29ya1Byb2Nlc3MgY3Jhc2hlcyBkdXJpbmcgYSBk b3dubG9hZCwgd2Ugd2FudCB0byByZW1vdmUgdGhlIG1lc3NhZ2UgcmVjZWl2ZXIgZnJvbSB0aGUg bWFwCisgICAgICAgIHNvIHdlIGRvbid0IGdldCBhbiBhc3NlcnRpb24gaW4gfk1lc3NhZ2VSZWNl aXZlciBpbiB0aGUgVUlQcm9jZXNzIHNvIHdlIGRvIG5vdCBoYXZlIGEgZnJlZWQKKyAgICAgICAg bWVzc2FnZSByZWNlaXZlciBpbiB0aGUgbWFwLgorCiAyMDE2LTA0LTI3ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGNsaWVudCBjZXJ0 aWZpY2F0ZSBhdXRoZW50aWNhdGlvbiB3aXRoIE5TVVJMU2Vzc2lvbiBvbiBpT1MKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eU1hcC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFBy b3h5TWFwLmNwcAkocmV2aXNpb24gMjAwMDQ1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjgsMTMg KzY4LDE0IEBAIHZvaWQgRG93bmxvYWRQcm94eU1hcDo6ZG93bmxvYWRGaW5pc2hlZCgKIHZvaWQg RG93bmxvYWRQcm94eU1hcDo6cHJvY2Vzc0RpZENsb3NlKCkKIHsKICAgICAvLyBJbnZhbGlkYXRl IGFsbCBvdXRzdGFuZGluZyBkb3dubG9hZHMuCi0gICAgZm9yIChhdXRvIGl0ID0gbV9kb3dubG9h ZHMuYmVnaW4oKS52YWx1ZXMoKSwgZW5kID0gbV9kb3dubG9hZHMuZW5kKCkudmFsdWVzKCk7IGl0 ICE9IGVuZDsgKytpdCkgewotICAgICAgICAoKml0KS0+cHJvY2Vzc0RpZENsb3NlKCk7Ci0gICAg ICAgICgqaXQpLT5pbnZhbGlkYXRlKCk7CisgICAgZm9yIChhdXRvIGl0ID0gbV9kb3dubG9hZHMu YmVnaW4oKSwgZW5kID0gbV9kb3dubG9hZHMuZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkgeworICAg ICAgICBpdC0+dmFsdWUtPnByb2Nlc3NEaWRDbG9zZSgpOworICAgICAgICBpdC0+dmFsdWUtPmlu dmFsaWRhdGUoKTsKKyAgICAgICAgbV9wcm9jZXNzLT5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVz c2FnZXM6OkRvd25sb2FkUHJveHk6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgaXQtPmtleS5kb3du bG9hZElEKCkpOwogICAgIH0KIAogICAgIG1fZG93bmxvYWRzLmNsZWFyKCk7Ci0gICAgbV9wcm9j ZXNzID0gMDsKKyAgICBtX3Byb2Nlc3MgPSBudWxscHRyOwogfQogCiB9IC8vIG5hbWVzcGFjZSBX ZWJLaXQK