<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>15710</bug_id>
          
          <creation_ts>2007-10-26 08:54:38 -0700</creation_ts>
          <short_desc>When QD plugins draw to an offscreen bitmap and the plugin is not at (0, 0) the clipping rectangle is not correct</short_desc>
          <delta_ts>2007-10-27 03:57:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Plug-ins</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://gmodules.com/ig/creator?synd=open&amp;url=http%3A//bejeweledg.googlecode.com/svn/trunk/bejeweled.xml&amp;pt=%26context%3Dd%26synd%3Dopen%26lang%3Den%26.lang%3Den%26country%3Dus%26.country%3Dus%26cat%3Dall%26num%3D1%26start%3D-1%26cols%3D1%26objs%3D0sN&amp;sn=0sN&amp;lang=en</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Mark Ambachtsheer">mark.a</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>59543</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Ambachtsheer">mark.a</who>
    <bug_when>2007-10-26 08:54:38 -0700</bug_when>
    <thetext>The code to render QD plugins on offscreen GWorlds does not account for the position of the plugin when calculating the clipping rectangle for the QD window.  This is apparent when using a Google Gadget like Bejeweled (URL attached) in an application that uses a WebKit view with an offscreen GWorld (i.e. not Safari).

This was not previously noticed because many widgets/gadgets/Flash videos place the plugin content at (0,0); Google Gadgets on the other hand place a text label above the plugin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59544</commentid>
    <comment_count>1</comment_count>
      <attachid>16880</attachid>
    <who name="Mark Ambachtsheer">mark.a</who>
    <bug_when>2007-10-26 09:01:21 -0700</bug_when>
    <thetext>Created attachment 16880
Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds.

This is a one-line change that should affect only applications that render to an offscreen GWorld (i.e. not Safari).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59547</commentid>
    <comment_count>2</comment_count>
      <attachid>16880</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-10-26 09:25:25 -0700</bug_when>
    <thetext>Comment on attachment 16880
Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds.

Looks fine, and I&apos;m assuming you tested it in your project.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59617</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-10-27 03:57:37 -0700</bug_when>
    <thetext>Landed in r27148.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>16880</attachid>
            <date>2007-10-26 09:01:21 -0700</date>
            <delta_ts>2007-10-26 09:25:25 -0700</delta_ts>
            <desc>Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds.</desc>
            <filename>15710.patch</filename>
            <type>text/plain</type>
            <size>1623</size>
            <attacher name="Mark Ambachtsheer">mark.a</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko
cmV2aXNpb24gMjcxMTEpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x
LDMgKzEsMTUgQEAKKzIwMDctMTAtMjYgIE1hcmsgQW1iYWNodHNoZWVyICA8bWFyay5hQGFwcGxl
LmNvbT4KKworICAgICAgICBGaXggZm9yIGJ1ZyAxNTcxMCwgV2hlbiBRRCBwbHVnaW5zIGRyYXcg
dG8gYW4gb2Zmc2NyZWVuIGJpdG1hcCBhbmQgdGhlIHBsdWdpbiBpcyBub3QgYXQgCisgICAgICAg
ICgwLCAwKSB0aGUgY2xpcHBpbmcgcmVjdGFuZ2xlIGlzIG5vdCBjb3JyZWN0LgorICAgICAgICBB
ZGRlZCB0aGUgb3JpZ2luIHRvIHRoZSB3aW5kb3cgY2xpcCByZWN0YW5nbGUgY29vcmRpbmF0ZXMg
dG8gYWNjb3VudCBmb3IgcGx1Z2lucyB0aGF0CisgICAgICAgIGRvbid0IG9yaWdpbmF0ZSBhdCAo
MCwwKTsgYWZmZWN0cyBjb2RlIGZvciBvZmZzY3JlZW4gR1dvcmxkcyBvbmx5LgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGx1Z2lucy9XZWJCYXNl
TmV0c2NhcGVQbHVnaW5WaWV3Lm1tOgorICAgICAgICAoLVtXZWJCYXNlTmV0c2NhcGVQbHVnaW5W
aWV3IHNhdmVBbmRTZXROZXdQb3J0U3RhdGVGb3JVcGRhdGU6XSk6CisKIDIwMDctMTAtMjUgIERh
dmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmb3IgYnVnIDE1Njcy
LCBiYWNrZ3JvdW5kcyBkb24ndCB0aWxlIHByb3Blcmx5IGluc2lkZSB0cmFuc2Zvcm1zLiAgVGhp
cyBwYXRjaCBmaXhlcyB0aWxpbmcKSW5kZXg6IFdlYktpdC9QbHVnaW5zL1dlYkJhc2VOZXRzY2Fw
ZVBsdWdpblZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L1BsdWdpbnMvV2ViQmFzZU5ldHNj
YXBlUGx1Z2luVmlldy5tbQkocmV2aXNpb24gMjcxMTEpCisrKyBXZWJLaXQvUGx1Z2lucy9XZWJC
YXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC00OTgsNyArNDk4LDcg
QEAgc3RhdGljIGlubGluZSB2b2lkIGdldE5QUmVjdChjb25zdCBOU1JlYwogCiAgICAgICAgICAg
ICAgICAgICAgICAgICAvLyBVc2UgdGhlIGNsaXAgYm91bmRzIGZyb20gdGhlIGNvbnRleHQgaW5z
dGVhZCBvZiB0aGUgYm91bmRzIHdlIGNyZWF0ZWQKICAgICAgICAgICAgICAgICAgICAgICAgIC8v
IGZyb20gdGhlIHdpbmRvdyBhYm92ZS4KLSAgICAgICAgICAgICAgICAgICAgICAgIGdldE5QUmVj
dChDR0NvbnRleHRHZXRDbGlwQm91bmRpbmdCb3goY3VycmVudENvbnRleHQpLCB3aW5kb3cuY2xp
cFJlY3QpOworICAgICAgICAgICAgICAgICAgICAgICAgZ2V0TlBSZWN0KENHUmVjdE9mZnNldChD
R0NvbnRleHRHZXRDbGlwQm91bmRpbmdCb3goY3VycmVudENvbnRleHQpLCAtb3JpZ2luLngsIG9y
aWdpbi55KSwgd2luZG93LmNsaXBSZWN0KTsKICAgICAgICAgICAgICAgICAgICAgfQogICAgICAg
ICAgICAgICAgIH0KICAgICAgICAgICAgIH0K
</data>
<flag name="review"
          id="7150"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>