157096 2016-04-27 11:48:35 -0700 Address feedback from https://bugs.webkit.org/show_bug.cgi?id=157048#c5. 2016-04-27 12:03:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue ggaren keith_miller mitz msaboff saam oldest_to_newest 1187883 0 mark.lam 2016-04-27 11:48:35 -0700 In JSWrapperMap.mm, 1. Check for USE(APPLE_INTERNAL_SDK) instead of __has_include(<mach-o/dyld_priv.h>). 2. Rename webkitFirstSDKVersionWithInitConstructorSupport to firstSDKVersionWithInitConstructorSupport. 1187891 1 277523 mark.lam 2016-04-27 11:55:43 -0700 Created attachment 277523 proposed patch. 1187892 2 277523 ggaren 2016-04-27 11:56:47 -0700 Comment on attachment 277523 proposed patch. r=me 1187902 3 mark.lam 2016-04-27 12:03:55 -0700 Thanks for the review. Landed in r200139: <http://trac.webkit.org/r200139>. 277523 2016-04-27 11:55:43 -0700 2016-04-27 11:56:47 -0700 proposed patch. bug-157096.patch text/plain 2172 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwMTM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTA0LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGRyZXNzIGZlZWRiYWNrIGZyb20gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NzA0OCNjNS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1NzA5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIDEuIENoZWNrIGZvciBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKSBpbnN0ZWFkIG9mIF9f aGFzX2luY2x1ZGUoPG1hY2gtby9keWxkX3ByaXYuaD4pLgorICAgICAgICAyLiBSZW5hbWUgd2Vi a2l0Rmlyc3RTREtWZXJzaW9uV2l0aEluaXRDb25zdHJ1Y3RvclN1cHBvcnQgdG8KKyAgICAgICAg ICAgZmlyc3RTREtWZXJzaW9uV2l0aEluaXRDb25zdHJ1Y3RvclN1cHBvcnQuCisKKyAgICAgICAg KiBBUEkvSlNXcmFwcGVyTWFwLm1tOgorICAgICAgICAoc3VwcG9ydHNJbml0TWV0aG9kQ29uc3Ry dWN0b3JzKToKKwogMjAxNi0wNC0yNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVzdHJpY3QgdGhlIGF2YWlsYWJpbGl0eSBvZiBzb21lIEpTQyBvcHRpb25zIHRv IGxvY2FsIGRlYnVnIGJ1aWxkcyBvbmx5LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ SS9KU1dyYXBwZXJNYXAubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ SS9KU1dyYXBwZXJNYXAubW0JKHJldmlzaW9uIDIwMDEzNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvSlNXcmFwcGVyTWFwLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NCwxNiArNDQsMTYg QEAKIAogI2luY2x1ZGUgPG1hY2gtby9keWxkLmg+CiAKLSNpZiBfX2hhc19pbmNsdWRlKDxtYWNo LW8vZHlsZF9wcml2Lmg+KQorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCiAjaW5jbHVkZSA8 bWFjaC1vL2R5bGRfcHJpdi5oPgogI2VuZGlmCiBleHRlcm4gIkMiIHVpbnQzMl90IGR5bGRfZ2V0 X3Byb2dyYW1fc2RrX3ZlcnNpb24oKTsKIAogI2lmIFBMQVRGT1JNKEFQUExFVFYpCiAjZWxpZiBQ TEFURk9STShJT1MpCi1zdGF0aWMgY29uc3QgdWludDMyX3Qgd2Via2l0Rmlyc3RTREtWZXJzaW9u V2l0aEluaXRDb25zdHJ1Y3RvclN1cHBvcnQgPSAweDgwMDAwOyAvLyBpT1MgOC4wLjAKK3N0YXRp YyBjb25zdCB1aW50MzJfdCBmaXJzdFNES1ZlcnNpb25XaXRoSW5pdENvbnN0cnVjdG9yU3VwcG9y dCA9IDB4ODAwMDA7IC8vIGlPUyA4LjAuMAogI2VsaWYgUExBVEZPUk0oTUFDKQotc3RhdGljIGNv bnN0IHVpbnQzMl90IHdlYmtpdEZpcnN0U0RLVmVyc2lvbldpdGhJbml0Q29uc3RydWN0b3JTdXBw b3J0ID0gMHhBMEEwMDsgLy8gT1NYIDEwLjEwLjAKK3N0YXRpYyBjb25zdCB1aW50MzJfdCBmaXJz dFNES1ZlcnNpb25XaXRoSW5pdENvbnN0cnVjdG9yU3VwcG9ydCA9IDB4QTBBMDA7IC8vIE9TWCAx MC4xMC4wCiAjZW5kaWYKIAogQGNsYXNzIEpTT2JqQ0NsYXNzSW5mbzsKQEAgLTY2NCw3ICs2NjQs NyBAQCBib29sIHN1cHBvcnRzSW5pdE1ldGhvZENvbnN0cnVjdG9ycygpCiAgICAgc3RhdGljIHVp bnQzMl90IHByb2dyYW1TREtWZXJzaW9uID0gMDsKICAgICBpZiAoIXByb2dyYW1TREtWZXJzaW9u KQogICAgICAgICBwcm9ncmFtU0RLVmVyc2lvbiA9IGR5bGRfZ2V0X3Byb2dyYW1fc2RrX3ZlcnNp b24oKTsKLSAgICByZXR1cm4gcHJvZ3JhbVNES1ZlcnNpb24gPj0gd2Via2l0Rmlyc3RTREtWZXJz aW9uV2l0aEluaXRDb25zdHJ1Y3RvclN1cHBvcnQ7CisgICAgcmV0dXJuIHByb2dyYW1TREtWZXJz aW9uID49IGZpcnN0U0RLVmVyc2lvbldpdGhJbml0Q29uc3RydWN0b3JTdXBwb3J0OwogI2VuZGlm CiB9CiAK