157093 2016-04-27 11:01:41 -0700 Clean up Font::removeFromSystemFallbackCache() 2016-04-29 16:53:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 157216 1 mmaxfield mmaxfield commit-queue oldest_to_newest 1187816 0 mmaxfield 2016-04-27 11:01:41 -0700 Clean up Font::removeFromSystemFallbackCache() 1187818 1 277491 mmaxfield 2016-04-27 11:04:12 -0700 Created attachment 277491 Patch 1187851 2 277491 darin 2016-04-27 11:35:38 -0700 Comment on attachment 277491 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277491&action=review Looks good. > Source/WebCore/platform/graphics/Font.cpp:484 > + systemFallbackCache().remove(this); Should change this function to take a reference, some day. 1187947 3 277491 commit-queue 2016-04-27 14:06:38 -0700 Comment on attachment 277491 Patch Clearing flags on attachment: 277491 Committed r200150: <http://trac.webkit.org/changeset/200150> 1187948 4 commit-queue 2016-04-27 14:06:42 -0700 All reviewed patches have been landed. Closing bug. 1188871 5 commit-queue 2016-04-29 16:53:44 -0700 Re-opened since this is blocked by bug 157216 277491 2016-04-27 11:04:12 -0700 2016-04-27 14:06:38 -0700 Patch bug-157093-20160427110442.patch text/plain 1949 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFlZjU3MDQ3ZjU0NTVl NmQyMjFkZTdkMTdmZWMwNjNhNmM5YmQwYS4uYmNjZTA1MjZmZTY2Nzg1MzA5Mzk0MGZiN2MyN2Y2 N2ZiMzA4MmQwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA0LTI3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAg Rm9udDo6cmVtb3ZlRnJvbVN5c3RlbUZhbGxiYWNrQ2FjaGUoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MDkzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9udHMgaGF2ZSBhIGJpdCB3aGljaCByZXBy ZXNlbnRzIHdoZXRoZXIgb3Igbm90IHRoZSBzeXN0ZW0gZmFsbGJhY2sgY2FjaGUgcmVmZXJlbmNl cyB0aGVtLgorICAgICAgICBUaGlzIGJpdCBnZXRzIHNldCB0byAxIHdoZW4gdGhleSBhcmUgaW5z ZXJ0ZWQgaW50byB0aGUgc3lzdGVtIGZhbGxiYWNrIGNhY2hlLCBidXQgd2FzIG5vdAorICAgICAg ICBiZWluZyByZXNldCBiYWNrIHRvIDAgd2hlbiBpdCB3YXMgcmVtb3ZlZC4KKworICAgICAgICBU aGlzIGlzIGJlbmlnbiwgc2luY2UgdGhlIG9sZCBjb2RlcGF0aCBoYXMgbm8gZWZmZWN0LiBIb3dl dmVyLCB3ZSBjYW4gc3BlZWQgdXAgdGhlIGZ1bmN0aW9uCisgICAgICAgIGJ5IHByb3Blcmx5IHVw ZGF0aW5nIHRoaXMgYml0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlz IG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6cmVtb3ZlRnJvbVN5c3RlbUZhbGxiYWNrQ2Fj aGUpOgorCiAyMDE2LTA0LTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAg ICAgICAgW1dlYiBJRExdIENsZWFuIHVwIHN1cHBvcnQgZm9yIFtDbGFtcF0gSURMIGV4dGVuZGVk IGF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Rm9udC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAppbmRl eCBlMmRjMDU0YTNmNzlmZjAzNzRhZGViMzVlODQ4NGU0MTA5MGJjMmYwLi5mYWJlMjhlOTg0M2Ux OWQwN2YxYjU5ZjU3MjczYzkyYjZiZTAyNWMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9Gb250LmNwcApAQCAtNDc3LDExICs0NzcsMTIgQEAgUmVmUHRyPEZvbnQ+IEZvbnQ6 OnN5c3RlbUZhbGxiYWNrRm9udEZvckNoYXJhY3RlcihVQ2hhcjMyIGNoYXJhY3RlciwgY29uc3Qg Rm9udEQKIAogdm9pZCBGb250OjpyZW1vdmVGcm9tU3lzdGVtRmFsbGJhY2tDYWNoZSgpCiB7Ci0g ICAgc3lzdGVtRmFsbGJhY2tDYWNoZSgpLnJlbW92ZSh0aGlzKTsKLQogICAgIGlmICghbV9pc1Vz ZWRJblN5c3RlbUZhbGxiYWNrQ2FjaGUpCiAgICAgICAgIHJldHVybjsKIAorICAgIG1faXNVc2Vk SW5TeXN0ZW1GYWxsYmFja0NhY2hlID0gZmFsc2U7CisgICAgc3lzdGVtRmFsbGJhY2tDYWNoZSgp LnJlbW92ZSh0aGlzKTsKKwogICAgIGZvciAoYXV0byYgY2hhcmFjdGVyTWFwIDogc3lzdGVtRmFs bGJhY2tDYWNoZSgpLnZhbHVlcygpKSB7CiAgICAgICAgIFZlY3RvcjxDaGFyYWN0ZXJGYWxsYmFj a01hcEtleSwgNTEyPiB0b1JlbW92ZTsKICAgICAgICAgZm9yIChhdXRvJiBlbnRyeSA6IGNoYXJh Y3Rlck1hcCkgewo=