157090 2016-04-27 10:44:05 -0700 Remove unnecessary HashMap from Font 2022-10-10 14:35:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield ahmad.saleem792 commit-queue webkit-bug-importer oldest_to_newest 1187806 0 mmaxfield 2016-04-27 10:44:05 -0700 Remove unnecessary HashMap from Font 1187808 1 277488 mmaxfield 2016-04-27 10:45:41 -0700 Created attachment 277488 Patch 1187814 2 277488 darin 2016-04-27 10:57:57 -0700 Comment on attachment 277488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277488&action=review > Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:40 > + RetainPtr<CFDictionaryRef>& attributesDictionary = enableKerning ? m_kernedCFStringAttributes : m_nonKernedCFStringAttributes; I think auto& would be better here. 1187824 3 277493 mmaxfield 2016-04-27 11:08:08 -0700 Created attachment 277493 Patch for committing 1187899 4 277493 commit-queue 2016-04-27 12:00:09 -0700 Comment on attachment 277493 Patch for committing Clearing flags on attachment: 277493 Committed r200140: <http://trac.webkit.org/changeset/200140> 1904622 5 ahmad.saleem792 2022-10-10 14:34:47 -0700 Landed - https://github.com/WebKit/WebKit/commit/dc94eba5215171e6b1a53ee15b619a0d6143cfcd and didn't back out. Marking this as "RESOLVED FIXED". 1904623 6 webkit-bug-importer 2022-10-10 14:35:17 -0700 <rdar://problem/100997848> 277488 2016-04-27 10:45:41 -0700 2016-04-27 10:57:57 -0700 Patch bug-157090-20160427104611.patch text/plain 2823 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFlZjU3MDQ3ZjU0NTVl NmQyMjFkZTdkMTdmZWMwNjNhNmM5YmQwYS4uYjIzZmZlMjlkYzI3MTAxMDczNmEzOWY2YzNiZjdj Mzg5ZmFjNTIwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA0LTI3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVu bmVjZXNzYXJ5IEhhc2hNYXAgZnJvbSBGb250CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGVyZSB3ZXJlIG9ubHkgZXZlciBhIG1heGltdW0gb2YgMiBr ZXlzIGluIHRoZSBoYXNobWFwLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJl IGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Zv bnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3Jl VGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250OjpnZXRDRlN0cmluZ0F0dHJpYnV0ZXMp OgorCiAyMDE2LTA0LTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgW1dlYiBJRExdIENsZWFuIHVwIHN1cHBvcnQgZm9yIFtDbGFtcF0gSURMIGV4dGVuZGVkIGF0 dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9u dC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5oCmluZGV4IDdiOGI1 NDBlMjBhMmYzYTY3YWIyMmRlZTE0YTZlMDA3N2JlNzAwM2YuLjM4YWZlMTRjNzM5OWZiNDQ0YWMy MDIyNzBhODQ5OGYxYTcyOTM1NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ZvbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G b250LmgKQEAgLTI3Niw3ICsyNzYsOCBAQCBwcml2YXRlOgogI2VuZGlmCiAKICNpZiBQTEFURk9S TShDT0NPQSkKLSAgICBtdXRhYmxlIEhhc2hNYXA8dW5zaWduZWQsIFJldGFpblB0cjxDRkRpY3Rp b25hcnlSZWY+PiBtX0NGU3RyaW5nQXR0cmlidXRlczsKKyAgICBtdXRhYmxlIFJldGFpblB0cjxD RkRpY3Rpb25hcnlSZWY+IG1fbm9uS2VybmVkQ0ZTdHJpbmdBdHRyaWJ1dGVzOworICAgIG11dGFi bGUgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gbV9rZXJuZWRDRlN0cmluZ0F0dHJpYnV0ZXM7 CiAgICAgbXV0YWJsZSBPcHRpb25hbDxCaXRWZWN0b3I+IG1fZ2x5cGhzU3VwcG9ydGVkQnlTbWFs bENhcHM7CiAgICAgbXV0YWJsZSBPcHRpb25hbDxCaXRWZWN0b3I+IG1fZ2x5cGhzU3VwcG9ydGVk QnlBbGxTbWFsbENhcHM7CiAgICAgbXV0YWJsZSBPcHRpb25hbDxCaXRWZWN0b3I+IG1fZ2x5cGhz U3VwcG9ydGVkQnlQZXRpdGVDYXBzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL1NpbXBsZUZvbnREYXRhQ29yZVRleHQuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1NpbXBsZUZvbnREYXRhQ29yZVRleHQuY3BwCmluZGV4 IDFmMTgzMjllYjRkMzZjYzA5YmJjMjZmYzdlZjcwY2JiMDg4YWU5MmYuLjNjMTY1YjRkODZjNGE2 OWZhZDhlYWJmMTE3YTc3ZGVlMzdjMGI4NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL21hYy9TaW1wbGVGb250RGF0YUNvcmVUZXh0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5j cHAKQEAgLTM3LDEwICszNyw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogQ0ZEaWN0aW9uYXJ5 UmVmIEZvbnQ6OmdldENGU3RyaW5nQXR0cmlidXRlcyhib29sIGVuYWJsZUtlcm5pbmcsIEZvbnRP cmllbnRhdGlvbiBvcmllbnRhdGlvbikgY29uc3QKIHsKLSAgICB1bnNpZ25lZCBrZXkgPSBzdGF0 aWNfY2FzdDx1bnNpZ25lZD4oZW5hYmxlS2VybmluZykgKyAxOwotICAgIEhhc2hNYXA8dW5zaWdu ZWQsIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+Pjo6QWRkUmVzdWx0IGFkZFJlc3VsdCA9IG1f Q0ZTdHJpbmdBdHRyaWJ1dGVzLmFkZChrZXksIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+KCkp OwotICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+JiBhdHRyaWJ1dGVzRGljdGlvbmFyeSA9 IGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWU7Ci0gICAgaWYgKCFhZGRSZXN1bHQuaXNOZXdFbnRy eSkKKyAgICBSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiYgYXR0cmlidXRlc0RpY3Rpb25hcnkg PSBlbmFibGVLZXJuaW5nID8gbV9rZXJuZWRDRlN0cmluZ0F0dHJpYnV0ZXMgOiBtX25vbktlcm5l ZENGU3RyaW5nQXR0cmlidXRlczsKKyAgICBpZiAoYXR0cmlidXRlc0RpY3Rpb25hcnkpCiAgICAg ICAgIHJldHVybiBhdHRyaWJ1dGVzRGljdGlvbmFyeS5nZXQoKTsKIAogICAgIGF0dHJpYnV0ZXNE aWN0aW9uYXJ5ID0gYWRvcHRDRihDRkRpY3Rpb25hcnlDcmVhdGVNdXRhYmxlKGtDRkFsbG9jYXRv ckRlZmF1bHQsIDQsICZrQ0ZDb3B5U3RyaW5nRGljdGlvbmFyeUtleUNhbGxCYWNrcywgJmtDRlR5 cGVEaWN0aW9uYXJ5VmFsdWVDYWxsQmFja3MpKTsK 277493 2016-04-27 11:08:08 -0700 2016-04-27 12:00:09 -0700 Patch for committing bug-157090-20160427110838.patch text/plain 2798 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFlZjU3MDQ3ZjU0NTVl NmQyMjFkZTdkMTdmZWMwNjNhNmM5YmQwYS4uMGVhZTczNjQ2YTljNGIxYzFlZmUyMzc3ZGQwOWZk YTE5NTdkZWQ3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA0LTI3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVu bmVjZXNzYXJ5IEhhc2hNYXAgZnJvbSBGb250CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KKworICAgICAgICBUaGVyZSB3ZXJlIG9ubHkgZXZlciBhIG1heGltdW0gb2YgMiBrZXlz IGluIHRoZSBoYXNobWFwLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlz IG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnQu aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250OjpnZXRDRlN0cmluZ0F0dHJpYnV0ZXMpOgor CiAyMDE2LTA0LTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg W1dlYiBJRExdIENsZWFuIHVwIHN1cHBvcnQgZm9yIFtDbGFtcF0gSURMIGV4dGVuZGVkIGF0dHJp YnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5oCmluZGV4IDdiOGI1NDBl MjBhMmYzYTY3YWIyMmRlZTE0YTZlMDA3N2JlNzAwM2YuLjM4YWZlMTRjNzM5OWZiNDQ0YWMyMDIy NzBhODQ5OGYxYTcyOTM1NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ZvbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250 LmgKQEAgLTI3Niw3ICsyNzYsOCBAQCBwcml2YXRlOgogI2VuZGlmCiAKICNpZiBQTEFURk9STShD T0NPQSkKLSAgICBtdXRhYmxlIEhhc2hNYXA8dW5zaWduZWQsIFJldGFpblB0cjxDRkRpY3Rpb25h cnlSZWY+PiBtX0NGU3RyaW5nQXR0cmlidXRlczsKKyAgICBtdXRhYmxlIFJldGFpblB0cjxDRkRp Y3Rpb25hcnlSZWY+IG1fbm9uS2VybmVkQ0ZTdHJpbmdBdHRyaWJ1dGVzOworICAgIG11dGFibGUg UmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gbV9rZXJuZWRDRlN0cmluZ0F0dHJpYnV0ZXM7CiAg ICAgbXV0YWJsZSBPcHRpb25hbDxCaXRWZWN0b3I+IG1fZ2x5cGhzU3VwcG9ydGVkQnlTbWFsbENh cHM7CiAgICAgbXV0YWJsZSBPcHRpb25hbDxCaXRWZWN0b3I+IG1fZ2x5cGhzU3VwcG9ydGVkQnlB bGxTbWFsbENhcHM7CiAgICAgbXV0YWJsZSBPcHRpb25hbDxCaXRWZWN0b3I+IG1fZ2x5cGhzU3Vw cG9ydGVkQnlQZXRpdGVDYXBzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL1NpbXBsZUZvbnREYXRhQ29yZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1NpbXBsZUZvbnREYXRhQ29yZVRleHQuY3BwCmluZGV4IDFm MTgzMjllYjRkMzZjYzA5YmJjMjZmYzdlZjcwY2JiMDg4YWU5MmYuLjkxZjY3ZjA0ZjgyMzk3OTQ4 MmZhZmYxN2E0M2Y1NDAzM2FlMjljYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL21hYy9TaW1wbGVGb250RGF0YUNvcmVUZXh0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5jcHAK QEAgLTM3LDEwICszNyw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogQ0ZEaWN0aW9uYXJ5UmVm IEZvbnQ6OmdldENGU3RyaW5nQXR0cmlidXRlcyhib29sIGVuYWJsZUtlcm5pbmcsIEZvbnRPcmll bnRhdGlvbiBvcmllbnRhdGlvbikgY29uc3QKIHsKLSAgICB1bnNpZ25lZCBrZXkgPSBzdGF0aWNf Y2FzdDx1bnNpZ25lZD4oZW5hYmxlS2VybmluZykgKyAxOwotICAgIEhhc2hNYXA8dW5zaWduZWQs IFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+Pjo6QWRkUmVzdWx0IGFkZFJlc3VsdCA9IG1fQ0ZT dHJpbmdBdHRyaWJ1dGVzLmFkZChrZXksIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+KCkpOwot ICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+JiBhdHRyaWJ1dGVzRGljdGlvbmFyeSA9IGFk ZFJlc3VsdC5pdGVyYXRvci0+dmFsdWU7Ci0gICAgaWYgKCFhZGRSZXN1bHQuaXNOZXdFbnRyeSkK KyAgICBhdXRvJiBhdHRyaWJ1dGVzRGljdGlvbmFyeSA9IGVuYWJsZUtlcm5pbmcgPyBtX2tlcm5l ZENGU3RyaW5nQXR0cmlidXRlcyA6IG1fbm9uS2VybmVkQ0ZTdHJpbmdBdHRyaWJ1dGVzOworICAg IGlmIChhdHRyaWJ1dGVzRGljdGlvbmFyeSkKICAgICAgICAgcmV0dXJuIGF0dHJpYnV0ZXNEaWN0 aW9uYXJ5LmdldCgpOwogCiAgICAgYXR0cmlidXRlc0RpY3Rpb25hcnkgPSBhZG9wdENGKENGRGlj dGlvbmFyeUNyZWF0ZU11dGFibGUoa0NGQWxsb2NhdG9yRGVmYXVsdCwgNCwgJmtDRkNvcHlTdHJp bmdEaWN0aW9uYXJ5S2V5Q2FsbEJhY2tzLCAma0NGVHlwZURpY3Rpb25hcnlWYWx1ZUNhbGxCYWNr cykpOwo=