157067 2016-04-27 03:23:59 -0700 [WinCairo] Invalid address specified to RtlValidateHeap at std::ctype<char>::_Tidy() when finishing MiniBrowser 2017-04-05 22:55:03 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii achristensen bfulgham commit-queue peavo pvollan thorton oldest_to_newest 1187716 0 fujii 2016-04-27 03:23:59 -0700 [WinCairo] Invalid address specified to RtlValidateHeap at std::ctype<char>::_Tidy() when finishing MiniBrowser trunk@200119, WinCairo port, Debug build 1) Launch MiniBrowser 2) Close the window 3) Invalid address specified to RtlValidateHeap This issue doesn't happen in every builds. I think this doesn't happen with a clean build, but a incremental build. If a build have this issue, this steps reproduces every time. Log: > HEAP[MiniBrowser.exe]: Invalid address specified to RtlValidateHeap( 000001A0F2C60000, 000001A0F812E7E0 ) > MiniBrowser.exe has triggered a breakpoint. call stack: > ntdll.dll!00007ffa314101c5() Unknown > ntdll.dll!00007ffa313e128f() Unknown > ntdll.dll!00007ffa31395702() Unknown > KernelBase.dll!00007ffa2dc4464a() Unknown > ucrtbased.dll!00007ffa1e5cdeb1() Unknown > ucrtbased.dll!00007ffa1e5cc259() Unknown > ucrtbased.dll!00007ffa1e5cf8a5() Unknown > ucrtbased.dll!00007ffa1e5cff88() Unknown > WebKit.dll!std::ctype<char>::_Tidy() Line 2503 C++ > WebKit.dll!std::ctype<char>::~ctype<char>() Line 2493 C++ > WebKit.dll!std::ctype<char>::`scalar deleting destructor'(unsigned int) C++ > WebKit.dll!std::_Fac_node::`scalar deleting destructor'(unsigned int) C++ > WebKit.dll!std::`dynamic atexit destructor for '_Fac_tidy_reg''() C++ > ucrtbased.dll!00007ffa1e5f9b27() Unknown > ucrtbased.dll!00007ffa1e5f95a5() Unknown > ucrtbased.dll!00007ffa1e5f969c() Unknown > ucrtbased.dll!00007ffa1e5f9cb5() Unknown > WebKit.dll!__scrt_dllmain_uninitialize_c() Line 392 C++ > WebKit.dll!dllmain_crt_process_detach(const bool is_terminating) Line 109 C++ > WebKit.dll!dllmain_crt_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 134 C++ > WebKit.dll!dllmain_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 209 C++ > WebKit.dll!_DllMainCRTStartup(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 251 C++ > ntdll.dll!00007ffa31335208() Unknown > ntdll.dll!00007ffa3137b2aa() Unknown > ntdll.dll!00007ffa3137b13a() Unknown > kernel32.dll!00007ffa2f944d8a() Unknown > MiniBrowser.exe!exit_or_terminate_process(const unsigned int return_code) Line 129 C++ > MiniBrowser.exe!common_exit(const int return_code, const _crt_exit_cleanup_mode cleanup_mode, const _crt_exit_return_mode return_mode) Line 269 C++ > [External Code] 1188091 1 fujii 2016-04-27 19:01:23 -0700 Sometimes I see a different log message with a similar call stack. Log: > Debug Assertion Failed! > > Program: ...8\work\webkit\trunk_c\WebKitBuild\Debug\bin64\MiniBrowser.exe > File: minkernel\crts\ucrt\src\appcrt\heap\debug_heap.cpp > Line: 892 > > Expression: is_block_type_valid(header->_block_use) > > For information on how your program can cause an assertion > failure, see the Visual C++ documentation on asserts. > > (Press Retry to debug the application) > MiniBrowser.exe has triggered a breakpoint. Call stack: > ucrtbased.dll!00007ff9f9dfc2f1() Unknown > ucrtbased.dll!00007ff9f9dff8a5() Unknown > ucrtbased.dll!00007ff9f9dfff88() Unknown > WebKit.dll!std::ctype<char>::_Tidy() Line 2503 C++ > WebKit.dll!std::ctype<char>::~ctype<char>() Line 2493 C++ > WebKit.dll!std::ctype<char>::`scalar deleting destructor'(unsigned int) C++ > WebKit.dll!std::_Fac_node::`scalar deleting destructor'(unsigned int) C++ > WebKit.dll!std::`dynamic atexit destructor for '_Fac_tidy_reg''() C++ > ucrtbased.dll!00007ff9f9e29b27() Unknown > ucrtbased.dll!00007ff9f9e295a5() Unknown > ucrtbased.dll!00007ff9f9e2969c() Unknown > ucrtbased.dll!00007ff9f9e29cb5() Unknown > WebKit.dll!__scrt_dllmain_uninitialize_c() Line 392 C++ > WebKit.dll!dllmain_crt_process_detach(const bool is_terminating) Line 109 C++ > WebKit.dll!dllmain_crt_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 134 C++ > WebKit.dll!dllmain_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 209 C++ > WebKit.dll!_DllMainCRTStartup(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 251 C++ > ntdll.dll!00007ffa31335208() Unknown > ntdll.dll!00007ffa3137b2aa() Unknown > ntdll.dll!00007ffa3137b13a() Unknown > kernel32.dll!00007ffa2f944d8a() Unknown > MiniBrowser.exe!exit_or_terminate_process(const unsigned int return_code) Line 129 C++ > MiniBrowser.exe!common_exit(const int return_code, const _crt_exit_cleanup_mode cleanup_mode, const _crt_exit_return_mode return_mode) Line 269 C++ > [External Code] 1188092 2 fujii 2016-04-27 19:02:47 -0700 I see this issue with following steps today. > svn up -r 200070 > perl Tools\Scripts\build-webkit --debug --wincairo --64-bit > svn up -r 200119 > perl Tools\Scripts\build-webkit --debug --wincairo --64-bit 1190658 3 fujii 2016-05-06 02:12:05 -0700 A DLL ucrtbased.dll is observed in the call stack of comment 0. According to a following document, ucrtbased.dll is just for dynamically linked CRT. CRT Library Features https://msdn.microsoft.com/en-us/library/abx4dbyh.aspx This is strange because WebKit is compiled with /MT switch to use static CRT. By using "dumpbin /imports WebKit.dll", it can be observed that vcruntime140d.dll and ucrtbased.dll are linked. In Source/WebKit/PlatformWin.cmake: > if (${WTF_PLATFORM_WIN_CAIRO}) > set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /NODEFAULTLIB:LIBCMT /NODEFAULTLIB:LIBCMTD") > else () > set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /NODEFAULTLIB:MSVCRT /NODEFAULTLIB:MSVCRTD") > endif () LIBCMT and LIBCMTD are ignored for WinCairo port. But, they are the static CRT. This code have been introduced in Bug 147851. 1190663 4 278247 fujii 2016-05-06 02:30:02 -0700 Created attachment 278247 Patch 1190674 5 achristensen 2016-05-06 06:48:00 -0700 There is one more similar check somewhere else. I'm pretty sure they were necessary to link successfully, but maybe not. 1190679 6 bfulgham 2016-05-06 08:32:00 -0700 (In reply to comment #3) > A DLL ucrtbased.dll is observed in the call stack of comment 0. > According to a following document, ucrtbased.dll is just for dynamically > linked CRT. [...] > LIBCMT and LIBCMTD are ignored for WinCairo port. > But, they are the static CRT. > This code have been introduced in Bug 147851. This reminds me that we should switch back to a dynamic runtime. That was a workaround for something that was happening a year or so ago, and it would be good to use a single shared runtime again. For internal reasons, we probably can't make this change until the fall, though. 1190889 7 achristensen 2016-05-06 21:05:38 -0700 Wincairo can change whenever though 1191143 8 278247 fujii 2016-05-08 23:57:14 -0700 Comment on attachment 278247 Patch I noticed one problem in my patch. Some modules (libpng, libjpeg, ICU) in WinCairoRequirements.zip are static libraries, and compiled with /MD to use DLL CRT. Then, WinCairo port must be compiled with /MD instread of /MT to link with the static libraries. Do you want to change WinCairo port to compile with /MD (DLL CRT) before AppleWin port will change in this year's fall? (In reply to comment #5) > There is one more similar check somewhere else. I cann't find. Could you tell me where? 1191155 9 278398 fujii 2016-05-09 03:06:00 -0700 Created attachment 278398 WIP patch to make WinCairo port use DLL CRT 1191196 10 achristensen 2016-05-09 09:31:32 -0700 (In reply to comment #8) > Comment on attachment 278247 [details] > Patch > > I noticed one problem in my patch. > Some modules (libpng, libjpeg, ICU) in WinCairoRequirements.zip are static > libraries, and compiled with /MD to use DLL CRT. > Then, WinCairo port must be compiled with /MD instread of /MT to link with > the static libraries. > > Do you want to change WinCairo port to compile with /MD (DLL CRT) before > AppleWin port will change in this year's fall? This should be a change to https://github.com/peavo/WinCairoRequirements 1191777 11 fujii 2016-05-10 18:30:22 -0700 I created a PR: https://github.com/peavo/WinCairoRequirements/pull/1 1293143 12 fujii 2017-03-31 03:08:46 -0700 I updated WinCairoRequirements.zip at <http://trac.webkit.org/changeset/214328>. Its libpng and libjpeg are DLLs. My first patch (comment 4) has no problem now. 1293146 13 305963 fujii 2017-03-31 03:15:30 -0700 Created attachment 305963 Patch 1294452 14 305963 pvollan 2017-04-05 02:35:59 -0700 Comment on attachment 305963 Patch r=me. Please check WinCairo 32-bit build as well :) 1294470 15 305963 achristensen 2017-04-05 05:51:47 -0700 Comment on attachment 305963 Patch This now matches the AppleWin port's flags and the flags in Tools/DumpRenderTree/PlatformWin.cmake and Tools/MiniBrowser/win/CMakeLists.txt 1294475 16 305963 commit-queue 2017-04-05 06:20:00 -0700 Comment on attachment 305963 Patch Clearing flags on attachment: 305963 Committed r214943: <http://trac.webkit.org/changeset/214943> 1294476 17 commit-queue 2017-04-05 06:20:02 -0700 All reviewed patches have been landed. Closing bug. 1294813 18 fujii 2017-04-05 22:55:03 -0700 Thank you for review, Per and Alex. I did tests of 32bit, too. I found a bug of 32bit of WinCairoRequirements and fixed it. https://github.com/fujii/WinCairoRequirements/commit/589e8db5a73e98a1b50b616714bbe8c19eb01b6e 278247 2016-05-06 02:30:02 -0700 2017-03-31 03:15:26 -0700 Patch bug-157067-20160506183043.patch text/plain 1985 fujii SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDA1MTApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA1LTA2ICBGdWppaSBIaXJv bm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gSW52 YWxpZCBhZGRyZXNzIHNwZWNpZmllZCB0byBSdGxWYWxpZGF0ZUhlYXAgYXQgc3RkOjpjdHlwZTxj aGFyPjo6X1RpZHkoKSB3aGVuIGZpbmlzaGluZyBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MDY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IGlzIGNvbXBpbGVkIHdpdGgg L01UIHN3aXRjaCB0byB1c2Ugc3RhdGljIENSVCBvbiBXaW5kb3dzLgorICAgICAgICBCdXQsIFdp bkNhaXJvIHBvcnQgZG9lcyBub3QgbGluayB0aGUgc3RhdGljIENSVCBieSBzcGVjaWZ5aW5nCisg ICAgICAgIC9OT0RFRkFVTFRMSUI6TElCQ01UIGFuZCAvTk9ERUZBVUxUTElCOkxJQkNNVEQgc3dp dGNoZXMuCisgICAgICAgIEV2ZW50dWFsbHksIGEgZHluYW1pY2FsbHkgbGlua2VkIENSVCBpcyBs aW5rZWQuICBUaGlzIGNhdXNlcworICAgICAgICBwb3RlbnRpYWwgaGVhcCBjb3JydXB0aW9uLgor CisgICAgICAgICogUGxhdGZvcm1XaW4uY21ha2U6IERvIG5vdCBzZXQgL05PREVGQVVMVExJQjpM SUJDTVQgYW5kCisgICAgICAgIC9OT0RFRkFVTFRMSUI6TElCQ01URCwgYnV0IC9OT0RFRkFVTFRM SUI6TVNWQ1JUIGFuZAorICAgICAgICAvTk9ERUZBVUxUTElCOk1TVkNSVEQgYXMgd2VsbCBhcyBB cHBsZVdpbiBwb3J0IGRvZXMKKwogMjAxNi0wNC0yNSAgUGVyIEFybmUgVm9sbGFuICA8cGVhdm9A b3V0bG9vay5jb20+CiAKICAgICAgICAgW1dpbl1bSW5kZXhlZERCXSBGaXggYnVpbGQgZXJyb3Jz LgpJbmRleDogU291cmNlL1dlYktpdC9QbGF0Zm9ybVdpbi5jbWFrZQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L1BsYXRmb3JtV2luLmNtYWtlCShyZXZpc2lvbiAyMDA1MDkpCisrKyBTb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC00NjQsMTEgKzQ2 NCw3IEBAIHN0cmluZyhSRVBMQUNFICIgIiAiXDsiIENYWF9MSUJTICR7Q01BS0UKIGxpc3QoQVBQ RU5EIFdlYktpdF9MSUJSQVJJRVMgJHtDWFhfTElCU30pCiBzZXQoQ01BS0VfQ1hYX1NUQU5EQVJE X0xJQlJBUklFUyAiIikKIAotaWYgKCR7V1RGX1BMQVRGT1JNX1dJTl9DQUlST30pCi0gICAgc2V0 KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfU0hBUkVEX0xJTktFUl9GTEFHU30g L05PREVGQVVMVExJQjpMSUJDTVQgL05PREVGQVVMVExJQjpMSUJDTVREIikKLWVsc2UgKCkKLSAg ICBzZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9TSEFSRURfTElOS0VSX0ZM QUdTfSAvTk9ERUZBVUxUTElCOk1TVkNSVCAvTk9ERUZBVUxUTElCOk1TVkNSVEQiKQotZW5kaWYg KCkKK3NldChDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIke0NNQUtFX1NIQVJFRF9MSU5LRVJf RkxBR1N9IC9OT0RFRkFVTFRMSUI6TVNWQ1JUIC9OT0RFRkFVTFRMSUI6TVNWQ1JURCIpCiAKICMg SWYgdGhpcyBkaXJlY3RvcnkgaXNuJ3QgY3JlYXRlZCBiZWZvcmUgbWlkbCBydW5zIGFuZCBhdHRl bXB0cyB0byBvdXRwdXQgV2ViS2l0LnRsYiwKICMgSXQgZmFpbHMgd2l0aCBhbiB1bnVzdWFsIGVy cm9yIC0gbWlkbCBmYWlsZWQgLSBmYWlsZWQgdG8gc2F2ZSBhbGwgY2hhbmdlcwo= 278398 2016-05-09 03:06:00 -0700 2017-03-31 02:37:29 -0700 WIP patch to make WinCairo port use DLL CRT bug157067-win-cairo-dll-crt.patch text/plain 3140 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtV2luLmNtYWtlCmluZGV4IDQ1Y2M5MjMuLjIwYWY0NDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UKKysrIGIvU291cmNlL1dlYktpdC9QbGF0 Zm9ybVdpbi5jbWFrZQpAQCAtNDY0LDkgKzQ2NCw3IEBAIHN0cmluZyhSRVBMQUNFICIgIiAiXDsi IENYWF9MSUJTICR7Q01BS0VfQ1hYX1NUQU5EQVJEX0xJQlJBUklFU30pCiBsaXN0KEFQUEVORCBX ZWJLaXRfTElCUkFSSUVTICR7Q1hYX0xJQlN9KQogc2V0KENNQUtFX0NYWF9TVEFOREFSRF9MSUJS QVJJRVMgIiIpCiAKLWlmICgke1dURl9QTEFURk9STV9XSU5fQ0FJUk99KQotICAgIHNldChDTUFL RV9TSEFSRURfTElOS0VSX0ZMQUdTICIke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1N9IC9OT0RF RkFVTFRMSUI6TElCQ01UIC9OT0RFRkFVTFRMSUI6TElCQ01URCIpCi1lbHNlICgpCitpZiAoTk9U IFdURl9QTEFURk9STV9XSU5fQ0FJUk8pCiAgICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxB R1MgIiR7Q01BS0VfU0hBUkVEX0xJTktFUl9GTEFHU30gL05PREVGQVVMVExJQjpNU1ZDUlQgL05P REVGQVVMVExJQjpNU1ZDUlREIikKIGVuZGlmICgpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFr ZS9PcHRpb25zV2luLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UKaW5kZXgg Zjk4ZGEzNy4uYjRkNjRjMiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21h a2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UKQEAgLTE2OSwxMiArMTY5LDE2 IEBAIGlmIChNU1ZDKQogICAgIGZvcmVhY2ggKGZsYWdfdmFyCiAgICAgICAgIENNQUtFX0NYWF9G TEFHUyBDTUFLRV9DWFhfRkxBR1NfREVCVUcgQ01BS0VfQ1hYX0ZMQUdTX1JFTEVBU0UKICAgICAg ICAgQ01BS0VfQ1hYX0ZMQUdTX01JTlNJWkVSRUwgQ01BS0VfQ1hYX0ZMQUdTX1JFTFdJVEhERUJJ TkZPKQotICAgICAgICAjIFVzZSB0aGUgbXVsdGl0aHJlYWRlZCBzdGF0aWMgcnVudGltZSBsaWJy YXJ5IGluc3RlYWQgb2YgdGhlIGRlZmF1bHQgRExMIHJ1bnRpbWUuCi0gICAgICAgIHN0cmluZyhS RUdFWCBSRVBMQUNFICIvTUQiICIvTVQiICR7ZmxhZ192YXJ9ICIkeyR7ZmxhZ192YXJ9fSIpCisK KyAgICAgICAgaWYgKE5PVCBXVEZfUExBVEZPUk1fV0lOX0NBSVJPKQorICAgICAgICAgICAgIyBV c2UgdGhlIG11bHRpdGhyZWFkZWQgc3RhdGljIHJ1bnRpbWUgbGlicmFyeSBpbnN0ZWFkIG9mIHRo ZSBkZWZhdWx0IERMTCBydW50aW1lLgorICAgICAgICAgICAgc3RyaW5nKFJFR0VYIFJFUExBQ0Ug Ii9NRCIgIi9NVCIgJHtmbGFnX3Zhcn0gIiR7JHtmbGFnX3Zhcn19IikKKyAgICAgICAgZW5kaWYg KCkKIAogICAgICAgICAjIE5vIGRlYnVnIHJ1bnRpbWUsIGV2ZW4gaW4gZGVidWcgYnVpbGRzLgog ICAgICAgICBpZiAoTk9UIERFQlVHX1NVRkZJWCkKICAgICAgICAgICAgIHN0cmluZyhSRUdFWCBS RVBMQUNFICIvTVRkIiAiL01UIiAke2ZsYWdfdmFyfSAiJHske2ZsYWdfdmFyfX0iKQorICAgICAg ICAgICAgc3RyaW5nKFJFR0VYIFJFUExBQ0UgIi9NRGQiICIvTUQiICR7ZmxhZ192YXJ9ICIkeyR7 ZmxhZ192YXJ9fSIpCiAgICAgICAgICAgICBzdHJpbmcoUkVHRVggUkVQTEFDRSAiL0RfREVCVUci ICIiICR7ZmxhZ192YXJ9ICIkeyR7ZmxhZ192YXJ9fSIpCiAgICAgICAgIGVuZGlmICgpCiAgICAg ZW5kZm9yZWFjaCAoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1X aW4uY21ha2UgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybVdpbi5jbWFrZQppbmRleCBk MTk3N2IyLi5iNGNlN2NmIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9y bVdpbi5jbWFrZQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybVdpbi5jbWFrZQpA QCAtMTI2LDcgKzEyNiw5IEBAIGVsc2UgKCkKIGVuZGlmICgpCiAKIEFERF9QUkVDT01QSUxFRF9I RUFERVIoIkR1bXBSZW5kZXJUcmVlUHJlZml4LmgiICJ3aW4vRHVtcFJlbmRlclRyZWVQcmVmaXgu Y3BwIiBEdW1wUmVuZGVyVHJlZUxpYl9TT1VSQ0VTKQotc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJf RkxBR1MgIiR7Q01BS0VfU0hBUkVEX0xJTktFUl9GTEFHU30gL05PREVGQVVMVExJQjpNU1ZDUlQg L05PREVGQVVMVExJQjpNU1ZDUlREIikKK2lmIChOT1QgV1RGX1BMQVRGT1JNX1dJTl9DQUlSTykK KyAgICBzZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9TSEFSRURfTElOS0VS X0ZMQUdTfSAvTk9ERUZBVUxUTElCOk1TVkNSVCAvTk9ERUZBVUxUTElCOk1TVkNSVEQiKQorZW5k aWYgKCkKIGFkZF9kZWZpbml0aW9ucygtRFVTRV9DT05TT0xFX0VOVFJZX1BPSU5UKQogCiBhZGRf bGlicmFyeShEdW1wUmVuZGVyVHJlZUxpYiBTSEFSRUQgJHtEdW1wUmVuZGVyVHJlZUxpYl9TT1VS Q0VTfSkKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9DTWFrZUxpc3RzLnR4dCBi L1Rvb2xzL01pbmlCcm93c2VyL3dpbi9DTWFrZUxpc3RzLnR4dAppbmRleCBhZTE4NGJlLi44MzMy NTQyIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vQ01ha2VMaXN0cy50eHQKKysr IGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlzdHMudHh0CkBAIC00Myw3ICs0Myw5IEBA IGVsc2UgKCkKICAgICApCiBlbmRpZiAoKQogCi1zZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFH UyAiJHtDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTfSAvTk9ERUZBVUxUTElCOk1TVkNSVCAvTk9E RUZBVUxUTElCOk1TVkNSVEQiKQoraWYgKE5PVCBXVEZfUExBVEZPUk1fV0lOX0NBSVJPKQorICAg IHNldChDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxB R1N9IC9OT0RFRkFVTFRMSUI6TVNWQ1JUIC9OT0RFRkFVTFRMSUI6TVNWQ1JURCIpCitlbmRpZiAo KQogc2V0KENNQUtFX0VYRV9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9GTEFHU30g L0VOVFJZOndXaW5NYWluQ1JUU3RhcnR1cCIpCiAKIGlmICgke1dURl9QTEFURk9STV9XSU5fQ0FJ Uk99KQo= 305963 2017-03-31 03:15:30 -0700 2017-04-05 06:20:00 -0700 Patch bug-157067-20170331191529.patch text/plain 2112 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc5N2NkMTVmYWY3ZmQ1ZWNk ZjU4NDgxNDY5OWEwZWZlYjZjZjE2YzQuLmE4NzczY2JmZDhhYWVkZWExZmZiNDMyZTAxMjQzMzUz MWM3MGEwOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTctMDMtMzEgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBJ bnZhbGlkIGFkZHJlc3Mgc3BlY2lmaWVkIHRvIFJ0bFZhbGlkYXRlSGVhcCBhdCBzdGQ6OmN0eXBl PGNoYXI+OjpfVGlkeSgpIHdoZW4gZmluaXNoaW5nIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcwNjcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQgaXMgY29tcGlsZWQgd2l0 aCAvTVQgc3dpdGNoIHRvIHVzZSBzdGF0aWMgQ1JUIG9uIFdpbmRvd3MuCisgICAgICAgIEJ1dCwg V2luQ2Fpcm8gcG9ydCBkb2VzIG5vdCBsaW5rIHRoZSBzdGF0aWMgQ1JUIGJ5IHNwZWNpZnlpbmcK KyAgICAgICAgL05PREVGQVVMVExJQjpMSUJDTVQgYW5kIC9OT0RFRkFVTFRMSUI6TElCQ01URCBz d2l0Y2hlcy4KKyAgICAgICAgRXZlbnR1YWxseSwgYSBkeW5hbWljYWxseSBsaW5rZWQgQ1JUIGlz IGxpbmtlZC4gIFRoaXMgY2F1c2VzCisgICAgICAgIHBvdGVudGlhbCBoZWFwIGNvcnJ1cHRpb24u CisKKyAgICAgICAgKiBQbGF0Zm9ybVdpbi5jbWFrZTogRG8gbm90IHNldCAvTk9ERUZBVUxUTElC OkxJQkNNVCBhbmQKKyAgICAgICAgL05PREVGQVVMVExJQjpMSUJDTVRELCBidXQgL05PREVGQVVM VExJQjpNU1ZDUlQgYW5kCisgICAgICAgIC9OT0RFRkFVTFRMSUI6TVNWQ1JURCBhcyB3ZWxsIGFz IEFwcGxlV2luIHBvcnQgZG9lcworCiAyMDE3LTAzLTI3ICBKRiBCYXN0aWVuICA8amZiYXN0aWVu QGFwcGxlLmNvbT4KIAogICAgICAgICBtYWtlIGJ1aWxkIGZpeCBmb3IgV2ViRGVmYXVsdFVJRGVs ZWdhdGUubQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdpbi5jbWFrZSBiL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UKaW5kZXggOTRkMjE4MDA5MjFiZjMzZWViZWY4 ZTdkZjgyMDY5YjZlNWJlNmYzMi4uZmQ3MjU1MzkzYzkwZTcyYWJiODU0MDkzMGRkY2FjM2I3MmFj ODI0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdpbi5jbWFrZQorKysgYi9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtV2luLmNtYWtlCkBAIC00NzAsMTEgKzQ3MCw3IEBAIHN0cmlu ZyhSRVBMQUNFICIgIiAiXDsiIENYWF9MSUJTICR7Q01BS0VfQ1hYX1NUQU5EQVJEX0xJQlJBUklF U30pCiBsaXN0KEFQUEVORCBXZWJLaXRfTElCUkFSSUVTICR7Q1hYX0xJQlN9KQogc2V0KENNQUtF X0NYWF9TVEFOREFSRF9MSUJSQVJJRVMgIiIpCiAKLWlmICgke1dURl9QTEFURk9STV9XSU5fQ0FJ Uk99KQotICAgIHNldChDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIke0NNQUtFX1NIQVJFRF9M SU5LRVJfRkxBR1N9IC9OT0RFRkFVTFRMSUI6TElCQ01UIC9OT0RFRkFVTFRMSUI6TElCQ01URCIp Ci1lbHNlICgpCi0gICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfU0hB UkVEX0xJTktFUl9GTEFHU30gL05PREVGQVVMVExJQjpNU1ZDUlQgL05PREVGQVVMVExJQjpNU1ZD UlREIikKLWVuZGlmICgpCitzZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9T SEFSRURfTElOS0VSX0ZMQUdTfSAvTk9ERUZBVUxUTElCOk1TVkNSVCAvTk9ERUZBVUxUTElCOk1T VkNSVEQiKQogCiAjIElmIHRoaXMgZGlyZWN0b3J5IGlzbid0IGNyZWF0ZWQgYmVmb3JlIG1pZGwg cnVucyBhbmQgYXR0ZW1wdHMgdG8gb3V0cHV0IFdlYktpdC50bGIsCiAjIEl0IGZhaWxzIHdpdGgg YW4gdW51c3VhbCBlcnJvciAtIG1pZGwgZmFpbGVkIC0gZmFpbGVkIHRvIHNhdmUgYWxsIGNoYW5n ZXMK