<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>157057</bug_id>
          
          <creation_ts>2016-04-26 18:02:00 -0700</creation_ts>
          <short_desc>Support legacy HTTP headers in WebSockets</short_desc>
          <delta_ts>2016-04-28 16:29:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>155602</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="John Wilander">wilander</reporter>
          <assigned_to name="John Wilander">wilander</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wilander</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1187601</commentid>
    <comment_count>0</comment_count>
    <who name="John Wilander">wilander</who>
    <bug_when>2016-04-26 18:02:00 -0700</bug_when>
    <thetext>The following four HTTP headers are needed for legacy reasons:
Sec-WebSocket-Location
Sec-WebSocket-Origin
WebSocket-Location
WebSocket-Origin</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1187602</commentid>
    <comment_count>1</comment_count>
    <who name="John Wilander">wilander</who>
    <bug_when>2016-04-26 18:03:11 -0700</bug_when>
    <thetext>rdar://problem/25913345</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1187611</commentid>
    <comment_count>2</comment_count>
      <attachid>277432</attachid>
    <who name="John Wilander">wilander</who>
    <bug_when>2016-04-26 18:39:11 -0700</bug_when>
    <thetext>Created attachment 277432
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1187629</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-04-26 19:32:47 -0700</bug_when>
    <thetext>r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1187636</commentid>
    <comment_count>4</comment_count>
      <attachid>277432</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2016-04-26 19:59:34 -0700</bug_when>
    <thetext>Comment on attachment 277432
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277432&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        No new tests since these headers are not officially supported and should not be used.

This is not a reason to avoid tests. If they were worth adding, it&apos;s worth verifying that we don&apos;t accidentally break them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1187637</commentid>
    <comment_count>5</comment_count>
      <attachid>277432</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-26 20:21:33 -0700</bug_when>
    <thetext>Comment on attachment 277432
Patch

Clearing flags on attachment: 277432

Committed r200120: &lt;http://trac.webkit.org/changeset/200120&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1187638</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-26 20:21:37 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1187888</commentid>
    <comment_count>7</comment_count>
    <who name="John Wilander">wilander</who>
    <bug_when>2016-04-27 11:51:49 -0700</bug_when>
    <thetext>Bug for adding test cases: https://bugs.webkit.org/show_bug.cgi?id=157095</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>277432</attachid>
            <date>2016-04-26 18:39:11 -0700</date>
            <delta_ts>2016-04-26 20:21:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-157057-20160426183941.patch</filename>
            <type>text/plain</type>
            <size>1410</size>
            <attacher name="John Wilander">wilander</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDExNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA0LTI2ICBKb2huIFdp
bGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFN1cHBvcnQgbGVnYWN5IEhU
VFAgaGVhZGVycyBpbiBXZWJTb2NrZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xNTcwNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgdGhlc2UgaGVhZGVycyBhcmUgbm90
IG9mZmljaWFsbHkgc3VwcG9ydGVkIGFuZCBzaG91bGQgbm90IGJlIHVzZWQuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbjoKKyAgICAgICAgICAgIEFkZGVk
IGZvdXIgbGVnYWN5IGhlYWRlcnMgbmVlZGVkIHRvIHN1cHBvcnQgb2xkZXIgV2ViU29ja2V0cyBz
ZXJ2ZXJzLgorICAgICAgICAgICAgVHdvIG9mIHRoZW0gYXJlIGluIHRoZSBkcmFmdCBmcm9tIEF1
Z3VzdCAyMDEwOiBodHRwczovL3doYXR3Zy5vcmcvc3BlY3Mvd2ViLXNvY2tldC1wcm90b2NvbC8K
KwogMjAxNi0wNC0yNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg
IFtXZWIgSURMXSBTcGVjaWZ5IGRlZmF1bHQgdmFsdWVzIGZvciBvcHRpb25hbCBwYXJhbWV0ZXJz
IG9mIHR5cGUgJ3Vuc2lnbmVkIGxvbmcnCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u
ZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbgkocmV2aXNpb24gMjAwMTAwKQorKysg
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTmFtZXMuaW4JKHdvcmtp
bmcgY29weSkKQEAgLTEwOCwzICsxMDgsMTAgQEAgSWN5LU1ldGFkYXRhCiBJY3ktTmFtZQogSWN5
LVRpdGxlCiBJY3ktVVJMCisKKy8vIFRoZXNlIGFyZSBzcGVjaWZpYyB0byBsZWdhY3kgV2ViU29j
a2V0cyBpbXBsZW1lbnRhdGlvbnMKKy8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xNTcwNTcKK1NlYy1XZWJTb2NrZXQtTG9jYXRpb24KK1NlYy1XZWJTb2NrZXQtT3Jp
Z2luCitXZWJTb2NrZXQtTG9jYXRpb24KK1dlYlNvY2tldC1PcmlnaW4K
</data>

          </attachment>
      

    </bug>

</bugzilla>