157046 2016-04-26 15:26:22 -0700 [JSC] GetByVal on Undecided use its children before its OSR Exit 2016-04-27 10:58:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff ossy saam oldest_to_newest 1187539 0 benjamin 2016-04-26 15:26:22 -0700 [JSC] GetByVal on Undecided use its children before its OSR Exit 1187543 1 277413 benjamin 2016-04-26 15:30:40 -0700 Created attachment 277413 Patch 1187546 2 277413 mark.lam 2016-04-26 15:33:48 -0700 Comment on attachment 277413 Patch r=me 1187573 3 277413 commit-queue 2016-04-26 16:25:53 -0700 Comment on attachment 277413 Patch Clearing flags on attachment: 277413 Committed r200113: <http://trac.webkit.org/changeset/200113> 1187574 4 commit-queue 2016-04-26 16:25:58 -0700 All reviewed patches have been landed. Closing bug. 1187691 5 ossy 2016-04-27 01:40:20 -0700 (In reply to comment #3) > Comment on attachment 277413 [details] > Patch > > Clearing flags on attachment: 277413 > > Committed r200113: <http://trac.webkit.org/changeset/200113> The new test introduced in this change fails on all 32 bit platforms: - https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/2205 - https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20%28BuildAndTest%29/builds/8925 - https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/60882 - https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/390 1187809 6 benjamin 2016-04-27 10:46:54 -0700 (In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 277413 [details] > > Patch > > > > Clearing flags on attachment: 277413 > > > > Committed r200113: <http://trac.webkit.org/changeset/200113> > > The new test introduced in this change fails on all 32 bit platforms: > - > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > bit%20JSC%20%28BuildAndTest%29/builds/2205 > - > https://build.webkit.org/builders/Apple%20Yosemite%2032- > bit%20JSC%20%28BuildAndTest%29/builds/8925 > - > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/60882 > - > https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/ > builds/390 Oh! Looks like I forgot to fix the 32bit counterpart. I'll do that today. 1187815 7 benjamin 2016-04-27 10:58:33 -0700 Quick follow up for 32bit: http://trac.webkit.org/changeset/200133 Thanks Ossy. 277413 2016-04-26 15:30:40 -0700 2016-04-26 16:25:53 -0700 Patch bug-157046-20160426153109.patch text/plain 3176 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw OTA5OWM3ODc4ZWVmMGM0N2IzOGY3MDNhMmYxZmM5YzI3NzBlNWU3Li5lNjI4NDZjMzdjNWRhODA5 NjhjNjY3M2ZlNDlmMzAxZjQzNGI1ZWUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wNC0yNiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBHZXRCeVZhbCBvbiBVbmRlY2lkZWQgdXNlIGl0cyBjaGls ZHJlbiBiZWZvcmUgaXRzIE9TUiBFeGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTcwNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBWZXJ5IHNpbGx5IGJ1ZzogR2V0QnlWYWwgb24gVW5kZWNpZGVkIHVz ZXMgaXRzIGNoaWxkcmVuIGJlZm9yZQorICAgICAgICB0aGUgc3BlY3VsYXRpb25DaGVjaygpLiBJ ZiB3ZSBmYWlsIHRoZSBzcGVjdWxhdGlvbiwgd2UgaGF2ZSBhbHJlYWR5CisgICAgICAgIGxvc3Qg aG93IHRvIHJlY292ZXIgdGhlIHZhbHVlcy4KKworICAgICAgICBUaGUgZXhpc3RpbmcgdGVzdHMg ZGlkIG5vdCBjYXRjaCB0aGlzIGJlY2F1c2Ugd2UgdGllciB1cCB0byBCMworICAgICAgICBiZWZv cmUgc3VjaCBFeGl0cyBoYXBwZW4uIEIzIGhhcyBleHBsaWNpdCBsaXZlbmVzcyBhbmQgZGlkIG5v dCBzdWZmZXIKKyAgICAgICAgZnJvbSB0aGlzIGJ1Zy4KKyAgICAgICAgVGhlIG5ldyB0ZXN0IGhh cyBhIHNtYWxsZXIgd2FybXVwIHRvIGV4ZXJjaXNlIHRoZSBPU1IgRXhpdCBpbiBERkcKKyAgICAg ICAgaW5zdGVhZCBvZiBGVEwuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5j cHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorICAgICAg ICAqIHRlc3RzL3N0cmVzcy9nZXQtYnktdmFsLW9uLXVuZGVjaWRlZC1vdXQtb2YtYm91bmRzLmpz OiBBZGRlZC4KKyAgICAgICAgKHN0cmluZ19hcHBlYXJlZF9oZXJlLm9wYXF1ZUdldEJ5VmFsS25v d25BcnJheSk6CisKIDIwMTYtMDQtMjUgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CiAKICAgICAgICAgQ3Jhc2ggdXNpbmcgQHRyeUdldEJ5SWQgaW4gREZHCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAppbmRleCBhNzVj NzVmZTgxYjBhMmY1OWZhMGZhNjFhNjQzOTFmODg3ZTQ2NGNiLi41NDg4ZmFjZTExZGUzNjVmMzE2 ZTMyOWFmYjVmNzdhZjBjMjljMDIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKQEAgLTI1NTQsMTIgKzI1NTQsMTIgQEAgdm9pZCBT cGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICAgICAgR1BSUmVnIGlu ZGV4R1BSID0gaW5kZXguZ3ByKCk7CiAgICAgICAgICAgICBHUFJSZWcgcmVzdWx0R1BSID0gcmVz dWx0LmdwcigpOwogCi0gICAgICAgICAgICB1c2Uobm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAg ICAgaW5kZXgudXNlKCk7Ci0KICAgICAgICAgICAgIHNwZWN1bGF0aW9uQ2hlY2soT3V0T2ZCb3Vu ZHMsIEpTVmFsdWVSZWdzKCksIG5vZGUsCiAgICAgICAgICAgICAgICAgbV9qaXQuYnJhbmNoMzIo TWFjcm9Bc3NlbWJsZXI6Okxlc3NUaGFuLCBpbmRleEdQUiwgTWFjcm9Bc3NlbWJsZXI6OlRydXN0 ZWRJbW0zMigwKSkpOwogCisgICAgICAgICAgICB1c2Uobm9kZS0+Y2hpbGQxKCkpOworICAgICAg ICAgICAgaW5kZXgudXNlKCk7CisKICAgICAgICAgICAgIG1faml0Lm1vdmUoTWFjcm9Bc3NlbWJs ZXI6OlRydXN0ZWRJbW02NChWYWx1ZVVuZGVmaW5lZCksIHJlc3VsdEdQUik7CiAgICAgICAgICAg ICBqc1ZhbHVlUmVzdWx0KHJlc3VsdEdQUiwgbm9kZSwgVXNlQ2hpbGRyZW5DYWxsZWRFeHBsaWNp dGx5KTsKICAgICAgICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3Rlc3RzL3N0cmVzcy9nZXQtYnktdmFsLW9uLXVuZGVjaWRlZC1vdXQtb2YtYm91bmRzLmpz IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9nZXQtYnktdmFsLW9uLXVuZGVj aWRlZC1vdXQtb2YtYm91bmRzLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE5YWE1Njc0ZTE3NDUzOGM1YTgyOTI2 NmQxZDQ5YjYwM2E3YWIwNzMKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvdGVzdHMvc3RyZXNzL2dldC1ieS12YWwtb24tdW5kZWNpZGVkLW91dC1vZi1ib3VuZHMuanMK QEAgLTAsMCArMSwyMCBAQAorInVzZSBzdHJpY3QiCisKK2Z1bmN0aW9uIG9wYXF1ZUdldEJ5VmFs S25vd25BcnJheSh2YWx1ZSkKK3sKKyAgICBsZXQgYXJyYXkgPSBbXTsKKyAgICByZXR1cm4gYXJy YXlbdmFsdWVdOworfQorbm9JbmxpbmUob3BhcXVlR2V0QnlWYWxLbm93bkFycmF5KTsKKworLy8g V2FybSB1cCB3aXRob3V0IG91dC1vZi1ib3VuZHMgYWNjZXNzLgorZm9yIChsZXQgaSA9IDA7IGkg PCAxZTM7ICsraSkgeworICAgIGlmIChvcGFxdWVHZXRCeVZhbEtub3duQXJyYXkoMCkgIT09IHVu ZGVmaW5lZCkKKyAgICAgICAgdGhyb3cgIkZhaWxlZCBvcGFxdWVHZXRCeVZhbEtub3duQXJyYXko MCkiOworfQorCisvLyBUaGVuIGFjY2VzcyBvdXQgb2YgYm91bmRzLgorZm9yIChsZXQgaSA9IDA7 IGkgPCAxZTM7ICsraSkgeworICAgIGlmIChvcGFxdWVHZXRCeVZhbEtub3duQXJyYXkoLTEpICE9 PSB1bmRlZmluZWQpCisgICAgICAgIHRocm93ICJGYWlsZWQgb3BhcXVlR2V0QnlWYWxLbm93bkFy cmF5KC0xKSI7Cit9ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=