157042 2016-04-26 13:49:29 -0700 [WinCairo][ANGLE] Display object is not created. 2016-04-26 14:46:59 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen commit-queue dino graouts kondapallykalyan oldest_to_newest 1187519 0 peavo 2016-04-26 13:49:29 -0700 The CreateDisplayFromAttribs function will not create a DisplayD3D object when the requested type is EGL_PLATFORM_ANGLE_TYPE_DEFAULT_ANGLE, because ANGLE_ENABLE_OPENGL is not defined. We should be able to create a DisplayD3D object without defining ANGLE_ENABLE_OPENGL. 1187520 1 277407 peavo 2016-04-26 13:53:48 -0700 Created attachment 277407 Patch 1187521 2 commit-queue 2016-04-26 13:55:04 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1187522 3 peavo 2016-04-26 13:58:15 -0700 Thanks for reviewing! 1187525 4 277407 commit-queue 2016-04-26 14:46:54 -0700 Comment on attachment 277407 Patch Clearing flags on attachment: 277407 Committed r200107: <http://trac.webkit.org/changeset/200107> 1187526 5 commit-queue 2016-04-26 14:46:59 -0700 All reviewed patches have been landed. Closing bug. 277407 2016-04-26 13:53:48 -0700 2016-04-26 14:46:54 -0700 Patch bug-157042-20160426225425.patch text/plain 1894 peavo SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDEwNikKKysrIFNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDE2LTA0LTI2ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4K KworICAgICAgICBbV2luQ2Fpcm9dW0FOR0xFXSBEaXNwbGF5IG9iamVjdCBpcyBub3QgY3JlYXRl ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzA0 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBD cmVhdGVEaXNwbGF5RnJvbUF0dHJpYnMgZnVuY3Rpb24gd2lsbCBub3QgY3JlYXRlIGEgRGlzcGxh eUQzRCBvYmplY3Qgd2hlbiB0aGUgcmVxdWVzdGVkCisgICAgICAgIHR5cGUgaXMgRUdMX1BMQVRG T1JNX0FOR0xFX1RZUEVfREVGQVVMVF9BTkdMRSwgYmVjYXVzZSBBTkdMRV9FTkFCTEVfT1BFTkdM IGlzIG5vdCBkZWZpbmVkLgorICAgICAgICBXZSBzaG91bGQgYmUgYWJsZSB0byBjcmVhdGUgYSBE aXNwbGF5RDNEIG9iamVjdCB3aXRob3V0IGRlZmluaW5nIEFOR0xFX0VOQUJMRV9PUEVOR0wuCisK KyAgICAgICAgKiBzcmMvbGliQU5HTEUvRGlzcGxheS5jcHA6CisKIDIwMTYtMDQtMjYgIFBlciBB cm5lIFZvbGxhbiAgPHBlYXZvQG91dGxvb2suY29tPgogCiAgICAgICAgIFtXaW5DYWlyb11bV2Vi R0xdIEVuYWJsZSBFU1NMIGFuZCBHTFNMIHRyYW5zbGF0b3JzLgpJbmRleDogU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL0Rpc3BsYXkuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9EaXNwbGF5LmNwcAkocmV2aXNpb24gMjAw MTA0KQorKysgU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL0Rpc3BsYXkuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMzksMTkgKzEzOSwxNyBAQCByeDo6RGlzcGxheUltcGwgKkNy ZWF0ZURpc3BsYXlGcm9tQXR0cmliCiAgICAgc3dpdGNoIChkaXNwbGF5VHlwZSkKICAgICB7CiAg ICAgICBjYXNlIEVHTF9QTEFURk9STV9BTkdMRV9UWVBFX0RFRkFVTFRfQU5HTEU6Ci0jaWYgZGVm aW5lZChBTkdMRV9FTkFCTEVfT1BFTkdMKQogI2lmIGRlZmluZWQoQU5HTEVfRU5BQkxFX0QzRDkp IHx8IGRlZmluZWQoQU5HTEVfRU5BQkxFX0QzRDExKQogICAgICAgICAvLyBEZWZhdWx0IHRvIEQz RCBkaXNwbGF5cwogICAgICAgICBpbXBsID0gbmV3IHJ4OjpEaXNwbGF5RDNEKCk7Ci0jZWxpZiBk ZWZpbmVkKEFOR0xFX1VTRV9YMTEpCisjZWxpZiBkZWZpbmVkKEFOR0xFX1VTRV9YMTEpICYmIGRl ZmluZWQoQU5HTEVfRU5BQkxFX09QRU5HTCkKICAgICAgICAgaW1wbCA9IG5ldyByeDo6RGlzcGxh eUdMWCgpOwotI2VsaWYgZGVmaW5lZChBTkdMRV9QTEFURk9STV9BUFBMRSkKKyNlbGlmIGRlZmlu ZWQoQU5HTEVfUExBVEZPUk1fQVBQTEUpICYmIGRlZmluZWQoQU5HTEVfRU5BQkxFX09QRU5HTCkK ICAgICAgICAgaW1wbCA9IG5ldyByeDo6RGlzcGxheUNHTCgpOwogI2Vsc2UKICAgICAgICAgLy8g Tm8gZGlzcGxheSBhdmFpbGFibGUKICAgICAgICAgVU5SRUFDSEFCTEUoKTsKICNlbmRpZgotI2Vu ZGlmCiAgICAgICAgIGJyZWFrOwogCiAgICAgICBjYXNlIEVHTF9QTEFURk9STV9BTkdMRV9UWVBF X0QzRDlfQU5HTEU6Cg==