157019 2016-04-25 20:33:45 -0700 [iOS] ftp links crash @ WebCore::FTPDirectoryDocumentParser::appendEntry 2016-04-25 22:07:23 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan cdumez commit-queue esprehn+autocc gyuyoung.kim jiewen_tan kling webkit-bug-importer oldest_to_newest 1187203 0 277315 jiewen_tan 2016-04-25 20:33:45 -0700 Created attachment 277315 crash test case ftp links crash @ WebCore::FTPDirectoryDocumentParser::appendEntry 1187206 1 jiewen_tan 2016-04-25 20:34:27 -0700 <rdar://problem/24292650> 1187211 2 277321 jiewen_tan 2016-04-25 20:41:10 -0700 Created attachment 277321 Patch 1187213 3 277321 cdumez 2016-04-25 20:46:47 -0700 Comment on attachment 277321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277321&action=review > Source/WebCore/ChangeLog:10 > + one. Can you clarify why? 1187215 4 277321 cdumez 2016-04-25 20:47:31 -0700 Comment on attachment 277321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277321&action=review > Source/WebCore/html/FTPDirectoryDocument.cpp:115 > + Ref<Element> nameElement = createTDForFilename(filename); Isn't it OK to assign to a Ref<> after it's been moved out? 1187222 5 277321 cdumez 2016-04-25 20:53:16 -0700 Comment on attachment 277321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277321&action=review >> Source/WebCore/ChangeLog:10 >> + one. > > Can you clarify why? Please explain in the changelog that Ref<>'s operator=() does not allow assignment after a WTFMove(). >> Source/WebCore/html/FTPDirectoryDocument.cpp:115 >> + Ref<Element> nameElement = createTDForFilename(filename); > > Isn't it OK to assign to a Ref<> after it's been moved out? Ok, I have just seem the implementation of Ref& operator=(T& object) and it clearly does not allow assignment after a move :/ 1187223 6 277321 cdumez 2016-04-25 20:54:03 -0700 Comment on attachment 277321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277321&action=review > Source/WebCore/ChangeLog:12 > + No changes of behavior. Why no test? 1187225 7 277321 jiewen_tan 2016-04-25 20:56:37 -0700 Comment on attachment 277321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277321&action=review Thanks Chris for reviewing this patch. >> Source/WebCore/ChangeLog:12 >> + No changes of behavior. > > Why no test? I don't know if it is possible to make a ftp test. Do you know how? >>> Source/WebCore/html/FTPDirectoryDocument.cpp:115 >>> + Ref<Element> nameElement = createTDForFilename(filename); >> >> Isn't it OK to assign to a Ref<> after it's been moved out? > > Ok, I have just seem the implementation of Ref& operator=(T& object) and it clearly does not allow assignment after a move :/ There is an ASSERT in operator= discouraging this usage. Here is the crash log. Process: com.apple.WebKit.WebContent.Development [8919] Path: /Users/USER/Documents/*/WebKit.framework/XPCServices/com.apple.WebKit.WebContent.Development.xpc/com.apple.WebKit.WebContent.Development Identifier: com.apple.WebKit.WebContent.Development Version: 602+ (602.1.30+) Code Type: X86-64 (Native) Parent Process: launchd_sim.development [6184] Responsible: com.apple.WebKit.WebContent.Development [8919] User ID: 501 Date/Time: 2016-04-25 19:16:49.008 -0700 OS Version: Mac OS X 10.11.5 (15F27) Report Version: 11 Anonymous UUID: 959E954D-4D93-D4D4-8B62-15433989F34D Sleep/Wake UUID: D5FEE3D1-A7DD-4FD0-A49D-825F10DE5647 Time Awake Since Boot: 46000 seconds Time Since Wake: 27000 seconds System Integrity Protection: enabled Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef Exception Note: EXC_CORPSE_NOTIFY VM Regions Near 0xbbadbeef: --> __TEXT 0000000104412000-0000000104414000 [ 8K] r-x/rwx SM=COW /Users/USER/Documents/*/WebKit.framework/XPCServices/com.apple.WebKit.WebContent.Development.xpc/com.apple.WebKit.WebContent.Development Application Specific Information: CoreSimulator 245 - Device: iPhone 5s For WebKit Development - Runtime: iOS 10.0 (14A233) - DeviceType: iPhone 5s Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 JavaScriptCore 0x000000010d461d64 WTFCrash + 36 (Assertions.cpp:322) 1 com.apple.WebCore 0x000000010fc4298a WTF::Ref<WebCore::Element>::operator=(WTF::Ref<WebCore::Element>&&) + 74 (Ref.h:98) 2 com.apple.WebCore 0x000000010fc42413 WebCore::FTPDirectoryDocumentParser::appendEntry(WTF::String const&, WTF::String const&, WTF::String const&, bool) + 787 (FTPDirectoryDocument.cpp:115) 3 com.apple.WebCore 0x000000010fc42f6b WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine(WTF::String const&) + 539 (FTPDirectoryDocument.cpp:268) 4 com.apple.WebCore 0x000000010fc44436 WebCore::FTPDirectoryDocumentParser::append(WTF::RefPtr<WTF::StringImpl>&&) + 870 (FTPDirectoryDocument.cpp:394) 5 com.apple.WebCore 0x000000010f7a171f WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter&, char const*, unsigned long) + 175 (DecodedDataDocumentParser.cpp:50) 6 com.apple.WebCore 0x000000010f8d9cd9 WebCore::DocumentWriter::addData(char const*, unsigned long) + 185 (DocumentWriter.cpp:235) 7 com.apple.WebCore 0x000000010f894d50 WebCore::DocumentLoader::commitData(char const*, unsigned long) + 1392 (DocumentLoader.cpp:914) 8 com.apple.WebKit 0x0000000104f6dc9f WebKit::WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 79 (WebFrameLoaderClient.cpp:950) 9 com.apple.WebCore 0x000000010f89790d WebCore::DocumentLoader::commitLoad(char const*, int) + 205 (DocumentLoader.cpp:832) 10 com.apple.WebCore 0x000000010f8981a9 WebCore::DocumentLoader::dataReceived(WebCore::CachedResource*, char const*, int) + 585 (DocumentLoader.cpp:943) 11 com.apple.WebCore 0x000000010f405c28 WebCore::CachedRawResource::notifyClientsDataWasReceived(char const*, unsigned int) + 152 (CachedRawResource.cpp:118) 12 com.apple.WebCore 0x000000010f405ab2 WebCore::CachedRawResource::addDataBuffer(WebCore::SharedBuffer&) + 194 (CachedRawResource.cpp:70) 13 com.apple.WebCore 0x00000001111d6ce5 WebCore::SubresourceLoader::didReceiveDataOrBuffer(char const*, int, WTF::PassRefPtr<WebCore::SharedBuffer>, long long, WebCore::DataPayloadType) + 485 (SubresourceLoader.cpp:322) 14 com.apple.WebCore 0x00000001111d6ae2 WebCore::SubresourceLoader::didReceiveData(char const*, unsigned int, long long, WebCore::DataPayloadType) + 98 (SubresourceLoader.cpp:298) 15 com.apple.WebKit 0x000000010522ecd9 WebKit::WebResourceLoader::didReceiveData(IPC::DataReference const&, long long) + 505 (WebResourceLoader.cpp:146) 16 com.apple.WebKit 0x0000000105233ddc void IPC::callMemberFunctionImpl<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long), std::__1::tuple<IPC::DataReference, long long>, 0ul, 1ul>(WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long), std::__1::tuple<IPC::DataReference, long long>&&, std::index_sequence<0ul, 1ul>) + 188 (HandleMessage.h:17) 17 com.apple.WebKit 0x0000000105233bb8 void IPC::callMemberFunction<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long), std::__1::tuple<IPC::DataReference, long long>, std::make_index_sequence<2ul> >(std::__1::tuple<IPC::DataReference, long long>&&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long)) + 88 (HandleMessage.h:23) 18 com.apple.WebKit 0x0000000105233093 void IPC::handleMessage<Messages::WebResourceLoader::DidReceiveData, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long)>(IPC::MessageDecoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long)) + 291 (HandleMessage.h:93) 19 com.apple.WebKit 0x0000000105232856 WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::MessageDecoder&) + 502 (WebResourceLoaderMessageReceiver.cpp:62) 20 com.apple.WebKit 0x0000000104cc8d1d WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 157 (NetworkProcessConnection.cpp:60) 21 com.apple.WebKit 0x0000000104aa06f3 IPC::Connection::dispatchMessage(IPC::MessageDecoder&) + 51 (Connection.cpp:896) 22 com.apple.WebKit 0x0000000104a96192 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 770 (Connection.cpp:928) 23 com.apple.WebKit 0x0000000104aa0ce0 IPC::Connection::dispatchOneMessage() + 1504 (Connection.cpp:957) 24 com.apple.WebKit 0x0000000104abfded IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10::operator()() const + 29 (Connection.cpp:890) 25 com.apple.WebKit 0x0000000104abfdbd void std::__1::__invoke_void_return_wrapper<void>::__call<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10&>(IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10&&&) + 45 (__functional_base:469) 26 com.apple.WebKit 0x0000000104abfc29 std::__1::__function::__func<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10, std::__1::allocator<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10>, void ()>::operator()() + 41 (functional:1437) 27 JavaScriptCore 0x000000010ce96aaa std::__1::function<void ()>::operator()() const + 26 (functional:1817) 28 JavaScriptCore 0x000000010d4a3379 WTF::RunLoop::performWork() + 297 (RunLoop.cpp:106) 29 JavaScriptCore 0x000000010d4a3b34 WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38) 30 com.apple.CoreFoundation 0x0000000107966941 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 31 com.apple.CoreFoundation 0x000000010794b51c __CFRunLoopDoSources0 + 556 32 com.apple.CoreFoundation 0x000000010794aa06 __CFRunLoopRun + 918 33 com.apple.CoreFoundation 0x000000010794a40d CFRunLoopRunSpecific + 285 34 com.apple.Foundation 0x00000001044ac530 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 274 35 com.apple.Foundation 0x00000001044ac40b -[NSRunLoop(NSRunLoop) run] + 76 36 libxpc.dylib 0x000000010915d75b _xpc_objc_main + 400 37 libxpc.dylib 0x000000010915fa86 xpc_main + 189 38 com.apple.WebKit.WebContent.Development 0x0000000104412dbc main + 892 (XPCServiceMain.mm:114) 39 libdyld.dylib 0x0000000108e62679 start + 1 1187228 8 cdumez 2016-04-25 20:58:59 -0700 (In reply to comment #7) > Comment on attachment 277321 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277321&action=review > > Thanks Chris for reviewing this patch. > > >> Source/WebCore/ChangeLog:12 > >> + No changes of behavior. > > > > Why no test? > > I don't know if it is possible to make a ftp test. Do you know how? I have just grep'ed for 'ftp' in our layout tests and did not find anything encouraging :/ I guess we don't have layout test support for FTP? > > >>> Source/WebCore/html/FTPDirectoryDocument.cpp:115 > >>> + Ref<Element> nameElement = createTDForFilename(filename); > >> > >> Isn't it OK to assign to a Ref<> after it's been moved out? > > > > Ok, I have just seem the implementation of Ref& operator=(T& object) and it clearly does not allow assignment after a move :/ > > There is an ASSERT in operator= discouraging this usage. Here is the crash > log. > > Process: com.apple.WebKit.WebContent.Development [8919] > Path: > /Users/USER/Documents/*/WebKit.framework/XPCServices/com.apple.WebKit. > WebContent.Development.xpc/com.apple.WebKit.WebContent.Development > Identifier: com.apple.WebKit.WebContent.Development > Version: 602+ (602.1.30+) > Code Type: X86-64 (Native) > Parent Process: launchd_sim.development [6184] > Responsible: com.apple.WebKit.WebContent.Development [8919] > User ID: 501 > > Date/Time: 2016-04-25 19:16:49.008 -0700 > OS Version: Mac OS X 10.11.5 (15F27) > Report Version: 11 > Anonymous UUID: 959E954D-4D93-D4D4-8B62-15433989F34D > > Sleep/Wake UUID: D5FEE3D1-A7DD-4FD0-A49D-825F10DE5647 > > Time Awake Since Boot: 46000 seconds > Time Since Wake: 27000 seconds > > System Integrity Protection: enabled > > Crashed Thread: 0 Dispatch queue: com.apple.main-thread > > Exception Type: EXC_BAD_ACCESS (SIGSEGV) > Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef > Exception Note: EXC_CORPSE_NOTIFY > > VM Regions Near 0xbbadbeef: > --> > __TEXT 0000000104412000-0000000104414000 [ 8K] > r-x/rwx SM=COW > /Users/USER/Documents/*/WebKit.framework/XPCServices/com.apple.WebKit. > WebContent.Development.xpc/com.apple.WebKit.WebContent.Development > > Application Specific Information: > CoreSimulator 245 - Device: iPhone 5s For WebKit Development - Runtime: iOS > 10.0 (14A233) - DeviceType: iPhone 5s > > Thread 0 Crashed:: Dispatch queue: com.apple.main-thread > 0 JavaScriptCore 0x000000010d461d64 WTFCrash + 36 > (Assertions.cpp:322) > 1 com.apple.WebCore 0x000000010fc4298a > WTF::Ref<WebCore::Element>::operator=(WTF::Ref<WebCore::Element>&&) + 74 > (Ref.h:98) > 2 com.apple.WebCore 0x000000010fc42413 > WebCore::FTPDirectoryDocumentParser::appendEntry(WTF::String const&, > WTF::String const&, WTF::String const&, bool) + 787 > (FTPDirectoryDocument.cpp:115) > 3 com.apple.WebCore 0x000000010fc42f6b > WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine(WTF::String > const&) + 539 (FTPDirectoryDocument.cpp:268) > 4 com.apple.WebCore 0x000000010fc44436 > WebCore::FTPDirectoryDocumentParser::append(WTF::RefPtr<WTF::StringImpl>&&) > + 870 (FTPDirectoryDocument.cpp:394) > 5 com.apple.WebCore 0x000000010f7a171f > WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter&, > char const*, unsigned long) + 175 (DecodedDataDocumentParser.cpp:50) > 6 com.apple.WebCore 0x000000010f8d9cd9 > WebCore::DocumentWriter::addData(char const*, unsigned long) + 185 > (DocumentWriter.cpp:235) > 7 com.apple.WebCore 0x000000010f894d50 > WebCore::DocumentLoader::commitData(char const*, unsigned long) + 1392 > (DocumentLoader.cpp:914) > 8 com.apple.WebKit 0x0000000104f6dc9f > WebKit::WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char > const*, int) + 79 (WebFrameLoaderClient.cpp:950) > 9 com.apple.WebCore 0x000000010f89790d > WebCore::DocumentLoader::commitLoad(char const*, int) + 205 > (DocumentLoader.cpp:832) > 10 com.apple.WebCore 0x000000010f8981a9 > WebCore::DocumentLoader::dataReceived(WebCore::CachedResource*, char const*, > int) + 585 (DocumentLoader.cpp:943) > 11 com.apple.WebCore 0x000000010f405c28 > WebCore::CachedRawResource::notifyClientsDataWasReceived(char const*, > unsigned int) + 152 (CachedRawResource.cpp:118) > 12 com.apple.WebCore 0x000000010f405ab2 > WebCore::CachedRawResource::addDataBuffer(WebCore::SharedBuffer&) + 194 > (CachedRawResource.cpp:70) > 13 com.apple.WebCore 0x00000001111d6ce5 > WebCore::SubresourceLoader::didReceiveDataOrBuffer(char const*, int, > WTF::PassRefPtr<WebCore::SharedBuffer>, long long, WebCore::DataPayloadType) > + 485 (SubresourceLoader.cpp:322) > 14 com.apple.WebCore 0x00000001111d6ae2 > WebCore::SubresourceLoader::didReceiveData(char const*, unsigned int, long > long, WebCore::DataPayloadType) + 98 (SubresourceLoader.cpp:298) > 15 com.apple.WebKit 0x000000010522ecd9 > WebKit::WebResourceLoader::didReceiveData(IPC::DataReference const&, long > long) + 505 (WebResourceLoader.cpp:146) > 16 com.apple.WebKit 0x0000000105233ddc void > IPC::callMemberFunctionImpl<WebKit::WebResourceLoader, void > (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long), > std::__1::tuple<IPC::DataReference, long long>, 0ul, > 1ul>(WebKit::WebResourceLoader*, void > (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long), > std::__1::tuple<IPC::DataReference, long long>&&, std::index_sequence<0ul, > 1ul>) + 188 (HandleMessage.h:17) > 17 com.apple.WebKit 0x0000000105233bb8 void > IPC::callMemberFunction<WebKit::WebResourceLoader, void > (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long), > std::__1::tuple<IPC::DataReference, long long>, > std::make_index_sequence<2ul> >(std::__1::tuple<IPC::DataReference, long > long>&&, WebKit::WebResourceLoader*, void > (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long)) + 88 > (HandleMessage.h:23) > 18 com.apple.WebKit 0x0000000105233093 void > IPC::handleMessage<Messages::WebResourceLoader::DidReceiveData, > WebKit::WebResourceLoader, void > (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long > long)>(IPC::MessageDecoder&, WebKit::WebResourceLoader*, void > (WebKit::WebResourceLoader::*)(IPC::DataReference const&, long long)) + 291 > (HandleMessage.h:93) > 19 com.apple.WebKit 0x0000000105232856 > WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC:: > Connection&, IPC::MessageDecoder&) + 502 > (WebResourceLoaderMessageReceiver.cpp:62) > 20 com.apple.WebKit 0x0000000104cc8d1d > WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, > IPC::MessageDecoder&) + 157 (NetworkProcessConnection.cpp:60) > 21 com.apple.WebKit 0x0000000104aa06f3 > IPC::Connection::dispatchMessage(IPC::MessageDecoder&) + 51 > (Connection.cpp:896) > 22 com.apple.WebKit 0x0000000104a96192 > IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, > std::__1::default_delete<IPC::MessageDecoder> >) + 770 (Connection.cpp:928) > 23 com.apple.WebKit 0x0000000104aa0ce0 > IPC::Connection::dispatchOneMessage() + 1504 (Connection.cpp:957) > 24 com.apple.WebKit 0x0000000104abfded > IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC:: > MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> > >)::$_10::operator()() const + 29 (Connection.cpp:890) > 25 com.apple.WebKit 0x0000000104abfdbd void > std::__1::__invoke_void_return_wrapper<void>::__call<IPC::Connection:: > enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, > std::__1::default_delete<IPC::MessageDecoder> > >)::$_10&>(IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC:: > MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10&&&) + > 45 (__functional_base:469) > 26 com.apple.WebKit 0x0000000104abfc29 > std::__1::__function::__func<IPC::Connection::enqueueIncomingMessage(std:: > __1::unique_ptr<IPC::MessageDecoder, > std::__1::default_delete<IPC::MessageDecoder> >)::$_10, > std::__1::allocator<IPC::Connection::enqueueIncomingMessage(std::__1:: > unique_ptr<IPC::MessageDecoder, > std::__1::default_delete<IPC::MessageDecoder> >)::$_10>, void > ()>::operator()() + 41 (functional:1437) > 27 JavaScriptCore 0x000000010ce96aaa > std::__1::function<void ()>::operator()() const + 26 (functional:1817) > 28 JavaScriptCore 0x000000010d4a3379 > WTF::RunLoop::performWork() + 297 (RunLoop.cpp:106) > 29 JavaScriptCore 0x000000010d4a3b34 > WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38) > 30 com.apple.CoreFoundation 0x0000000107966941 > __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 > 31 com.apple.CoreFoundation 0x000000010794b51c __CFRunLoopDoSources0 > + 556 > 32 com.apple.CoreFoundation 0x000000010794aa06 __CFRunLoopRun + 918 > 33 com.apple.CoreFoundation 0x000000010794a40d CFRunLoopRunSpecific + > 285 > 34 com.apple.Foundation 0x00000001044ac530 -[NSRunLoop(NSRunLoop) > runMode:beforeDate:] + 274 > 35 com.apple.Foundation 0x00000001044ac40b -[NSRunLoop(NSRunLoop) > run] + 76 > 36 libxpc.dylib 0x000000010915d75b _xpc_objc_main + 400 > 37 libxpc.dylib 0x000000010915fa86 xpc_main + 189 > 38 com.apple.WebKit.WebContent.Development 0x0000000104412dbc main + 892 > (XPCServiceMain.mm:114) > 39 libdyld.dylib 0x0000000108e62679 start + 1 Even in release, this would crash since it called m_ptr->deref(); and m_ptr has been nulled out by the move. 1187229 9 277321 cdumez 2016-04-25 20:59:43 -0700 Comment on attachment 277321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277321&action=review >>>> Source/WebCore/ChangeLog:12 >>>> + No changes of behavior. >>> >>> Why no test? >> >> I don't know if it is possible to make a ftp test. Do you know how? > > I have just grep'ed for 'ftp' in our layout tests and did not find anything encouraging :/ I guess we don't have layout test support for FTP? Just drop this "No changes of behavior." as this is not true. You are fixing a crash. 1187234 10 277325 jiewen_tan 2016-04-25 21:08:43 -0700 Created attachment 277325 Patch 1187235 11 277326 jiewen_tan 2016-04-25 21:11:45 -0700 Created attachment 277326 Patch 1187262 12 277326 commit-queue 2016-04-25 22:07:18 -0700 Comment on attachment 277326 Patch Clearing flags on attachment: 277326 Committed r200074: <http://trac.webkit.org/changeset/200074> 1187263 13 commit-queue 2016-04-25 22:07:23 -0700 All reviewed patches have been landed. Closing bug. 277315 2016-04-25 20:33:45 -0700 2016-04-25 20:33:45 -0700 crash test case ftp.html text/html 242 jiewen_tan PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4K ICAgICAgICA8YSBocmVmPSJmdHA6Ly9mdHAuZnJlZWJzZC5vcmcvcHViL0ZyZWVCU0QvcmVsZWFz ZXMvYW1kNjQvYW1kNjQvSVNPLUlNQUdFUy8xMC4zLyI+ZnRwOi8vZnRwLmZyZWVic2Qub3JnL3B1 Yi9GcmVlQlNEL3JlbGVhc2VzL2FtZDY0L2FtZDY0L0lTTy1JTUFHRVMvMTAuMy88L2E+CiAgICA8 L2JvZHk+CjwvaHRtbD4= 277321 2016-04-25 20:41:10 -0700 2016-04-25 21:08:38 -0700 Patch bug-157019-20160425204138.patch text/plain 4015 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI2MDkzNTQyM2Q2YzI3 YmQyYmVlMzA0OTZiMjJkZTYzN2E4OTBiOC4uYTBjMzE2MDg5YzFmNDQ0NjFiMjgzODMxYmU2OWI1 YzhjZGM4NmI3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA0LTI1ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gZnRwIGxpbmtz IGNyYXNoIEAgV2ViQ29yZTo6RlRQRGlyZWN0b3J5RG9jdW1lbnRQYXJzZXI6OmFwcGVuZEVudHJ5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcwMTkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0MjkyNjUwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyZWF0ZSBzZXBhcmF0ZSBSZWY8RWxlbWVudD4g b2JqZWN0IGZvciBldmVyeSByb3cgZWxlbWVudCBpbnN0ZWFkIG9mIHJldXNpbmcKKyAgICAgICAg b25lLgorCisgICAgICAgIE5vIGNoYW5nZXMgb2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBodG1s L0ZUUERpcmVjdG9yeURvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZUUERpcmVjdG9y eURvY3VtZW50UGFyc2VyOjphcHBlbmRFbnRyeSk6CisKIDIwMTYtMDQtMjIgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBDYW5ub3QgYWNjZXNzIHRoZSBTUUxUcmFu c2FjdGlvbi5jb25zdHJ1Y3Rvci5wcm90b3R5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvRlRQRGlyZWN0b3J5RG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9GVFBE aXJlY3RvcnlEb2N1bWVudC5jcHAKaW5kZXggN2E2NDUzMzFlZGIyY2NiMWY1MmE4NmE5MjNjMjVh YWYxODU1MDJlYy4uYTczNGM3NWFmMjE5ZTAzZTI5NjYxOTk4MjlkNTAxYzEwZmE4NDY2YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9GVFBEaXJlY3RvcnlEb2N1bWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9GVFBEaXJlY3RvcnlEb2N1bWVudC5jcHAKQEAgLTEwNCwy NyArMTA0LDI3IEBAIHZvaWQgRlRQRGlyZWN0b3J5RG9jdW1lbnRQYXJzZXI6OmFwcGVuZEVudHJ5 KGNvbnN0IFN0cmluZyYgZmlsZW5hbWUsIGNvbnN0IFN0cmluCiAgICAgUmVmUHRyPEVsZW1lbnQ+ IHJvd0VsZW1lbnQgPSBtX3RhYmxlRWxlbWVudC0+aW5zZXJ0Um93KC0xLCBJR05PUkVfRVhDRVBU SU9OKTsKICAgICByb3dFbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIs ICJmdHBEaXJlY3RvcnlFbnRyeVJvdyIpOwogCi0gICAgUmVmPEVsZW1lbnQ+IGVsZW1lbnQgPSBk b2N1bWVudCgpLT5jcmVhdGVFbGVtZW50KHRkVGFnLCBmYWxzZSk7Ci0gICAgZWxlbWVudC0+YXBw ZW5kQ2hpbGQoVGV4dDo6Y3JlYXRlKCpkb2N1bWVudCgpLCBTdHJpbmcoJm5vQnJlYWtTcGFjZSwg MSkpLCBJR05PUkVfRVhDRVBUSU9OKTsKKyAgICBSZWY8RWxlbWVudD4gdHlwZUVsZW1lbnQgPSBk b2N1bWVudCgpLT5jcmVhdGVFbGVtZW50KHRkVGFnLCBmYWxzZSk7CisgICAgdHlwZUVsZW1lbnQt PmFwcGVuZENoaWxkKFRleHQ6OmNyZWF0ZSgqZG9jdW1lbnQoKSwgU3RyaW5nKCZub0JyZWFrU3Bh Y2UsIDEpKSwgSUdOT1JFX0VYQ0VQVElPTik7CiAgICAgaWYgKGlzRGlyZWN0b3J5KQotICAgICAg ICBlbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3Rv cnlJY29uIGZ0cERpcmVjdG9yeVR5cGVEaXJlY3RvcnkiKTsKKyAgICAgICAgdHlwZUVsZW1lbnQt PnNldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmNsYXNzQXR0ciwgImZ0cERpcmVjdG9yeUljb24gZnRw RGlyZWN0b3J5VHlwZURpcmVjdG9yeSIpOwogICAgIGVsc2UKLSAgICAgICAgZWxlbWVudC0+c2V0 QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0b3J5SWNvbiBmdHBEaXJl Y3RvcnlUeXBlRmlsZSIpOwotICAgIHJvd0VsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZWxl bWVudCksIElHTk9SRV9FWENFUFRJT04pOwotCi0gICAgZWxlbWVudCA9IGNyZWF0ZVRERm9yRmls ZW5hbWUoZmlsZW5hbWUpOwotICAgIGVsZW1lbnQtPnNldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmNs YXNzQXR0ciwgImZ0cERpcmVjdG9yeUZpbGVOYW1lIik7Ci0gICAgcm93RWxlbWVudC0+YXBwZW5k Q2hpbGQoV1RGTW92ZShlbGVtZW50KSwgSUdOT1JFX0VYQ0VQVElPTik7Ci0KLSAgICBlbGVtZW50 ID0gZG9jdW1lbnQoKS0+Y3JlYXRlRWxlbWVudCh0ZFRhZywgZmFsc2UpOwotICAgIGVsZW1lbnQt PmFwcGVuZENoaWxkKFRleHQ6OmNyZWF0ZSgqZG9jdW1lbnQoKSwgZGF0ZSksIElHTk9SRV9FWENF UFRJT04pOwotICAgIGVsZW1lbnQtPnNldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmNsYXNzQXR0ciwg ImZ0cERpcmVjdG9yeUZpbGVEYXRlIik7Ci0gICAgcm93RWxlbWVudC0+YXBwZW5kQ2hpbGQoV1RG TW92ZShlbGVtZW50KSwgSUdOT1JFX0VYQ0VQVElPTik7Ci0KLSAgICBlbGVtZW50ID0gZG9jdW1l bnQoKS0+Y3JlYXRlRWxlbWVudCh0ZFRhZywgZmFsc2UpOwotICAgIGVsZW1lbnQtPmFwcGVuZENo aWxkKFRleHQ6OmNyZWF0ZSgqZG9jdW1lbnQoKSwgc2l6ZSksIElHTk9SRV9FWENFUFRJT04pOwot ICAgIGVsZW1lbnQtPnNldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmNsYXNzQXR0ciwgImZ0cERpcmVj dG9yeUZpbGVTaXplIik7Ci0gICAgcm93RWxlbWVudC0+YXBwZW5kQ2hpbGQoV1RGTW92ZShlbGVt ZW50KSwgSUdOT1JFX0VYQ0VQVElPTik7CisgICAgICAgIHR5cGVFbGVtZW50LT5zZXRBdHRyaWJ1 dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlJY29uIGZ0cERpcmVjdG9yeVR5 cGVGaWxlIik7CisgICAgcm93RWxlbWVudC0+YXBwZW5kQ2hpbGQoV1RGTW92ZSh0eXBlRWxlbWVu dCksIElHTk9SRV9FWENFUFRJT04pOworCisgICAgUmVmPEVsZW1lbnQ+IG5hbWVFbGVtZW50ID0g Y3JlYXRlVERGb3JGaWxlbmFtZShmaWxlbmFtZSk7CisgICAgbmFtZUVsZW1lbnQtPnNldEF0dHJp YnV0ZShIVE1MTmFtZXM6OmNsYXNzQXR0ciwgImZ0cERpcmVjdG9yeUZpbGVOYW1lIik7CisgICAg cm93RWxlbWVudC0+YXBwZW5kQ2hpbGQoV1RGTW92ZShuYW1lRWxlbWVudCksIElHTk9SRV9FWENF UFRJT04pOworCisgICAgUmVmPEVsZW1lbnQ+IGRhdGVFbGVtZW50ID0gZG9jdW1lbnQoKS0+Y3Jl YXRlRWxlbWVudCh0ZFRhZywgZmFsc2UpOworICAgIGRhdGVFbGVtZW50LT5hcHBlbmRDaGlsZChU ZXh0OjpjcmVhdGUoKmRvY3VtZW50KCksIGRhdGUpLCBJR05PUkVfRVhDRVBUSU9OKTsKKyAgICBk YXRlRWxlbWVudC0+c2V0QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0 b3J5RmlsZURhdGUiKTsKKyAgICByb3dFbGVtZW50LT5hcHBlbmRDaGlsZChXVEZNb3ZlKGRhdGVF bGVtZW50KSwgSUdOT1JFX0VYQ0VQVElPTik7CisKKyAgICBSZWY8RWxlbWVudD4gc2l6ZUVsZW1l bnQgPSBkb2N1bWVudCgpLT5jcmVhdGVFbGVtZW50KHRkVGFnLCBmYWxzZSk7CisgICAgc2l6ZUVs ZW1lbnQtPmFwcGVuZENoaWxkKFRleHQ6OmNyZWF0ZSgqZG9jdW1lbnQoKSwgc2l6ZSksIElHTk9S RV9FWENFUFRJT04pOworICAgIHNpemVFbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpj bGFzc0F0dHIsICJmdHBEaXJlY3RvcnlGaWxlU2l6ZSIpOworICAgIHJvd0VsZW1lbnQtPmFwcGVu ZENoaWxkKFdURk1vdmUoc2l6ZUVsZW1lbnQpLCBJR05PUkVfRVhDRVBUSU9OKTsKIH0KIAogUmVm PEVsZW1lbnQ+IEZUUERpcmVjdG9yeURvY3VtZW50UGFyc2VyOjpjcmVhdGVUREZvckZpbGVuYW1l KGNvbnN0IFN0cmluZyYgZmlsZW5hbWUpCg== 277325 2016-04-25 21:08:43 -0700 2016-04-25 21:11:41 -0700 Patch bug-157019-20160425210911.patch text/plain 4052 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI2MDkzNTQyM2Q2YzI3 YmQyYmVlMzA0OTZiMjJkZTYzN2E4OTBiOC4uYWUwZmQ1M2M2ODAwYTlkNzY1ZmQyNTBjZDMxYzE0 ZGNmMzM1MTNkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA0LTI1ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gZnRwIGxpbmtz IGNyYXNoIEAgV2ViQ29yZTo6RlRQRGlyZWN0b3J5RG9jdW1lbnRQYXJzZXI6OmFwcGVuZEVudHJ5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcwMTkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0MjkyNjUwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyZWF0ZSBzZXBhcmF0ZSBSZWY8RWxlbWVudD4g b2JqZWN0IGZvciBldmVyeSByb3cgZWxlbWVudCBpbnN0ZWFkIG9mIHJldXNpbmcKKyAgICAgICAg b25lIGJlY2F1c2UgUmVmPD4ncyBvcGVyYXRvcj0oKSBkb2VzIG5vdCBhbGxvdyBhc3NpZ25tZW50 IGFmdGVyIGEgV1RGTW92ZSgpLgorCisgICAgICAgICogaHRtbC9GVFBEaXJlY3RvcnlEb2N1bWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGVFBEaXJlY3RvcnlEb2N1bWVudFBhcnNlcjo6YXBw ZW5kRW50cnkpOgorCiAyMDE2LTA0LTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgQ2Fubm90IGFjY2VzcyB0aGUgU1FMVHJhbnNhY3Rpb24uY29uc3RydWN0b3Iu cHJvdG90eXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZUUERpcmVjdG9yeURv Y3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRlRQRGlyZWN0b3J5RG9jdW1lbnQuY3Bw CmluZGV4IDdhNjQ1MzMxZWRiMmNjYjFmNTJhODZhOTIzYzI1YWFmMTg1NTAyZWMuLmE3MzRjNzVh ZjIxOWUwM2UyOTY2MTk5ODI5ZDUwMWMxMGZhODQ2NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvRlRQRGlyZWN0b3J5RG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvRlRQRGlyZWN0b3J5RG9jdW1lbnQuY3BwCkBAIC0xMDQsMjcgKzEwNCwyNyBAQCB2b2lkIEZU UERpcmVjdG9yeURvY3VtZW50UGFyc2VyOjphcHBlbmRFbnRyeShjb25zdCBTdHJpbmcmIGZpbGVu YW1lLCBjb25zdCBTdHJpbgogICAgIFJlZlB0cjxFbGVtZW50PiByb3dFbGVtZW50ID0gbV90YWJs ZUVsZW1lbnQtPmluc2VydFJvdygtMSwgSUdOT1JFX0VYQ0VQVElPTik7CiAgICAgcm93RWxlbWVu dC0+c2V0QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0b3J5RW50cnlS b3ciKTsKIAotICAgIFJlZjxFbGVtZW50PiBlbGVtZW50ID0gZG9jdW1lbnQoKS0+Y3JlYXRlRWxl bWVudCh0ZFRhZywgZmFsc2UpOwotICAgIGVsZW1lbnQtPmFwcGVuZENoaWxkKFRleHQ6OmNyZWF0 ZSgqZG9jdW1lbnQoKSwgU3RyaW5nKCZub0JyZWFrU3BhY2UsIDEpKSwgSUdOT1JFX0VYQ0VQVElP Tik7CisgICAgUmVmPEVsZW1lbnQ+IHR5cGVFbGVtZW50ID0gZG9jdW1lbnQoKS0+Y3JlYXRlRWxl bWVudCh0ZFRhZywgZmFsc2UpOworICAgIHR5cGVFbGVtZW50LT5hcHBlbmRDaGlsZChUZXh0Ojpj cmVhdGUoKmRvY3VtZW50KCksIFN0cmluZygmbm9CcmVha1NwYWNlLCAxKSksIElHTk9SRV9FWENF UFRJT04pOwogICAgIGlmIChpc0RpcmVjdG9yeSkKLSAgICAgICAgZWxlbWVudC0+c2V0QXR0cmli dXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0b3J5SWNvbiBmdHBEaXJlY3RvcnlU eXBlRGlyZWN0b3J5Iik7CisgICAgICAgIHR5cGVFbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5h bWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlJY29uIGZ0cERpcmVjdG9yeVR5cGVEaXJlY3Rv cnkiKTsKICAgICBlbHNlCi0gICAgICAgIGVsZW1lbnQtPnNldEF0dHJpYnV0ZShIVE1MTmFtZXM6 OmNsYXNzQXR0ciwgImZ0cERpcmVjdG9yeUljb24gZnRwRGlyZWN0b3J5VHlwZUZpbGUiKTsKLSAg ICByb3dFbGVtZW50LT5hcHBlbmRDaGlsZChXVEZNb3ZlKGVsZW1lbnQpLCBJR05PUkVfRVhDRVBU SU9OKTsKLQotICAgIGVsZW1lbnQgPSBjcmVhdGVUREZvckZpbGVuYW1lKGZpbGVuYW1lKTsKLSAg ICBlbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3Rv cnlGaWxlTmFtZSIpOwotICAgIHJvd0VsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZWxlbWVu dCksIElHTk9SRV9FWENFUFRJT04pOwotCi0gICAgZWxlbWVudCA9IGRvY3VtZW50KCktPmNyZWF0 ZUVsZW1lbnQodGRUYWcsIGZhbHNlKTsKLSAgICBlbGVtZW50LT5hcHBlbmRDaGlsZChUZXh0Ojpj cmVhdGUoKmRvY3VtZW50KCksIGRhdGUpLCBJR05PUkVfRVhDRVBUSU9OKTsKLSAgICBlbGVtZW50 LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlGaWxlRGF0 ZSIpOwotICAgIHJvd0VsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZWxlbWVudCksIElHTk9S RV9FWENFUFRJT04pOwotCi0gICAgZWxlbWVudCA9IGRvY3VtZW50KCktPmNyZWF0ZUVsZW1lbnQo dGRUYWcsIGZhbHNlKTsKLSAgICBlbGVtZW50LT5hcHBlbmRDaGlsZChUZXh0OjpjcmVhdGUoKmRv Y3VtZW50KCksIHNpemUpLCBJR05PUkVfRVhDRVBUSU9OKTsKLSAgICBlbGVtZW50LT5zZXRBdHRy aWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlGaWxlU2l6ZSIpOwotICAg IHJvd0VsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZWxlbWVudCksIElHTk9SRV9FWENFUFRJ T04pOworICAgICAgICB0eXBlRWxlbWVudC0+c2V0QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NB dHRyLCAiZnRwRGlyZWN0b3J5SWNvbiBmdHBEaXJlY3RvcnlUeXBlRmlsZSIpOworICAgIHJvd0Vs ZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUodHlwZUVsZW1lbnQpLCBJR05PUkVfRVhDRVBUSU9O KTsKKworICAgIFJlZjxFbGVtZW50PiBuYW1lRWxlbWVudCA9IGNyZWF0ZVRERm9yRmlsZW5hbWUo ZmlsZW5hbWUpOworICAgIG5hbWVFbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFz c0F0dHIsICJmdHBEaXJlY3RvcnlGaWxlTmFtZSIpOworICAgIHJvd0VsZW1lbnQtPmFwcGVuZENo aWxkKFdURk1vdmUobmFtZUVsZW1lbnQpLCBJR05PUkVfRVhDRVBUSU9OKTsKKworICAgIFJlZjxF bGVtZW50PiBkYXRlRWxlbWVudCA9IGRvY3VtZW50KCktPmNyZWF0ZUVsZW1lbnQodGRUYWcsIGZh bHNlKTsKKyAgICBkYXRlRWxlbWVudC0+YXBwZW5kQ2hpbGQoVGV4dDo6Y3JlYXRlKCpkb2N1bWVu dCgpLCBkYXRlKSwgSUdOT1JFX0VYQ0VQVElPTik7CisgICAgZGF0ZUVsZW1lbnQtPnNldEF0dHJp YnV0ZShIVE1MTmFtZXM6OmNsYXNzQXR0ciwgImZ0cERpcmVjdG9yeUZpbGVEYXRlIik7CisgICAg cm93RWxlbWVudC0+YXBwZW5kQ2hpbGQoV1RGTW92ZShkYXRlRWxlbWVudCksIElHTk9SRV9FWENF UFRJT04pOworCisgICAgUmVmPEVsZW1lbnQ+IHNpemVFbGVtZW50ID0gZG9jdW1lbnQoKS0+Y3Jl YXRlRWxlbWVudCh0ZFRhZywgZmFsc2UpOworICAgIHNpemVFbGVtZW50LT5hcHBlbmRDaGlsZChU ZXh0OjpjcmVhdGUoKmRvY3VtZW50KCksIHNpemUpLCBJR05PUkVfRVhDRVBUSU9OKTsKKyAgICBz aXplRWxlbWVudC0+c2V0QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0 b3J5RmlsZVNpemUiKTsKKyAgICByb3dFbGVtZW50LT5hcHBlbmRDaGlsZChXVEZNb3ZlKHNpemVF bGVtZW50KSwgSUdOT1JFX0VYQ0VQVElPTik7CiB9CiAKIFJlZjxFbGVtZW50PiBGVFBEaXJlY3Rv cnlEb2N1bWVudFBhcnNlcjo6Y3JlYXRlVERGb3JGaWxlbmFtZShjb25zdCBTdHJpbmcmIGZpbGVu YW1lKQo= 277326 2016-04-25 21:11:45 -0700 2016-04-25 22:07:18 -0700 Patch bug-157019-20160425211213.patch text/plain 4049 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI2MDkzNTQyM2Q2YzI3 YmQyYmVlMzA0OTZiMjJkZTYzN2E4OTBiOC4uNTFmZWFiMjgyOTllYTkzOTk2Mjk4ZDM1ZjRiZTE0 NDhiZWM1ZDMwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA0LTI1ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gZnRwIGxpbmtz IGNyYXNoIEAgV2ViQ29yZTo6RlRQRGlyZWN0b3J5RG9jdW1lbnRQYXJzZXI6OmFwcGVuZEVudHJ5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcwMTkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0MjkyNjUwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IENocmlzIER1bWV6LgorCisgICAgICAgIENyZWF0ZSBzZXBhcmF0ZSBSZWY8RWxlbWVudD4gb2Jq ZWN0IGZvciBldmVyeSByb3cgZWxlbWVudCBpbnN0ZWFkIG9mIHJldXNpbmcKKyAgICAgICAgb25l IGJlY2F1c2UgUmVmPD4ncyBvcGVyYXRvcj0oKSBkb2VzIG5vdCBhbGxvdyBhc3NpZ25tZW50IGFm dGVyIGEgV1RGTW92ZSgpLgorCisgICAgICAgICogaHRtbC9GVFBEaXJlY3RvcnlEb2N1bWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGVFBEaXJlY3RvcnlEb2N1bWVudFBhcnNlcjo6YXBwZW5k RW50cnkpOgorCiAyMDE2LTA0LTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgQ2Fubm90IGFjY2VzcyB0aGUgU1FMVHJhbnNhY3Rpb24uY29uc3RydWN0b3IucHJv dG90eXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZUUERpcmVjdG9yeURvY3Vt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRlRQRGlyZWN0b3J5RG9jdW1lbnQuY3BwCmlu ZGV4IDdhNjQ1MzMxZWRiMmNjYjFmNTJhODZhOTIzYzI1YWFmMTg1NTAyZWMuLmE3MzRjNzVhZjIx OWUwM2UyOTY2MTk5ODI5ZDUwMWMxMGZhODQ2NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvRlRQRGlyZWN0b3J5RG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv RlRQRGlyZWN0b3J5RG9jdW1lbnQuY3BwCkBAIC0xMDQsMjcgKzEwNCwyNyBAQCB2b2lkIEZUUERp cmVjdG9yeURvY3VtZW50UGFyc2VyOjphcHBlbmRFbnRyeShjb25zdCBTdHJpbmcmIGZpbGVuYW1l LCBjb25zdCBTdHJpbgogICAgIFJlZlB0cjxFbGVtZW50PiByb3dFbGVtZW50ID0gbV90YWJsZUVs ZW1lbnQtPmluc2VydFJvdygtMSwgSUdOT1JFX0VYQ0VQVElPTik7CiAgICAgcm93RWxlbWVudC0+ c2V0QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0b3J5RW50cnlSb3ci KTsKIAotICAgIFJlZjxFbGVtZW50PiBlbGVtZW50ID0gZG9jdW1lbnQoKS0+Y3JlYXRlRWxlbWVu dCh0ZFRhZywgZmFsc2UpOwotICAgIGVsZW1lbnQtPmFwcGVuZENoaWxkKFRleHQ6OmNyZWF0ZSgq ZG9jdW1lbnQoKSwgU3RyaW5nKCZub0JyZWFrU3BhY2UsIDEpKSwgSUdOT1JFX0VYQ0VQVElPTik7 CisgICAgUmVmPEVsZW1lbnQ+IHR5cGVFbGVtZW50ID0gZG9jdW1lbnQoKS0+Y3JlYXRlRWxlbWVu dCh0ZFRhZywgZmFsc2UpOworICAgIHR5cGVFbGVtZW50LT5hcHBlbmRDaGlsZChUZXh0OjpjcmVh dGUoKmRvY3VtZW50KCksIFN0cmluZygmbm9CcmVha1NwYWNlLCAxKSksIElHTk9SRV9FWENFUFRJ T04pOwogICAgIGlmIChpc0RpcmVjdG9yeSkKLSAgICAgICAgZWxlbWVudC0+c2V0QXR0cmlidXRl KEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0b3J5SWNvbiBmdHBEaXJlY3RvcnlUeXBl RGlyZWN0b3J5Iik7CisgICAgICAgIHR5cGVFbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVz OjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlJY29uIGZ0cERpcmVjdG9yeVR5cGVEaXJlY3Rvcnki KTsKICAgICBlbHNlCi0gICAgICAgIGVsZW1lbnQtPnNldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmNs YXNzQXR0ciwgImZ0cERpcmVjdG9yeUljb24gZnRwRGlyZWN0b3J5VHlwZUZpbGUiKTsKLSAgICBy b3dFbGVtZW50LT5hcHBlbmRDaGlsZChXVEZNb3ZlKGVsZW1lbnQpLCBJR05PUkVfRVhDRVBUSU9O KTsKLQotICAgIGVsZW1lbnQgPSBjcmVhdGVUREZvckZpbGVuYW1lKGZpbGVuYW1lKTsKLSAgICBl bGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlG aWxlTmFtZSIpOwotICAgIHJvd0VsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZWxlbWVudCks IElHTk9SRV9FWENFUFRJT04pOwotCi0gICAgZWxlbWVudCA9IGRvY3VtZW50KCktPmNyZWF0ZUVs ZW1lbnQodGRUYWcsIGZhbHNlKTsKLSAgICBlbGVtZW50LT5hcHBlbmRDaGlsZChUZXh0OjpjcmVh dGUoKmRvY3VtZW50KCksIGRhdGUpLCBJR05PUkVfRVhDRVBUSU9OKTsKLSAgICBlbGVtZW50LT5z ZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlGaWxlRGF0ZSIp OwotICAgIHJvd0VsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZWxlbWVudCksIElHTk9SRV9F WENFUFRJT04pOwotCi0gICAgZWxlbWVudCA9IGRvY3VtZW50KCktPmNyZWF0ZUVsZW1lbnQodGRU YWcsIGZhbHNlKTsKLSAgICBlbGVtZW50LT5hcHBlbmRDaGlsZChUZXh0OjpjcmVhdGUoKmRvY3Vt ZW50KCksIHNpemUpLCBJR05PUkVfRVhDRVBUSU9OKTsKLSAgICBlbGVtZW50LT5zZXRBdHRyaWJ1 dGUoSFRNTE5hbWVzOjpjbGFzc0F0dHIsICJmdHBEaXJlY3RvcnlGaWxlU2l6ZSIpOwotICAgIHJv d0VsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZWxlbWVudCksIElHTk9SRV9FWENFUFRJT04p OworICAgICAgICB0eXBlRWxlbWVudC0+c2V0QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRy LCAiZnRwRGlyZWN0b3J5SWNvbiBmdHBEaXJlY3RvcnlUeXBlRmlsZSIpOworICAgIHJvd0VsZW1l bnQtPmFwcGVuZENoaWxkKFdURk1vdmUodHlwZUVsZW1lbnQpLCBJR05PUkVfRVhDRVBUSU9OKTsK KworICAgIFJlZjxFbGVtZW50PiBuYW1lRWxlbWVudCA9IGNyZWF0ZVRERm9yRmlsZW5hbWUoZmls ZW5hbWUpOworICAgIG5hbWVFbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpjbGFzc0F0 dHIsICJmdHBEaXJlY3RvcnlGaWxlTmFtZSIpOworICAgIHJvd0VsZW1lbnQtPmFwcGVuZENoaWxk KFdURk1vdmUobmFtZUVsZW1lbnQpLCBJR05PUkVfRVhDRVBUSU9OKTsKKworICAgIFJlZjxFbGVt ZW50PiBkYXRlRWxlbWVudCA9IGRvY3VtZW50KCktPmNyZWF0ZUVsZW1lbnQodGRUYWcsIGZhbHNl KTsKKyAgICBkYXRlRWxlbWVudC0+YXBwZW5kQ2hpbGQoVGV4dDo6Y3JlYXRlKCpkb2N1bWVudCgp LCBkYXRlKSwgSUdOT1JFX0VYQ0VQVElPTik7CisgICAgZGF0ZUVsZW1lbnQtPnNldEF0dHJpYnV0 ZShIVE1MTmFtZXM6OmNsYXNzQXR0ciwgImZ0cERpcmVjdG9yeUZpbGVEYXRlIik7CisgICAgcm93 RWxlbWVudC0+YXBwZW5kQ2hpbGQoV1RGTW92ZShkYXRlRWxlbWVudCksIElHTk9SRV9FWENFUFRJ T04pOworCisgICAgUmVmPEVsZW1lbnQ+IHNpemVFbGVtZW50ID0gZG9jdW1lbnQoKS0+Y3JlYXRl RWxlbWVudCh0ZFRhZywgZmFsc2UpOworICAgIHNpemVFbGVtZW50LT5hcHBlbmRDaGlsZChUZXh0 OjpjcmVhdGUoKmRvY3VtZW50KCksIHNpemUpLCBJR05PUkVfRVhDRVBUSU9OKTsKKyAgICBzaXpl RWxlbWVudC0+c2V0QXR0cmlidXRlKEhUTUxOYW1lczo6Y2xhc3NBdHRyLCAiZnRwRGlyZWN0b3J5 RmlsZVNpemUiKTsKKyAgICByb3dFbGVtZW50LT5hcHBlbmRDaGlsZChXVEZNb3ZlKHNpemVFbGVt ZW50KSwgSUdOT1JFX0VYQ0VQVElPTik7CiB9CiAKIFJlZjxFbGVtZW50PiBGVFBEaXJlY3RvcnlE b2N1bWVudFBhcnNlcjo6Y3JlYXRlVERGb3JGaWxlbmFtZShjb25zdCBTdHJpbmcmIGZpbGVuYW1l KQo=