157017 2016-04-25 20:01:28 -0700 [Web IDL] Specify default values for optional parameters of TypedArray types 2016-04-26 09:11:57 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue darin sam youennf oldest_to_newest 1187191 0 cdumez 2016-04-25 20:01:28 -0700 Specify default values for optional parameters of TypedArray types and let the bindings generator use WTF::Optional<> for the ones that do not have a default value. 1187210 1 277320 cdumez 2016-04-25 20:40:50 -0700 Created attachment 277320 Patch 1187361 2 277320 darin 2016-04-26 08:21:03 -0700 Comment on attachment 277320 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277320&action=review > Source/WebCore/html/HTMLMediaElement.idl:102 > + [Conditional=ENCRYPTED_MEDIA, RaisesException] void webkitGenerateKeyRequest(DOMString? keySystem, optional Uint8Array initData = null); > + [Conditional=ENCRYPTED_MEDIA, RaisesException] void webkitAddKey(DOMString? keySystem, Uint8Array key, optional Uint8Array initData = null, optional DOMString sessionId = null); This seems a little peculiar. Given that the argument isn’t nullable, I’m not entirely sure that a default of “null” makes logical sense. Anyway, seems a fine practical way to leave the code for now. 1187402 3 277320 commit-queue 2016-04-26 09:11:53 -0700 Comment on attachment 277320 Patch Clearing flags on attachment: 277320 Committed r200088: <http://trac.webkit.org/changeset/200088> 1187403 4 commit-queue 2016-04-26 09:11:57 -0700 All reviewed patches have been landed. Closing bug. 277320 2016-04-25 20:40:50 -0700 2016-04-26 09:11:53 -0700 Patch bug-157017-20160425204118.patch text/plain 6710 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYyNDNiNmYzMTE1M2Ix ZjZkNGE5ZTZkZmNiYTc2MjYzNThiNzU0Yi4uYzYwMjkzMThlZTY0OTgxZDQxYzE0OGFkM2NmNTkx ZWIxNDhlMTlkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE2LTA0LTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgW1dlYiBJRExdIFNwZWNpZnkg ZGVmYXVsdCB2YWx1ZXMgZm9yIG9wdGlvbmFsIHBhcmFtZXRlcnMgb2YgVHlwZWRBcnJheSB0eXBl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MDE3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlY2lm eSBkZWZhdWx0IHZhbHVlcyBmb3Igb3B0aW9uYWwgcGFyYW1ldGVycyBvZiBUeXBlZEFycmF5IHR5 cGVzIGFuZCBsZXQKKyAgICAgICAgdGhlIGJpbmRpbmdzIGdlbmVyYXRvciB1c2UgV1RGOjpPcHRp b25hbDw+IGZvciB0aGUgb25lcyB0aGF0IGRvIG5vdCBoYXZlIGEKKyAgICAgICAgZGVmYXVsdCB2 YWx1ZS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgor ICAgICAgICAoQ2FuVXNlV1RGT3B0aW9uYWxGb3JQYXJhbWV0ZXIpOiBEZWxldGVkLgorICAgICAg ICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVk aWFFbGVtZW50Ojp3ZWJraXRHZW5lcmF0ZUtleVJlcXVlc3QpOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTE1lZGlhRWxlbWVudDo6d2Via2l0QWRkS2V5KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxN ZWRpYUVsZW1lbnQ6OndlYmtpdENhbmNlbEtleVJlcXVlc3QpOiBEZWxldGVkLgorICAgICAgICAq IGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVu dC5pZGw6CisKKzIwMTYtMDQtMjUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwog ICAgICAgICBDcmFzaCB1bmRlciBNZW1vcnlDYWNoZTo6cmVtb3ZlKCkKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzAwMAogICAgICAgICA8cmRhcjov L3Byb2JsZW0vMjMzNDQ2NjA+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDgwNjMzMDJhYTEyYjA0OGIxNmZmZTNmYjM4NzNl ODU4YzgwZTg1ZGMuLmM0MGQwMDYyZWEwOTk0MzMxYTRjN2M0YzI2YWI0ODIxN2IwNGI4MzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpT LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpT LnBtCkBAIC0zMzgxLDcgKzMzODEsNiBAQCBzdWIgQ2FuVXNlV1RGT3B0aW9uYWxGb3JQYXJhbWV0 ZXIKICAgICByZXR1cm4gMCBpZiAkcGFyYW1ldGVyLT5pc1ZhcmlhZGljOwogICAgIHJldHVybiAw IGlmICRjb2RlR2VuZXJhdG9yLT5Jc0NhbGxiYWNrSW50ZXJmYWNlKCR0eXBlKTsKICAgICByZXR1 cm4gMCBpZiAkY29kZUdlbmVyYXRvci0+SXNFbnVtVHlwZSgkdHlwZSk7Ci0gICAgcmV0dXJuIDAg aWYgJGNvZGVHZW5lcmF0b3ItPklzVHlwZWRBcnJheVR5cGUoJHR5cGUpOwogICAgIHJldHVybiAw IGlmICRjb2RlR2VuZXJhdG9yLT5Jc1dyYXBwZXJUeXBlKCR0eXBlKTsKICAgICByZXR1cm4gMCBp ZiAkdHlwZSBlcSAiRE9NU3RyaW5nIjsKICAgICByZXR1cm4gMCBpZiAkdHlwZSBlcSAiRGljdGlv bmFyeSI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA1NDZh MmM3ODIzZDliMTBmNGVkMTExYmRiZDFjNzE3MzdmNThhMWRiLi44YjJkOGRhZTc5YzNhNjNlZDVl M2I5MzkyMDE5NTdlMjhhY2Y1ZTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxl bWVudC5jcHAKQEAgLTMxMTQsNyArMzExNCw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y2xv c2VNZWRpYVNvdXJjZSgpCiAjZW5kaWYKIAogI2lmIEVOQUJMRShFTkNSWVBURURfTUVESUEpCi12 b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdEdlbmVyYXRlS2V5UmVxdWVzdChjb25zdCBTdHJp bmcmIGtleVN5c3RlbSwgUGFzc1JlZlB0cjxVaW50OEFycmF5PiBpbml0RGF0YSwgRXhjZXB0aW9u Q29kZSYgZWMpCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdEdlbmVyYXRlS2V5UmVxdWVz dChjb25zdCBTdHJpbmcmIGtleVN5c3RlbSwgUmVmUHRyPFVpbnQ4QXJyYXk+JiYgaW5pdERhdGEs IEV4Y2VwdGlvbkNvZGUmIGVjKQogewogI2lmIEVOQUJMRShFTkNSWVBURURfTUVESUFfVjIpCiAg ICAgc3RhdGljIGJvb2wgZmlyc3RUaW1lID0gdHJ1ZTsKQEAgLTMxMzQsNyArMzEzNCw3IEBAIHZv aWQgSFRNTE1lZGlhRWxlbWVudDo6d2Via2l0R2VuZXJhdGVLZXlSZXF1ZXN0KGNvbnN0IFN0cmlu ZyYga2V5U3lzdGVtLCBQYXNzUmVmCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBjb25z dCB1bnNpZ25lZCBjaGFyKiBpbml0RGF0YVBvaW50ZXIgPSAwOworICAgIGNvbnN0IHVuc2lnbmVk IGNoYXIqIGluaXREYXRhUG9pbnRlciA9IG51bGxwdHI7CiAgICAgdW5zaWduZWQgaW5pdERhdGFM ZW5ndGggPSAwOwogICAgIGlmIChpbml0RGF0YSkgewogICAgICAgICBpbml0RGF0YVBvaW50ZXIg PSBpbml0RGF0YS0+ZGF0YSgpOwpAQCAtMzE0NSwxMSArMzE0NSw2IEBAIHZvaWQgSFRNTE1lZGlh RWxlbWVudDo6d2Via2l0R2VuZXJhdGVLZXlSZXF1ZXN0KGNvbnN0IFN0cmluZyYga2V5U3lzdGVt LCBQYXNzUmVmCiAgICAgZWMgPSBleGNlcHRpb25Db2RlRm9yTWVkaWFLZXlFeGNlcHRpb24ocmVz dWx0KTsKIH0KIAotdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp3ZWJraXRHZW5lcmF0ZUtleVJlcXVl c3QoY29uc3QgU3RyaW5nJiBrZXlTeXN0ZW0sIEV4Y2VwdGlvbkNvZGUmIGVjKQotewotICAgIHdl YmtpdEdlbmVyYXRlS2V5UmVxdWVzdChrZXlTeXN0ZW0sIFVpbnQ4QXJyYXk6OmNyZWF0ZSgwKSwg ZWMpOwotfQotCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdEFkZEtleShjb25zdCBTdHJp bmcmIGtleVN5c3RlbSwgUGFzc1JlZlB0cjxVaW50OEFycmF5PiBrZXksIFBhc3NSZWZQdHI8VWlu dDhBcnJheT4gaW5pdERhdGEsIGNvbnN0IFN0cmluZyYgc2Vzc2lvbklkLCBFeGNlcHRpb25Db2Rl JiBlYykKIHsKICNpZiBFTkFCTEUoRU5DUllQVEVEX01FRElBX1YyKQpAQCAtMzE4MCw3ICszMTc1 LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp3ZWJraXRBZGRLZXkoY29uc3QgU3RyaW5nJiBr ZXlTeXN0ZW0sIFBhc3NSZWZQdHI8VWludDhBcnIKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAot ICAgIGNvbnN0IHVuc2lnbmVkIGNoYXIqIGluaXREYXRhUG9pbnRlciA9IDA7CisgICAgY29uc3Qg dW5zaWduZWQgY2hhciogaW5pdERhdGFQb2ludGVyID0gbnVsbHB0cjsKICAgICB1bnNpZ25lZCBp bml0RGF0YUxlbmd0aCA9IDA7CiAgICAgaWYgKGluaXREYXRhKSB7CiAgICAgICAgIGluaXREYXRh UG9pbnRlciA9IGluaXREYXRhLT5kYXRhKCk7CkBAIC0zMTkxLDExICszMTg2LDYgQEAgdm9pZCBI VE1MTWVkaWFFbGVtZW50Ojp3ZWJraXRBZGRLZXkoY29uc3QgU3RyaW5nJiBrZXlTeXN0ZW0sIFBh c3NSZWZQdHI8VWludDhBcnIKICAgICBlYyA9IGV4Y2VwdGlvbkNvZGVGb3JNZWRpYUtleUV4Y2Vw dGlvbihyZXN1bHQpOwogfQogCi12b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdEFkZEtleShj b25zdCBTdHJpbmcmIGtleVN5c3RlbSwgUGFzc1JlZlB0cjxVaW50OEFycmF5PiBrZXksIEV4Y2Vw dGlvbkNvZGUmIGVjKQotewotICAgIHdlYmtpdEFkZEtleShrZXlTeXN0ZW0sIGtleSwgVWludDhB cnJheTo6Y3JlYXRlKDApLCBTdHJpbmcoKSwgZWMpOwotfQotCiB2b2lkIEhUTUxNZWRpYUVsZW1l bnQ6OndlYmtpdENhbmNlbEtleVJlcXVlc3QoY29uc3QgU3RyaW5nJiBrZXlTeXN0ZW0sIGNvbnN0 IFN0cmluZyYgc2Vzc2lvbklkLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBpZiAoa2V5U3lz dGVtLmlzRW1wdHkoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVk aWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAppbmRl eCAwNWExNTc1ODVjY2Y1N2ZmMTM0ZGIyZjc1MTExMzI2ZDI4OTczMTY5Li4wZjIzYWIwZjY5ZTRk ZDhhMjkyODlhYTRiMDYwM2E1Y2UxNzUyMzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuaApAQCAtMjM0LDEwICsyMzQsOCBAQCBwdWJsaWM6CiAjZW5kaWYKIAogI2lmIEVO QUJMRShFTkNSWVBURURfTUVESUEpCi0gICAgdm9pZCB3ZWJraXRHZW5lcmF0ZUtleVJlcXVlc3Qo Y29uc3QgU3RyaW5nJiBrZXlTeXN0ZW0sIFBhc3NSZWZQdHI8VWludDhBcnJheT4gaW5pdERhdGEs IEV4Y2VwdGlvbkNvZGUmKTsKLSAgICB2b2lkIHdlYmtpdEdlbmVyYXRlS2V5UmVxdWVzdChjb25z dCBTdHJpbmcmIGtleVN5c3RlbSwgRXhjZXB0aW9uQ29kZSYpOworICAgIHZvaWQgd2Via2l0R2Vu ZXJhdGVLZXlSZXF1ZXN0KGNvbnN0IFN0cmluZyYga2V5U3lzdGVtLCBSZWZQdHI8VWludDhBcnJh eT4mJiBpbml0RGF0YSwgRXhjZXB0aW9uQ29kZSYpOwogICAgIHZvaWQgd2Via2l0QWRkS2V5KGNv bnN0IFN0cmluZyYga2V5U3lzdGVtLCBQYXNzUmVmUHRyPFVpbnQ4QXJyYXk+IGtleSwgUGFzc1Jl ZlB0cjxVaW50OEFycmF5PiBpbml0RGF0YSwgY29uc3QgU3RyaW5nJiBzZXNzaW9uSWQsIEV4Y2Vw dGlvbkNvZGUmKTsKLSAgICB2b2lkIHdlYmtpdEFkZEtleShjb25zdCBTdHJpbmcmIGtleVN5c3Rl bSwgUGFzc1JlZlB0cjxVaW50OEFycmF5PiBrZXksIEV4Y2VwdGlvbkNvZGUmKTsKICAgICB2b2lk IHdlYmtpdENhbmNlbEtleVJlcXVlc3QoY29uc3QgU3RyaW5nJiBrZXlTeXN0ZW0sIGNvbnN0IFN0 cmluZyYgc2Vzc2lvbklkLCBFeGNlcHRpb25Db2RlJik7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5pZGwKaW5kZXggODdlMDI4YTFlMjEzNmI1MzdhOWM0Nzgx N2IyODVlNDAzOGViMjcwMS4uMzYwYThiMzFmNjg1ZDVmYWNkYmViYjJiNDdkZWE0MTVhNTJiZjI1 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsCkBAIC05OCw4ICs5 OCw4IEBACiAjZW5kaWYKIAogI2lmICghZGVmaW5lZChMQU5HVUFHRV9HT0JKRUNUKSB8fCAhTEFO R1VBR0VfR09CSkVDVCkgJiYgKCFkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSB8fCAhTEFO R1VBR0VfT0JKRUNUSVZFX0MpCi0gICAgW0NvbmRpdGlvbmFsPUVOQ1JZUFRFRF9NRURJQSwgUmFp c2VzRXhjZXB0aW9uXSB2b2lkIHdlYmtpdEdlbmVyYXRlS2V5UmVxdWVzdChET01TdHJpbmc/IGtl eVN5c3RlbSwgb3B0aW9uYWwgVWludDhBcnJheSBpbml0RGF0YSk7Ci0gICAgW0NvbmRpdGlvbmFs PUVOQ1JZUFRFRF9NRURJQSwgUmFpc2VzRXhjZXB0aW9uXSB2b2lkIHdlYmtpdEFkZEtleShET01T dHJpbmc/IGtleVN5c3RlbSwgVWludDhBcnJheSBrZXksIG9wdGlvbmFsIFVpbnQ4QXJyYXkgaW5p dERhdGEsIG9wdGlvbmFsIERPTVN0cmluZyBzZXNzaW9uSWQgPSBudWxsKTsKKyAgICBbQ29uZGl0 aW9uYWw9RU5DUllQVEVEX01FRElBLCBSYWlzZXNFeGNlcHRpb25dIHZvaWQgd2Via2l0R2VuZXJh dGVLZXlSZXF1ZXN0KERPTVN0cmluZz8ga2V5U3lzdGVtLCBvcHRpb25hbCBVaW50OEFycmF5IGlu aXREYXRhID0gbnVsbCk7CisgICAgW0NvbmRpdGlvbmFsPUVOQ1JZUFRFRF9NRURJQSwgUmFpc2Vz RXhjZXB0aW9uXSB2b2lkIHdlYmtpdEFkZEtleShET01TdHJpbmc/IGtleVN5c3RlbSwgVWludDhB cnJheSBrZXksIG9wdGlvbmFsIFVpbnQ4QXJyYXkgaW5pdERhdGEgPSBudWxsLCBvcHRpb25hbCBE T01TdHJpbmcgc2Vzc2lvbklkID0gbnVsbCk7CiAgICAgW0NvbmRpdGlvbmFsPUVOQ1JZUFRFRF9N RURJQSwgUmFpc2VzRXhjZXB0aW9uXSB2b2lkIHdlYmtpdENhbmNlbEtleVJlcXVlc3QoRE9NU3Ry aW5nPyBrZXlTeXN0ZW0sIG9wdGlvbmFsIERPTVN0cmluZyBzZXNzaW9uSWQgPSBudWxsKTsKIAog ICAgIFtDb25kaXRpb25hbD1FTkNSWVBURURfTUVESUFfVjIsIEltcGxlbWVudGVkQXM9a2V5c10g cmVhZG9ubHkgYXR0cmlidXRlIE1lZGlhS2V5cyB3ZWJraXRLZXlzOwo=