157014 2016-04-25 19:30:48 -0700 Chart status should always be computed against prior values 2016-04-26 09:33:34 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa barraclough cdumez commit-queue dewei_zhu rniwa slewis oldest_to_newest 1187174 0 rniwa 2016-04-25 19:30:48 -0700 Right now, the chart status text compares the current value against baseline / target values that appear after the current value. Change that to compare against the prior values. 1187180 1 277309 rniwa 2016-04-25 19:36:21 -0700 Created attachment 277309 Changes the behavior 1187406 2 277309 darin 2016-04-26 09:16:47 -0700 Comment on attachment 277309 Changes the behavior rs=me 1187416 3 277309 commit-queue 2016-04-26 09:33:29 -0700 Comment on attachment 277309 Changes the behavior Clearing flags on attachment: 277309 Committed r200090: <http://trac.webkit.org/changeset/200090> 1187417 4 commit-queue 2016-04-26 09:33:34 -0700 All reviewed patches have been landed. Closing bug. 277309 2016-04-25 19:36:21 -0700 2016-04-26 09:33:29 -0700 Changes the behavior bug-157014-20160425193744.patch text/plain 6525 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwMDY3KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDE2LTA0LTI1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIENoYXJ0IHN0YXR1cyBzaG91bGQgYWx3YXlzIGJlIGNvbXB1dGVkIGFnYWluc3Qg cHJpb3IgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTcwMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDb21wYXJlIHRoZSBjdXJyZW50IHZhbHVlIGFnYWluc3QgdGhlIGxhc3QgYmFzZWxpbmUg b3IgdGFyZ2V0IHZhbHVlIHRoYXQgYXBwZWFyIGJlZm9yZSB0aGUgY3VycmVudCB2YWx1ZSBpbiB0 aW1lCisgICAgICAgIHNvIHRoYXQgdGhlIGNvbXBhcmlzb24gc3RheSB0aGUgc2FtZSBldmVuIHdo ZW4gbmV3IGJhc2VsaW5lIGFuZCB0YXJnZXQgdmFsdWVzIGFyZSByZXBvcnRlZC4gQWxzbyBpbmNs dWRlIHRoZSBjb21wYXJlZAorICAgICAgICBiYXNlbGluZSBvciB0YXJnZXQgdmFsdWUgaW4gdGhl IGxhYmVsIGZvciBjbGFyaXR5LgorCisgICAgICAgICogcHVibGljL3YzL2NvbXBvbmVudHMvY2hh cnQtc3RhdHVzLXZpZXcuanM6CisgICAgICAgIChDaGFydFN0YXR1c1ZpZXcucHJvdG90eXBlLl9j b21wdXRlQ2hhcnRTdGF0dXMpOgorICAgICAgICAoQ2hhcnRTdGF0dXNWaWV3LnByb3RvdHlwZS5f Y29tcHV0ZUNoYXJ0U3RhdHVzLmxhYmVsRm9yRGlmZik6CisgICAgICAgIChDaGFydFN0YXR1c1Zp ZXcucHJvdG90eXBlLl9maW5kTGFzdFBvaW50UHJpb3JUb1RpbWUpOiBFeHRyYWN0ZWQgZnJvbSBf cmVsYXRpdmVEaWZmZXJlbmNlVG9MYXRlclBvaW50SW5UaW1lU2VyaWVzLgorICAgICAgICBOb3cg ZmluZHMgdGhlIGxhc3QgcG9pbnQgYmVmb3JlIHRoZSBjdXJyZW50IHBvaW50J3MgdGltZSBpZiB0 aGVyZSBpcyBhbnksIG9yIHRoZSBsYXN0IHBvaW50IGluIGJhc2VsaW5lIC8gdGFyZ2V0LgorICAg ICAgICAoQ2hhcnRTdGF0dXNWaWV3LnByb3RvdHlwZS5fcmVsYXRpdmVEaWZmZXJlbmNlVG9MYXRl clBvaW50SW5UaW1lU2VyaWVzKTogRGVsZXRlZC4KKyAgICAgICAgKiBwdWJsaWMvdjMvbW9kZWxz L21ldHJpYy5qczoKKyAgICAgICAgKE1ldHJpYy5wcm90b3R5cGUubWFrZUZvcm1hdHRlcik6IERv bid0IHVzZSBTSSB1bml0cyBmb3IgdW5pdC1sZXNzIG1ldHJpY3MuCisKIDIwMTYtMDQtMTMgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTk5 NDQ0KTogUGVyZiBkYXNoYm9hcmQgYWx3YXlzIGZldGNoZXMgYWxsIG1lYXN1cmVtZW50IHNldHMK SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9jaGFy dC1zdGF0dXMtdmlldy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL3YzL2NvbXBvbmVudHMvY2hhcnQtc3RhdHVzLXZpZXcuanMJKHJldmlzaW9uIDIwMDA2 NykKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9jaGFy dC1zdGF0dXMtdmlldy5qcwkod29ya2luZyBjb3B5KQpAQCAtMTEyLDMzICsxMTIsMzggQEAgY2xh c3MgQ2hhcnRTdGF0dXNWaWV3IGV4dGVuZHMgQ29tcG9uZW50QgogICAgICAgICBpZiAoIWN1cnJl bnRQb2ludCkKICAgICAgICAgICAgIGN1cnJlbnRQb2ludCA9IGN1cnJlbnRUaW1lU2VyaWVzRGF0 YVtjdXJyZW50VGltZVNlcmllc0RhdGEubGVuZ3RoIC0gMV07CiAKLSAgICAgICAgdmFyIGRpZmZG cm9tQmFzZWxpbmUgPSB0aGlzLl9yZWxhdGl2ZURpZmZlcmVuY2VUb0xhdGVyUG9pbnRJblRpbWVT ZXJpZXMoY3VycmVudFBvaW50LCBiYXNlbGluZVRpbWVTZXJpZXNEYXRhKTsKLSAgICAgICAgdmFy IGRpZmZGcm9tVGFyZ2V0ID0gdGhpcy5fcmVsYXRpdmVEaWZmZXJlbmNlVG9MYXRlclBvaW50SW5U aW1lU2VyaWVzKGN1cnJlbnRQb2ludCwgdGFyZ2V0VGltZVNlcmllc0RhdGEpOworICAgICAgICB2 YXIgYmFzZWxpbmVQb2ludCA9IHRoaXMuX2ZpbmRMYXN0UG9pbnRQcmlvclRvVGltZShjdXJyZW50 UG9pbnQsIGJhc2VsaW5lVGltZVNlcmllc0RhdGEpOworICAgICAgICB2YXIgZGlmZkZyb21CYXNl bGluZSA9IGJhc2VsaW5lUG9pbnQgIT09IHVuZGVmaW5lZCA/IChjdXJyZW50UG9pbnQudmFsdWUg LSBiYXNlbGluZVBvaW50LnZhbHVlKSAvIGJhc2VsaW5lUG9pbnQudmFsdWUgOiB1bmRlZmluZWQ7 CisKKyAgICAgICAgdmFyIHRhcmdldFBvaW50ID0gdGhpcy5fZmluZExhc3RQb2ludFByaW9yVG9U aW1lKGN1cnJlbnRQb2ludCwgdGFyZ2V0VGltZVNlcmllc0RhdGEpOworICAgICAgICB2YXIgZGlm ZkZyb21UYXJnZXQgPSB0YXJnZXRQb2ludCAhPT0gdW5kZWZpbmVkID8gKGN1cnJlbnRQb2ludC52 YWx1ZSAtIHRhcmdldFBvaW50LnZhbHVlKSAvIHRhcmdldFBvaW50LnZhbHVlIDogdW5kZWZpbmVk OwogCiAgICAgICAgIHZhciBsYWJlbCA9ICcnOwogICAgICAgICB2YXIgY2xhc3NOYW1lID0gJyc7 CiAKLSAgICAgICAgZnVuY3Rpb24gbGFiZWxGb3JEaWZmKGRpZmYsIG5hbWUsIGNvbXBhcmlzb24p CisgICAgICAgIGZ1bmN0aW9uIGxhYmVsRm9yRGlmZihkaWZmLCByZWZlcmVuY2VQb2ludCwgbmFt ZSwgY29tcGFyaXNvbikKICAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIE1hdGguYWJzKGRp ZmYgKiAxMDApLnRvRml4ZWQoMSkgKyAnJSAnICsgY29tcGFyaXNvbiArICcgJyArIG5hbWU7Cisg ICAgICAgICAgICB2YXIgcmVsYXRpdmVEaWZmID0gTWF0aC5hYnMoZGlmZiAqIDEwMCkudG9GaXhl ZCgxKTsKKyAgICAgICAgICAgIHZhciByZWZlcmVuY2VWYWx1ZSA9IHJlZmVyZW5jZVBvaW50ID8g YCAoJHtmb3JtYXR0ZXIocmVmZXJlbmNlUG9pbnQudmFsdWUpfSlgIDogJyc7CisgICAgICAgICAg ICByZXR1cm4gYCR7cmVsYXRpdmVEaWZmfSUgJHtjb21wYXJpc29ufSAke25hbWV9JHtyZWZlcmVu Y2VWYWx1ZX1gOwogICAgICAgICB9CiAKICAgICAgICAgdmFyIHNtYWxsZXJJc0JldHRlciA9IG1l dHJpYy5pc1NtYWxsZXJCZXR0ZXIoKTsKICAgICAgICAgaWYgKGRpZmZGcm9tQmFzZWxpbmUgIT09 IHVuZGVmaW5lZCAmJiBkaWZmRnJvbVRhcmdldCAhPT0gdW5kZWZpbmVkKSB7CiAgICAgICAgICAg ICBpZiAoZGlmZkZyb21CYXNlbGluZSA+IDAgPT0gc21hbGxlcklzQmV0dGVyKSB7Ci0gICAgICAg ICAgICAgICAgbGFiZWwgPSBsYWJlbEZvckRpZmYoZGlmZkZyb21CYXNlbGluZSwgJ2Jhc2VsaW5l JywgJ3dvcnNlIHRoYW4nKTsKKyAgICAgICAgICAgICAgICBsYWJlbCA9IGxhYmVsRm9yRGlmZihk aWZmRnJvbUJhc2VsaW5lLCBiYXNlbGluZVBvaW50LCAnYmFzZWxpbmUnLCAnd29yc2UgdGhhbicp OwogICAgICAgICAgICAgICAgIGNsYXNzTmFtZSA9ICd3b3JzZSc7CiAgICAgICAgICAgICB9IGVs c2UgaWYgKGRpZmZGcm9tVGFyZ2V0IDwgMCA9PSBzbWFsbGVySXNCZXR0ZXIpIHsKLSAgICAgICAg ICAgICAgICBsYWJlbCA9IGxhYmVsRm9yRGlmZihkaWZmRnJvbUJhc2VsaW5lLCAndGFyZ2V0Jywg J2JldHRlciB0aGFuJyk7CisgICAgICAgICAgICAgICAgbGFiZWwgPSBsYWJlbEZvckRpZmYoZGlm ZkZyb21UYXJnZXQsIHRhcmdldFBvaW50LCAndGFyZ2V0JywgJ2JldHRlciB0aGFuJyk7CiAgICAg ICAgICAgICAgICAgY2xhc3NOYW1lID0gJ2JldHRlcic7CiAgICAgICAgICAgICB9IGVsc2UKLSAg ICAgICAgICAgICAgICBsYWJlbCA9IGxhYmVsRm9yRGlmZihkaWZmRnJvbVRhcmdldCwgJ3Rhcmdl dCcsICd1bnRpbCcpOworICAgICAgICAgICAgICAgIGxhYmVsID0gbGFiZWxGb3JEaWZmKGRpZmZG cm9tVGFyZ2V0LCB0YXJnZXRQb2ludCwgJ3RhcmdldCcsICd1bnRpbCcpOwogICAgICAgICB9IGVs c2UgaWYgKGRpZmZGcm9tQmFzZWxpbmUgIT09IHVuZGVmaW5lZCkgewogICAgICAgICAgICAgY2xh c3NOYW1lID0gZGlmZkZyb21CYXNlbGluZSA+IDAgPT0gc21hbGxlcklzQmV0dGVyID8gJ3dvcnNl JyA6ICdiZXR0ZXInOwotICAgICAgICAgICAgbGFiZWwgPSBsYWJlbEZvckRpZmYoZGlmZkZyb21C YXNlbGluZSwgJ2Jhc2VsaW5lJywgY2xhc3NOYW1lICsgJyB0aGFuJyk7CisgICAgICAgICAgICBs YWJlbCA9IGxhYmVsRm9yRGlmZihkaWZmRnJvbUJhc2VsaW5lLCBiYXNlbGluZVBvaW50LCAnYmFz ZWxpbmUnLCBjbGFzc05hbWUgKyAnIHRoYW4nKTsKICAgICAgICAgfSBlbHNlIGlmIChkaWZmRnJv bVRhcmdldCAhPT0gdW5kZWZpbmVkKSB7CiAgICAgICAgICAgICBjbGFzc05hbWUgPSBkaWZmRnJv bVRhcmdldCA8IDAgPT0gc21hbGxlcklzQmV0dGVyID8gJ2JldHRlcicgOiAnd29yc2UnOwotICAg ICAgICAgICAgbGFiZWwgPSBsYWJlbEZvckRpZmYoZGlmZkZyb21UYXJnZXQsICd0YXJnZXQnLCBj bGFzc05hbWUgKyAnIHRoYW4nKTsKKyAgICAgICAgICAgIGxhYmVsID0gbGFiZWxGb3JEaWZmKGRp ZmZGcm9tVGFyZ2V0LCB0YXJnZXRQb2ludCwgJ3RhcmdldCcsIGNsYXNzTmFtZSArICcgdGhhbicp OwogICAgICAgICB9CiAKICAgICAgICAgdmFyIHZhbHVlRGVsdGEgPSBudWxsOwpAQCAtMTU3LDIw ICsxNjIsMTcgQEAgY2xhc3MgQ2hhcnRTdGF0dXNWaWV3IGV4dGVuZHMgQ29tcG9uZW50QgogICAg ICAgICB9OwogICAgIH0KIAotICAgIF9yZWxhdGl2ZURpZmZlcmVuY2VUb0xhdGVyUG9pbnRJblRp bWVTZXJpZXMoY3VycmVudFBvaW50LCB0aW1lU2VyaWVzRGF0YSkKKyAgICBfZmluZExhc3RQb2lu dFByaW9yVG9UaW1lKGN1cnJlbnRQb2ludCwgdGltZVNlcmllc0RhdGEpCiAgICAgewogICAgICAg ICBpZiAoIWN1cnJlbnRQb2ludCB8fCAhdGltZVNlcmllc0RhdGEgfHwgIXRpbWVTZXJpZXNEYXRh Lmxlbmd0aCkKICAgICAgICAgICAgIHJldHVybiB1bmRlZmluZWQ7CiAKLSAgICAgICAgLy8gRklY TUU6IFdlIHNob3VsZG4ndCBiZSB1c2luZyB0aGUgZmlyc3QgZGF0YSBwb2ludCB0byBhY2Nlc3Mg dGhlIHRpbWUgc2VyaWVzIG9iamVjdC4KLSAgICAgICAgdmFyIHJlZmVyZW5jZVBvaW50ID0gdGlt ZVNlcmllc0RhdGFbMF0uc2VyaWVzLmZpbmRQb2ludEFmdGVyVGltZShjdXJyZW50UG9pbnQudGlt ZSk7Ci0gICAgICAgIGlmICghcmVmZXJlbmNlUG9pbnQpCi0gICAgICAgICAgICByZXR1cm4gdW5k ZWZpbmVkOwotCi0gICAgICAgIHJldHVybiAoY3VycmVudFBvaW50LnZhbHVlIC0gcmVmZXJlbmNl UG9pbnQudmFsdWUpIC8gcmVmZXJlbmNlUG9pbnQudmFsdWU7CisgICAgICAgIHZhciBpID0gMDsK KyAgICAgICAgd2hpbGUgKGkgPCB0aW1lU2VyaWVzRGF0YS5sZW5ndGggLSAxICYmIHRpbWVTZXJp ZXNEYXRhW2kgKyAxXS50aW1lIDwgY3VycmVudFBvaW50LnRpbWUpCisgICAgICAgICAgICBpKys7 CisgICAgICAgIHJldHVybiB0aW1lU2VyaWVzRGF0YVtpXTsKICAgICB9CiAKLQogICAgIHN0YXRp YyBodG1sVGVtcGxhdGUoKQogICAgIHsKICAgICAgICAgcmV0dXJuIGAKSW5kZXg6IFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL21ldHJpYy5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVscy9tZXRyaWMuanMJKHJl dmlzaW9uIDIwMDA2NykKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9k ZWxzL21ldHJpYy5qcwkod29ya2luZyBjb3B5KQpAQCAtNjgsOCArNjgsMTEgQEAgY2xhc3MgTWV0 cmljIGV4dGVuZHMgTGFiZWxlZE9iamVjdCB7CiAgICAgICAgICAgICBpc01pbGlzZWNvbmRzID0g dHJ1ZTsKICAgICAgICAgICAgIHVuaXQgPSAncyc7CiAgICAgICAgIH0KLSAgICAgICAgdmFyIGRp dmlzb3IgPSB1bml0ID09ICdCJyA/IDEwMjQgOiAxMDAwOwogCisgICAgICAgIGlmICghdW5pdCkK KyAgICAgICAgICAgIHJldHVybiBmdW5jdGlvbiAodmFsdWUpIHsgcmV0dXJuIHZhbHVlLnRvRml4 ZWQoMikgKyAnICcgKyAodW5pdCB8fCAnJyk7IH0KKworICAgICAgICB2YXIgZGl2aXNvciA9IHVu aXQgPT0gJ0InID8gMTAyNCA6IDEwMDA7CiAgICAgICAgIHZhciBzdWZmaXggPSBbJ1x1MDNCQycs ICdtJywgJycsICdLJywgJ00nLCAnRycsICdUJywgJ1AnLCAnRSddOwogICAgICAgICB2YXIgdGhy ZXNob2xkID0gc2lnRmlnID49IDMgPyBkaXZpc29yIDogKGRpdmlzb3IgLyAxMCk7CiAgICAgICAg IHJldHVybiBmdW5jdGlvbiAodmFsdWUpIHsK