156992 2016-04-25 12:53:08 -0700 Crash using @tryGetById in DFG 2016-04-25 13:59:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1187026 0 msaboff 2016-04-25 12:53:08 -0700 The TryGetById DFG node doesn't spill live registers on the slow path. 1187030 1 webkit-bug-importer 2016-04-25 12:55:43 -0700 <rdar://problem/25913491> 1187032 2 277271 msaboff 2016-04-25 13:05:29 -0700 Created attachment 277271 Patch 1187051 3 277271 commit-queue 2016-04-25 13:59:14 -0700 Comment on attachment 277271 Patch Clearing flags on attachment: 277271 Committed r200048: <http://trac.webkit.org/changeset/200048> 1187052 4 commit-queue 2016-04-25 13:59:18 -0700 All reviewed patches have been landed. Closing bug. 277271 2016-04-25 13:05:29 -0700 2016-04-25 13:59:14 -0700 Patch 156992.patch text/plain 2795 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwMDQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE2LTA0LTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENyYXNoIHVzaW5nIEB0cnlHZXRCeUlkIGluIERGRworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2OTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBzcGlsbCBsaXZlIHJlZ2lzdGVy cyB3aGVuIGNvbXBpbGluZyBUcnlHZXRCeUlkIGluIERGRy4KKworICAgICAgICAqIGRmZy9ERkdT cGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNv bXBpbGVUcnlHZXRCeUlkKToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvcmVncmVzcy0xNTY5OTIu anM6IE5ldyB0ZXN0LgorICAgICAgICAodHJ5TXVsdGlwbGVHZXRCeUlkcyk6CisgICAgICAgICh0 ZXN0KToKKwogMjAxNi0wNC0yNSAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZSBkb24ndCBoYXZlIHRvIHBhcnNlIGEgZnVuY3Rpb24ncyBwYXJhbWV0ZXJzIGV2 ZXJ5IHRpbWUgaWYgdGhlIGZ1bmN0aW9uIGlzIGluIHRoZSBzb3VyY2UgcHJvdmlkZXIgY2FjaGUK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQu Y3BwCShyZXZpc2lvbiAyMDAwMzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTc2LDcgKzk3Niw3IEBAIHZvaWQg U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVUcnlHZXRCeUlkKE4KIAogICAgICAgICBiYXNlLnVzZSgp OwogCi0gICAgICAgIGNhY2hlZEdldEJ5SWQobm9kZS0+b3JpZ2luLnNlbWFudGljLCBiYXNlUmVn cywgcmVzdWx0UmVncywgbm9kZS0+aWRlbnRpZmllck51bWJlcigpLCBKSVRDb21waWxlcjo6SnVt cCgpLCBEb250U3BpbGwsIEFjY2Vzc1R5cGU6OkdldFB1cmUpOworICAgICAgICBjYWNoZWRHZXRC eUlkKG5vZGUtPm9yaWdpbi5zZW1hbnRpYywgYmFzZVJlZ3MsIHJlc3VsdFJlZ3MsIG5vZGUtPmlk ZW50aWZpZXJOdW1iZXIoKSwgSklUQ29tcGlsZXI6Okp1bXAoKSwgTmVlZFRvU3BpbGwsIEFjY2Vz c1R5cGU6OkdldFB1cmUpOwogCiAgICAgICAgIGpzVmFsdWVSZXN1bHQocmVzdWx0UmVncywgbm9k ZSwgRGF0YUZvcm1hdEpTLCBVc2VDaGlsZHJlbkNhbGxlZEV4cGxpY2l0bHkpOwogICAgICAgICBi cmVhazsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvcmVncmVzcy0x NTY5OTIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy9yZWdyZXNzLTE1Njk5Mi5qcwkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS90ZXN0cy9zdHJlc3MvcmVncmVzcy0xNTY5OTIuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCAr MSwzMyBAQAorLy8gVmVyaWZ5IHRoYXQgREZHIFRyeUdldEJ5SWQgbm9kZXMgcHJvcGVybHkgc2F2 ZSBsaXZlIHJlZ2lzdGVycy4gIFRoaXMgdGVzdCBzaG91bGQgbm90IGNyYXNoLgorCitmdW5jdGlv biB0cnlNdWx0aXBsZUdldEJ5SWRzKCkgeyByZXR1cm4gJyhmdW5jdGlvbiAoYmFzZSkgeyByZXR1 cm4gQHRyeUdldEJ5SWQoYmFzZSwgInZhbHVlMSIpICsgQHRyeUdldEJ5SWQoYmFzZSwgInZhbHVl MiIpICsgQHRyeUdldEJ5SWQoYmFzZSwgInZhbHVlMyIpOyB9KSc7IH0gCisKKworbGV0IGdldCA9 IGNyZWF0ZUJ1aWx0aW4odHJ5TXVsdGlwbGVHZXRCeUlkcygpKTsKK25vSW5saW5lKGdldCk7CisK K2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgbGV0IG9iajEgPSB7CisgICAgICAgIHZhbHVlMTogIlRl c3RpbmcsICIsCisgICAgICAgIHZhbHVlMjogInRlc3RpbmcsICIsCisgICAgICAgIHZhbHVlMzog IjEyMyIsCisgICAgICAgIGV4cGVjdGVkOiAiVGVzdGluZywgdGVzdGluZywgMTIzIgorICAgIH07 CisgICAgbGV0IG9iajIgPSB7CisgICAgICAgIGV4dHJhRmllbGRUb01ha2VUaGlzT2JqZWN0RGlm ZmVyZW50VGhhbk9iajE6IDQyLAorICAgICAgICB2YWx1ZTE6IDIwLAorICAgICAgICB2YWx1ZTI6 IDEwLAorICAgICAgICB2YWx1ZTM6IDEyLAorICAgICAgICBleHBlY3RlZDogNDIKKyAgICB9Owor CisgICAgbGV0IG9iamVjdHMgPSBbb2JqMSwgb2JqMl07CisKKyAgICBmb3IgKGxldCBpID0gMDsg aSA8IDIwMDAwMDsgaSsrKSB7CisgICAgICAgIGxldCBvYmogPSBvYmplY3RzW2kgJSAyXTsKKyAg ICAgICAgaWYgKGdldChvYmopICE9PSBvYmouZXhwZWN0ZWQpCisgICAgICAgICAgICB0aHJvdyBu ZXcgRXJyb3IoIndyb25nIG9uIGl0ZXJhdGlvbjogIiArIGkpOworICAgIH0KK30KKwordGVzdCgp Owo=