156985 2016-04-25 11:02:56 -0700 Stop listening for "media can start" notifications when media player is cleared 2016-04-25 12:44:58 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1186987 0 eric.carlson 2016-04-25 11:02:56 -0700 Stop listening for page notifications when the media player is cleared. 1186989 1 eric.carlson 2016-04-25 11:03:26 -0700 <rdar://problem/23158505> 1186993 2 277263 eric.carlson 2016-04-25 11:31:05 -0700 Created attachment 277263 Proposed patch. 1186994 3 commit-queue 2016-04-25 11:32:55 -0700 Attachment 277263 did not pass style-queue: ERROR: Source/WebCore/html/HTMLMediaElement.cpp:5600: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1187017 4 eric.carlson 2016-04-25 12:37:44 -0700 Committed r200039: https://trac.webkit.org/r200039 1187021 5 eric.carlson 2016-04-25 12:44:58 -0700 (In reply to comment #1) > <rdar://problem/23158505> This is the wrong Radar number. The correct number is <rdar://problem/25862536> 277263 2016-04-25 11:31:05 -0700 2016-04-25 12:37:55 -0700 Proposed patch. patch_1.txt text/plain 3892 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDAzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA0LTI1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFN0b3AgbGlzdGVuaW5n IGZvciAibWVkaWEgY2FuIHN0YXJ0IiBub3RpZmljYXRpb25zIHdoZW4gbWVkaWEgcGxheWVyIGlz IGNsZWFyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1Njk4NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjMxNTg1MDU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBJIGhhdmUg bm90IGJlZW4gYWJsZSB0byBjcmVhdGUgYSB0ZXN0IHRoYXQgcmVsaWFibHkgcmVwcm9kdWNlcyB0 aGlzLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRJbnRlcm5hbCk6IEFkZCBsb2dnaW5nLgorICAg ICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c2VsZWN0TWVkaWFSZXNvdXJjZSk6IEFz c2VydCBhbmQgcmV0dXJuIGVhcmx5IGlmIHRoZXJlIGlzCisgICAgICAgICAgbm8gbWVkaWEgcGxh eWVyLgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y2xlYXJNZWRpYVBsYXll cik6IFN0b3AgbGlzdGVuaW5nIGZvciBjYW4gc3RhcnQgbm90aWZpY2F0aW9ucy4KKyAgICAgICAg KFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnZpc2liaWxpdHlTdGF0ZUNoYW5nZWQpOiBBZGQg bG9nZ2luZy4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhQ2FuU3Rh cnQpOiBEaXR0by4KKwogMjAxNi0wNC0yNSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgSW1wbGVtZW50IGxhdGVzdCBGaWxlIG9iamVjdCBzcGVjIChpbmNsdWRp bmcgaXRzIGNvbnN0cnVjdG9yKS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcAkocmV2aXNpb24gMTk5Nzk1KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEzOCw2ICsxMTM4LDggQEAgdm9p ZCBIVE1MTWVkaWFFbGVtZW50OjpwcmVwYXJlRm9yTG9hZCgpCiAKIHZvaWQgSFRNTE1lZGlhRWxl bWVudDo6bG9hZEludGVybmFsKCkKIHsKKyAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50 Ojpsb2FkSW50ZXJuYWwoJXApIiwgdGhpcyk7CisKICAgICAvLyBTb21lIG9mIHRoZSBjb2RlIHBh dGhzIGJlbG93IHRoaXMgZnVuY3Rpb24gZGlzcGF0Y2ggdGhlIEJlZm9yZUxvYWQgZXZlbnQuIFRo aXMgQVNTRVJUIGhlbHBzCiAgICAgLy8gdXMgY2F0Y2ggdGhvc2UgYnVncyBtb3JlIHF1aWNrbHkg d2l0aG91dCBuZWVkaW5nIGFsbCB0aGUgYnJhbmNoZXMgdG8gYWxpZ24gdG8gYWN0dWFsbHkKICAg ICAvLyB0cmlnZ2VyIHRoZSBldmVudC4KQEAgLTExNDUsMTEgKzExNDcsMTIgQEAgdm9pZCBIVE1M TWVkaWFFbGVtZW50Ojpsb2FkSW50ZXJuYWwoKQogCiAgICAgLy8gSWYgd2UgY2FuJ3Qgc3RhcnQg YSBsb2FkIHJpZ2h0IGF3YXksIHN0YXJ0IGl0IGxhdGVyLgogICAgIGlmICghbV9tZWRpYVNlc3Np b24tPnBhZ2VBbGxvd3NEYXRhTG9hZGluZygqdGhpcykpIHsKKyAgICAgICAgTE9HKE1lZGlhLCAi SFRNTE1lZGlhRWxlbWVudDo6bG9hZEludGVybmFsKCVwKSAtIG5vdCBhbGxvd2VkIHRvIGxvYWQg aW4gYmFja2dyb3VuZCwgd2FpdGluZyIsIHRoaXMpOwogICAgICAgICBzZXRTaG91bGREZWxheUxv YWRFdmVudChmYWxzZSk7CiAgICAgICAgIGlmIChtX2lzV2FpdGluZ1VudGlsTWVkaWFDYW5TdGFy dCkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgZG9jdW1lbnQoKS5hZGRNZWRpYUNhblN0 YXJ0TGlzdGVuZXIodGhpcyk7CiAgICAgICAgIG1faXNXYWl0aW5nVW50aWxNZWRpYUNhblN0YXJ0 ID0gdHJ1ZTsKKyAgICAgICAgZG9jdW1lbnQoKS5hZGRNZWRpYUNhblN0YXJ0TGlzdGVuZXIodGhp cyk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTExODUsNiArMTE4OCwxMCBAQCB2b2lk IEhUTUxNZWRpYUVsZW1lbnQ6OnNlbGVjdE1lZGlhUmVzb3VyCiB7CiAgICAgTE9HKE1lZGlhLCAi SFRNTE1lZGlhRWxlbWVudDo6c2VsZWN0TWVkaWFSZXNvdXJjZSglcCkiLCB0aGlzKTsKIAorICAg IEFTU0VSVChtX3BsYXllcik7CisgICAgaWYgKCFtX3BsYXllcikKKyAgICAgICAgcmV0dXJuOwor CiAgICAgZW51bSBNb2RlIHsgYXR0cmlidXRlLCBjaGlsZHJlbiB9OwogCiAgICAgLy8gMyAtIElm IHRoZSBtZWRpYSBlbGVtZW50IGhhcyBhIHNyYyBhdHRyaWJ1dGUsIHRoZW4gbGV0IG1vZGUgYmUg YXR0cmlidXRlLgpAQCAtNDk5NSw2ICs1MDAyLDExIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6 Y2xlYXJNZWRpYVBsYXllcigKICAgICB9CiAjZW5kaWYKIAorICAgIGlmIChtX2lzV2FpdGluZ1Vu dGlsTWVkaWFDYW5TdGFydCkgeworICAgICAgICBtX2lzV2FpdGluZ1VudGlsTWVkaWFDYW5TdGFy dCA9IGZhbHNlOworICAgICAgICBkb2N1bWVudCgpLnJlbW92ZU1lZGlhQ2FuU3RhcnRMaXN0ZW5l cih0aGlzKTsKKyAgICB9CisKICAgICBtX3BsYXllciA9IG51bGxwdHI7CiAKICAgICBzdG9wUGVy aW9kaWNUaW1lcnMoKTsKQEAgLTUxNDAsOCArNTE1Miw4IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVu dDo6bWVkaWFWb2x1bWVEaWRDaGEKIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp2aXNpYmlsaXR5 U3RhdGVDaGFuZ2VkKCkKIHsKLSAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50Ojp2aXNp YmlsaXR5U3RhdGVDaGFuZ2VkKCVwKSIsIHRoaXMpOwogICAgIG1fZWxlbWVudElzSGlkZGVuID0g ZG9jdW1lbnQoKS5oaWRkZW4oKTsKKyAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50Ojp2 aXNpYmlsaXR5U3RhdGVDaGFuZ2VkKCVwKSAtIHZpc2libGUgPSAlcyIsIHRoaXMsIGJvb2xTdHJp bmcoIW1fZWxlbWVudElzSGlkZGVuKSk7CiAgICAgdXBkYXRlU2xlZXBEaXNhYmxpbmcoKTsKICAg ICBtX21lZGlhU2Vzc2lvbi0+dmlzaWJpbGl0eUNoYW5nZWQoKTsKIH0KQEAgLTU1ODUsNyArNTU5 Nyw4IEBAIHVuc2lnbmVkIEhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdFZpZGVvRGUKIAogdm9pZCBI VE1MTWVkaWFFbGVtZW50OjptZWRpYUNhblN0YXJ0KCkKIHsKLSAgICBMT0coTWVkaWEsICJIVE1M TWVkaWFFbGVtZW50OjptZWRpYUNhblN0YXJ0KCVwKSIsIHRoaXMpOworICAgIExPRyhNZWRpYSwg IkhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhQ2FuU3RhcnQoJXApIC0gbV9pc1dhaXRpbmdVbnRpbE1l ZGlhQ2FuU3RhcnQgPSAlcywgbV9wYXVzZWRJbnRlcm5hbCA9ICVzIiwKKyAgICAgICAgICAgIHRo aXMsIGJvb2xTdHJpbmcobV9pc1dhaXRpbmdVbnRpbE1lZGlhQ2FuU3RhcnQpLCBib29sU3RyaW5n KG1fcGF1c2VkSW50ZXJuYWwpICk7CiAKICAgICBBU1NFUlQobV9pc1dhaXRpbmdVbnRpbE1lZGlh Q2FuU3RhcnQgfHwgbV9wYXVzZWRJbnRlcm5hbCk7CiAgICAgaWYgKG1faXNXYWl0aW5nVW50aWxN ZWRpYUNhblN0YXJ0KSB7Cg==