156979 2016-04-25 08:04:18 -0700 Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow 2016-04-26 06:17:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 156844 1 youennf youennf cdumez commit-queue esprehn+autocc kangil.han kondapallykalyan WebkitBugTracker oldest_to_newest 1186932 0 youennf 2016-04-25 08:04:18 -0700 Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow 1186933 1 277249 youennf 2016-04-25 08:07:31 -0700 Created attachment 277249 Patch 1186982 2 277249 cdumez 2016-04-25 10:44:10 -0700 Comment on attachment 277249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277249&action=review r=me with comment. > Source/WebCore/dom/WebKitNamedFlow.idl:38 > + NodeList getRegionsByContent(Node? contentNode); Should add a FIXME comment as I don't believe this matches the spec. 1187324 3 277357 youennf 2016-04-26 05:15:00 -0700 Created attachment 277357 Patch for landing 1187325 4 youennf 2016-04-26 05:16:25 -0700 Thanks for the review. > > Source/WebCore/dom/WebKitNamedFlow.idl:38 > > + NodeList getRegionsByContent(Node? contentNode); > > Should add a FIXME comment as I don't believe this matches the spec. Right, I did not find the spec yesterday but found it now. Patch is fixed accordingly 1187339 5 277357 commit-queue 2016-04-26 06:17:00 -0700 Comment on attachment 277357 Patch for landing Clearing flags on attachment: 277357 Committed r200079: <http://trac.webkit.org/changeset/200079> 1187340 6 commit-queue 2016-04-26 06:17:04 -0700 All reviewed patches have been landed. Closing bug. 277249 2016-04-25 08:07:31 -0700 2016-04-26 05:14:52 -0700 Patch bug-156979-20160425170757.patch text/plain 1625 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFiYWJhZTlhMTQwN2Qz N2EyNDQ5ZjdkNzQzMzM2YzcwZDY2ZDExZi4uMGRjYTFjYmUwMjM1YTQ5ODY5Y2ExZDhiYzU2ZDJj N2ViNThjZTZkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTA0LTI1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKKyAgICAgICAgRHJvcCBb VXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHNdIGZyb20gV2ViS2l0 TmFtZWRGbG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTY5NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBkb20vV2ViS2l0TmFtZWRGbG93 LmlkbDogTWFya2luZyBjb250ZW50Tm9kZSBwYXJhbWV0ZXIgYXMgbnVsbGFibGUuCisKKzIwMTYt MDQtMjUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KKwogICAg ICAgICBEcm9wIFtVc2VQb2ludGVyc0V2ZW5Gb3JOb25OdWxsYWJsZU9iamVjdEFyZ3VtZW50c10g ZnJvbSBNZWRpYVNvdXJjZSBpbnRlcmZhY2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY5MDQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL1dlYktpdE5hbWVkRmxvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFtZWRG bG93LmlkbAppbmRleCBmZWZmYTlkZTM5OGVhNWQ4NGViZjRiNzhiYzE0N2VhOGEwMjEyMjY3Li44 ZTM2NzAwYTVjZDRiYThiOTQ2MjljNzg2OGQ1MTVlMjc1MjNjZjNjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vV2ViS2l0TmFtZWRGbG93LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vV2ViS2l0TmFtZWRGbG93LmlkbApAQCAtMjgsMTUgKzI4LDE0IEBACiAgKi8KIAogWwotICAg IFVzZVBvaW50ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzLAotICAgIE5vSW50 ZXJmYWNlT2JqZWN0LAogICAgIEdlbmVyYXRlSXNSZWFjaGFibGU9SW1wbE93bmVyTm9kZVJvb3Qs CisgICAgTm9JbnRlcmZhY2VPYmplY3QsCiBdIGludGVyZmFjZSBXZWJLaXROYW1lZEZsb3cgOiBF dmVudFRhcmdldAogewogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgbmFtZTsKICAg ICByZWFkb25seSBhdHRyaWJ1dGUgYm9vbGVhbiBvdmVyc2V0OwogICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBsb25nIGZpcnN0RW1wdHlSZWdpb25JbmRleDsKLSAgICBOb2RlTGlzdCBnZXRSZWdpb25z QnlDb250ZW50KE5vZGUgY29udGVudE5vZGUpOworICAgIE5vZGVMaXN0IGdldFJlZ2lvbnNCeUNv bnRlbnQoTm9kZT8gY29udGVudE5vZGUpOwogICAgIE5vZGVMaXN0IGdldFJlZ2lvbnMoKTsKICAg ICBOb2RlTGlzdCBnZXRDb250ZW50KCk7CiB9Owo= 277357 2016-04-26 05:15:00 -0700 2016-04-26 06:17:00 -0700 Patch for landing bug-156979-20160426141528.patch text/plain 1568 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzlmMTVjNjM2MGVlOTk0 NTU2ODZmZjRhNGUwYjE5N2QxOTliYzZhNy4uMzUzMzk3ZjUzNGNlZDU0Yjk5OWZhMjg5ZWEzYjA3 OTc3NDUwNDY3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA0LTI2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgRHJvcCBb VXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHNdIGZyb20gV2ViS2l0 TmFtZWRGbG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTY5NzkKKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICBO byBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBkb20vV2ViS2l0TmFtZWRGbG93Lmlk bDogTWFya2luZyBjb250ZW50Tm9kZSBwYXJhbWV0ZXIgYXMgbnVsbGFibGUuCisKIDIwMTYtMDQt MjUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHRo ZSBidWlsZCBmbGFnIGZvciB0ZW1wbGF0ZSBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL1dlYktpdE5hbWVkRmxvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0 TmFtZWRGbG93LmlkbAppbmRleCBmZWZmYTlkZTM5OGVhNWQ4NGViZjRiNzhiYzE0N2VhOGEwMjEy MjY3Li44YTNmNzFhMDZlM2E5Y2I5MGE3NDMyOGI3MTkyOWQ4ZTc0NWE3MTYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFtZWRGbG93LmlkbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vV2ViS2l0TmFtZWRGbG93LmlkbApAQCAtMjgsMTUgKzI4LDE1IEBACiAgKi8KIAog WwotICAgIFVzZVBvaW50ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzLAotICAg IE5vSW50ZXJmYWNlT2JqZWN0LAogICAgIEdlbmVyYXRlSXNSZWFjaGFibGU9SW1wbE93bmVyTm9k ZVJvb3QsCisgICAgTm9JbnRlcmZhY2VPYmplY3QsCiBdIGludGVyZmFjZSBXZWJLaXROYW1lZEZs b3cgOiBFdmVudFRhcmdldAogewogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgbmFt ZTsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgYm9vbGVhbiBvdmVyc2V0OwogICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSBsb25nIGZpcnN0RW1wdHlSZWdpb25JbmRleDsKLSAgICBOb2RlTGlzdCBnZXRS ZWdpb25zQnlDb250ZW50KE5vZGUgY29udGVudE5vZGUpOworICAgIC8vIEZJWE1FOiBjb250ZW50 Tm9kZSBzaG91bGQgbm90IGJlIG51bGxhYmxlLgorICAgIE5vZGVMaXN0IGdldFJlZ2lvbnNCeUNv bnRlbnQoTm9kZT8gY29udGVudE5vZGUpOwogICAgIE5vZGVMaXN0IGdldFJlZ2lvbnMoKTsKICAg ICBOb2RlTGlzdCBnZXRDb250ZW50KCk7CiB9Owo=