156963 2016-04-24 16:09:14 -0700 Web Inspector: Can't select record bar in Frames timeline 2016-05-10 16:51:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 156960 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1186785 0 mattbaker 2016-04-24 16:09:14 -0700 * SUMMARY Can't select record bar in Frames timeline. The element is quickly deselected immediately after becoming selected. * STEPS TO REPRODUCE 1. Record a timeline, view Frames 2. Select a bar in the overview => Selection flashes in the overview and data grid, but selection doesn't stick 1186787 1 webkit-bug-importer 2016-04-24 16:09:28 -0700 <rdar://problem/25898256> 1191718 2 278548 mattbaker 2016-05-10 16:25:49 -0700 Created attachment 278548 [Patch] Proposed Fix 1191731 3 278548 commit-queue 2016-05-10 16:50:59 -0700 Comment on attachment 278548 [Patch] Proposed Fix Clearing flags on attachment: 278548 Committed r200656: <http://trac.webkit.org/changeset/200656> 1191732 4 commit-queue 2016-05-10 16:51:03 -0700 All reviewed patches have been landed. Closing bug. 278548 2016-05-10 16:25:49 -0700 2016-05-10 16:50:59 -0700 [Patch] Proposed Fix bug-156963-20160510162637.patch text/plain 5018 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 OTdhMzY4YzJmMjllNjU2MjBhOGI1YmNjMDEyZTZjNjU2ZjI2YThlLi4zMzc5YzhhZmY0ODI4MTVj YWQ5M2UxYjQ4ODBiNTI4ODBjZTA3NWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwzMCBAQAogMjAxNi0wNS0xMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FuJ3Qgc2VsZWN0IHJlY29yZCBiYXIgaW4gRnJh bWVzIHRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTY5NjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1ODk4MjU2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN5bmMgcmVjb3JkIHNlbGVj dGlvbiBiZXR3ZWVuIHRoZSBSZW5kZXJpbmcgRnJhbWVzIGdyaWQgYW5kIG92ZXJ2aWV3IGdyYXBo LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUucHJvdG90eXBlLmhhc0FuY2VzdG9yKToKKyAgICAg ICAgQWRkIGhlbHBlciBmdW5jdGlvbiBuZWVkZWQgYnkgVGltZWxpbmVWaWV3LgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9SZW5kZXJpbmdGcmFtZVRpbWVsaW5lT3ZlcnZpZXdHcmFw aC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZW5kZXJpbmdGcmFtZVRpbWVsaW5lT3ZlcnZp ZXdHcmFwaC5wcm90b3R5cGUuX21vdXNlQ2xpY2tlZCk6CisgICAgICAgIERvbid0IGRlc2VsZWN0 IHRoZSBzZWxlY3RlZCByZWNvcmQgd2hlbiBjbGlja2VkLiBJbml0aWFsbHkgdGhpcyBzZWVtZWQK KyAgICAgICAgbGlrZSBhIGdvb2QgaWRlYSBidXQgaXQgY29tcGxpY2F0ZXMgdGhlIFVJIGZvciBu byBhZGRlZCB2YWx1ZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVS ZWNvcmRpbmdDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVJl Y29yZGluZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fY29udGVudFZpZXdTZWxlY3Rpb25QYXRoQ29t cG9uZW50RGlkQ2hhbmdlKToKKyAgICAgICAgR2V0IHBhdGggY29tcG9uZW50cyBmcm9tIHRoZSBj dXJyZW50IFRpbWVsaW5lVmlldyBpbnN0ZWFkIG9mIHRoZQorICAgICAgICBUaW1lbGluZVJlY29y ZGluZ0NvbnRlbnRWaWV3LCBub3cgdGhhdCB0aGUgc2VsZWN0ZWQgcmVjb3JkIGFwcGVhcnMKKyAg ICAgICAgaW4gdGhlIGJvdHRvbSBDb250ZW50QnJvd3NlcidzIG5hdmlnYXRpb24gYmFyLgorCisy MDE2LTA1LTEwICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBEZWJ1Z2dlciBzaWRlYmFyIHNob3VsZCByZWZyZXNoIHdoZW4gRGVidWcg VUkgZW5hYmxlZC9kaXNhYmxlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU3NTQwCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjIwNzA2ND4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFH cmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdy aWQuanMKaW5kZXggMzlkNDQ1NjU3ODA0MjRlZTc4NjBlM2IwOWI2MDNlNGI0NTNiYmJjZi4uNDIw NTQ5MmRmM2FhMThiMWJhOTQwZjFhNGM4NGQ5MDNiODE4ZWE3NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKQEAgLTIw MjgsNiArMjAyOCwyMiBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlID0gY2xhc3MgRGF0YUdy aWROb2RlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICAgICAgdGhpcy5jb2xs YXBzZSgpOwogICAgIH0KIAorICAgIGhhc0FuY2VzdG9yKGFuY2VzdG9yKQorICAgIHsKKyAgICAg ICAgaWYgKCFhbmNlc3RvcikKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICBs ZXQgY3VycmVudEFuY2VzdG9yID0gdGhpcy5wYXJlbnQ7CisgICAgICAgIHdoaWxlIChjdXJyZW50 QW5jZXN0b3IpIHsKKyAgICAgICAgICAgIGlmIChhbmNlc3RvciA9PT0gY3VycmVudEFuY2VzdG9y KQorICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOworCisgICAgICAgICAgICBjdXJyZW50QW5j ZXN0b3IgPSBjdXJyZW50QW5jZXN0b3IucGFyZW50OworICAgICAgICB9CisKKyAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIH0KKwogICAgIHJlZnJlc2goKQogICAgIHsKICAgICAgICAgaWYgKCF0 aGlzLl9lbGVtZW50IHx8ICF0aGlzLmRhdGFHcmlkKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVuZGVyaW5nRnJhbWVUaW1lbGluZU92ZXJ2 aWV3R3JhcGguanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9S ZW5kZXJpbmdGcmFtZVRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcwppbmRleCA1Y2IzNDM0YmMzMWRi ZDkzMWJlYWRkNmZiMWMyNGUyNDk2ZGYwOTcwLi4wMTAwMDI3NDNhZWM2OTU5YmM1ZTlmMmI0NzIz NGMxN2I3OTMyNjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9SZW5kZXJpbmdGcmFtZVRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZW5kZXJpbmdGcmFtZVRp bWVsaW5lT3ZlcnZpZXdHcmFwaC5qcwpAQCAtMjU5LDkgKzI1OSw4IEBAIFdlYkluc3BlY3Rvci5S ZW5kZXJpbmdGcmFtZVRpbWVsaW5lT3ZlcnZpZXdHcmFwaCA9IGNsYXNzIFJlbmRlcmluZ0ZyYW1l VGltZWxpbmVPCiAgICAgICAgIGlmIChuZXdTZWxlY3RlZFJlY29yZFtXZWJJbnNwZWN0b3IuUmVu ZGVyaW5nRnJhbWVUaW1lbGluZU92ZXJ2aWV3R3JhcGguUmVjb3JkV2FzRmlsdGVyZWRTeW1ib2xd KQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIC8vIENsaWNraW5nIHRoZSBzZWxlY3Rl ZCBmcmFtZSBjYXVzZXMgaXQgdG8gYmUgZGVzZWxlY3RlZC4KICAgICAgICAgaWYgKHRoaXMuc2Vs ZWN0ZWRSZWNvcmQgPT09IG5ld1NlbGVjdGVkUmVjb3JkKQotICAgICAgICAgICAgbmV3U2VsZWN0 ZWRSZWNvcmQgPSBudWxsOworICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChmcmFt ZUluZGV4ID49IHRoaXMudGltZWxpbmVPdmVydmlldy5zZWxlY3Rpb25TdGFydFRpbWUgJiYgZnJh bWVJbmRleCA8IHRoaXMudGltZWxpbmVPdmVydmlldy5zZWxlY3Rpb25TdGFydFRpbWUgKyB0aGlz LnRpbWVsaW5lT3ZlcnZpZXcuc2VsZWN0aW9uRHVyYXRpb24pIHsKICAgICAgICAgICAgIHRoaXMu c2VsZWN0ZWRSZWNvcmQgPSBuZXdTZWxlY3RlZFJlY29yZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmluZGV4IDZiYTk3ZjU0NzAxOGIxMWE5YTY0ZWM5 MmM0ZDE1NTZjM2MwMjQ5YWYuLjE3MzE2ODdmYTlmYzU1MDIyYzc0M2RjMTFhZDlhYzViNjFjNmNh NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwpA QCAtMzIyLDggKzMyMiwxMiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50 VmlldyA9IGNsYXNzIFRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgZQogICAgICAgICBpZiAo dGhpcy5jdXJyZW50VGltZWxpbmVWaWV3ID09PSB0aGlzLl9vdmVydmlld1RpbWVsaW5lVmlldykK ICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgcmVjb3JkUGF0aENvbXBvbmVudCA9 IHRoaXMuc2VsZWN0aW9uUGF0aENvbXBvbmVudHMuZmluZChmdW5jdGlvbihlbGVtZW50KSB7IHJl dHVybiBlbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlRp bWVsaW5lUmVjb3JkOyB9KTsKLSAgICAgICAgdmFyIHJlY29yZCA9IHJlY29yZFBhdGhDb21wb25l bnQgPyByZWNvcmRQYXRoQ29tcG9uZW50LnJlcHJlc2VudGVkT2JqZWN0IDogbnVsbDsKKyAgICAg ICAgbGV0IHJlY29yZCA9IG51bGw7CisgICAgICAgIGlmICh0aGlzLmN1cnJlbnRUaW1lbGluZVZp ZXcuc2VsZWN0aW9uUGF0aENvbXBvbmVudHMpIHsKKyAgICAgICAgICAgIGxldCByZWNvcmRQYXRo Q29tcG9uZW50ID0gdGhpcy5jdXJyZW50VGltZWxpbmVWaWV3LnNlbGVjdGlvblBhdGhDb21wb25l bnRzLmZpbmQoKGVsZW1lbnQpID0+IGVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2Vv ZiBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmQpOworICAgICAgICAgICAgcmVjb3JkID0gcmVj b3JkUGF0aENvbXBvbmVudCA/IHJlY29yZFBhdGhDb21wb25lbnQucmVwcmVzZW50ZWRPYmplY3Qg OiBudWxsOworICAgICAgICB9CisKICAgICAgICAgdGhpcy5fdGltZWxpbmVPdmVydmlldy5zZWxl Y3RSZWNvcmQoZXZlbnQudGFyZ2V0LnJlcHJlc2VudGVkT2JqZWN0LCByZWNvcmQpOwogICAgIH0K IAo=