156960 2016-04-24 14:41:40 -0700 Web Inspector: Error when selecting a bar in the Frames timeline 2016-04-24 18:03:02 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 154924 156963 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1186777 0 mattbaker 2016-04-24 14:41:40 -0700 * SUMMARY Error when selecting a bar in the Frames timeline. Inspector dies with: undefined is not an object (evaluating 'this.currentTimelineView.navigationSidebarTreeOutline.selectedTreeElement'). * NOTE The fault lies with TimelineRecordingContentView._recordSelected, which assumes all TimelineViews have a tree outline. 1186778 1 webkit-bug-importer 2016-04-24 14:41:54 -0700 <rdar://problem/25897955> 1186779 2 mattbaker 2016-04-24 14:43:43 -0700 A fix is ready. Waiting on https://webkit.org/b/154924, which adds grid support to TimelineView. 1186784 3 277200 mattbaker 2016-04-24 16:04:05 -0700 Created attachment 277200 [Patch] Proposed Fix 1186788 4 mattbaker 2016-04-24 16:10:00 -0700 This patch prevents the crash but there is another problem with record selection: https://bugs.webkit.org/show_bug.cgi?id=156963 1186810 5 277200 commit-queue 2016-04-24 18:02:58 -0700 Comment on attachment 277200 [Patch] Proposed Fix Clearing flags on attachment: 277200 Committed r199972: <http://trac.webkit.org/changeset/199972> 1186811 6 commit-queue 2016-04-24 18:03:02 -0700 All reviewed patches have been landed. Closing bug. 277200 2016-04-24 16:04:05 -0700 2016-04-24 18:02:58 -0700 [Patch] Proposed Fix bug-156960-20160424160432.patch text/plain 5880 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZTQ3MzVmNmQ4ZGViNzhkZDE3NTAzYzMwYTY4MWJlNjFmZjFkOWYzLi5mYzAzMDc5N2MwMmMwZDky ODYwYTIzYTRmYmE0ZmI1MWJlYzRmODQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNi0wNC0yNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXJyb3Igd2hlbiBzZWxlY3RpbmcgYSBiYXIgaW4g dGhlIEZyYW1lcyB0aW1lbGluZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU2OTYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTg5Nzk1NT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyB0aW1l bGluZSBncmlkIG5vZGUgc2VsZWN0aW9uIHdoZW4gcmVjb3JkIHNlbGVjdGVkIGluIHRoZSBvdmVy dmlldy4KKyAgICAgICAgQWRkcyBnZW5lcmFsIHB1cnBvc2UgYGZpbmROb2RlYCBtZXRob2QgdG8g RGF0YUdyaWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5maW5kTm9kZSk6CisgICAg ICAgIEJhc2ljIGZpbmQgZnVuY3Rpb24gZm9yIGxvY2F0aW5nIGEgZ3JpZCBub2RlIGluIGxpbmVh ciB0aW1lLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGlu Z0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5n Q29udGVudFZpZXcucHJvdG90eXBlLl9yZWNvcmRTZWxlY3RlZCk6CisgICAgICAgIFJlbW92ZSB0 cmVlIG91dGxpbmUgcmVmZXJlbmNlcywgY2FsbCBnZW5lcmljIHNlbGVjdCBtZXRob2QuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVmlldy5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UaW1lbGluZVZpZXcucHJvdG90eXBlLnNlbGVjdFJlY29yZCk6CisgICAgICAg IElmIGEgZGF0YSBncmlkIHdhcyBzZXQsIGRlc2VsZWN0IGN1cnJlbnQgc2VsZWN0aW9uIGFuZCBz ZWxlY3QgdGhlIG5vZGUKKyAgICAgICAgYXNzb2NpYXRlZCB3aXRoIHRoZSB0aW1lbGluZSByZWNv cmQuCisKIDIwMTYtMDQtMjIgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IEhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lIGdyaWQgc2hvdWxk IHVzZSBidWlsdC1pbiBncmlkIGNvbHVtbiBpY29ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwppbmRleCAwODliNDZlZjU4 ZDMzZmZhMGYyYzBhNjJhMWNkNGRhOThkNDQ0MGI1Li5kYjg3MzU5ZGIyMzExNzg4NzJkYmQ0Yzc0 NTJlZmY1OTdhODFkYzI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwpAQCAtMTA0Miw2ICsxMDQyLDIzIEBAIFdlYklu c3BlY3Rvci5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZp ZXcKICAgICAgICAgdGhpcy5jaGlsZHJlbiA9IFtdOwogICAgIH0KIAorICAgIGZpbmROb2RlKGNv bXBhcmF0b3IsIHNraXBIaWRkZW4sIHN0YXlXaXRoaW4sIGRvbnRQb3B1bGF0ZSkKKyAgICB7Cisg ICAgICAgIGNvbnNvbGUuYXNzZXJ0KHR5cGVvZiBjb21wYXJhdG9yID09PSAiZnVuY3Rpb24iKTsK KworICAgICAgICBsZXQgY3VycmVudE5vZGUgPSB0aGlzLl9yb3dzWzBdOworICAgICAgICB3aGls ZSAoY3VycmVudE5vZGUgJiYgIWN1cnJlbnROb2RlLnJvb3QpIHsKKyAgICAgICAgICAgIGlmICgh Y3VycmVudE5vZGUuaXNQbGFjZWhvbGRlck5vZGUgJiYgIShza2lwSGlkZGVuICYmIGN1cnJlbnRO b2RlLmhpZGRlbikpIHsKKyAgICAgICAgICAgICAgICBpZiAoY29tcGFyYXRvcihjdXJyZW50Tm9k ZSkpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBjdXJyZW50Tm9kZTsKKyAgICAgICAgICAg IH0KKworICAgICAgICAgICAgY3VycmVudE5vZGUgPSBjdXJyZW50Tm9kZS50cmF2ZXJzZU5leHRO b2RlKHNraXBIaWRkZW4sIHN0YXlXaXRoaW4sIGRvbnRQb3B1bGF0ZSk7CisgICAgICAgIH0KKwor ICAgICAgICByZXR1cm4gbnVsbDsKKyAgICB9CisKICAgICBzb3J0Tm9kZXMoY29tcGFyYXRvcikK ICAgICB7CiAgICAgICAgIGlmICh0aGlzLl9zb3J0Tm9kZXNSZXF1ZXN0SWQpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29y ZGluZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwppbmRleCA3YTg2YWM1Y2JkNGM0 Zjk3NDMyNmVhZmJlMTNmMjcwZmNjYTYzNjhlLi4xZDNhZmNmZWE1NTA3OWNiODQzM2QzNDAwOTVj N2RmOGZhYjI2ZTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcuanMKQEAgLTcxNSwyOCArNzE1LDEyIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29y ZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdDb250ZW50VmlldyBlCiAK ICAgICBfcmVjb3JkU2VsZWN0ZWQoZXZlbnQpCiAgICAgewotICAgICAgICB2YXIgdGltZWxpbmVW aWV3ID0gdGhpcy5fdGltZWxpbmVWaWV3TWFwLmdldChldmVudC5kYXRhLnRpbWVsaW5lKTsKKyAg ICAgICAgbGV0IHRpbWVsaW5lVmlldyA9IHRoaXMuX3RpbWVsaW5lVmlld01hcC5nZXQoZXZlbnQu ZGF0YS50aW1lbGluZSk7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRpbWVsaW5lVmlldyA9PT0g dGhpcy5jdXJyZW50VGltZWxpbmVWaWV3LCB0aW1lbGluZVZpZXcpOwogICAgICAgICBpZiAodGlt ZWxpbmVWaWV3ICE9PSB0aGlzLmN1cnJlbnRUaW1lbGluZVZpZXcpCiAgICAgICAgICAgICByZXR1 cm47CiAKLSAgICAgICAgdmFyIHNlbGVjdGVkVHJlZUVsZW1lbnQgPSB0aGlzLmN1cnJlbnRUaW1l bGluZVZpZXcubmF2aWdhdGlvblNpZGViYXJUcmVlT3V0bGluZS5zZWxlY3RlZFRyZWVFbGVtZW50 OwotICAgICAgICBpZiAoIWV2ZW50LmRhdGEucmVjb3JkKSB7Ci0gICAgICAgICAgICBpZiAoc2Vs ZWN0ZWRUcmVlRWxlbWVudCkKLSAgICAgICAgICAgICAgICBzZWxlY3RlZFRyZWVFbGVtZW50LmRl c2VsZWN0KCk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLQotICAgICAgICB2YXIg dHJlZUVsZW1lbnQgPSB0aGlzLmN1cnJlbnRUaW1lbGluZVZpZXcubmF2aWdhdGlvblNpZGViYXJU cmVlT3V0bGluZS5maW5kVHJlZUVsZW1lbnQoZXZlbnQuZGF0YS5yZWNvcmQpOwotICAgICAgICBj b25zb2xlLmFzc2VydCh0cmVlRWxlbWVudCwgIlRpbWVsaW5lIHZpZXcgaGFzIG5vIHRyZWUgZWxl bWVudCBmb3IgcmVjb3JkIHNlbGVjdGVkIGluIHRpbWVsaW5lIG92ZXJ2aWV3LiIsIHRpbWVsaW5l VmlldywgZXZlbnQuZGF0YS5yZWNvcmQpOwotICAgICAgICBpZiAoIXRyZWVFbGVtZW50IHx8IHRy ZWVFbGVtZW50LnNlbGVjdGVkKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIC8vIERv bid0IHNlbGVjdCB0aGUgcmVjb3JkJ3MgdHJlZSBlbGVtZW50IGlmIG9uZSBvZiBpdCdzIGNoaWxk cmVuIGlzIGFscmVhZHkgc2VsZWN0ZWQuCi0gICAgICAgIGlmIChzZWxlY3RlZFRyZWVFbGVtZW50 ICYmIHNlbGVjdGVkVHJlZUVsZW1lbnQuaGFzQW5jZXN0b3IodHJlZUVsZW1lbnQpKQotICAgICAg ICAgICAgcmV0dXJuOwotCi0gICAgICAgIHRyZWVFbGVtZW50LnJldmVhbEFuZFNlbGVjdChmYWxz ZSwgZmFsc2UsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgdGltZWxpbmVWaWV3LnNlbGVjdFJlY29y ZChldmVudC5kYXRhLnJlY29yZCk7CiAgICAgfQogCiAgICAgX3RpbWVsaW5lU2VsZWN0ZWQoKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVWaWV3LmpzCmluZGV4IDVjY2YxNWJhMDJjNzk3NzdlYWRhYjliZjZhYzkwYTlkMGQ2 YmE0OTMuLmYyMTFlMzk1MmFhYzBkNjFkZDJhYjdiZTcwZWIwZjk4YTMyYzgyMzQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVmll dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZVZpZXcuanMKQEAgLTE0Miw2ICsxNDIsMzAgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmll dyA9IGNsYXNzIFRpbWVsaW5lVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5Db250ZW50Vmlldwog ICAgICAgICAvLyBJbXBsZW1lbnRlZCBieSBzdWItY2xhc3NlcyBpZiBuZWVkZWQuCiAgICAgfQog CisgICAgc2VsZWN0UmVjb3JkKHJlY29yZCkKKyAgICB7CisgICAgICAgIGlmICghdGhpcy5fdGlt ZWxpbmVEYXRhR3JpZCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBsZXQgc2VsZWN0 ZWREYXRhR3JpZE5vZGUgPSB0aGlzLl90aW1lbGluZURhdGFHcmlkLnNlbGVjdGVkTm9kZTsKKyAg ICAgICAgaWYgKCFyZWNvcmQpIHsKKyAgICAgICAgICAgIGlmIChzZWxlY3RlZERhdGFHcmlkTm9k ZSkKKyAgICAgICAgICAgICAgICBzZWxlY3RlZERhdGFHcmlkTm9kZS5kZXNlbGVjdCgpOworICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgbGV0IGRhdGFHcmlkTm9kZSA9 IHRoaXMuX3RpbWVsaW5lRGF0YUdyaWQuZmluZE5vZGUoKG5vZGUpID0+IG5vZGUucmVjb3JkID09 PSByZWNvcmQpOworICAgICAgICBjb25zb2xlLmFzc2VydChkYXRhR3JpZE5vZGUsICJUaW1lbGlu ZSB2aWV3IGhhcyBubyBncmlkIG5vZGUgZm9yIHJlY29yZCBzZWxlY3RlZCBpbiB0aW1lbGluZSBv dmVydmlldy4iLCB0aGlzLCByZWNvcmQpOworICAgICAgICBpZiAoIWRhdGFHcmlkTm9kZSB8fCBk YXRhR3JpZE5vZGUuc2VsZWN0ZWQpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgLy8g RG9uJ3Qgc2VsZWN0IHRoZSByZWNvcmQncyBncmlkIG5vZGUgaWYgb25lIG9mIGl0J3MgY2hpbGRy ZW4gaXMgYWxyZWFkeSBzZWxlY3RlZC4KKyAgICAgICAgaWYgKHNlbGVjdGVkRGF0YUdyaWROb2Rl ICYmIHNlbGVjdGVkRGF0YUdyaWROb2RlLmhhc0FuY2VzdG9yKGRhdGFHcmlkTm9kZSkpCisgICAg ICAgICAgICByZXR1cm47CisKKyAgICAgICAgZGF0YUdyaWROb2RlLnJldmVhbEFuZFNlbGVjdCgp OworICAgIH0KKwogICAgIG1hdGNoVHJlZUVsZW1lbnRBZ2FpbnN0Q3VzdG9tRmlsdGVycyh0cmVl RWxlbWVudCkKICAgICB7CiAgICAgICAgIC8vIEltcGxlbWVudGVkIGJ5IHN1Yi1jbGFzc2VzIGlm IG5lZWRlZC4K