156937 2016-04-22 16:43:13 -0700 bmalloc: vm allocations should plant guard pages 2016-04-28 12:22:04 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren barraclough cdumez ggaren kling msaboff oliver oldest_to_newest 1186498 0 ggaren 2016-04-22 16:43:13 -0700 bmalloc: vm allocations should plant guard pages 1186501 1 277114 ggaren 2016-04-22 16:44:58 -0700 Created attachment 277114 Patch 1186507 2 277114 msaboff 2016-04-22 16:54:57 -0700 Comment on attachment 277114 Patch r=me 1186508 3 ggaren 2016-04-22 16:56:30 -0700 Committed r199936: <http://trac.webkit.org/changeset/199936> 1186624 4 barraclough 2016-04-23 10:06:15 -0700 Rolled out in r199950, looks like this is a memory regression. 1186992 5 ggaren 2016-04-25 11:21:17 -0700 Rolled back in: <http://trac.webkit.org/changeset/200035>. 1188341 6 cdumez 2016-04-28 12:22:04 -0700 The roll out in r199950 was a ~1% PLT progression. 277114 2016-04-22 16:44:58 -0700 2016-04-22 16:54:57 -0700 Patch bug-156937-20160422164541.patch text/plain 3001 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTkzNCkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA0LTIyICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogdm0gYWxsb2Nh dGlvbnMgc2hvdWxkIHBsYW50IGd1YXJkIHBhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY5MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJtYWxsb2MvT2JqZWN0Lmg6CisgICAgICAgIChibWFs bG9jOjpPYmplY3Q6Om9wZXJhdG9yLSk6IEFkZGVkIGEgLSBoZWxwZXIuCisKKyAgICAgICAgKiBi bWFsbG9jL1ZNQWxsb2NhdGUuaDoKKyAgICAgICAgKGJtYWxsb2M6OnZtUmV2b2tlUGVybWlzc2lv bnMpOiBBZGRlZCBhIGhlbHBlciB0byByZXZva2UgcGVybWlzc2lvbnMgb24KKyAgICAgICAgYSBW TSByZWdpb24uIFdlIHVzZSB0aGlzIGZvciBndWFyZCBwYWdlcy4KKworICAgICAgICAqIGJtYWxs b2MvVk1IZWFwLmNwcDoKKyAgICAgICAgKGJtYWxsb2M6OlZNSGVhcDo6YWxsb2NhdGVTbWFsbENo dW5rKTogQWRkIGd1YXJkIHBhZ2VzIHRvIHRoZSBzdGFydCBhbmQKKyAgICAgICAgZW5kIG9mIHRo ZSBjaHVuay4KKworICAgICAgICBOb3RlIHRoYXQgd2UgZG9uJ3QgZ3VhcmQgbGFyZ2UgY2h1bmtz IGJlY3Vhc2Ugd2UgbmVlZCB0byBiZSBhYmxlIHRvIG1lcmdlCisgICAgICAgIHRoZW0uIE90aGVy d2lzZSwgd2Ugd2lsbCBydW4gb3V0IG9mIHZpcnR1YWwgYWRkcmVzc2VzLgorCiAyMDE2LTA0LTIy ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgYm1hbGxvYzog Q29uc3RpZnkgaW50cm9zcGVjdCBmdW5jdGlvbiBwb2ludGVyIHRhYmxlCkluZGV4OiBTb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL09iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvT2JqZWN0LmgJKHJldmlzaW9uIDE5OTkyNCkKKysrIFNvdXJjZS9ibWFsbG9jL2JtYWxs b2MvT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDYgKzUyLDcgQEAgcHVibGljOgogICAg IFNtYWxsUGFnZSogcGFnZSgpOwogICAgIAogICAgIE9iamVjdCBvcGVyYXRvcisoc2l6ZV90KTsK KyAgICBPYmplY3Qgb3BlcmF0b3ItKHNpemVfdCk7CiAgICAgYm9vbCBvcGVyYXRvcjw9KGNvbnN0 IE9iamVjdCYpOwogCiBwcml2YXRlOgpAQCAtNjQsNiArNjUsMTEgQEAgaW5saW5lIE9iamVjdCBP YmplY3Q6Om9wZXJhdG9yKyhzaXplX3QgbwogICAgIHJldHVybiBPYmplY3QobV9jaHVuaywgbV9v ZmZzZXQgKyBvZmZzZXQpOwogfQogCitpbmxpbmUgT2JqZWN0IE9iamVjdDo6b3BlcmF0b3ItKHNp emVfdCBvZmZzZXQpCit7CisgICAgcmV0dXJuIE9iamVjdChtX2NodW5rLCBtX29mZnNldCAtIG9m ZnNldCk7Cit9CisKIGlubGluZSBib29sIE9iamVjdDo6b3BlcmF0b3I8PShjb25zdCBPYmplY3Qm IG90aGVyKQogewogICAgIEJBU1NFUlQobV9jaHVuayA9PSBvdGhlci5tX2NodW5rKTsKSW5kZXg6 IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvVk1BbGxvY2F0ZS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9ibWFsbG9jL2JtYWxsb2MvVk1BbGxvY2F0ZS5oCShyZXZpc2lvbiAxOTk5MjQpCisrKyBTb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL1ZNQWxsb2NhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTM3LDYg KzEzNywxMiBAQCBpbmxpbmUgdm9pZCB2bURlYWxsb2NhdGUodm9pZCogcCwgc2l6ZV90CiAgICAg bXVubWFwKHAsIHZtU2l6ZSk7CiB9CiAKK2lubGluZSB2b2lkIHZtUmV2b2tlUGVybWlzc2lvbnMo dm9pZCogcCwgc2l6ZV90IHZtU2l6ZSkKK3sKKyAgICB2bVZhbGlkYXRlKHAsIHZtU2l6ZSk7Cisg ICAgbXByb3RlY3QocCwgdm1TaXplLCBQUk9UX05PTkUpOworfQorCiAvLyBBbGxvY2F0ZXMgdm1T aXplIGJ5dGVzIGF0IGEgc3BlY2lmaWVkIHBvd2VyLW9mLXR3byBhbGlnbm1lbnQuCiAvLyBVc2Ug dGhpcyBmdW5jdGlvbiB0byBjcmVhdGUgbWFza2FibGUgbWVtb3J5IHJlZ2lvbnMuCiAKSW5kZXg6 IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvVk1IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL1ZNSGVhcC5jcHAJKHJldmlzaW9uIDE5OTkyNCkKKysrIFNvdXJjZS9i bWFsbG9jL2JtYWxsb2MvVk1IZWFwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzUsNiArNzUsMTIg QEAgdm9pZCBWTUhlYXA6OmFsbG9jYXRlU21hbGxDaHVuayhzdGQ6OmxvYwogICAgIE9iamVjdCBi ZWdpbihjaHVuaywgbWV0YWRhdGFTaXplKTsKICAgICBPYmplY3QgZW5kKGNodW5rLCBjaHVua1Np emUpOwogCisgICAgdm1SZXZva2VQZXJtaXNzaW9ucyhiZWdpbi5iZWdpbigpLCBwYWdlU2l6ZSk7 CisgICAgdm1SZXZva2VQZXJtaXNzaW9ucyhlbmQuYmVnaW4oKSAtIHBhZ2VTaXplLCBwYWdlU2l6 ZSk7CisKKyAgICBiZWdpbiA9IGJlZ2luICsgcGFnZVNpemU7CisgICAgZW5kID0gZW5kIC0gcGFn ZVNpemU7CisKICAgICBmb3IgKE9iamVjdCBpdCA9IGJlZ2luOyBpdCArIHBhZ2VTaXplIDw9IGVu ZDsgaXQgPSBpdCArIHBhZ2VTaXplKSB7CiAgICAgICAgIFNtYWxsUGFnZSogcGFnZSA9IGl0LnBh Z2UoKTsKICAgICAgICAgbmV3IChwYWdlKSBTbWFsbFBhZ2U7Cg==