156934 2016-04-22 15:31:48 -0700 Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons 2016-04-22 19:49:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1186468 0 mattbaker 2016-04-22 15:31:48 -0700 * SUMMARY HeapAllocationsTimeline grid should use built-in grid column icons. To avoid subtle differences in styling, grid nodes should avoid creating their own icon elements for document fragment cells. 1186470 1 277108 mattbaker 2016-04-22 15:34:29 -0700 Created attachment 277108 [Patch] Proposed Fix 1186472 2 webkit-bug-importer 2016-04-22 15:35:23 -0700 <rdar://problem/25887367> 1186473 3 webkit-bug-importer 2016-04-22 15:35:29 -0700 <rdar://problem/25887363> 1186480 4 277108 joepeck 2016-04-22 15:51:37 -0700 Comment on attachment 277108 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=277108&action=review I still don't think it makes sense for DataGrid to special case having an icon for a data grid cell. It feels like too much is getting put into DataGrid. As is, this change looks fine, it just seems like increased complexity for no profit. > Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:40 > + icon: true Style: Should have trailing comma. 1186482 5 mattbaker 2016-04-22 16:05:51 -0700 (In reply to comment #4) > Comment on attachment 277108 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277108&action=review > > I still don't think it makes sense for DataGrid to special case having an > icon for a data grid cell. It feels like too much is getting put into > DataGrid. As is, this change looks fine, it just seems like increased > complexity for no profit. I disagree. Adding icon elements is a common operation, and pushing it into the grid adds very little complexity while ensuring consistently styled cell content. 1186483 6 277110 mattbaker 2016-04-22 16:09:26 -0700 Created attachment 277110 [Patch] Proposed Fix 1186491 7 277110 timothy 2016-04-22 16:20:40 -0700 Comment on attachment 277110 [Patch] Proposed Fix One solution to Joe's concerns would be to have a subclass of DataGridNode that added the icon support, but didn't bake it into DataGridNode directly. That would be similar to GeneralTreeElement for TreeOutlines. But I think this is fine. I suspect there are other places we could do this. 1186549 8 mattbaker 2016-04-22 19:00:52 -0700 Since grid cell formatting is the same for all cells in a column, we might want something like this: DataGridColumn (basic formatting for text & numbers) DataGridIconColumn DataGridCustomColumn (for document fragment cells) I'll give it some more thought. 1186559 9 277110 commit-queue 2016-04-22 19:49:20 -0700 Comment on attachment 277110 [Patch] Proposed Fix Clearing flags on attachment: 277110 Committed r199947: <http://trac.webkit.org/changeset/199947> 1186560 10 commit-queue 2016-04-22 19:49:25 -0700 All reviewed patches have been landed. Closing bug. 277108 2016-04-22 15:34:29 -0700 2016-04-22 16:09:23 -0700 [Patch] Proposed Fix bug-156934-20160422153454.patch text/plain 3491 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl NzQ1ZWZkNzRjZGI5NWJmODcyMDRkN2ZhNmViMDE4MDcwMDZhMjk1Li45MmVhYjI4ZjgyODNlODZh Yzg4Y2ExYzc3NWRjYWQ2MjQ0ODcwMjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wNC0yMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGVhcEFsbG9jYXRpb25zVGltZWxpbmUgZ3JpZCBz aG91bGQgdXNlIGJ1aWx0LWluIGdyaWQgY29sdW1uIGljb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY5MzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFs bG9jYXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu SGVhcEFsbG9jYXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUpOgorICAgICAgICBVc2UgZXhpc3Rp bmcgYmFzZSBjbGFzcyBoZWxwZXIgZnVuY3Rpb24gdG8gY3JlYXRlIG1haW4gdGl0bGUgdGV4dC4K KyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9k ZS5wcm90b3R5cGUuY3JlYXRlQ2VsbENvbnRlbnQpOgorICAgICAgICBBZGQgaWNvbiBjbGFzcyBu YW1lcyB0byBjZWxsLCByZW1vdmUgaWNvbiBlbGVtZW50LgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3KToKKyAgICAgICAgVHVybiBvbiBp Y29ucyBmb3IgdGhlIGNvbHVtbi4KKwogMjAxNi0wNC0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGlt b3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIGFuIGFzc2VydCB0byBhIHdhcm4gYmFz ZWQgb24gcG9zdCByZXZpZXcgZmVlZGJhY2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlk Tm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBB bGxvY2F0aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzCmluZGV4IDk1YmZhZGIwMjRkYzdhZjhj Mjg5ZDVlZmE0ZmNlNzA1ZmNiNjkzYTkuLmZmYjk4YTA1ODVmMjZmNzc2ZWFjNTJkNzNlNThiMTM1 MWM0ZjgyNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVs aW5lRGF0YUdyaWROb2RlLmpzCkBAIC0zMyw3ICszMyw3IEBAIFdlYkluc3BlY3Rvci5IZWFwQWxs b2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZSA9IGNsYXNzIEhlYXBBbGxvY2F0aW9uc1RpbWVs aW5lCiAgICAgICAgIHRoaXMuX2hlYXBBbGxvY2F0aW9uc1ZpZXcgPSBoZWFwQWxsb2NhdGlvbnNW aWV3OwogCiAgICAgICAgIHRoaXMuX2RhdGEgPSB7Ci0gICAgICAgICAgICBuYW1lOiBXZWJJbnNw ZWN0b3IuVGltZWxpbmVUYWJDb250ZW50Vmlldy5kaXNwbGF5TmFtZUZvclJlY29yZChoZWFwQWxs b2NhdGlvbnNUaW1lbGluZVJlY29yZCksCisgICAgICAgICAgICBuYW1lOiB0aGlzLmRpc3BsYXlO YW1lKCksCiAgICAgICAgICAgICB0aW1lc3RhbXA6IHRoaXMuX3JlY29yZC50aW1lc3RhbXAgLSB6 ZXJvVGltZSwKICAgICAgICAgICAgIHNpemU6IHRoaXMuX3JlY29yZC5oZWFwU25hcHNob3QudG90 YWxTaXplLAogICAgICAgICB9OwpAQCAtNDgsOSArNDgsOSBAQCBXZWJJbnNwZWN0b3IuSGVhcEFs bG9jYXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUgPSBjbGFzcyBIZWFwQWxsb2NhdGlvbnNUaW1l bGluZQogICAgIHsKICAgICAgICAgc3dpdGNoIChjb2x1bW5JZGVudGlmaWVyKSB7CiAgICAgICAg IGNhc2UgIm5hbWUiOgorICAgICAgICAgICAgY2VsbC5jbGFzc0xpc3QuYWRkKC4uLnRoaXMuaWNv bkNsYXNzTmFtZXMoKSk7CisKICAgICAgICAgICAgIGxldCBmcmFnbWVudCA9IGRvY3VtZW50LmNy ZWF0ZURvY3VtZW50RnJhZ21lbnQoKTsKLSAgICAgICAgICAgIGxldCBpY29uRWxlbWVudCA9IGZy YWdtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImltZyIpKTsKLSAgICAg ICAgICAgIGljb25FbGVtZW50LmNsYXNzTGlzdC5hZGQoImljb24iLCAiaGVhcC1zbmFwc2hvdCIp OwogICAgICAgICAgICAgbGV0IHRpdGxlRWxlbWVudCA9IGZyYWdtZW50LmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKSk7CiAgICAgICAgICAgICB0aXRsZUVsZW1lbnQu dGV4dENvbnRlbnQgPSB0aGlzLl9kYXRhLm5hbWU7CiAgICAgICAgICAgICBsZXQgZ29Ub0J1dHRv biA9IGZyYWdtZW50LmFwcGVuZENoaWxkKFdlYkluc3BlY3Rvci5jcmVhdGVHb1RvQXJyb3dCdXR0 b24oKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanMKaW5k ZXggZjJkOWJhNWNlOWRjMzIxZDhkNGZkN2RkYjRhOTgyZDE1Yzg4MzU1NC4uY2MwMDljMjUwNWM0 ZDdmMTA1OWJhMDczN2JmM2Q5ZGI3YmM4MzZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxv Y2F0aW9uc1RpbWVsaW5lVmlldy5qcwpAQCAtMzcsNiArMzcsNyBAQCBXZWJJbnNwZWN0b3IuSGVh cEFsbG9jYXRpb25zVGltZWxpbmVWaWV3ID0gY2xhc3MgSGVhcEFsbG9jYXRpb25zVGltZWxpbmVW aWV3IGV4dAogICAgICAgICAgICAgbmFtZTogewogICAgICAgICAgICAgICAgIHRpdGxlOiBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIk5hbWUiKSwKICAgICAgICAgICAgICAgICB3aWR0aDogIjE1MHB4 IiwKKyAgICAgICAgICAgICAgICBpY29uOiB0cnVlCiAgICAgICAgICAgICB9LAogICAgICAgICAg ICAgdGltZXN0YW1wOiB7CiAgICAgICAgICAgICAgICAgdGl0bGU6IFdlYkluc3BlY3Rvci5VSVN0 cmluZygiVGltZSIpLAo= 277110 2016-04-22 16:09:26 -0700 2016-04-22 19:49:20 -0700 [Patch] Proposed Fix bug-156934-20160422160951.patch text/plain 3492 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl NzQ1ZWZkNzRjZGI5NWJmODcyMDRkN2ZhNmViMDE4MDcwMDZhMjk1Li45MmVhYjI4ZjgyODNlODZh Yzg4Y2ExYzc3NWRjYWQ2MjQ0ODcwMjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wNC0yMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGVhcEFsbG9jYXRpb25zVGltZWxpbmUgZ3JpZCBz aG91bGQgdXNlIGJ1aWx0LWluIGdyaWQgY29sdW1uIGljb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY5MzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFs bG9jYXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu SGVhcEFsbG9jYXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUpOgorICAgICAgICBVc2UgZXhpc3Rp bmcgYmFzZSBjbGFzcyBoZWxwZXIgZnVuY3Rpb24gdG8gY3JlYXRlIG1haW4gdGl0bGUgdGV4dC4K KyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9k ZS5wcm90b3R5cGUuY3JlYXRlQ2VsbENvbnRlbnQpOgorICAgICAgICBBZGQgaWNvbiBjbGFzcyBu YW1lcyB0byBjZWxsLCByZW1vdmUgaWNvbiBlbGVtZW50LgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3KToKKyAgICAgICAgVHVybiBvbiBp Y29ucyBmb3IgdGhlIGNvbHVtbi4KKwogMjAxNi0wNC0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGlt b3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIGFuIGFzc2VydCB0byBhIHdhcm4gYmFz ZWQgb24gcG9zdCByZXZpZXcgZmVlZGJhY2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlk Tm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBB bGxvY2F0aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzCmluZGV4IDk1YmZhZGIwMjRkYzdhZjhj Mjg5ZDVlZmE0ZmNlNzA1ZmNiNjkzYTkuLmZmYjk4YTA1ODVmMjZmNzc2ZWFjNTJkNzNlNThiMTM1 MWM0ZjgyNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVs aW5lRGF0YUdyaWROb2RlLmpzCkBAIC0zMyw3ICszMyw3IEBAIFdlYkluc3BlY3Rvci5IZWFwQWxs b2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZSA9IGNsYXNzIEhlYXBBbGxvY2F0aW9uc1RpbWVs aW5lCiAgICAgICAgIHRoaXMuX2hlYXBBbGxvY2F0aW9uc1ZpZXcgPSBoZWFwQWxsb2NhdGlvbnNW aWV3OwogCiAgICAgICAgIHRoaXMuX2RhdGEgPSB7Ci0gICAgICAgICAgICBuYW1lOiBXZWJJbnNw ZWN0b3IuVGltZWxpbmVUYWJDb250ZW50Vmlldy5kaXNwbGF5TmFtZUZvclJlY29yZChoZWFwQWxs b2NhdGlvbnNUaW1lbGluZVJlY29yZCksCisgICAgICAgICAgICBuYW1lOiB0aGlzLmRpc3BsYXlO YW1lKCksCiAgICAgICAgICAgICB0aW1lc3RhbXA6IHRoaXMuX3JlY29yZC50aW1lc3RhbXAgLSB6 ZXJvVGltZSwKICAgICAgICAgICAgIHNpemU6IHRoaXMuX3JlY29yZC5oZWFwU25hcHNob3QudG90 YWxTaXplLAogICAgICAgICB9OwpAQCAtNDgsOSArNDgsOSBAQCBXZWJJbnNwZWN0b3IuSGVhcEFs bG9jYXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUgPSBjbGFzcyBIZWFwQWxsb2NhdGlvbnNUaW1l bGluZQogICAgIHsKICAgICAgICAgc3dpdGNoIChjb2x1bW5JZGVudGlmaWVyKSB7CiAgICAgICAg IGNhc2UgIm5hbWUiOgorICAgICAgICAgICAgY2VsbC5jbGFzc0xpc3QuYWRkKC4uLnRoaXMuaWNv bkNsYXNzTmFtZXMoKSk7CisKICAgICAgICAgICAgIGxldCBmcmFnbWVudCA9IGRvY3VtZW50LmNy ZWF0ZURvY3VtZW50RnJhZ21lbnQoKTsKLSAgICAgICAgICAgIGxldCBpY29uRWxlbWVudCA9IGZy YWdtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImltZyIpKTsKLSAgICAg ICAgICAgIGljb25FbGVtZW50LmNsYXNzTGlzdC5hZGQoImljb24iLCAiaGVhcC1zbmFwc2hvdCIp OwogICAgICAgICAgICAgbGV0IHRpdGxlRWxlbWVudCA9IGZyYWdtZW50LmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKSk7CiAgICAgICAgICAgICB0aXRsZUVsZW1lbnQu dGV4dENvbnRlbnQgPSB0aGlzLl9kYXRhLm5hbWU7CiAgICAgICAgICAgICBsZXQgZ29Ub0J1dHRv biA9IGZyYWdtZW50LmFwcGVuZENoaWxkKFdlYkluc3BlY3Rvci5jcmVhdGVHb1RvQXJyb3dCdXR0 b24oKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanMKaW5k ZXggZjJkOWJhNWNlOWRjMzIxZDhkNGZkN2RkYjRhOTgyZDE1Yzg4MzU1NC4uYWRkMzVkNjliNWQ4 YTIzZjAxYTFiMTM2ODVmYWY1MTg2ZDhmMzEwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxv Y2F0aW9uc1RpbWVsaW5lVmlldy5qcwpAQCAtMzcsNiArMzcsNyBAQCBXZWJJbnNwZWN0b3IuSGVh cEFsbG9jYXRpb25zVGltZWxpbmVWaWV3ID0gY2xhc3MgSGVhcEFsbG9jYXRpb25zVGltZWxpbmVW aWV3IGV4dAogICAgICAgICAgICAgbmFtZTogewogICAgICAgICAgICAgICAgIHRpdGxlOiBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIk5hbWUiKSwKICAgICAgICAgICAgICAgICB3aWR0aDogIjE1MHB4 IiwKKyAgICAgICAgICAgICAgICBpY29uOiB0cnVlLAogICAgICAgICAgICAgfSwKICAgICAgICAg ICAgIHRpbWVzdGFtcDogewogICAgICAgICAgICAgICAgIHRpdGxlOiBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlRpbWUiKSwK