156930 2016-04-22 14:07:09 -0700 ASSERT(m_stack.last().isTailDeleted) at ShadowChicken.cpp:127 inspecting the inspector 2016-04-22 15:46:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck fpizlo commit-queue fpizlo ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1186421 0 joepeck 2016-04-22 14:07:09 -0700 * SUMMARY Assertion when inspecting the inspector. * STEPS TO REPRODUCE 1. $ defaults write com.apple.Safari WebKitDebugDeveloperExtrasEnabled -bool YES 2. $ run-safari --debug 3. Inspect about:blank 4. Inspect the inspector (Right Click on the toolbar and select Inspect Element) 5. inspector²: Open DebuggerObserver.js 6. inspector²: Set a breakpoint in globalObjectCleared 7. inspector¹: Reload the page => triggers breakpoint in inspector² 8. inspector²: Continue 9. Repeat steps 7 and 8 if needed => ASSERT * ASSERT ASSERTION FAILED: !m_stack.last().isTailDeleted /Users/pecoraro/Code/safari/OpenSource/Source/JavaScriptCore/interpreter/ShadowChicken.cpp(127) : void JSC::ShadowChicken::update(JSC::VM &, JSC::ExecState *) 1 0x10a158130 WTFCrash 2 0x109cc6045 JSC::ShadowChicken::update(JSC::VM&, JSC::ExecState*) 3 0x109ba2723 operationProcessShadowChickenLog 4 0x54ddab59107d 5 0x54ddab5aa6bf 6 0x54ddab8f9295 7 0x54ddab573005 8 0x54ddab573026 9 0x54ddab573026 10 0x54ddab573026 11 0x54ddab573026 12 0x109d8311f llint_entry 13 0x109d83199 llint_entry 14 0x109d83199 llint_entry 15 0x109d83199 llint_entry 16 0x109d83199 llint_entry 17 0x109d7c65e vmEntryToJavaScript 18 0x109b8bdea JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 19 0x109b1f1cc JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 20 0x1093fc28e JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 21 0x109bdf4d2 JSC::boundFunctionCall(JSC::ExecState*) 22 0x54ddab401028 23 0x109d83199 llint_entry 24 0x109d83199 llint_entry 25 0x109d7c65e vmEntryToJavaScript 26 0x109b8bdea JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 27 0x109b1f1cc JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 28 0x1093fc28e JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 29 0x109a3e4f5 JSC::callSetter(JSC::ExecState*, JSC::JSValue, JSC::JSValue, JSC::JSValue, JSC::ECMAMode) 30 0x109c9622f JSC::JSObject::putInlineSlow(JSC::ExecState*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) 31 0x109ba52e8 JSC::JSObject::putInline(JSC::JSCell*, JSC::ExecState*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) ERROR: Exiting process early due to unacknowledged closed-connection 1186422 1 fpizlo 2016-04-22 14:08:19 -0700 I think that this may be a bad assertion. I will look. 1186427 2 fpizlo 2016-04-22 14:13:40 -0700 I think I have a fix. 1186434 3 fpizlo 2016-04-22 14:20:34 -0700 JoePeck confirmed that my fix works for him and he reviewed it. I am running all of the tests. 1186436 4 277101 fpizlo 2016-04-22 14:21:10 -0700 Created attachment 277101 patch for EWS If EWS and my tests are happy then I'll land this, with a ChangeLog of course. 1186477 5 fpizlo 2016-04-22 15:46:13 -0700 Landed in http://trac.webkit.org/changeset/199918 277101 2016-04-22 14:21:10 -0700 2016-04-22 14:21:10 -0700 patch for EWS blah.patch text/plain 716 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9TaGFkb3dDaGlja2VuLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvU2hhZG93 Q2hpY2tlbi5jcHAJKHJldmlzaW9uIDE5OTkwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9TaGFkb3dDaGlja2VuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE0LDcgKzEx NCw3IEBAIHZvaWQgU2hhZG93Q2hpY2tlbjo6dXBkYXRlKFZNJiwgRXhlY1N0YXQKICAgICBpZiAo dmVyYm9zZSkKICAgICAgICAgZGF0YUxvZygiICAgIEhpZ2hlc3QgcG9pbnQgc2luY2UgbGFzdCB0 aW1lOiAiLCBSYXdQb2ludGVyKGhpZ2hlc3RQb2ludFNpbmNlTGFzdFRpbWUpLCAiXG4iKTsKICAg ICAKLSAgICB3aGlsZSAoIW1fc3RhY2suaXNFbXB0eSgpICYmIG1fc3RhY2subGFzdCgpLmZyYW1l IDwgaGlnaGVzdFBvaW50U2luY2VMYXN0VGltZSkKKyAgICB3aGlsZSAoIW1fc3RhY2suaXNFbXB0 eSgpICYmIChtX3N0YWNrLmxhc3QoKS5mcmFtZSA8IGhpZ2hlc3RQb2ludFNpbmNlTGFzdFRpbWUg fHwgbV9zdGFjay5sYXN0KCkuaXNUYWlsRGVsZXRlZCkpCiAgICAgICAgIG1fc3RhY2sucmVtb3Zl TGFzdCgpOwogICAgIAogICAgIGlmICh2ZXJib3NlKQo=