156927 2016-04-22 13:49:08 -0700 Web Inspector: Include columnNumber in event listener locations 2016-04-22 17:44:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1186406 0 joepeck 2016-04-22 13:49:08 -0700 * SUMMARY Include columnNumber in event listener locations. This is needed in minified code to jump to accurate locations. 1186407 1 webkit-bug-importer 2016-04-22 13:49:31 -0700 <rdar://problem/25884584> 1186411 2 277096 joepeck 2016-04-22 13:54:14 -0700 Created attachment 277096 [PATCH] Proposed Fix 1186426 3 277096 bburg 2016-04-22 14:11:58 -0700 Comment on attachment 277096 [PATCH] Proposed Fix No test coverage? :( 1186506 4 277096 bburg 2016-04-22 16:52:55 -0700 Comment on attachment 277096 [PATCH] Proposed Fix r=me This is a reminder to file a bug somewhere about adding test coverage for event listener locations. 1186531 5 277096 commit-queue 2016-04-22 17:44:24 -0700 Comment on attachment 277096 [PATCH] Proposed Fix Clearing flags on attachment: 277096 Committed r199940: <http://trac.webkit.org/changeset/199940> 1186532 6 commit-queue 2016-04-22 17:44:28 -0700 All reviewed patches have been landed. Closing bug. 277096 2016-04-22 13:54:14 -0700 2016-04-22 17:44:24 -0700 [PATCH] Proposed Fix column-number.patch text/plain 2304 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMTk0YTE4Li42NTBkMWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMDQtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbmNsdWRlIGNvbHVtbk51bWJlciBpbiBldmVudCBsaXN0 ZW5lciBsb2NhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1NjkyNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjU4ODQ1ODQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5z cGVjdG9yRE9NQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6 OmJ1aWxkT2JqZWN0Rm9yRXZlbnRMaXN0ZW5lcik6CisgICAgICAgIEluY2x1ZGUgdGhlIGNvbHVt biBudW1iZXIgaW4gdGhlIGxvY2F0aW9uIGFzIHdlbGwuCisKIDIwMTYtMDQtMjEgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIEJhY2tkcm9wIEZpbHRlciBzaG91bGQg bm90IGJlIHZpc2libGUgaWYgZWxlbWVudCBoYXMgdmlzaWJpbGl0eTpoaWRkZW4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDMwNmQzZDMu LjdlMDRiYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JE T01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFn ZW50LmNwcApAQCAtMTQ2Niw2ICsxNDY2LDcgQEAgUmVmPEluc3BlY3Rvcjo6UHJvdG9jb2w6OkRP TTo6RXZlbnRMaXN0ZW5lcj4gSW5zcGVjdG9yRE9NQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9yRXYKICAg ICBKU0M6OkpTT2JqZWN0KiBoYW5kbGVyID0gbnVsbHB0cjsKICAgICBTdHJpbmcgYm9keTsKICAg ICBpbnQgbGluZU51bWJlciA9IDA7CisgICAgaW50IGNvbHVtbk51bWJlciA9IDA7CiAgICAgU3Ry aW5nIHNjcmlwdElEOwogICAgIFN0cmluZyBzb3VyY2VOYW1lOwogICAgIGlmIChhdXRvIHNjcmlw dExpc3RlbmVyID0gSlNFdmVudExpc3RlbmVyOjpjYXN0KGV2ZW50TGlzdGVuZXIuZ2V0KCkpKSB7 CkBAIC0xNDc4LDYgKzE0NzksNyBAQCBSZWY8SW5zcGVjdG9yOjpQcm90b2NvbDo6RE9NOjpFdmVu dExpc3RlbmVyPiBJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRPYmplY3RGb3JFdgogICAgICAgICAg ICAgICAgIGlmICghZnVuY3Rpb24tPmlzSG9zdE9yQnVpbHRpbkZ1bmN0aW9uKCkpIHsKICAgICAg ICAgICAgICAgICAgICAgaWYgKGF1dG8gZXhlY3V0YWJsZSA9IGZ1bmN0aW9uLT5qc0V4ZWN1dGFi bGUoKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgbGluZU51bWJlciA9IGV4ZWN1dGFibGUt PmZpcnN0TGluZSgpIC0gMTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbHVtbk51bWJlciA9 IGV4ZWN1dGFibGUtPnN0YXJ0Q29sdW1uKCkgLSAxOwogICAgICAgICAgICAgICAgICAgICAgICAg c2NyaXB0SUQgPSBleGVjdXRhYmxlLT5zb3VyY2VJRCgpID09IEpTQzo6U291cmNlUHJvdmlkZXI6 Om51bGxJRCA/IGVtcHR5U3RyaW5nKCkgOiBTdHJpbmc6Om51bWJlcihleGVjdXRhYmxlLT5zb3Vy Y2VJRCgpKTsKICAgICAgICAgICAgICAgICAgICAgICAgIHNvdXJjZU5hbWUgPSBleGVjdXRhYmxl LT5zb3VyY2VVUkwoKTsKICAgICAgICAgICAgICAgICAgICAgfQpAQCAtMTUwMyw2ICsxNTA1LDcg QEAgUmVmPEluc3BlY3Rvcjo6UHJvdG9jb2w6OkRPTTo6RXZlbnRMaXN0ZW5lcj4gSW5zcGVjdG9y RE9NQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9yRXYKICAgICAgICAgICAgIC5zZXRTY3JpcHRJZChzY3Jp cHRJRCkKICAgICAgICAgICAgIC5zZXRMaW5lTnVtYmVyKGxpbmVOdW1iZXIpCiAgICAgICAgICAg ICAucmVsZWFzZSgpOworICAgICAgICBsb2NhdGlvbi0+c2V0Q29sdW1uTnVtYmVyKGNvbHVtbk51 bWJlcik7CiAgICAgICAgIHZhbHVlLT5zZXRMb2NhdGlvbihXVEZNb3ZlKGxvY2F0aW9uKSk7CiAg ICAgICAgIGlmICghc291cmNlTmFtZS5pc0VtcHR5KCkpCiAgICAgICAgICAgICB2YWx1ZS0+c2V0 U291cmNlTmFtZShzb3VyY2VOYW1lKTsK