15690 2007-10-25 09:36:35 -0700 Bug in layout test framework (setUpPage vs. setUpPageStatus) 2023-11-28 03:53:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 15707 1 renselp webkit-unassigned ap ddkilzer ian.eng.webkit manzasiamrama2 oldest_to_newest 59437 0 renselp 2007-10-25 09:36:35 -0700 There seems to be a bug the test framework used by the layout tests. Upon completion the setUpPage function overwrites itself when it really means to update setUpPageComplete. I'm not sure exactly what the consequences are but in any case it seems wrong. 59443 1 renselp 2007-10-25 10:51:33 -0700 Correction: not setUpPageComplete but setUpPageStatus. 59484 2 mrowe 2007-10-25 19:10:00 -0700 Can you be more specific about this? 59492 3 renselp 2007-10-25 21:18:50 -0700 If you run dom/xhtml/level2/html/HTMLIFrameElement11.xhtml an exception is thrown at selfxhtml.js:715 and the actual test is never run. However, the test is still marked as passed for some reason. Also, if you look at the code in HTMLIFrameElement11.js (or any of the others like it) I think it is pretty obvious that overwriting setUpPage is not the intended behavior. 59496 4 ap 2007-10-25 22:03:41 -0700 Here are the results for this test, I don't see it marked as passed: Test http://www.w3.org/2001/DOM-Test-Suite/level2/html/HTMLIFrameElement11 Status failure Message titleLink: assertEquals failed, actual , expected NIST DOM HTML Test - FRAME. 59497 5 renselp 2007-10-25 22:25:42 -0700 Sorry, I picked the wrong HTMLIFrameElement11 -- I meant dom/html/level2/html/HTMLIFrameElement11.html. In safari 3.0.3 I get Test: http://www.w3.org/2001/DOM-Test-Suite/level2/html/HTMLIFrameElement11 Status: Success But an error shows up in the javascript console: Value complete (result of expression setUpPage) is not object. selfhtml.js:692 59508 6 ap 2007-10-25 23:35:58 -0700 Oh, that's a bad bug - thanks for catching it! Interestingly, this particular test starts to crash for me when corrected :-(. I'm going to see if this can be easily fixed. 59513 7 renselp 2007-10-26 00:00:23 -0700 Note that this is a potential problem for any test whose .js file was created from the same template, which I think is most of them. 59514 8 ap 2007-10-26 00:02:01 -0700 Yes, there were several thousand instances of this problem. Filed <http://www.w3.org/Bugs/Public/show_bug.cgi?id=5227>, so that this could be fixed upstream, too. 64657 9 ap 2007-12-18 12:30:19 -0800 *** Bug 16494 has been marked as a duplicate of this bug. *** 66140 10 ian.eng.webkit 2008-01-03 10:18:15 -0800 The bug in w3c is marked as fixed. How can we down steam changes to WebKit? (In reply to comment #9) > *** Bug 16494 has been marked as a duplicate of this bug. *** > (In reply to comment #8) > Yes, there were several thousand instances of this problem. > > Filed <http://www.w3.org/Bugs/Public/show_bug.cgi?id=5227>, so that this could > be fixed upstream, too. > 66145 11 ap 2008-01-03 12:45:14 -0800 We need to fix bug 15707, which blocks this one. 110574 12 ap 2009-02-23 06:48:44 -0800 Fix committed r41140...r41145.