156899 2016-04-22 02:17:48 -0700 Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack 2016-04-25 03:26:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 156844 1 youennf youennf calvaris cdumez commit-queue darin eric.carlson esprehn+autocc gyuyoung.kim kondapallykalyan philipj oldest_to_newest 1186179 0 youennf 2016-04-22 02:17:48 -0700 Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack. 1186183 1 277028 youennf 2016-04-22 02:20:28 -0700 Created attachment 277028 Patch 1186282 2 277028 cdumez 2016-04-22 09:46:55 -0700 Comment on attachment 277028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277028&action=review r=me with nit > Source/WebCore/html/track/TextTrack.idl:43 > readonly attribute TextTrackCueList cues; Since we are passing by, could we mark this one as nullable to match the spec (no behavior change) > Source/WebCore/html/track/TextTrack.idl:44 > readonly attribute TextTrackCueList activeCues; Since we are passing by, could we mark this one as nullable to match the spec (no behavior change) 1186729 3 youennf 2016-04-24 04:52:37 -0700 (In reply to comment #2) > Comment on attachment 277028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277028&action=review > > r=me with nit > > > Source/WebCore/html/track/TextTrack.idl:43 > > readonly attribute TextTrackCueList cues; > > Since we are passing by, could we mark this one as nullable to match the > spec (no behavior change) > > > Source/WebCore/html/track/TextTrack.idl:44 > > readonly attribute TextTrackCueList activeCues; > > Since we are passing by, could we mark this one as nullable to match the > spec (no behavior change) Thanks for the review. I'll check this and update patch accordingly. 1186892 4 277238 youennf 2016-04-25 02:25:55 -0700 Created attachment 277238 Patch for landing 1186899 5 277238 commit-queue 2016-04-25 03:26:28 -0700 Comment on attachment 277238 Patch for landing Clearing flags on attachment: 277238 Committed r199986: <http://trac.webkit.org/changeset/199986> 1186900 6 commit-queue 2016-04-25 03:26:35 -0700 All reviewed patches have been landed. Closing bug. 277028 2016-04-22 02:20:28 -0700 2016-04-25 02:25:45 -0700 Patch bug-156899-20160422112050.patch text/plain 2378 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTBhY2Y0ZTA2MzEwMTM5 ZTQ2ODBmNmY0YjgxZWQyYmY5OTE3YWZmNi4uMTZmZmQ2MDdlYmFiMTM3YTNhNzJmMjZhNzZhZDlj YTNlZWQ3NzRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA0LTIyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgRHJvcCBb VXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHNdIGZyb20gVGV4dFRy YWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY4 OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBi ZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICogaHRtbC90cmFjay9UZXh0VHJhY2suaWRsOiBN YXJraW5nIGN1ZSBhbmQgcmVnaW9uIHBhcmFtZXRlciBhcyBudWxsYWJsZS4KKwogMjAxNi0wNC0y MSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIERyb3AgW1VzZVBv aW50ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzXSBmcm9tIERvY3VtZW50CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFjay5pZGwgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFjay5pZGwKaW5kZXggNjg4NGIyODk2OGI2OGQz ZjEwN2FhMTJlOWY2MGFmZTE4NWM0ZjU1OS4uYmIzNGNjYzUxZDAxMjE4NzQzZWVmMTcxOTk1YzRi Mzk2NDRiZjIwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJh Y2suaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrLmlkbApAQCAt MjgsNyArMjgsNiBAQCBlbnVtIFRleHRUcmFja0tpbmQgeyAic3VidGl0bGVzIiwgICJjYXB0aW9u cyIsICAiZGVzY3JpcHRpb25zIiwgICJjaGFwdGVycyIsICJtZQogCiBbCiAgICAgQ29uZGl0aW9u YWw9VklERU9fVFJBQ0ssCi0gICAgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RB cmd1bWVudHMsCiAgICAgR2VuZXJhdGVJc1JlYWNoYWJsZT1JbXBsRWxlbWVudFJvb3QsCiAgICAg SlNDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgU2tpcFZUYWJsZVZhbGlkYXRpb24sCkBAIC00NCwx NCArNDMsMTYgQEAgZW51bSBUZXh0VHJhY2tLaW5kIHsgInN1YnRpdGxlcyIsICAiY2FwdGlvbnMi LCAgImRlc2NyaXB0aW9ucyIsICAiY2hhcHRlcnMiLCAibWUKICAgICByZWFkb25seSBhdHRyaWJ1 dGUgVGV4dFRyYWNrQ3VlTGlzdCBjdWVzOwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBUZXh0VHJh Y2tDdWVMaXN0IGFjdGl2ZUN1ZXM7CiAKLSAgICBbUmFpc2VzRXhjZXB0aW9uXSB2b2lkIGFkZEN1 ZShUZXh0VHJhY2tDdWUgY3VlKTsKLSAgICBbUmFpc2VzRXhjZXB0aW9uXSB2b2lkIHJlbW92ZUN1 ZShUZXh0VHJhY2tDdWUgY3VlKTsKKyAgICAvLyBGSVhNRTogY3VlIHBhcmFtZXRlciBzaG91bGQg bm90IGJlIG51bGxhYmxlIGluIGFkZEN1ZSBhbmQgcmVtb3ZlQ3VlLgorICAgIFtSYWlzZXNFeGNl cHRpb25dIHZvaWQgYWRkQ3VlKFRleHRUcmFja0N1ZT8gY3VlKTsKKyAgICBbUmFpc2VzRXhjZXB0 aW9uXSB2b2lkIHJlbW92ZUN1ZShUZXh0VHJhY2tDdWU/IGN1ZSk7CiAKICAgICBhdHRyaWJ1dGUg RXZlbnRIYW5kbGVyIG9uY3VlY2hhbmdlOwogCiAjaWYgIWRlZmluZWQoTEFOR1VBR0VfR09CSkVD VCkgfHwgIUxBTkdVQUdFX0dPQkpFQ1QgLy8gV29yayBhcm91bmQgc2hvcnRjb21pbmdzIGluIHRo ZSBnb2JqZWN0IGJpbmRpbmcgZ2VuZXJhdG9yIGhhbmRsaW5nIG9mIGNvbmRpdGlvbmFsIGZlYXR1 cmVzIGJ5IHR1cm5pbmcgdGhlc2Ugb2ZmIGZvciBnb2JqZWN0LgogICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBWVFRSZWdpb25MaXN0IHJlZ2lvbnM7Ci0gICAgdm9pZCBhZGRSZWdpb24oVlRUUmVnaW9u IHJlZ2lvbik7Ci0gICAgW1JhaXNlc0V4Y2VwdGlvbl0gdm9pZCByZW1vdmVSZWdpb24oVlRUUmVn aW9uIHJlZ2lvbik7CisgICAgLy8gRklYTUU6IHJlZ2lvbiBwYXJhbWV0ZXIgc2hvdWxkIG5vdCBi ZSBudWxsYWJsZSBpbiBhZGRSZWdpb24gYW5kIHJlbW92ZVJlZ2lvbi4KKyAgICB2b2lkIGFkZFJl Z2lvbihWVFRSZWdpb24/IHJlZ2lvbik7CisgICAgW1JhaXNlc0V4Y2VwdGlvbl0gdm9pZCByZW1v dmVSZWdpb24oVlRUUmVnaW9uPyByZWdpb24pOwogI2VuZGlmCiB9Owo= 277238 2016-04-25 02:25:55 -0700 2016-04-25 03:26:28 -0700 Patch for landing bug-156899-20160425112620.patch text/plain 2560 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRkNzdjZjI0M2I5OTMz YmQ0MGRjMzIyMjhiZTAyOWZlODE2YzQxZC4uMjYxZmVhMjYwZDdlNzk0YjZiNDlhZjQ1NzExM2Zi NTU2NTdhOTZhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA0LTI1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgRHJvcCBb VXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHNdIGZyb20gVGV4dFRy YWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY4 OTkKKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICBObyBiZWhh dmlvciBjaGFuZ2VzLgorCisgICAgICAgICogaHRtbC90cmFjay9UZXh0VHJhY2suaWRsOiBNYXJr aW5nIGN1ZSBhbmQgcmVnaW9uIHBhcmFtZXRlciBhcyBudWxsYWJsZS4KKyAgICAgICAgQWxzbyBt YXJraW5nIGN1ZXMgYW5kIGFjdGl2ZUN1ZXMgYXMgbnVsbGFibGUgYXR0cmlidXRlcy4KKwogMjAx Ni0wNC0yNSAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgTWlu b3IgcmVmYWN0b3JpbmcgaW4gUmVuZGVyTWF0aE1MT3BlcmF0b3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv dHJhY2svVGV4dFRyYWNrLmlkbAppbmRleCA2ODg0YjI4OTY4YjY4ZDNmMTA3YWExMmU5ZjYwYWZl MTg1YzRmNTU5Li5iYTFjMTYxNTIzMzYyNDAxYzBkNjI1MGJiNmY4MTg5ZTgxOWRmNWY0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFjay5pZGwKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2suaWRsCkBAIC0yOCw3ICsyOCw2IEBAIGVu dW0gVGV4dFRyYWNrS2luZCB7ICJzdWJ0aXRsZXMiLCAgImNhcHRpb25zIiwgICJkZXNjcmlwdGlv bnMiLCAgImNoYXB0ZXJzIiwgIm1lCiAKIFsKICAgICBDb25kaXRpb25hbD1WSURFT19UUkFDSywK LSAgICBVc2VQb2ludGVyc0V2ZW5Gb3JOb25OdWxsYWJsZU9iamVjdEFyZ3VtZW50cywKICAgICBH ZW5lcmF0ZUlzUmVhY2hhYmxlPUltcGxFbGVtZW50Um9vdCwKICAgICBKU0N1c3RvbU1hcmtGdW5j dGlvbiwKICAgICBTa2lwVlRhYmxlVmFsaWRhdGlvbiwKQEAgLTQxLDE3ICs0MCwxOSBAQCBlbnVt IFRleHRUcmFja0tpbmQgeyAic3VidGl0bGVzIiwgICJjYXB0aW9ucyIsICAiZGVzY3JpcHRpb25z IiwgICJjaGFwdGVycyIsICJtZQogCiAgICAgYXR0cmlidXRlIFRleHRUcmFja01vZGUgbW9kZTsK IAotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBUZXh0VHJhY2tDdWVMaXN0IGN1ZXM7Ci0gICAgcmVh ZG9ubHkgYXR0cmlidXRlIFRleHRUcmFja0N1ZUxpc3QgYWN0aXZlQ3VlczsKKyAgICByZWFkb25s eSBhdHRyaWJ1dGUgVGV4dFRyYWNrQ3VlTGlzdD8gY3VlczsKKyAgICByZWFkb25seSBhdHRyaWJ1 dGUgVGV4dFRyYWNrQ3VlTGlzdD8gYWN0aXZlQ3VlczsKIAotICAgIFtSYWlzZXNFeGNlcHRpb25d IHZvaWQgYWRkQ3VlKFRleHRUcmFja0N1ZSBjdWUpOwotICAgIFtSYWlzZXNFeGNlcHRpb25dIHZv aWQgcmVtb3ZlQ3VlKFRleHRUcmFja0N1ZSBjdWUpOworICAgIC8vIEZJWE1FOiBjdWUgcGFyYW1l dGVyIHNob3VsZCBub3QgYmUgbnVsbGFibGUgaW4gYWRkQ3VlIGFuZCByZW1vdmVDdWUuCisgICAg W1JhaXNlc0V4Y2VwdGlvbl0gdm9pZCBhZGRDdWUoVGV4dFRyYWNrQ3VlPyBjdWUpOworICAgIFtS YWlzZXNFeGNlcHRpb25dIHZvaWQgcmVtb3ZlQ3VlKFRleHRUcmFja0N1ZT8gY3VlKTsKIAogICAg IGF0dHJpYnV0ZSBFdmVudEhhbmRsZXIgb25jdWVjaGFuZ2U7CiAKICNpZiAhZGVmaW5lZChMQU5H VUFHRV9HT0JKRUNUKSB8fCAhTEFOR1VBR0VfR09CSkVDVCAvLyBXb3JrIGFyb3VuZCBzaG9ydGNv bWluZ3MgaW4gdGhlIGdvYmplY3QgYmluZGluZyBnZW5lcmF0b3IgaGFuZGxpbmcgb2YgY29uZGl0 aW9uYWwgZmVhdHVyZXMgYnkgdHVybmluZyB0aGVzZSBvZmYgZm9yIGdvYmplY3QuCiAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIFZUVFJlZ2lvbkxpc3QgcmVnaW9uczsKLSAgICB2b2lkIGFkZFJlZ2lv bihWVFRSZWdpb24gcmVnaW9uKTsKLSAgICBbUmFpc2VzRXhjZXB0aW9uXSB2b2lkIHJlbW92ZVJl Z2lvbihWVFRSZWdpb24gcmVnaW9uKTsKKyAgICAvLyBGSVhNRTogcmVnaW9uIHBhcmFtZXRlciBz aG91bGQgbm90IGJlIG51bGxhYmxlIGluIGFkZFJlZ2lvbiBhbmQgcmVtb3ZlUmVnaW9uLgorICAg IHZvaWQgYWRkUmVnaW9uKFZUVFJlZ2lvbj8gcmVnaW9uKTsKKyAgICBbUmFpc2VzRXhjZXB0aW9u XSB2b2lkIHJlbW92ZVJlZ2lvbihWVFRSZWdpb24/IHJlZ2lvbik7CiAjZW5kaWYKIH07Cg==