156892 2016-04-21 22:50:45 -0700 [JSC] Fix build break since r199866 2016-04-22 18:11:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 156871 1 jh718.park jh718.park benjamin commit-queue darin fpizlo keith_miller mark.lam msaboff ossy saam oldest_to_newest 1186124 0 jh718.park 2016-04-21 22:50:45 -0700 Add using namespace std statement. 1186127 1 jh718.park 2016-04-21 22:56:21 -0700 Committed r199868: <http://trac.webkit.org/changeset/199868> 1186175 2 ossy 2016-04-22 02:05:16 -0700 (In reply to comment #1) > Committed r199868: <http://trac.webkit.org/changeset/199868> And Darin landed one more fix: (I don't konw which build it fixed.) http://trac.webkit.org/changeset/199870 But now the Apple Mac cloop build is broken: /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/runtime/MathCommon.h:61:28: error: expected unqualified-id if (!constant || !std::isnormal(constant)) ^ /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/runtime/MathCommon.h:65:9: error: no member named 'frexp' in namespace 'std'; did you mean simply 'frexp'? if (std::frexp(constant, &exponent) != 0.5) ^~~~~~~~~~ frexp /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/runtime/MathCommon.h:77:25: error: no member named 'ldexp' in namespace 'std'; did you mean simply 'ldexp'? double reciprocal = std::ldexp(1, -exponent); ^~~~~~~~~~ ldexp /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/runtime/MathCommon.h:78:17: error: expected unqualified-id ASSERT(std::isnormal(reciprocal)); ^ Common, nobody watches bots after landing random patches? Why ???? The original patch broke all Linux builds, the buildfixes broke the Apple Mac cloop build. 1186195 3 jh718.park 2016-04-22 02:35:26 -0700 (In reply to comment #2) > (In reply to comment #1) > > Committed r199868: <http://trac.webkit.org/changeset/199868> > > And Darin landed one more fix: (I don't konw which build it fixed.) > http://trac.webkit.org/changeset/199870 > > But now the Apple Mac cloop build is broken: > > /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/ > runtime/MathCommon.h:61:28: error: expected unqualified-id > if (!constant || !std::isnormal(constant)) > ^ > /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/ > runtime/MathCommon.h:65:9: error: no member named 'frexp' in namespace > 'std'; did you mean simply 'frexp'? > if (std::frexp(constant, &exponent) != 0.5) > ^~~~~~~~~~ > frexp > > /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/ > runtime/MathCommon.h:77:25: error: no member named 'ldexp' in namespace > 'std'; did you mean simply 'ldexp'? > double reciprocal = std::ldexp(1, -exponent); > ^~~~~~~~~~ > ldexp > > /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/ > runtime/MathCommon.h:78:17: error: expected unqualified-id > ASSERT(std::isnormal(reciprocal)); > ^ > > Common, nobody watches bots after landing random patches? Why ???? > The original patch broke all Linux builds, the buildfixes broke the > Apple Mac cloop build. I'm sorry, Ossy. If it is not fixed soon, let me check it out again. My mac is at home, so I couldn't check mac cloop port in advance. 1186203 4 jh718.park 2016-04-22 04:02:39 -0700 Reopening to attach new patch. 1186204 5 277039 jh718.park 2016-04-22 04:02:43 -0700 Created attachment 277039 To check EWS build status 1186205 6 ossy 2016-04-22 04:11:41 -0700 (In reply to comment #5) > Created attachment 277039 [details] > To check EWS build status FYI: there is no EWS for cloop build. 1186206 7 277040 jh718.park 2016-04-22 04:14:36 -0700 Created attachment 277040 Fix a typo ignoring style check warning. cloop build was successful 1186207 8 commit-queue 2016-04-22 04:16:37 -0700 Attachment 277040 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/MathCommon.h:36: Do not use 'using namespace std;'. [build/using_namespace] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1186209 9 277041 jh718.park 2016-04-22 04:30:00 -0700 Created attachment 277041 Change commit log to let this patch be reviewed. 1186210 10 commit-queue 2016-04-22 04:31:20 -0700 Attachment 277041 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/MathCommon.h:36: Do not use 'using namespace std;'. [build/using_namespace] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1186283 11 277041 mark.lam 2016-04-22 09:49:33 -0700 Comment on attachment 277041 Change commit log to let this patch be reviewed. r=me 1186285 12 277041 darin 2016-04-22 09:50:28 -0700 Comment on attachment 277041 Change commit log to let this patch be reviewed. View in context: https://bugs.webkit.org/attachment.cgi?id=277041&action=review > Source/JavaScriptCore/runtime/MathCommon.h:36 > +using namespace std; I think the correct fix is to add an include so we get the "std::" versions of these rather than doing this. 1186286 13 277041 mark.lam 2016-04-22 09:51:54 -0700 Comment on attachment 277041 Change commit log to let this patch be reviewed. r- per Darin's comment. 1186460 14 benjamin 2016-04-22 15:02:18 -0700 Quick fix: http://trac.webkit.org/changeset/199913 Let's see if the bots like that better. 1186462 15 277105 jh718.park 2016-04-22 15:13:42 -0700 Created attachment 277105 Follow up to Bejamin's quick fix 1186536 16 277105 commit-queue 2016-04-22 18:11:22 -0700 Comment on attachment 277105 Follow up to Bejamin's quick fix Clearing flags on attachment: 277105 Committed r199943: <http://trac.webkit.org/changeset/199943> 1186537 17 commit-queue 2016-04-22 18:11:25 -0700 All reviewed patches have been landed. Closing bug. 277039 2016-04-22 04:02:43 -0700 2016-04-22 04:14:29 -0700 To check EWS build status bug-156892-20160422200306.patch text/plain 2040 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5ODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MmQwMjZjYjE0ODJiZWQyZDc2YTk0ZWI4ZTY2MTU2OWU0NWRkMGExLi41NDI2YmRkOGUyZGNjZWI1 N2Y1ZDRhNDdiZDJlYzEyMDU2OWRjYTg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMSBAQAorMjAxNi0wNC0yMiAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIGJyZWFrIHNpbmNlIHIxOTk4NjYuIFVu cmV2aWV3ZWQuIEZvciBjbG9vcCBwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU2ODkyCisKKyAgICAgICAgKiBydW50aW1lL01hdGhDb21tb24u aDoKKyAgICAgICAgKEpTQzo6c2FmZVJlY2lwcm9jYWxGb3JEaXZCeUNvbnN0KToKKwogMjAxNi0w NC0yMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgRm9sbG93LW9u IHRvIHRoZSBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9NYXRoQ29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29t bW9uLmgKaW5kZXggYmM0ZTFhYTQ5OTg3NzE5ODhkNDRkNThlYzA2YjIyMWRjNGNjMGE2NC4uOGE0 NjhhMjA3NTYyNmI0MjZiY2VjODIyYjlkNWVjMDk5YThkN2Q0ZSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWF0aENvbW1vbi5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL01hdGhDb21tb24uaApAQCAtMzMsNiArMzMsOCBAQAogI2RlZmluZSBK SVRfT1BFUkFUSU9OCiAjZW5kaWYKIAordXNpbmcgbmFtZXNwYWNlOjpzdGQ7CisKIG5hbWVzcGFj ZSBKU0MgewogZG91YmxlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uTWF0aFBvdyhkb3VibGUgeCwg ZG91YmxlIHkpIFdURl9JTlRFUk5BTDsKIApAQCAtNTgsMTEgKzYwLDExIEBAIGlubGluZSBpbnQg Y2x6MzIodWludDMyX3QgbnVtYmVyKQogaW5saW5lIE9wdGlvbmFsPGRvdWJsZT4gc2FmZVJlY2lw cm9jYWxGb3JEaXZCeUNvbnN0KGRvdWJsZSBjb25zdGFudCkKIHsKICAgICAvLyBObyAid2VpcmQi IG51bWJlcnMgKE5hTiwgRGVub3JtYWwsIGV0YykuCi0gICAgaWYgKCFjb25zdGFudCB8fCAhc3Rk Ojppc25vcm1hbChjb25zdGFudCkpCisgICAgaWYgKCFjb25zdGFudCB8fCAhaXNub3JtYWwoY29u c3RhbnQpKQogICAgICAgICByZXR1cm4gTnVsbG9wdDsKIAogICAgIGludCBleHBvbmVudDsKLSAg ICBpZiAoc3RkOjpmcmV4cChjb25zdGFudCwgJmV4cG9uZW50KSAhPSAwLjUpCisgICAgaWYgKGZy ZXhwKGNvbnN0YW50LCAmZXhwb25lbnQpICE9IDAuNSkKICAgICAgICAgcmV0dXJuIE51bGxvcHQ7 CiAKICAgICAvLyBOb3RlIHRoYXQgZnJleHAoKSByZXR1cm5zIHRoZSB2YWx1ZSBkaXZpZGVkIGJ5 IHR3bwpAQCAtNzQsOCArNzYsOCBAQCBpbmxpbmUgT3B0aW9uYWw8ZG91YmxlPiBzYWZlUmVjaXBy b2NhbEZvckRpdkJ5Q29uc3QoZG91YmxlIGNvbnN0YW50KQogICAgIGlmIChleHBvbmVudCA9PSAx MDIzKQogICAgICAgICByZXR1cm4gTnVsbG9wdDsKIAotICAgIGRvdWJsZSByZWNpcHJvY2FsID0g c3RkOjpsZGV4cCgxLCAtZXhwb25lbnQpOwotICAgIEFTU0VSVChzdGQ6Omlzbm9ybWFsKHJlY2lw cm9jYWwpKTsKKyAgICBkb3VibGUgcmVjaXByb2NhbCA9IGxkZXhwKDEsIC1leHBvbmVudCk7Cisg ICAgQVNTRVJUKGlzbm9ybWFsKHJlY2lwcm9jYWwpKTsKICAgICBBU1NFUlQoMS4gLyBjb25zdGFu dCA9PSByZWNpcHJvY2FsKTsKICAgICBBU1NFUlQoY29uc3RhbnQgPT0gMS4gLyByZWNpcHJvY2Fs KTsKICAgICBBU1NFUlQoMS4gPT0gY29uc3RhbnQgKiByZWNpcHJvY2FsKTsK 277040 2016-04-22 04:14:36 -0700 2016-04-22 04:29:52 -0700 Fix a typo ignoring style check warning. cloop build was successful bug-156892-20160422201459.patch text/plain 2078 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5ODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MmQwMjZjYjE0ODJiZWQyZDc2YTk0ZWI4ZTY2MTU2OWU0NWRkMGExLi40ZTE4Yzc1N2RiZTMzYWRh NWYxZTlhMjFjNjFmZDIyYTZiMWIyYTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wNC0yMiAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIGJyZWFrIHNpbmNlIHIxOTk4NjYuIFVu cmV2aWV3ZWQuIEZvciBjbG9vcCBwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU2ODkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL01hdGhDb21tb24uaDoKKyAgICAgICAgKEpTQzo6 c2FmZVJlY2lwcm9jYWxGb3JEaXZCeUNvbnN0KToKKwogMjAxNi0wNC0yMSAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgRm9sbG93LW9uIHRvIHRoZSBidWlsZCBmaXgu CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9uLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9uLmgKaW5kZXggYmM0ZTFh YTQ5OTg3NzE5ODhkNDRkNThlYzA2YjIyMWRjNGNjMGE2NC4uMjg2ZGQ2NTI0M2I2M2I4NGFiZTU5 OTUyYzI2YzJiZWVkMDgyY2YyNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvTWF0aENvbW1vbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01h dGhDb21tb24uaApAQCAtMzMsNiArMzMsOCBAQAogI2RlZmluZSBKSVRfT1BFUkFUSU9OCiAjZW5k aWYKIAordXNpbmcgbmFtZXNwYWNlIHN0ZDsKKwogbmFtZXNwYWNlIEpTQyB7CiBkb3VibGUgSklU X09QRVJBVElPTiBvcGVyYXRpb25NYXRoUG93KGRvdWJsZSB4LCBkb3VibGUgeSkgV1RGX0lOVEVS TkFMOwogCkBAIC01OCwxMSArNjAsMTEgQEAgaW5saW5lIGludCBjbHozMih1aW50MzJfdCBudW1i ZXIpCiBpbmxpbmUgT3B0aW9uYWw8ZG91YmxlPiBzYWZlUmVjaXByb2NhbEZvckRpdkJ5Q29uc3Qo ZG91YmxlIGNvbnN0YW50KQogewogICAgIC8vIE5vICJ3ZWlyZCIgbnVtYmVycyAoTmFOLCBEZW5v cm1hbCwgZXRjKS4KLSAgICBpZiAoIWNvbnN0YW50IHx8ICFzdGQ6Omlzbm9ybWFsKGNvbnN0YW50 KSkKKyAgICBpZiAoIWNvbnN0YW50IHx8ICFpc25vcm1hbChjb25zdGFudCkpCiAgICAgICAgIHJl dHVybiBOdWxsb3B0OwogCiAgICAgaW50IGV4cG9uZW50OwotICAgIGlmIChzdGQ6OmZyZXhwKGNv bnN0YW50LCAmZXhwb25lbnQpICE9IDAuNSkKKyAgICBpZiAoZnJleHAoY29uc3RhbnQsICZleHBv bmVudCkgIT0gMC41KQogICAgICAgICByZXR1cm4gTnVsbG9wdDsKIAogICAgIC8vIE5vdGUgdGhh dCBmcmV4cCgpIHJldHVybnMgdGhlIHZhbHVlIGRpdmlkZWQgYnkgdHdvCkBAIC03NCw4ICs3Niw4 IEBAIGlubGluZSBPcHRpb25hbDxkb3VibGU+IHNhZmVSZWNpcHJvY2FsRm9yRGl2QnlDb25zdChk b3VibGUgY29uc3RhbnQpCiAgICAgaWYgKGV4cG9uZW50ID09IDEwMjMpCiAgICAgICAgIHJldHVy biBOdWxsb3B0OwogCi0gICAgZG91YmxlIHJlY2lwcm9jYWwgPSBzdGQ6OmxkZXhwKDEsIC1leHBv bmVudCk7Ci0gICAgQVNTRVJUKHN0ZDo6aXNub3JtYWwocmVjaXByb2NhbCkpOworICAgIGRvdWJs ZSByZWNpcHJvY2FsID0gbGRleHAoMSwgLWV4cG9uZW50KTsKKyAgICBBU1NFUlQoaXNub3JtYWwo cmVjaXByb2NhbCkpOwogICAgIEFTU0VSVCgxLiAvIGNvbnN0YW50ID09IHJlY2lwcm9jYWwpOwog ICAgIEFTU0VSVChjb25zdGFudCA9PSAxLiAvIHJlY2lwcm9jYWwpOwogICAgIEFTU0VSVCgxLiA9 PSBjb25zdGFudCAqIHJlY2lwcm9jYWwpOwo= 277041 2016-04-22 04:30:00 -0700 2016-04-22 15:13:34 -0700 Change commit log to let this patch be reviewed. bug-156892-20160422203022.patch text/plain 2050 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5ODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MmQwMjZjYjE0ODJiZWQyZDc2YTk0ZWI4ZTY2MTU2OWU0NWRkMGExLi45ZjNhN2M0MDc5NDkxMzFm OWZjYjE5ZWM2YTkwOGQ4NTQ2ZjhmZDU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wNC0yMiAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIGJyZWFrIHNpbmNlIHIxOTk4NjYuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY4OTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUv TWF0aENvbW1vbi5oOgorICAgICAgICAoSlNDOjpzYWZlUmVjaXByb2NhbEZvckRpdkJ5Q29uc3Qp OgorCiAyMDE2LTA0LTIxICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAg ICBGb2xsb3ctb24gdG8gdGhlIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL01hdGhDb21tb24uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL01hdGhDb21tb24uaAppbmRleCBiYzRlMWFhNDk5ODc3MTk4OGQ0NGQ1OGVjMDZiMjIxZGM0 Y2MwYTY0Li4yODZkZDY1MjQzYjYzYjg0YWJlNTk5NTJjMjZjMmJlZWQwODJjZjI0IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9uLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWF0aENvbW1vbi5oCkBAIC0zMyw2ICszMyw4IEBA CiAjZGVmaW5lIEpJVF9PUEVSQVRJT04KICNlbmRpZgogCit1c2luZyBuYW1lc3BhY2Ugc3RkOwor CiBuYW1lc3BhY2UgSlNDIHsKIGRvdWJsZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbk1hdGhQb3co ZG91YmxlIHgsIGRvdWJsZSB5KSBXVEZfSU5URVJOQUw7CiAKQEAgLTU4LDExICs2MCwxMSBAQCBp bmxpbmUgaW50IGNsejMyKHVpbnQzMl90IG51bWJlcikKIGlubGluZSBPcHRpb25hbDxkb3VibGU+ IHNhZmVSZWNpcHJvY2FsRm9yRGl2QnlDb25zdChkb3VibGUgY29uc3RhbnQpCiB7CiAgICAgLy8g Tm8gIndlaXJkIiBudW1iZXJzIChOYU4sIERlbm9ybWFsLCBldGMpLgotICAgIGlmICghY29uc3Rh bnQgfHwgIXN0ZDo6aXNub3JtYWwoY29uc3RhbnQpKQorICAgIGlmICghY29uc3RhbnQgfHwgIWlz bm9ybWFsKGNvbnN0YW50KSkKICAgICAgICAgcmV0dXJuIE51bGxvcHQ7CiAKICAgICBpbnQgZXhw b25lbnQ7Ci0gICAgaWYgKHN0ZDo6ZnJleHAoY29uc3RhbnQsICZleHBvbmVudCkgIT0gMC41KQor ICAgIGlmIChmcmV4cChjb25zdGFudCwgJmV4cG9uZW50KSAhPSAwLjUpCiAgICAgICAgIHJldHVy biBOdWxsb3B0OwogCiAgICAgLy8gTm90ZSB0aGF0IGZyZXhwKCkgcmV0dXJucyB0aGUgdmFsdWUg ZGl2aWRlZCBieSB0d28KQEAgLTc0LDggKzc2LDggQEAgaW5saW5lIE9wdGlvbmFsPGRvdWJsZT4g c2FmZVJlY2lwcm9jYWxGb3JEaXZCeUNvbnN0KGRvdWJsZSBjb25zdGFudCkKICAgICBpZiAoZXhw b25lbnQgPT0gMTAyMykKICAgICAgICAgcmV0dXJuIE51bGxvcHQ7CiAKLSAgICBkb3VibGUgcmVj aXByb2NhbCA9IHN0ZDo6bGRleHAoMSwgLWV4cG9uZW50KTsKLSAgICBBU1NFUlQoc3RkOjppc25v cm1hbChyZWNpcHJvY2FsKSk7CisgICAgZG91YmxlIHJlY2lwcm9jYWwgPSBsZGV4cCgxLCAtZXhw b25lbnQpOworICAgIEFTU0VSVChpc25vcm1hbChyZWNpcHJvY2FsKSk7CiAgICAgQVNTRVJUKDEu IC8gY29uc3RhbnQgPT0gcmVjaXByb2NhbCk7CiAgICAgQVNTRVJUKGNvbnN0YW50ID09IDEuIC8g cmVjaXByb2NhbCk7CiAgICAgQVNTRVJUKDEuID09IGNvbnN0YW50ICogcmVjaXByb2NhbCk7Cg== 277105 2016-04-22 15:13:42 -0700 2016-04-22 18:11:22 -0700 Follow up to Bejamin's quick fix bug-156892-20160423071405.patch text/plain 1119 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5OTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh Y2FiMjUyZDg4M2Y1ZjIwMWU5ZWZlMzdkZmMxZjMyNDYzYTQ0OWM4Li4xNTAyMmM2NTJkMTJiN2Q1 NGQwYWYxYzVmOGQ3ZWVjMTc1MzdhYzMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wNC0yMiAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIGJyZWFrIHNpbmNlIHIxOTk4NjYKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Njg5MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9N YXRoQ29tbW9uLmNwcDogRm9sbG93IHVwIHRvIHIxOTk5MTMuIFJlbW92ZSAnaW5jbHVkZSBjbWF0 aCcgaW4gY3BwIGZpbGUuCisKIDIwMTYtMDQtMjIgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1p bkB3ZWJraXQub3JnPgogCiAgICAgICAgIEF0dGVtcHQgdG8gZml4IHRoZSBDTG9vcCBhZnRlciBy MTk5ODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29t bW9uLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhDb21tb24uY3BwCmlu ZGV4IGQ2ODgyYzAzZTZiODgzMWVhOGUwMzJjZmMxZmYwNWQxYmM3NmJkZjcuLmFlYzI5NmY4YTg0 YWE1YTQyZjRlMmI3ZGM5YTVmZWQ0Mjc0ODU2MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL01hdGhDb21tb24uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL01hdGhDb21tb24uY3BwCkBAIC0yNiw3ICsyNiw2IEBACiAjaW5jbHVkZSAiY29u ZmlnLmgiCiAjaW5jbHVkZSAiTWF0aENvbW1vbi5oIgogCi0jaW5jbHVkZSA8Y21hdGg+CiAjaW5j bHVkZSAiUHVyZU5hTi5oIgogCiBuYW1lc3BhY2UgSlNDIHsK