15689 2007-10-25 08:32:17 -0700 [GTK] Background of loading images is always black 2007-11-28 04:48:14 -0800 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) All All RESOLVED FIXED Cairo, Gtk P2 Minor --- 1 alp webkit-unassigned oldest_to_newest 59429 0 alp 2007-10-25 08:32:17 -0700 The background of currently loading images is always black. This is kind of distracting. It should be transparent, or at least similar to the background of the page. 62554 1 alp 2007-11-28 01:23:23 -0800 This can be fixed by returning true in all cases in ImageSource::frameHasAlphaAtIndex() in ImageSourceCairo.cpp. A better fix would preserve the optimization. I'm working on a solution now. 62561 2 17573 alp 2007-11-28 04:20:08 -0800 Created attachment 17573 Fix Includes a workaround for http://bugs.webkit.org/show_bug.cgi?id=16169 62562 3 17574 alp 2007-11-28 04:30:18 -0800 Created attachment 17574 Simplified fix 62563 4 17574 mrowe 2007-11-28 04:36:55 -0800 Comment on attachment 17574 Simplified fix r=me 62564 5 alp 2007-11-28 04:48:14 -0800 Landed in r28109. 17573 2007-11-28 04:20:08 -0800 2007-11-28 04:30:18 -0800 Fix black-images.patch text/plain 2954 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODEwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMDctMTEtMjggIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Njg5CisgICAgICAgIFtHVEtdIEJhY2tn cm91bmQgb2YgbG9hZGluZyBpbWFnZXMgaXMgYWx3YXlzIGJsYWNrCisKKyAgICAgICAgZnJhbWVI YXNBbHBoYUF0SW5kZXgoKSBleGlzdHMgb25seSB0byBhbGxvdyBvcHRpbWl6YXRpb24gZm9yIGNh c2VzIHdlCisgICAgICAgIGFyZSBjZXJ0YWluIHRoZSBpbWFnZSBjYW4gYmUgYmxpdHRlZCByYXRo ZXIgdGhhbiBjb21wb3NpdGVkLgorCisgICAgICAgIFRodXMgd2UgbmVlZCB0byBiZSBjb25zZXJ2 YXRpdmUsIHJldHVybmluZyBmYWxzZSBvbmx5IHdoZW4gd2UgYXJlCisgICAgICAgIGFic29sdXRl bHkgY2VydGFpbiB0aGVyZSBpcyBubyBuZWVkIGZvciBjb21wb3NpdGVkIGNvcHlpbmcsIGFuZCB0 cnVlCisgICAgICAgIG90aGVyd2lzZS4KKworICAgICAgICBDRyBkb2Vzbid0IGV2ZW4gYm90aGVy IHdpdGggdGhpcyBvcHRpbWl6YXRpb24gYXQgYWxsIGFuZCBhbHdheXMKKyAgICAgICAgcmV0dXJu cyB0cnVlLgorCisgICAgICAgIFBhdGNoIGluY2x1ZGVzIGEgd29ya2Fyb3VuZCBmb3IKKyAgICAg ICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE2OQorICAgICAg ICAgIEdJRiBJbWFnZURlY29kZXIgaGFzQWxwaGEoKSByZXR1cm4gdmFsdWUgaW5jb3JyZWN0CisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZVNvdXJjZUNhaXJvLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkltYWdlU291cmNlOjpmcmFtZUhhc0FscGhhQXRJbmRleCk6CisK IDIwMDctMTEtMjggIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBhbmQgR2VvZmYuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0ltYWdlU291cmNlQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VTb3VyY2VDYWlyby5jcHAJKHJldmlzaW9uIDI4 MTA4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZVNvdXJjZUNhaXJv LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkzLDE0ICsxOTMsNDAgQEAgZmxvYXQgSW1hZ2VTb3Vy Y2U6OmZyYW1lRHVyYXRpb25BdEluZGV4KAogCiBib29sIEltYWdlU291cmNlOjpmcmFtZUhhc0Fs cGhhQXRJbmRleChzaXplX3QgaW5kZXgpCiB7Ci0gICAgaWYgKCFtX2RlY29kZXIgfHwgIW1fZGVj b2Rlci0+c3VwcG9ydHNBbHBoYSgpKQotICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgLy8gV2Ug YWxtb3N0IGFsd2F5cyB3YW50IHRvIHN1cHBvcnQgYWxwaGEsIGVzcGVjaWFsbHkgZm9yIGltYWdl cyB0aGF0IGFyZQorICAgIC8vIG9ubHkgcGFydGlhbGx5IGxvYWRlZC4KKyAgICAvLworICAgIC8v IFRoZXJlIGlzIG9uZSBleGNlcHRpb246CisgICAgLy8KKyAgICAvLyBBcyBhbiBvcHRpbWl6YXRp b24gd2UgY2FuIGFsbG93IHRoZSBpbWFnZSByZW5kZXJlciB0byBibGl0IHRoZSBpbWFnZQorICAg IC8vIChpbXBsZW1lbnRlZCBhcyBDb21wb3NpdGVDb3B5IGluIEltYWdlQ2Fpcm8pIGJ5IHJldHVy bmluZyBmYWxzZSBpZiBhbmQKKyAgICAvLyBvbmx5IGlmOgorICAgIC8vCisgICAgLy8gICAqIFRo ZSBpbWFnZSBoYXMgYmVlbiBmdWxseSBsb2FkZWQKKyAgICAvLyAgICogVGhlIGRlY29kZXIgZG9l cyBub3Qgc3VwcG9ydCBhbHBoYQorICAgIC8vICAgKiBUaGUgYnVmZmVyIGlzIG1hcmtlZCBhcyBu b3QgaGF2aW5nIGFscGhhIHRyYW5zcGFyZW5jeQogCisgICAgaWYgKCFmcmFtZUlzQ29tcGxldGVB dEluZGV4KGluZGV4KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICBBU1NFUlQobV9kZWNv ZGVyKTsKICAgICBSR0JBMzJCdWZmZXIqIGJ1ZmZlciA9IG1fZGVjb2Rlci0+ZnJhbWVCdWZmZXJB dEluZGV4KGluZGV4KTsKLSAgICBpZiAoIWJ1ZmZlciB8fCBidWZmZXItPnN0YXR1cygpID09IFJH QkEzMkJ1ZmZlcjo6RnJhbWVFbXB0eSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIEFTU0VS VChidWZmZXIpOworCisgICAgaWYgKGJ1ZmZlci0+aGFzQWxwaGEoKSkKKyAgICAgICAgcmV0dXJu IHRydWU7CisKKyAgICAvLyBGSVhNRTogVGhpcyBpcyBhIGhhY2sgdGhhdCBtYWtlcyB0aGUgd2hv bGUgb3B0aW1pemF0aW9uIG9ic29sZXRlIGluCisgICAgLy8gbWFueSBjYXNlcy4gSXQgaXMgbmVj ZXNzYXJ5IGJlY2F1c2UgYnVmZmVyLT5oYXNBbHBoYSgpIGluY29ycmVjdGx5CisgICAgLy8gcmV0 dXJucyBmYWxzZSB3aGVuIGl0IHNob3VsZCByZXR1cm4gdHJ1ZSBmb3IgY2VydGFpbiBHSUYgaW1h Z2VzLgorICAgIC8vCisgICAgLy8gV2Ugc2hvdWxkIGlkZWFsbHkgbmV2ZXIgaGF2ZSB0byBjaGVj ayBpZiB0aGUgZGVjb2RlciBzdXBwb3J0cyBhbHBoYS4KKyAgICAvLworICAgIC8vIFNlZSBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE2OQorICAgIGlmIChtX2RlY29k ZXItPnN1cHBvcnRzQWxwaGEoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICByZXR1cm4g YnVmZmVyLT5oYXNBbHBoYSgpOworICAgIHJldHVybiBmYWxzZTsKIH0KIAogfQo= 17574 2007-11-28 04:30:18 -0800 2007-11-28 04:36:55 -0800 Simplified fix black-images.patch text/plain 2829 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODEwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMDctMTEtMjggIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Njg5CisgICAgICAgIFtHVEtdIEJhY2tn cm91bmQgb2YgbG9hZGluZyBpbWFnZXMgaXMgYWx3YXlzIGJsYWNrCisKKyAgICAgICAgZnJhbWVI YXNBbHBoYUF0SW5kZXgoKSBleGlzdHMgb25seSB0byBhbGxvdyBvcHRpbWl6YXRpb24gZm9yIGNh c2VzIHdlCisgICAgICAgIGFyZSBjZXJ0YWluIHRoZSBpbWFnZSBjYW4gYmUgYmxpdHRlZCByYXRo ZXIgdGhhbiBjb21wb3NpdGVkLgorCisgICAgICAgIFRodXMgd2UgbmVlZCB0byBiZSBjb25zZXJ2 YXRpdmUsIHJldHVybmluZyBmYWxzZSBvbmx5IHdoZW4gd2UgYXJlCisgICAgICAgIGFic29sdXRl bHkgY2VydGFpbiB0aGVyZSBpcyBubyBuZWVkIGZvciBjb21wb3NpdGVkIGNvcHlpbmcsIGFuZCB0 cnVlCisgICAgICAgIG90aGVyd2lzZS4KKworICAgICAgICBDRyBkb2Vzbid0IGV2ZW4gYm90aGVy IHdpdGggdGhpcyBvcHRpbWl6YXRpb24gYXQgYWxsIGFuZCBhbHdheXMKKyAgICAgICAgcmV0dXJu cyB0cnVlLgorCisgICAgICAgIFBhdGNoIGluY2x1ZGVzIGEgd29ya2Fyb3VuZCBmb3IKKyAgICAg ICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE2OQorICAgICAg ICAgIEdJRiBJbWFnZURlY29kZXIgaGFzQWxwaGEoKSByZXR1cm4gdmFsdWUgaW5jb3JyZWN0CisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZVNvdXJjZUNhaXJvLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkltYWdlU291cmNlOjpmcmFtZUhhc0FscGhhQXRJbmRleCk6CisK IDIwMDctMTEtMjggIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBhbmQgR2VvZmYuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0ltYWdlU291cmNlQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VTb3VyY2VDYWlyby5jcHAJKHJldmlzaW9uIDI4 MTA4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZVNvdXJjZUNhaXJv LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkzLDEyICsxOTMsMzQgQEAgZmxvYXQgSW1hZ2VTb3Vy Y2U6OmZyYW1lRHVyYXRpb25BdEluZGV4KAogCiBib29sIEltYWdlU291cmNlOjpmcmFtZUhhc0Fs cGhhQXRJbmRleChzaXplX3QgaW5kZXgpCiB7Ci0gICAgaWYgKCFtX2RlY29kZXIgfHwgIW1fZGVj b2Rlci0+c3VwcG9ydHNBbHBoYSgpKQotICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgLy8gV2Ug YWxtb3N0IGFsd2F5cyB3YW50IHRvIHN1cHBvcnQgYWxwaGEsIGVzcGVjaWFsbHkgZm9yIGltYWdl cyB0aGF0IGFyZQorICAgIC8vIG9ubHkgcGFydGlhbGx5IGxvYWRlZC4KKyAgICAvLworICAgIC8v IFRoZXJlIGlzIG9uZSBleGNlcHRpb246CisgICAgLy8KKyAgICAvLyBBcyBhbiBvcHRpbWl6YXRp b24gd2UgY2FuIGFsbG93IHRoZSBpbWFnZSByZW5kZXJlciB0byBibGl0IHRoZSBpbWFnZQorICAg IC8vIChpbXBsZW1lbnRlZCBhcyBDb21wb3NpdGVDb3B5IGluIEltYWdlQ2Fpcm8pIGJ5IHJldHVy bmluZyBmYWxzZSBpZiBhbmQKKyAgICAvLyBvbmx5IGlmOgorICAgIC8vCisgICAgLy8gICAqIFRo ZSBpbWFnZSBoYXMgYmVlbiBmdWxseSBsb2FkZWQKKyAgICAvLyAgICogVGhlIGJ1ZmZlciBpcyBt YXJrZWQgYXMgbm90IGhhdmluZyBhbHBoYSB0cmFuc3BhcmVuY3kKIAorICAgIGlmICghZnJhbWVJ c0NvbXBsZXRlQXRJbmRleChpbmRleCkpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgQVNT RVJUKG1fZGVjb2Rlcik7CiAgICAgUkdCQTMyQnVmZmVyKiBidWZmZXIgPSBtX2RlY29kZXItPmZy YW1lQnVmZmVyQXRJbmRleChpbmRleCk7Ci0gICAgaWYgKCFidWZmZXIgfHwgYnVmZmVyLT5zdGF0 dXMoKSA9PSBSR0JBMzJCdWZmZXI6OkZyYW1lRW1wdHkpCi0gICAgICAgIHJldHVybiBmYWxzZTsK KyAgICBBU1NFUlQoYnVmZmVyKTsKKworICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEgaGFjayB0aGF0 IG1ha2VzIHRoZSB3aG9sZSBvcHRpbWl6YXRpb24gdXNlbGVzcyBpbgorICAgIC8vIG1hbnkgY2Fz ZXMuIEl0IGlzIG5lY2Vzc2FyeSBiZWNhdXNlIGJ1ZmZlci0+aGFzQWxwaGEoKSBpbmNvcnJlY3Rs eQorICAgIC8vIHJldHVybnMgZmFsc2Ugd2hlbiBpdCBzaG91bGQgcmV0dXJuIHRydWUgZm9yIGNl cnRhaW4gR0lGIGltYWdlcy4KKyAgICAvLworICAgIC8vIFdlIHNob3VsZCBpZGVhbGx5IG5ldmVy IGhhdmUgdG8gY2hlY2sgaWYgdGhlIGRlY29kZXIgc3VwcG9ydHMgYWxwaGEuCisgICAgLy8KKyAg ICAvLyBTZWUgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNjkKKyAg ICBpZiAobV9kZWNvZGVyLT5zdXBwb3J0c0FscGhhKCkpCisgICAgICAgIHJldHVybiB0cnVlOwog CiAgICAgcmV0dXJuIGJ1ZmZlci0+aGFzQWxwaGEoKTsKIH0K