156878 2016-04-21 16:23:24 -0700 RenderVideo should always update the intrinsic size before layout. 2016-04-28 00:48:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan adachan commit-queue dbates jeremyj-wk jer.noble jonlee simon.fraser oldest_to_newest 1186002 0 zalan 2016-04-21 16:23:24 -0700 and definitely not after that. 1186012 1 276980 zalan 2016-04-21 16:33:52 -0700 Created attachment 276980 Patch 1186054 2 276980 commit-queue 2016-04-21 18:13:13 -0700 Comment on attachment 276980 Patch Clearing flags on attachment: 276980 Committed r199856: <http://trac.webkit.org/changeset/199856> 1186055 3 commit-queue 2016-04-21 18:13:17 -0700 All reviewed patches have been landed. Closing bug. 1188166 4 276980 dbates 2016-04-28 00:47:20 -0700 Comment on attachment 276980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276980&action=review > Source/WebCore/rendering/RenderVideo.cpp:225 > + bool intrinsicSizeChanged; > + intrinsicSizeChanged = updateIntrinsicSize(); I would have written this in one line: bool intrinsicSizeChanged = updateIntrinsicSize(); 276980 2016-04-21 16:33:52 -0700 2016-04-21 18:13:13 -0700 Patch bug-156878-20160421163414.patch text/plain 3353 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg3NDMxNmI3NTBhZTRl YzM3NzM5OThkNDBhMTU1MDcwYjU5OTg5ZS4uNGJkOTAyNzcxMWJjNGQ5MzExYTNiMGM1ZDMzMGRi YmU4Y2Y5ZTBhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA0LTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyVmlkZW8gc2hvdWxk IGFsd2F5cyB1cGRhdGUgdGhlIGludHJpbnNpYyBzaXplIGJlZm9yZSBsYXlvdXQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY4NzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBvcmRlciB0byBsYXlv dXQgdmlkZW8gZWxlbWVudCBwcm9wZXJseSB3ZSBuZWVkIHRvIGtub3cgdGhlIGNvcnJlY3QgaW50 cmluc2ljIHNpemUuCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyBhc3NlcnRzIGlmIHdlIGVuZCB1 cCB1cGRhdGluZyB0aGUgaW50cmluc2ljIHNpemUgcmlnaHQgYWZ0ZXIgZmluaXNoaW5nIHZpZGVv IHJlbmRlcmVyIGxheW91dC4KKworICAgICAgICBUaGlzIGlzc3VlcyB3YXMgZGlzY292ZXJlZCBh cyBwYXJ0IG9mIHdlYmtpdC5vcmcvYi8xNTYyNDUuIChoZW5jZSBjb3ZlcmVkIGJ5IGV4aXN0aW5n IHRlc3RzKQorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclZpZGVvOjp1cGRhdGVJbnRyaW5zaWNTaXplKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclZpZGVvOjpsYXlvdXQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlk ZW86OnVwZGF0ZVBsYXllcik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZGVvLmg6CisK IDIwMTYtMDQtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtDYWlyb10gR3JhcGhpY3NDb250ZXh0OjpkcmF3Rm9jdXNSaW5nIG1ldGhvZHMg YXJlIG5vdCBjb25zaXN0ZW50IHRvIGVhY2ggb3RoZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVmlkZW8uY3BwCmluZGV4IDk3NjYyMWQ1Zjk5MWZiOWQxYjA5NzQ5Mjc1ZTc0N2YyOWNl MmNmMTEuLmE5MWFjYzNmODhkNzA4OTNmZTkxYzZjMzY1YWMzYzNlNWY3OGIzZmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcApAQCAtNzYsMjEgKzc2LDIyIEBAIHZv aWQgUmVuZGVyVmlkZW86OmludHJpbnNpY1NpemVDaGFuZ2VkKCkKICAgICB1cGRhdGVJbnRyaW5z aWNTaXplKCk7IAogfQogCi12b2lkIFJlbmRlclZpZGVvOjp1cGRhdGVJbnRyaW5zaWNTaXplKCkK K2Jvb2wgUmVuZGVyVmlkZW86OnVwZGF0ZUludHJpbnNpY1NpemUoKQogewogICAgIExheW91dFNp emUgc2l6ZSA9IGNhbGN1bGF0ZUludHJpbnNpY1NpemUoKTsKICAgICBzaXplLnNjYWxlKHN0eWxl KCkuZWZmZWN0aXZlWm9vbSgpKTsKIAogICAgIC8vIE5ldmVyIHNldCB0aGUgZWxlbWVudCBzaXpl IHRvIHplcm8gd2hlbiBpbiBhIG1lZGlhIGRvY3VtZW50LgogICAgIGlmIChzaXplLmlzRW1wdHko KSAmJiBkb2N1bWVudCgpLmlzTWVkaWFEb2N1bWVudCgpKQotICAgICAgICByZXR1cm47CisgICAg ICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChzaXplID09IGludHJpbnNpY1NpemUoKSkKLSAg ICAgICAgcmV0dXJuOworICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBzZXRJbnRyaW5zaWNT aXplKHNpemUpOwogICAgIHNldFByZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eSh0cnVlKTsKICAg ICBzZXROZWVkc0xheW91dCgpOworICAgIHJldHVybiB0cnVlOwogfQogICAgIAogTGF5b3V0U2l6 ZSBSZW5kZXJWaWRlbzo6Y2FsY3VsYXRlSW50cmluc2ljU2l6ZSgpCkBAIC0xOTksNiArMjAwLDcg QEAgdm9pZCBSZW5kZXJWaWRlbzo6cGFpbnRSZXBsYWNlZChQYWludEluZm8mIHBhaW50SW5mbywg Y29uc3QgTGF5b3V0UG9pbnQmIHBhaW50T2YKIHZvaWQgUmVuZGVyVmlkZW86OmxheW91dCgpCiB7 CiAgICAgU3RhY2tTdGF0czo6TGF5b3V0Q2hlY2tQb2ludCBsYXlvdXRDaGVja1BvaW50OworICAg IHVwZGF0ZUludHJpbnNpY1NpemUoKTsKICAgICBSZW5kZXJNZWRpYTo6bGF5b3V0KCk7CiAgICAg dXBkYXRlUGxheWVyKCk7CiB9CkBAIC0yMTksNyArMjIxLDkgQEAgdm9pZCBSZW5kZXJWaWRlbzo6 dXBkYXRlUGxheWVyKCkKICAgICBpZiAoZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgpKQogICAgICAg ICByZXR1cm47CiAKLSAgICB1cGRhdGVJbnRyaW5zaWNTaXplKCk7CisgICAgYm9vbCBpbnRyaW5z aWNTaXplQ2hhbmdlZDsKKyAgICBpbnRyaW5zaWNTaXplQ2hhbmdlZCA9IHVwZGF0ZUludHJpbnNp Y1NpemUoKTsKKyAgICBBU1NFUlRfVU5VU0VEKGludHJpbnNpY1NpemVDaGFuZ2VkLCAhaW50cmlu c2ljU2l6ZUNoYW5nZWQgfHwgIXZpZXcoKS5mcmFtZVZpZXcoKS5pc0luUmVuZGVyVHJlZUxheW91 dCgpKTsKIAogICAgIE1lZGlhUGxheWVyKiBtZWRpYVBsYXllciA9IHZpZGVvRWxlbWVudCgpLnBs YXllcigpOwogICAgIGlmICghbWVkaWFQbGF5ZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVmlkZW8uaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJWaWRlby5oCmluZGV4IDExZDBmMzllNDIwNWZlYTAyNjBmZjAyZDRjNzYyYmRkMTQ0YzhlMDgu LmZjZmQ5ZDMyZWJjYjRjODQ3OTg2MTg1NmFjNGI5NTczM2VlMDdkOTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJWaWRlby5oCkBAIC01OSw3ICs1OSw3IEBAIHByaXZhdGU6CiAKICAg ICB2b2lkIGludHJpbnNpY1NpemVDaGFuZ2VkKCkgb3ZlcnJpZGU7CiAgICAgTGF5b3V0U2l6ZSBj YWxjdWxhdGVJbnRyaW5zaWNTaXplKCk7Ci0gICAgdm9pZCB1cGRhdGVJbnRyaW5zaWNTaXplKCk7 CisgICAgYm9vbCB1cGRhdGVJbnRyaW5zaWNTaXplKCk7CiAKICAgICB2b2lkIGltYWdlQ2hhbmdl ZChXcmFwcGVkSW1hZ2VQdHIsIGNvbnN0IEludFJlY3QqKSBvdmVycmlkZTsKIAo=