156872 2016-04-21 14:57:24 -0700 PolymorphicAccess adds sizeof(CallerFrameAndPC) rather than subtracting it when calculating stack height 2016-04-21 15:11:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1185965 0 fpizlo 2016-04-21 14:57:24 -0700 Patch forthcoming. 1185968 1 276966 fpizlo 2016-04-21 15:00:40 -0700 Created attachment 276966 the patch 1185970 2 commit-queue 2016-04-21 15:02:38 -0700 Attachment 276966 did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:995: Declaration has space between type name and * in numberOfRegsForCall * sizeof [whitespace/declaration] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1185971 3 276966 ggaren 2016-04-21 15:06:06 -0700 Comment on attachment 276966 the patch r=me 1185973 4 fpizlo 2016-04-21 15:11:44 -0700 Landed in http://trac.webkit.org/changeset/199837 276966 2016-04-21 15:00:40 -0700 2016-04-21 15:06:06 -0700 the patch blah.patch text/plain 2004 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5ODM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE2LTA0LTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UG9seW1vcnBoaWNBY2Nlc3MgYWRkcyBzaXplb2YoQ2FsbGVyRnJhbWVBbmRQQykgcmF0aGVyIHRo YW4gc3VidHJhY3RpbmcgaXQgd2hlbiBjYWxjdWxhdGluZyBzdGFjayBoZWlnaHQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Njg3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhlIGNvZGUg dGhhdCBhZGRlZCBzaXplb2YoQ2FsbGVyRnJhbWVBbmRQQykgZW1lcmdlZCBmcm9tIGEgYmFkIGNv cHktcGFzdGUgaW4gcjE4OTU4Ni4gVGhhdCB3YXMKKyAgICAgICAgdGhlIHJldmlzaW9uIHRoYXQg Y3JlYXRlZCB0aGUgUG9seW1vcnBoaWNBY2Nlc3MgY2xhc3MuIEl0IG1vdmVkIGNvZGUgZm9yIGdl bmVyYXRpbmcgYQorICAgICAgICBnZXR0ZXIvc2V0dGVyIGNhbGwgZnJvbSBSZXBhdGNoLmNwcCB0 byBQb2x5bW9ycGhpY0FjY2Vzcy5jcHAuIFlvdSBjYW4gc2VlIHRoZSBjb2RlIGRvaW5nIGEKKyAg ICAgICAgc3VidHJhY3Rpb24gaGVyZToKKyAgICAgICAgCisgICAgICAgICAgICBodHRwOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC8xODk1ODYvdHJ1bmsvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9SZXBhdGNoLmNwcAorICAgICAgICAKKyAgICAgICAgVGhpcyBtYWtlcyB0aGUgd29ybGQg cmlnaHQgYWdhaW4uCisKKyAgICAgICAgKiBieXRlY29kZS9Qb2x5bW9ycGhpY0FjY2Vzcy5jcHA6 CisgICAgICAgIChKU0M6OkFjY2Vzc0Nhc2U6OmdlbmVyYXRlSW1wbCk6CisKIDIwMTYtMDQtMjEg IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCB3YXJu aW5nOiBDT0RFX1NJR05fRU5USVRMRU1FTlRTIHNwZWNpZmllZCB3aXRob3V0IHNwZWNpZnlpbmcg Q09ERV9TSUdOX0lERU5USVRZCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv UG9seW1vcnBoaWNBY2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9Qb2x5bW9ycGhpY0FjY2Vzcy5jcHAJKHJldmlzaW9uIDE5OTgyNSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Qb2x5bW9ycGhpY0FjY2Vzcy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTk5Miw3ICs5OTIsNyBAQCB2b2lkIEFjY2Vzc0Nhc2U6OmdlbmVyYXRlSW1w bChBY2Nlc3NHZW5lCiAgICAgICAgICAgICB1bnNpZ25lZCBudW1iZXJPZlJlZ3NGb3JDYWxsID0g SlNTdGFjazo6Q2FsbEZyYW1lSGVhZGVyU2l6ZSArIG51bWJlck9mUGFyYW1ldGVyczsKIAogICAg ICAgICAgICAgdW5zaWduZWQgbnVtYmVyT2ZCeXRlc0ZvckNhbGwgPQotICAgICAgICAgICAgICAg IG51bWJlck9mUmVnc0ZvckNhbGwgKiBzaXplb2YoUmVnaXN0ZXIpICsgc2l6ZW9mKENhbGxlckZy YW1lQW5kUEMpOworICAgICAgICAgICAgICAgIG51bWJlck9mUmVnc0ZvckNhbGwgKiBzaXplb2Yo UmVnaXN0ZXIpIC0gc2l6ZW9mKENhbGxlckZyYW1lQW5kUEMpOwogCiAgICAgICAgICAgICB1bnNp Z25lZCBhbGlnbmVkTnVtYmVyT2ZCeXRlc0ZvckNhbGwgPQogICAgICAgICAgICAgICAgIFdURjo6 cm91bmRVcFRvTXVsdGlwbGVPZihzdGFja0FsaWdubWVudEJ5dGVzKCksIG51bWJlck9mQnl0ZXNG b3JDYWxsKTsK