15686 2007-10-25 05:53:23 -0700 GtkLauncher aborts on launch due to uninitialized threading subsystem 2007-10-25 11:32:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Normal --- 1 mdt webkit-unassigned beidson mrowe oldest_to_newest 59420 0 mdt 2007-10-25 05:53:23 -0700 initialization fails with the message: GLib-ERROR **: The thread system is not yet initialized. aborting... glib's threading must be initilized before database stuff is initialized. i put if (!g_thread_supported ()) g_thread_init (NULL); into WebKitTools/GtkLauncher/main.cpp but maybe webkit_init() in WebKit/gtk/Api/webkitgtkglobal.cpp is a better place. 59421 1 mrowe 2007-10-25 05:56:53 -0700 What is happening here is that webkit_init calls DatabaseTracker::tracker to retrieve the DatabaseTracker singleton to set the database path. The DatabaseTracker constructor allocates a SQLDatabase, which in turn allocates a Mutex. All of this happens without WebCore calling initializeThreading. The Gtk port could work around this by calling initializeThreading from webkit_init, but WebCore should be doing this itself before doing anything thread-related (this includes allocating mutexes). 59423 2 mrowe 2007-10-25 05:58:16 -0700 Copying Brady as he's done a lot of the work on the threading support in WebCore. Brady, do you have any idea how to ensure that initializeThreading is always called at the appropriate times? The two locations that it is currently called from seem quite arbitrary. 59428 3 alp 2007-10-25 08:17:09 -0700 Database support has been disabled in r27047 pending a fix for this bug. GtkLauncher should work again. 59434 4 beidson 2007-10-25 09:17:58 -0700 Actually, there's already an abstraction for this in WebCore. Check out threading.h - void initializeThreading(); It seems that GTK already hooked into that in r26864 initializeThreading() is called at any point a secondary thread might be kicked off. Currently this include the IconDatabase c'tor and the Database c'tor. GTK's impl in ThreadingGTK.cpp seems to do exactly what you say needs to be done - if (!g_thread_supported ()) g_thread_init (NULL); So in other words, I'm surprised this isn't working already. 59435 5 beidson 2007-10-25 09:19:25 -0700 Per Mark's comment of "the two locations now seem quite arbritrary" - perhaps the specific locations can be tweaked somewhat, but I like the idea of initializing threading *only* when a secondary thread might be kicked off. If a client doesn't use the icon database and never visits a page with client-side databases, there's no reason they should init threading 59447 6 16861 alp 2007-10-25 11:28:03 -0700 Created attachment 16861 Fix, initialize thread support early as possible 59448 7 16861 beidson 2007-10-25 11:29:47 -0700 Comment on attachment 16861 Fix, initialize thread support early as possible I'm still curious why the initialize-on-the-spot didn't work, but this seems reasonable. 59449 8 alp 2007-10-25 11:32:12 -0700 Fixed in r27050. 16861 2007-10-25 11:28:03 -0700 2007-10-25 11:29:47 -0700 Fix, initialize thread support early as possible enable-db-fix.patch text/plain 2777 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzA0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMTAtMjUgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Njg2CisgICAgICAgIEd0a0xhdW5jaGVy IGFib3J0cyBvbiBsYXVuY2ggZHVlIHRvIHVuaW5pdGlhbGl6ZWQgdGhyZWFkaW5nIHN1YnN5c3Rl bQorCisgICAgICAgIFJlLWVuYWJsZSBkYXRhYmFzZSBzdXBwb3J0IGluIHRoZSBHVEsrIHBvcnQs IHdpdGggYSBmaXguCisKKyAgICAgICAgKiBXZWJDb3JlLnBybzoKKwogMjAwNy0xMC0yNSAgSm9u IEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFN0ZXZlLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnBybwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L1dlYkNvcmUucHJvCShyZXZpc2lvbiAyNzA0OSkKKysrIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHdv cmtpbmcgY29weSkKQEAgLTUyLDkgKzUyLDYgQEAgd2luMzItZysrIHsKIAogZ3RrLXBvcnQ6IFBL R0NPTkZJRyArPSBndGhyZWFkLTIuMAogCi0jIERhdGFiYXNlIHN1cHBvcnQgdGVtcG9yYXJpbHkg ZGlzYWJsZWQsIHNlZSBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY4 NgotZ3RrLXBvcnQ6IERFRklORVMgKz0gRU5BQkxFX0lDT05EQVRBQkFTRT0wIEVOQUJMRV9EQVRB QkFTRT0wCi0KICMgT3B0aW9uYWwgY29tcG9uZW50cyAobG9vayBmb3IgZGVmcyBpbiBjb25maWcu aCBhbmQgaW5jbHVkZWQgZmlsZXMhKQogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVRBQkFT RT0uKTogREVGSU5FUyArPSBFTkFCTEVfREFUQUJBU0U9MQogIWNvbnRhaW5zKERFRklORVMsIEVO QUJMRV9JQ09OREFUQUJBU0U9Lik6IERFRklORVMgKz0gRU5BQkxFX0lDT05EQVRBQkFTRT0xCkBA IC05NjAsNyArOTU3LDYgQEAgZ3RrLXBvcnQgewogICAgICAgICAuLi9XZWJLaXQvZ3RrL1dlYkNv cmVTdXBwb3J0L0luc3BlY3RvckNsaWVudEd0ay5jcHAKIH0KIAotIyBFTkFCTEVfREFUQUJBU0Ug cHJvYmFibHkgY2Fubm90IGJlIGRpc2FibGVkIHdpdGhvdXQgYnJlYWtpbmcgdGhpbmdzCiBjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfREFUQUJBU0U9MSkgewogICAgIEZFQVRVUkVfREVGSU5FU19K QVZBU0NSSVBUICs9IEVOQUJMRV9EQVRBQkFTRT0xCiAgICAgcXQtcG9ydDogSU5DTFVERVBBVEgg Kz0gJCRbUVRfSU5TVEFMTF9QUkVGSVhdL3NyYy8zcmRwYXJ0eS9zcWxpdGUvCkluZGV4OiBXZWJL aXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvZ3RrL0NoYW5nZUxvZwkocmV2 aXNpb24gMjcwNDkpCisrKyBXZWJLaXQvZ3RrL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE2IEBACisyMDA3LTEwLTI1ICBBbHAgVG9rZXIgIDxhbHBAYXRva2VyLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY4NgorICAgICAgICBHdGtMYXVuY2hlciBh Ym9ydHMgb24gbGF1bmNoIGR1ZSB0byB1bmluaXRpYWxpemVkIHRocmVhZGluZyBzdWJzeXN0ZW0K KworICAgICAgICBSZS1lbmFibGUgZGF0YWJhc2Ugc3VwcG9ydCBpbiB0aGUgR1RLKyBwb3J0LCB3 aXRoIGEgZml4LgorCisgICAgICAgIEluaXRpYWxpemUgR0xpYiB0aHJlYWRpbmcgYXMgZWFybHkg YXMgcG9zc2libGUuCisKKyAgICAgICAgKiBBcGkvd2Via2l0Z3RrZ2xvYmFsLmNwcDoKKwogMjAw Ny0xMC0yNSAgQWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBmaXggdG8gbWFrZSB0aGUgR1RLKyBwb3J0IHJ1bi4KSW5kZXg6IFdlYktpdC9ndGsvQXBpL3dl YmtpdGd0a2dsb2JhbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9BcGkvd2Via2l0Z3Rr Z2xvYmFsLmNwcAkocmV2aXNpb24gMjcwNDkpCisrKyBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtn bG9iYWwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw4IEBAIHZvaWQgd2Via2l0X2lu aXQodm9pZCkKIHsKICAgICBXZWJDb3JlOjpJbml0aWFsaXplTG9nZ2luZ0NoYW5uZWxzSWZOZWNl c3NhcnkoKTsKIAorICAgIFdlYkNvcmU6OmluaXRpYWxpemVUaHJlYWRpbmcoKTsKKwogI2lmIEVO QUJMRShEQVRBQkFTRSkKICAgICAvLyBGSVhNRTogSXQgc2hvdWxkIGJlIHBvc3NpYmxlIGZvciBj bGllbnQgYXBwbGljYXRpb25zIHRvIG92ZXJyaWRlIHRoaXMgZGVmYXVsdCBsb2NhdGlvbgogICAg IGdjaGFyKiBkYXRhYmFzZURpcmVjdG9yeSA9IGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9k YXRhX2RpcigpLCAid2Via2l0IiwgImRhdGFiYXNlcyIsIE5VTEwpOwo=