156833 2016-04-20 22:00:26 -0700 Build fail because of quotes. 2017-02-16 09:12:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build PC Linux RESOLVED FIXED P2 Minor --- 1 holo annulen achristensen annulen commit-queue fujii mcatanzaro oldest_to_newest 1185693 0 holo 2016-04-20 22:00:26 -0700 Build fails when upstream version string has some special letter. Because cmake automatically insert quotes when build. At Source/WebCore/CMakeList.txt, there's code setting PYTHONPATH variable. When version has some special letter like '2.10.4+dev12~1.gbp7c2f8b' builds fail with error '/bin/sh: 1: PYTHONPATH=/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/Source/JavaScriptCore/inspector/scripts: not found'. Because command will be 'cd "/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/obj-i586-linux-gnu/Source/WebCore" && "PYTHONPATH=/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/Source/JavaScriptCore/inspector/scripts" /usr/bin/python2.7 ...' ps. I changed format 3.0(quilt) to 3.0(native). Because I don't need quilt. 1185694 1 276899 holo 2016-04-20 22:01:18 -0700 Created attachment 276899 patch 1186990 2 achristensen 2016-04-25 11:09:16 -0700 The env command doesn't exist on Windows. 1187291 3 277347 holo 2016-04-26 00:24:22 -0700 Created attachment 277347 Patch Use -E for platform independence. But '-E env' depends on cmake>=3.1. 1187450 4 277347 achristensen 2016-04-26 10:25:43 -0700 Comment on attachment 277347 Patch We currently support CMake 2.8.12, and I don't think this alone is reason enough to bump the minimum version that high. 1277606 5 301743 annulen 2017-02-16 04:28:14 -0800 Created attachment 301743 Patch 1277689 6 301743 commit-queue 2017-02-16 09:12:46 -0800 Comment on attachment 301743 Patch Clearing flags on attachment: 301743 Committed r212435: <http://trac.webkit.org/changeset/212435> 1277690 7 commit-queue 2017-02-16 09:12:50 -0800 All reviewed patches have been landed. Closing bug. 276899 2016-04-20 22:01:18 -0700 2016-04-26 00:24:22 -0700 patch Patch.patch text/plain 1570 holo RnJvbSA4NmU5NzE1NGU3MzhlOGY4MzAzMDZhYjZlZWMxNTQ4NWRiMGM1MTE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIFJhZmUgTGVlIDxob2xvQHdpc2V3b2xmLm9yZz4KRGF0 ZTogVGh1LCAyMSBBcHIgMjAxNiAxMzo1NDo1NSArMDkwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeGVk IGJ1ZyBjYXVzZWQgYnkgcXVvdGVzIGF1dG9tYXRpY2FsbHkgaW5zZXJ0ZWQuCgotLS0KIFNvdXJj ZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VM aXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCA5MjI4NmI2Li5i YmYzMzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9T b3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMzU4Nyw3ICszNTg3LDcgQEAgaWYgKFdl YkNvcmVfVVNFUl9BR0VOVF9TQ1JJUFRTKQogICAgICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJD RVNfV0VCQ09SRV9ESVJ9L1VzZXJBZ2VudFNjcmlwdHNEYXRhLmNwcCAke0RFUklWRURfU09VUkNF U19XRUJDT1JFX0RJUn0vVXNlckFnZW50U2NyaXB0cy5oCiAgICAgICAgIE1BSU5fREVQRU5ERU5D WSAke1dFQkNPUkVfRElSfS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkKICAgICAgICAg REVQRU5EUyAke1dlYkNvcmVfVVNFUl9BR0VOVF9TQ1JJUFRTfQotICAgICAgICBDT01NQU5EICJQ WVRIT05QQVRIPSR7SmF2YVNjcmlwdENvcmVfU0NSSVBUU19ESVJ9IiAke1BZVEhPTl9FWEVDVVRB QkxFfSAke1dFQkNPUkVfRElSfS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkgJHtERVJJ VkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1VzZXJBZ2VudFNjcmlwdHMuaCAke0RFUklWRURfU09V UkNFU19XRUJDT1JFX0RJUn0vVXNlckFnZW50U2NyaXB0c0RhdGEuY3BwICR7V2ViQ29yZV9VU0VS X0FHRU5UX1NDUklQVFN9CisgICAgICAgIENPTU1BTkQgZW52ICJQWVRIT05QQVRIPSR7SmF2YVNj cmlwdENvcmVfU0NSSVBUU19ESVJ9IiAke1BZVEhPTl9FWEVDVVRBQkxFfSAke1dFQkNPUkVfRElS fS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09S RV9ESVJ9L1VzZXJBZ2VudFNjcmlwdHMuaCAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0v VXNlckFnZW50U2NyaXB0c0RhdGEuY3BwICR7V2ViQ29yZV9VU0VSX0FHRU5UX1NDUklQVFN9CiAg ICAgICAgIFZFUkJBVElNKQogICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfREVSSVZFRF9TT1VSQ0VT ICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9Vc2VyQWdlbnRTY3JpcHRzRGF0YS5jcHAp CiAgICAgQUREX1NPVVJDRV9XRUJDT1JFX0RFUklWRURfREVQRU5ERU5DSUVTKCR7V2ViQ29yZV9V U0VSX0FHRU5UX1NDUklQVFNfREVQRU5ERU5DSUVTfSBVc2VyQWdlbnRTY3JpcHRzRGF0YS5jcHAg VXNlckFnZW50U2NyaXB0cy5oKQotLSAKMS45LjEKCg== 277347 2016-04-26 00:24:22 -0700 2017-02-16 04:28:02 -0800 Patch Patch.patch text/plain 1590 holo RnJvbSBjZWNjM2JjMjZmMjE1Zjc0MTQxYTA1MTc5ODU1YWNjOGJlNTAyZjk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIFJhZmUgTGVlIDxob2xvQHdpc2V3b2xmLm9yZz4KRGF0 ZTogVGh1LCAyMSBBcHIgMjAxNiAxMzo1NDo1NSArMDkwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeGVk IGJ1ZyBjYXVzZWQgYnkgcXVvdGVzIGF1dG9tYXRpY2FsbHkgaW5zZXJ0ZWQuCgotLS0KIFNvdXJj ZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VM aXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCA5MjI4NmI2Li5i OTIzMDBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9T b3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMzU4Nyw3ICszNTg3LDcgQEAgaWYgKFdl YkNvcmVfVVNFUl9BR0VOVF9TQ1JJUFRTKQogICAgICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJD RVNfV0VCQ09SRV9ESVJ9L1VzZXJBZ2VudFNjcmlwdHNEYXRhLmNwcCAke0RFUklWRURfU09VUkNF U19XRUJDT1JFX0RJUn0vVXNlckFnZW50U2NyaXB0cy5oCiAgICAgICAgIE1BSU5fREVQRU5ERU5D WSAke1dFQkNPUkVfRElSfS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkKICAgICAgICAg REVQRU5EUyAke1dlYkNvcmVfVVNFUl9BR0VOVF9TQ1JJUFRTfQotICAgICAgICBDT01NQU5EICJQ WVRIT05QQVRIPSR7SmF2YVNjcmlwdENvcmVfU0NSSVBUU19ESVJ9IiAke1BZVEhPTl9FWEVDVVRB QkxFfSAke1dFQkNPUkVfRElSfS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkgJHtERVJJ VkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1VzZXJBZ2VudFNjcmlwdHMuaCAke0RFUklWRURfU09V UkNFU19XRUJDT1JFX0RJUn0vVXNlckFnZW50U2NyaXB0c0RhdGEuY3BwICR7V2ViQ29yZV9VU0VS X0FHRU5UX1NDUklQVFN9CisgICAgICAgIENPTU1BTkQgJHtDTUFLRV9DT01NQU5EfSAtRSBlbnYg IlBZVEhPTlBBVEg9JHtKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUn0iICR7UFlUSE9OX0VYRUNV VEFCTEV9ICR7V0VCQ09SRV9ESVJ9L1NjcmlwdHMvbWFrZS1qcy1maWxlLWFycmF5cy5weSAke0RF UklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vVXNlckFnZW50U2NyaXB0cy5oICR7REVSSVZFRF9T T1VSQ0VTX1dFQkNPUkVfRElSfS9Vc2VyQWdlbnRTY3JpcHRzRGF0YS5jcHAgJHtXZWJDb3JlX1VT RVJfQUdFTlRfU0NSSVBUU30KICAgICAgICAgVkVSQkFUSU0pCiAgICAgbGlzdChBUFBFTkQgV2Vi Q29yZV9ERVJJVkVEX1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1VzZXJB Z2VudFNjcmlwdHNEYXRhLmNwcCkKICAgICBBRERfU09VUkNFX1dFQkNPUkVfREVSSVZFRF9ERVBF TkRFTkNJRVMoJHtXZWJDb3JlX1VTRVJfQUdFTlRfU0NSSVBUU19ERVBFTkRFTkNJRVN9IFVzZXJB Z2VudFNjcmlwdHNEYXRhLmNwcCBVc2VyQWdlbnRTY3JpcHRzLmgpCi0tIAoxLjkuMQoK 301743 2017-02-16 04:28:14 -0800 2017-02-16 09:12:46 -0800 Patch bug-156833-20170216152537.patch text/plain 1731 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQppbmRleCBh YTRkODEwNGE1YjUyMGZmMDAyZjFhZmViMjVlMDM1NTMxNDUyYTgxLi42ZTlhZmUwMWU0MWY5OGI4 MTU5NDViODFiMWFiMzRkNmJiNmNjYmRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTM4 NSw3ICszODUsOSBAQCBtYWNybyhHRU5FUkFURV9XRUJLSVQyX01FU1NBR0VfU09VUkNFUyBfb3V0 cHV0X3NvdXJjZSBfaW5wdXRfZmlsZXMpCiBlbmRtYWNybygpCiAKIG1hY3JvKE1BS0VfSlNfRklM RV9BUlJBWVMgX291dHB1dF9jcHAgX291dHB1dF9oIF9zY3JpcHRzIF9zY3JpcHRzX2RlcGVuZGVu Y2llcykKLSAgICBpZiAoV0lOMzIpCisgICAgaWYgKE5PVCBDTUFLRV9WRVJTSU9OIFZFUlNJT05f TEVTUyAzLjEpCisgICAgICAgIHNldChfcHl0aG9uX3BhdGggJHtDTUFLRV9DT01NQU5EfSAtRSBl bnYgIlBZVEhPTlBBVEg9JHtKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUn0iKQorICAgIGVsc2Vp ZiAoV0lOMzIpCiAgICAgICAgIHNldChfcHl0aG9uX3BhdGggc2V0ICJQWVRIT05QQVRIPSR7SmF2 YVNjcmlwdENvcmVfU0NSSVBUU19ESVJ9IiAmJikKICAgICBlbHNlICgpCiAgICAgICAgIHNldChf cHl0aG9uX3BhdGggIlBZVEhPTlBBVEg9JHtKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX0RJUn0iKQpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDczOWRjYTUwNWM3NGZkYzc3 YjIzZTIyZTEyZTQxMGRiNDIzMDBjMjMuLmJmOWI3ODgxYTdiMTQ3NTFiZTkwY2Q0NDBiMzdjMWUz MzAyNTcwYWQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOCBAQAorMjAxNy0wMi0xNiAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgu cnU+CisKKyAgICAgICAgW2NtYWtlXSBVc2UgZW52IGNvbW1hbmQgdG8gc2V0IFBZVEhPTlBBVEgg aWYgY21ha2UgaXMgbmV3IGVub3VnaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU2ODMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgZml4ZXMgMiBpc3N1ZXMgd2hlbiBDTWFrZSA+PSAz LjEgaXMgdXNlZDoKKyAgICAgICAgLSBXaGVuIFBZVEhPTlBBVEggY29udGFpbnMgc3BlY2lhbCBj aGFyYWN0ZXJzLCBDTWFrZSBhZGRzIHF1b3RlcyBhcm91bmQKKyAgICAgICAgIlBZVEhPTlBBVEg9 Li4uIiBhbmQgcHJvZHVjZXMgYnJva2VuIGJ1aWxkIGNvbW1hbmQgaW4gbm9uLVdJTjMyIGNhc2Uu CisgICAgICAgIC0gT24gV0lOMzIsIHVuaXgtbGlrZSBzaGVsbCBjYW4gYmUgdXNlZCBpbnN0ZWFk IG9mIGNtZC5leGUsIGJ1dCB0aGlzIGNhc2UKKyAgICAgICAgY2Fubm90IGJlIGVhc2lseSBkZXRl Y3RlZCBpbiBjbWFrZS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21h a2U6CisKIDIwMTctMDItMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZCBFTkFCTEVfSU5URVJTRUNUSU9OX09CU0VS VkVSIG9wdGlvbiB0byBDTWFrZS4K