156830 2016-04-20 19:12:36 -0700 DFG del_by_id support forgets to set() 2016-04-20 19:35:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1185653 0 fpizlo 2016-04-20 19:12:36 -0700 Patch forthcoming. 1185655 1 276885 fpizlo 2016-04-20 19:17:37 -0700 Created attachment 276885 the patch 1185656 2 commit-queue 2016-04-20 19:19:11 -0700 Attachment 276885 did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4244: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1185657 3 fpizlo 2016-04-20 19:20:06 -0700 (In reply to comment #2) > Attachment 276885 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4244: One line > control clauses should not use braces. [whitespace/braces] [4] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Oops, I'll remove that. 1185658 4 276886 fpizlo 2016-04-20 19:20:26 -0700 Created attachment 276886 the patch 1185661 5 fpizlo 2016-04-20 19:35:30 -0700 Landed in http://trac.webkit.org/changeset/199801 276885 2016-04-20 19:17:37 -0700 2016-04-20 19:20:26 -0700 the patch blah.patch text/plain 2725 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5ODAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE2LTA0LTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIGRlbF9ieV9pZCBzdXBwb3J0IGZvcmdldHMgdG8gc2V0KCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjgzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNw cDoKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayk6CisgICAg ICAgICogdGVzdHMvc3RyZXNzL2RmZy1kZWwtYnktaWQuanM6IEFkZGVkLgorCiAyMDE2LTA0LTIw ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEltcHJvdmUgc2Ft cGxpbmcgcHJvZmlsZXIgQ0xJIEpTQyB0b29sCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkocmV2aXNpb24gMTk5Nzk5KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQwNDQsNyArNDA0NCw4IEBAIGJvb2wgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2so dW5zaWduZWQKICAgICAgICAgY2FzZSBvcF9kZWxfYnlfaWQ6IHsKICAgICAgICAgICAgIE5vZGUq IGJhc2UgPSBnZXQoVmlydHVhbFJlZ2lzdGVyKGN1cnJlbnRJbnN0cnVjdGlvblsyXS51Lm9wZXJh bmQpKTsKICAgICAgICAgICAgIHVuc2lnbmVkIGlkZW50aWZpZXJOdW1iZXIgPSBtX2lubGluZVN0 YWNrVG9wLT5tX2lkZW50aWZpZXJSZW1hcFtjdXJyZW50SW5zdHJ1Y3Rpb25bM10udS5vcGVyYW5k XTsKLSAgICAgICAgICAgIGFkZFRvR3JhcGgoRGVsZXRlQnlJZCwgT3BJbmZvKGlkZW50aWZpZXJO dW1iZXIpLCBiYXNlKTsKKyAgICAgICAgICAgIHNldChWaXJ0dWFsUmVnaXN0ZXIoY3VycmVudElu c3RydWN0aW9uWzFdLnUub3BlcmFuZCksCisgICAgICAgICAgICAgICAgYWRkVG9HcmFwaChEZWxl dGVCeUlkLCBPcEluZm8oaWRlbnRpZmllck51bWJlciksIGJhc2UpKTsKICAgICAgICAgICAgIE5F WFRfT1BDT0RFKG9wX2RlbF9ieV9pZCk7CiAgICAgICAgIH0KIApAQCAtNDIzOCw4ICs0MjM5LDkg QEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayh1bnNpZ25lZAogICAgICAgICAgICAg QVNTRVJUKCFtX2N1cnJlbnRCbG9jay0+dGVybWluYWwoKSk7CiAgICAgICAgICAgICBpZiAoaW5s aW5lQ2FsbEZyYW1lKCkpIHsKICAgICAgICAgICAgICAgICBmbHVzaEZvclJldHVybigpOwotICAg ICAgICAgICAgICAgIGlmIChtX2lubGluZVN0YWNrVG9wLT5tX3JldHVyblZhbHVlLmlzVmFsaWQo KSkKKyAgICAgICAgICAgICAgICBpZiAobV9pbmxpbmVTdGFja1RvcC0+bV9yZXR1cm5WYWx1ZS5p c1ZhbGlkKCkpIHsKICAgICAgICAgICAgICAgICAgICAgc2V0RGlyZWN0KG1faW5saW5lU3RhY2tU b3AtPm1fcmV0dXJuVmFsdWUsIGdldChWaXJ0dWFsUmVnaXN0ZXIoY3VycmVudEluc3RydWN0aW9u WzFdLnUub3BlcmFuZCkpLCBJbW1lZGlhdGVTZXRXaXRoRmx1c2gpOworICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICBtX2lubGluZVN0YWNrVG9wLT5tX2RpZFJldHVybiA9IHRydWU7 CiAgICAgICAgICAgICAgICAgaWYgKG1faW5saW5lU3RhY2tUb3AtPm1fdW5saW5rZWRCbG9ja3Mu aXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAgICAgICAgIC8vIElmIHdlJ3JlIHJldHVybmluZyBm cm9tIHRoZSBmaXJzdCBibG9jaywgdGhlbiB3ZSdyZSBkb25lIHBhcnNpbmcuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2RmZy1kZWwtYnktaWQuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9kZmctZGVsLWJ5LWlkLmpz CShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9kZmct ZGVsLWJ5LWlkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTQgQEAKK2Z1bmN0aW9uIGZv byhvKSB7CisgICAgcmV0dXJuIGRlbGV0ZSBvLmY7Cit9CisKK25vSW5saW5lKGZvbyk7CisKK2Zv ciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7ICsraSkgeworICAgIHZhciBvID0ge2Y6NDJ9OworICAg IHZhciByZXN1bHQgPSBmb28obyk7CisgICAgaWYgKHJlc3VsdCAhPT0gdHJ1ZSkKKyAgICAgICAg dGhyb3cgIkVycm9yOiBiYWQgcmVzdWx0OiAiICsgcmVzdWx0OworICAgIGlmICgiZiIgaW4gbykK KyAgICAgICAgdGhyb3cgIkVycm9yOiBcImZcIiBzdGlsbCBpbiBvayI7Cit9Cg== 276886 2016-04-20 19:20:26 -0700 2016-04-20 19:22:21 -0700 the patch blah.patch text/plain 2033 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5ODAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE2LTA0LTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIGRlbF9ieV9pZCBzdXBwb3J0IGZvcmdldHMgdG8gc2V0KCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjgzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNw cDoKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayk6CisgICAg ICAgICogdGVzdHMvc3RyZXNzL2RmZy1kZWwtYnktaWQuanM6IEFkZGVkLgorCiAyMDE2LTA0LTIw ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEltcHJvdmUgc2Ft cGxpbmcgcHJvZmlsZXIgQ0xJIEpTQyB0b29sCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkocmV2aXNpb24gMTk5Nzk5KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQwNDQsNyArNDA0NCw4IEBAIGJvb2wgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2so dW5zaWduZWQKICAgICAgICAgY2FzZSBvcF9kZWxfYnlfaWQ6IHsKICAgICAgICAgICAgIE5vZGUq IGJhc2UgPSBnZXQoVmlydHVhbFJlZ2lzdGVyKGN1cnJlbnRJbnN0cnVjdGlvblsyXS51Lm9wZXJh bmQpKTsKICAgICAgICAgICAgIHVuc2lnbmVkIGlkZW50aWZpZXJOdW1iZXIgPSBtX2lubGluZVN0 YWNrVG9wLT5tX2lkZW50aWZpZXJSZW1hcFtjdXJyZW50SW5zdHJ1Y3Rpb25bM10udS5vcGVyYW5k XTsKLSAgICAgICAgICAgIGFkZFRvR3JhcGgoRGVsZXRlQnlJZCwgT3BJbmZvKGlkZW50aWZpZXJO dW1iZXIpLCBiYXNlKTsKKyAgICAgICAgICAgIHNldChWaXJ0dWFsUmVnaXN0ZXIoY3VycmVudElu c3RydWN0aW9uWzFdLnUub3BlcmFuZCksCisgICAgICAgICAgICAgICAgYWRkVG9HcmFwaChEZWxl dGVCeUlkLCBPcEluZm8oaWRlbnRpZmllck51bWJlciksIGJhc2UpKTsKICAgICAgICAgICAgIE5F WFRfT1BDT0RFKG9wX2RlbF9ieV9pZCk7CiAgICAgICAgIH0KIApJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9kZmctZGVsLWJ5LWlkLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZGZnLWRlbC1ieS1pZC5qcwkocmV2aXNp b24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZGZnLWRlbC1ieS1p ZC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE0IEBACitmdW5jdGlvbiBmb28obykgewor ICAgIHJldHVybiBkZWxldGUgby5mOworfQorCitub0lubGluZShmb28pOworCitmb3IgKHZhciBp ID0gMDsgaSA8IDEwMDAwOyArK2kpIHsKKyAgICB2YXIgbyA9IHtmOjQyfTsKKyAgICB2YXIgcmVz dWx0ID0gZm9vKG8pOworICAgIGlmIChyZXN1bHQgIT09IHRydWUpCisgICAgICAgIHRocm93ICJF cnJvcjogYmFkIHJlc3VsdDogIiArIHJlc3VsdDsKKyAgICBpZiAoImYiIGluIG8pCisgICAgICAg IHRocm93ICJFcnJvcjogXCJmXCIgc3RpbGwgaW4gb2siOworfQo=