156824 2016-04-20 17:05:04 -0700 Improve sampling profiler CLI JSC tool 2016-04-20 17:55:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue keith_miller mark.lam msaboff oldest_to_newest 1185618 0 saam 2016-04-20 17:05:04 -0700 Add a few more things: - Display JITType - Make stack trace timeout interval a JSC option 1185626 1 276873 saam 2016-04-20 17:20:04 -0700 Created attachment 276873 patch 1185629 2 276873 mark.lam 2016-04-20 17:23:29 -0700 Comment on attachment 276873 patch View in context: https://bugs.webkit.org/attachment.cgi?id=276873&action=review r=me with comment fix. > Source/JavaScriptCore/ChangeLog:11 > + being in LLInt vs. Baseline could be wrong. For example, we may have took typo:/took/taken/. 1185640 3 saam 2016-04-20 17:55:09 -0700 landed in: http://trac.webkit.org/changeset/199800 276873 2016-04-20 17:20:04 -0700 2016-04-20 17:23:29 -0700 patch b-backup.diff text/plain 6001 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5Nzk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA CisyMDE2LTA0LTIwICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEltcHJvdmUgc2FtcGxpbmcgcHJvZmlsZXIgQ0xJIEpTQyB0b29sCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY4MjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGVuaGFuY2VzIHRoZSBT YW1wbGluZyBQcm9maWxlciBDTEkgdG9vbCBmcm9tIHRoZSBKU0Mgc2hlbGwKKyAgICAgICAgdG8g ZGlzcGxheSB0aGUgSklUVHlwZSBvZiBhIHBhcnRpY3VsYXIgQ29kZUJsb2NrLiBCZWNhdXNlIHRo aXMgaGFwcGVucworICAgICAgICBvbmNlIHdlIHByb2Nlc3MgYSBsb2cgb2Ygc3RhY2sgZnJhbWVz LCB0aGUgZGF0YSBmb3IgYSBwYXJ0aWN1bGFyIGZyYW1lCisgICAgICAgIGJlaW5nIGluIExMSW50 IHZzLiBCYXNlbGluZSBjb3VsZCBiZSB3cm9uZy4gRm9yIGV4YW1wbGUsIHdlIG1heSBoYXZlIHRv b2sgCisgICAgICAgIGEgc3RhY2sgdHJhY2Ugb2YgYSBDb2RlQmxvY2sgd2hpbGUgaXQgd2FzIGV4 ZWN1dGluZyBpbiB0aGUgTExJbnQsIHRoZW4gCisgICAgICAgIGl0IHRpZXJzIHVwIHRvIHRoZSBi YXNlbGluZSwgdGhlbiB3ZSBwcm9jZXNzIHRoZSBsb2cuIFdlIHdpbGwgc2hvdyBzdWNoIENvZGVC bG9ja3MKKyAgICAgICAgYXMgYmVpbmcgaW4gdGhlIGJhc2VsaW5lIEpJVC4gV2UgY291bGQgYmUg c21hcnRlciBhYm91dCB0aGlzIGluIHRoZSBmdXR1cmUgaWYKKyAgICAgICAgaXQgdHVybnMgb3V0 IHRvIHRydWx5IGJlIGEgcHJvYmxlbS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gYWRkcyBh ICdzYW1wbGluZ1Byb2ZpbGVyVGltaW5nSW50ZXJ2YWwnIEpTQyBvcHRpb24gdG8gYWxsb3cKKyAg ICAgICAgQ0xJIHVzZXJzIHRvIGNvbnRyb2wgdGhlIHNsZWVwIHRpbWUgYmV0d2VlbiBzdGFjayB0 cmFjZXMuCisKKyAgICAgICAgKiBqc2MuY3BwOgorICAgICAgICAoanNjbWFpbik6CisgICAgICAg ICogcnVudGltZS9PcHRpb25zLmg6CisgICAgICAgICogcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVy LmNwcDoKKyAgICAgICAgKEpTQzo6U2FtcGxpbmdQcm9maWxlcjo6U2FtcGxpbmdQcm9maWxlcik6 CisgICAgICAgIChKU0M6OlNhbXBsaW5nUHJvZmlsZXI6OnByb2Nlc3NVbnZlcmlmaWVkU3RhY2tU cmFjZXMpOgorICAgICAgICAoSlNDOjpTYW1wbGluZ1Byb2ZpbGVyOjpyZXBvcnRUb3BCeXRlY29k ZXMpOgorICAgICAgICAqIHJ1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oOgorICAgICAgICAoSlND OjpTYW1wbGluZ1Byb2ZpbGVyOjpTdGFja0ZyYW1lOjpoYXNFeHByZXNzaW9uSW5mbyk6CisKIDIw MTYtMDQtMjAgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW0pTQ10gREZHIHNob3VsZCBub3QgZ2VuZXJhdGUgdHdvIGp1bXBzIHdoZW4gdGhlIHRhcmdl dCBvZiBEb3VibGVCcmFuY2ggaXMgdGhlIG5leHQgYmxvY2sgIApJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2pzYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pz Yy5jcHAJKHJldmlzaW9uIDE5OTc5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yMjc1LDYgKzIyNzUsNyBAQCBpbnQganNjbWFpbihpbnQgYXJn YywgY2hhcioqIGFyZ3YpCiAKICAgICBpZiAob3B0aW9ucy5tX2R1bXBTYW1wbGluZ1Byb2ZpbGVy RGF0YSkgewogI2lmIEVOQUJMRShTQU1QTElOR19QUk9GSUxFUikKKyAgICAgICAgSlNMb2NrSG9s ZGVyIGxvY2tlcih2bSk7CiAgICAgICAgIHZtLT5zYW1wbGluZ1Byb2ZpbGVyKCktPnJlcG9ydFRv cEZ1bmN0aW9ucygpOwogICAgICAgICB2bS0+c2FtcGxpbmdQcm9maWxlcigpLT5yZXBvcnRUb3BC eXRlY29kZXMoKTsKICNlbHNlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P cHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0 aW9ucy5oCShyZXZpc2lvbiAxOTk3OTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxOCw2ICszMTgsNyBAQCB0eXBlZGVmIGNv bnN0IGNoYXIqIG9wdGlvblN0cmluZzsKICAgICB2KGJvb2wsIHVzZVR5cGVQcm9maWxlciwgZmFs c2UsIG51bGxwdHIpIFwKICAgICB2KGJvb2wsIHVzZUNvbnRyb2xGbG93UHJvZmlsZXIsIGZhbHNl LCBudWxscHRyKSBcCiAgICAgdihib29sLCB1c2VTYW1wbGluZ1Byb2ZpbGVyLCBmYWxzZSwgbnVs bHB0cikgXAorICAgIHYodW5zaWduZWQsIHNhbXBsaW5nUHJvZmlsZXJUaW1pbmdJbnRlcnZhbCwg MTAwMCwgIlRpbWUgYmV0d2VlbiBzdGFjayB0cmFjZXMgaW4gbWljcm9zZWNvbmRzLiIpIFwKICAg ICB2KGJvb2wsIGNvbGxlY3RTYW1wbGluZ1Byb2ZpbGVyRGF0YUZvckpTQ1NoZWxsLCBmYWxzZSwg IlRoaXMgY29ycmVzcG9uZHMgdG8gdGhlIEpTQyBzaGVsbCdzIC0tcmVwb3J0U2FtcGxpbmdQcm9m aWxlckRhdGEgb3B0aW9uLiIpIFwKICAgICB2KGJvb2wsIGFsd2F5c0dlbmVyYXRlUENUb0NvZGVP cmlnaW5NYXAsIGZhbHNlLCAiVGhpcyB3aWxsIG1ha2Ugc3VyZSB3ZSBhbHdheXMgZ2VuZXJhdGUg YSBQQ1RvQ29kZU9yaWdpbk1hcCBmb3IgSklUZWQgY29kZS4iKSBcCiAgICAgXApJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5jcHAJ KHJldmlzaW9uIDE5OTc5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NhbXBs aW5nUHJvZmlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODUsNyArMTg1LDcgQEAgcHJpdmF0 ZToKIFNhbXBsaW5nUHJvZmlsZXI6OlNhbXBsaW5nUHJvZmlsZXIoVk0mIHZtLCBSZWZQdHI8U3Rv cHdhdGNoPiYmIHN0b3B3YXRjaCkKICAgICA6IG1fdm0odm0pCiAgICAgLCBtX3N0b3B3YXRjaChX VEZNb3ZlKHN0b3B3YXRjaCkpCi0gICAgLCBtX3RpbWluZ0ludGVydmFsKHN0ZDo6Y2hyb25vOjpt aWNyb3NlY29uZHMoMTAwMCkpCisgICAgLCBtX3RpbWluZ0ludGVydmFsKHN0ZDo6Y2hyb25vOjpt aWNyb3NlY29uZHMoT3B0aW9uczo6c2FtcGxpbmdQcm9maWxlclRpbWluZ0ludGVydmFsKCkpKQog ICAgICwgbV90aHJlYWRJZGVudGlmaWVyKDApCiAgICAgLCBtX2pzY0V4ZWN1dGlvblRocmVhZChu dWxscHRyKQogICAgICwgbV9pc1BhdXNlZChmYWxzZSkKQEAgLTM2OCw4ICszNjgsMTAgQEAgdm9p ZCBTYW1wbGluZ1Byb2ZpbGVyOjpwcm9jZXNzVW52ZXJpZmllZAogICAgICAgICAgICAgICAgICAg ICBzdGFja1RyYWNlLmZyYW1lcy5sYXN0KCkubGluZU51bWJlciwgc3RhY2tUcmFjZS5mcmFtZXMu bGFzdCgpLmNvbHVtbk51bWJlcik7CiAgICAgICAgICAgICAgICAgc3RhY2tUcmFjZS5mcmFtZXMu bGFzdCgpLmJ5dGVjb2RlSW5kZXggPSBieXRlY29kZUluZGV4OwogICAgICAgICAgICAgfQotICAg ICAgICAgICAgaWYgKE9wdGlvbnM6OmNvbGxlY3RTYW1wbGluZ1Byb2ZpbGVyRGF0YUZvckpTQ1No ZWxsKCkpCisgICAgICAgICAgICBpZiAoT3B0aW9uczo6Y29sbGVjdFNhbXBsaW5nUHJvZmlsZXJE YXRhRm9ySlNDU2hlbGwoKSkgewogICAgICAgICAgICAgICAgIHN0YWNrVHJhY2UuZnJhbWVzLmxh c3QoKS5jb2RlQmxvY2tIYXNoID0gY29kZUJsb2NrLT5oYXNoKCk7CisgICAgICAgICAgICAgICAg c3RhY2tUcmFjZS5mcmFtZXMubGFzdCgpLmppdFR5cGUgPSBjb2RlQmxvY2stPmppdFR5cGUoKTsK KyAgICAgICAgICAgIH0KICAgICAgICAgfTsKIAogICAgICAgICBhdXRvIGFwcGVuZEVtcHR5RnJh bWUgPSBbJl0gewpAQCAtODMyLDcgKzgzNCw3IEBAIHZvaWQgU2FtcGxpbmdQcm9maWxlcjo6cmVw b3J0VG9wQnl0ZWNvZGUKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBjb2RlQmxvY2tIYXNo ID0gIjxuaWw+IjsKIAotICAgICAgICBTdHJpbmcgZnJhbWVEZXNjcmlwdGlvbiA9IG1ha2VTdHJp bmcoZnJhbWUuZGlzcGxheU5hbWUobV92bSksICIjIiwgY29kZUJsb2NrSGFzaCwgIjoiLCBieXRl Y29kZUluZGV4KTsKKyAgICAgICAgU3RyaW5nIGZyYW1lRGVzY3JpcHRpb24gPSBtYWtlU3RyaW5n KGZyYW1lLmRpc3BsYXlOYW1lKG1fdm0pLCAiIyIsIGNvZGVCbG9ja0hhc2gsICI6IiwgSklUQ29k ZTo6dHlwZU5hbWUoZnJhbWUuaml0VHlwZSksICI6IiwgYnl0ZWNvZGVJbmRleCk7CiAgICAgICAg IGJ5dGVjb2RlQ291bnRzLmFkZChmcmFtZURlc2NyaXB0aW9uLCAwKS5pdGVyYXRvci0+dmFsdWUr KzsKICAgICB9CiAKQEAgLTg1MSw3ICs4NTMsNyBAQCB2b2lkIFNhbXBsaW5nUHJvZmlsZXI6OnJl cG9ydFRvcEJ5dGVjb2RlCiAgICAgfTsKIAogICAgIGRhdGFMb2coIlxuXG5TYW1wbGluZyByYXRl OiAiLCBtX3RpbWluZ0ludGVydmFsLmNvdW50KCksICIgbWljcm9zZWNvbmRzXG4iKTsKLSAgICBk YXRhTG9nKCJIb3R0ZXN0IGJ5dGVjb2RlcyBhcyA8bnVtU2FtcGxlcyAgICdmdW5jdGlvbk5hbWUj aGFzaDpieXRlY29kZUluZGV4Jz5cbiIpOworICAgIGRhdGFMb2coIkhvdHRlc3QgYnl0ZWNvZGVz IGFzIDxudW1TYW1wbGVzICAgJ2Z1bmN0aW9uTmFtZSNoYXNoOkpJVFR5cGU6Ynl0ZWNvZGVJbmRl eCc+XG4iKTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IDgwOyBpKyspIHsKICAgICAgICAg YXV0byBwYWlyID0gdGFrZU1heCgpOwogICAgICAgICBpZiAocGFpci5maXJzdC5pc0VtcHR5KCkp CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9m aWxlci5oCShyZXZpc2lvbiAxOTk3OTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9TYW1wbGluZ1Byb2ZpbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDcgQEAKIAog I2luY2x1ZGUgIkNhbGxGcmFtZS5oIgogI2luY2x1ZGUgIkNvZGVCbG9ja0hhc2guaCIKKyNpbmNs dWRlICJKSVRDb2RlLmgiCiAjaW5jbHVkZSAiTWFjaGluZVN0YWNrTWFya2VyLmgiCiAjaW5jbHVk ZSA8d3RmL0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvTG9jay5oPgpAQCAtODYsNiArODcsNyBA QCBwdWJsaWM6CiAgICAgICAgIHVuc2lnbmVkIGNvbHVtbk51bWJlciB7IHN0ZDo6bnVtZXJpY19s aW1pdHM8dW5zaWduZWQ+OjptYXgoKSB9OwogICAgICAgICB1bnNpZ25lZCBieXRlY29kZUluZGV4 IHsgc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpIH07CiAgICAgICAgIENvZGVC bG9ja0hhc2ggY29kZUJsb2NrSGFzaDsKKyAgICAgICAgSklUQ29kZTo6SklUVHlwZSBqaXRUeXBl IHsgSklUQ29kZTo6Tm9uZSB9OwogCiAgICAgICAgIGJvb2wgaGFzRXhwcmVzc2lvbkluZm8oKSBj b25zdAogICAgICAgICB7Cg==