156807 2016-04-20 13:31:28 -0700 We don't need a manual stack for an RAII object when the machine's stack will do just fine 2016-04-20 14:47:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1185526 0 saam 2016-04-20 13:31:28 -0700 ... 1185527 1 oliver 2016-04-20 13:32:36 -0700 need moar context? 1185528 2 276849 saam 2016-04-20 13:36:18 -0700 Created attachment 276849 patch 1185529 3 276849 mark.lam 2016-04-20 13:39:11 -0700 Comment on attachment 276849 patch r=me 1185550 4 saam 2016-04-20 14:47:41 -0700 landed in: http://trac.webkit.org/changeset/199787 276849 2016-04-20 13:36:18 -0700 2016-04-20 13:39:11 -0700 patch b-backup.diff text/plain 2991 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5NzgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE2LTA0LTIwICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlIGRvbid0IG5lZWQgYSBtYW51YWwgc3RhY2sgZm9yIGFuIFJBSUkgb2JqZWN0IHdoZW4gdGhl IG1hY2hpbmUncyBzdGFjayB3aWxsIGRvIGp1c3QgZmluZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2ODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Uga2VwdCBhcm91bmQgYSB2ZWN0b3IgZm9yIGFu IFJBSUkgb2JqZWN0IHRvIG1haW50YWluCisgICAgICAgIHRoZSByZWN1cnNpdmUgbmF0dXJlIG9m IGhhdmluZyB0aGVzZSBSQUlJIG9iamVjdHMgb24KKyAgICAgICAgdGhlIHN0YWNrIGFzIHRoZSBw YXJzZXIgcmVjdXJzZWQuIEluc3RlYWQsIHRoZSBSQUlJIG9iamVjdAorICAgICAgICBjYW4ganVz dCBoYXZlIGEgZmllbGQgd2l0aCB0aGUgdmFsdWUgaXQgd2FudHMgdG8gcmVzdG9yZQorICAgICAg ICBhbmQgdXNlIHRoZSBtYWNoaW5lJ3Mgc3RhY2suCisKKyAgICAgICAgVGhpcyBpcyBhIDElIG9j dGFuZSBjb2RlLWxvYWQgcHJvZ3Jlc3Npb24uCisKKyAgICAgICAgKiBwYXJzZXIvU3ludGF4Q2hl Y2tlci5oOgorICAgICAgICAoSlNDOjpTeW50YXhDaGVja2VyOjpCaW5hcnlFeHByQ29udGV4dDo6 QmluYXJ5RXhwckNvbnRleHQpOgorICAgICAgICAoSlNDOjpTeW50YXhDaGVja2VyOjpCaW5hcnlF eHByQ29udGV4dDo6fkJpbmFyeUV4cHJDb250ZXh0KToKKyAgICAgICAgKEpTQzo6U3ludGF4Q2hl Y2tlcjo6VW5hcnlFeHByQ29udGV4dDo6VW5hcnlFeHByQ29udGV4dCk6CisgICAgICAgIChKU0M6 OlN5bnRheENoZWNrZXI6OlVuYXJ5RXhwckNvbnRleHQ6On5VbmFyeUV4cHJDb250ZXh0KToKKyAg ICAgICAgKEpTQzo6U3ludGF4Q2hlY2tlcjo6b3BlcmF0b3JTdGFja1BvcCk6CisKIDIwMTYtMDQt MjAgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTihyMTkwMjg5KTogU3BpbiB0cnlpbmcgdG8gdmlldy9zaWduIGluIHRvIGhib2dvLmNvbQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9TeW50YXhDaGVja2VyLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9TeW50YXhDaGVja2VyLmgJKHJl dmlzaW9uIDE5OTc0NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU3ludGF4Q2hl Y2tlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOCwzMCArMzgsMzAgQEAgcHVibGljOgogICAgICAg ICBCaW5hcnlFeHByQ29udGV4dChTeW50YXhDaGVja2VyJiBjb250ZXh0KQogICAgICAgICAgICAg OiBtX2NvbnRleHQoJmNvbnRleHQpCiAgICAgICAgIHsKLSAgICAgICAgICAgIG1fY29udGV4dC0+ bV90b3BCaW5hcnlFeHBycy5hcHBlbmQobV9jb250ZXh0LT5tX3RvcEJpbmFyeUV4cHIpOworICAg ICAgICAgICAgbV90b2tlbiA9IG1fY29udGV4dC0+bV90b3BCaW5hcnlFeHByOwogICAgICAgICAg ICAgbV9jb250ZXh0LT5tX3RvcEJpbmFyeUV4cHIgPSAwOwogICAgICAgICB9CiAgICAgICAgIH5C aW5hcnlFeHByQ29udGV4dCgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIG1fY29udGV4dC0+bV90 b3BCaW5hcnlFeHByID0gbV9jb250ZXh0LT5tX3RvcEJpbmFyeUV4cHJzLmxhc3QoKTsKLSAgICAg ICAgICAgIG1fY29udGV4dC0+bV90b3BCaW5hcnlFeHBycy5yZW1vdmVMYXN0KCk7CisgICAgICAg ICAgICBtX2NvbnRleHQtPm1fdG9wQmluYXJ5RXhwciA9IG1fdG9rZW47CiAgICAgICAgIH0KICAg ICBwcml2YXRlOgorICAgICAgICBpbnQgbV90b2tlbjsKICAgICAgICAgU3ludGF4Q2hlY2tlciog bV9jb250ZXh0OwogICAgIH07CiAgICAgc3RydWN0IFVuYXJ5RXhwckNvbnRleHQgewogICAgICAg ICBVbmFyeUV4cHJDb250ZXh0KFN5bnRheENoZWNrZXImIGNvbnRleHQpCiAgICAgICAgICAgICA6 IG1fY29udGV4dCgmY29udGV4dCkKICAgICAgICAgewotICAgICAgICAgICAgbV9jb250ZXh0LT5t X3RvcFVuYXJ5VG9rZW5zLmFwcGVuZChtX2NvbnRleHQtPm1fdG9wVW5hcnlUb2tlbik7CisgICAg ICAgICAgICBtX3Rva2VuID0gbV9jb250ZXh0LT5tX3RvcFVuYXJ5VG9rZW47CiAgICAgICAgICAg ICBtX2NvbnRleHQtPm1fdG9wVW5hcnlUb2tlbiA9IDA7CiAgICAgICAgIH0KICAgICAgICAgflVu YXJ5RXhwckNvbnRleHQoKQogICAgICAgICB7Ci0gICAgICAgICAgICBtX2NvbnRleHQtPm1fdG9w VW5hcnlUb2tlbiA9IG1fY29udGV4dC0+bV90b3BVbmFyeVRva2Vucy5sYXN0KCk7Ci0gICAgICAg ICAgICBtX2NvbnRleHQtPm1fdG9wVW5hcnlUb2tlbnMucmVtb3ZlTGFzdCgpOworICAgICAgICAg ICAgbV9jb250ZXh0LT5tX3RvcFVuYXJ5VG9rZW4gPSBtX3Rva2VuOwogICAgICAgICB9CiAgICAg cHJpdmF0ZToKKyAgICAgICAgaW50IG1fdG9rZW47CiAgICAgICAgIFN5bnRheENoZWNrZXIqIG1f Y29udGV4dDsKICAgICB9OwogICAgIApAQCAtMzk3LDggKzM5Nyw2IEBAIHB1YmxpYzoKIHByaXZh dGU6CiAgICAgaW50IG1fdG9wQmluYXJ5RXhwcjsKICAgICBpbnQgbV90b3BVbmFyeVRva2VuOwot ICAgIFZlY3RvcjxpbnQsIDg+IG1fdG9wQmluYXJ5RXhwcnM7Ci0gICAgVmVjdG9yPGludCwgOD4g bV90b3BVbmFyeVRva2VuczsKIH07CiAKIH0K