156806 2016-04-20 12:57:20 -0700 Crash under needsAppleMailPaginationQuirk() 2016-04-21 09:15:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=156852 InRadar P2 Normal --- 1 cdumez cdumez bdakin commit-queue darin esprehn+autocc glenn kondapallykalyan simon.fraser webkit-bug-importer zalan oldest_to_newest 1185514 0 cdumez 2016-04-20 12:57:20 -0700 Stop repeatedly atomizing string in needsAppleMailPaginationQuirk() and instead leverage the operator==(const AtomicString&, const char*). 1185515 1 276846 cdumez 2016-04-20 13:04:15 -0700 Created attachment 276846 Patch 1185516 2 cdumez 2016-04-20 13:08:24 -0700 rdar://problem/23323479 1185517 3 cdumez 2016-04-20 13:08:37 -0700 [ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WTF::String::impl() const at WTFString.h:153 [ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WTF::AtomicString::impl() const at AtomicString.h:94 [ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WTF::operator==(WTF::AtomicString const&, WTF::AtomicString const&) at AtomicString.h:194 [ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WebCore::needsAppleMailPaginationQuirk(WebCore::RootInlineBox&) + 101 at RenderBlockFlow.cpp:1623 [ 0] 0x00007fff9635251d WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) + 2141 at RenderBlockFlow.cpp:1711 [ 1] 0x00007fff9635de9c WebCore`WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int) + 4748 at RenderBlockLineLayout.cpp:1306:21 [ 2] 0x00007fff9635b6af WebCore`WebCore::RenderBlockFlow::layoutRunsAndFloats(WebCore::LineLayoutState&, bool) + 1167 at RenderBlockLineLayout.cpp:1202:5 [ 3] 0x00007fff9635fa9b WebCore`WebCore::RenderBlockFlow::layoutLineBoxes(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&) + 2219 at RenderBlockLineLayout.cpp:1612:9 [ 4] 0x00007fff9634bb7d WebCore`WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) + 941 at RenderBlockFlow.cpp:483:9 1185518 4 276847 cdumez 2016-04-20 13:13:30 -0700 Created attachment 276847 Patch 1185532 5 276847 commit-queue 2016-04-20 14:06:44 -0700 Comment on attachment 276847 Patch Clearing flags on attachment: 276847 Committed r199784: <http://trac.webkit.org/changeset/199784> 1185533 6 commit-queue 2016-04-20 14:06:50 -0700 All reviewed patches have been landed. Closing bug. 276846 2016-04-20 13:04:15 -0700 2016-04-20 13:13:26 -0700 Patch bug-156806-20160420130436.patch text/plain 1656 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRmNWM3MTZlOGFiM2E5 ZTNkMzAzZTc4NDJkZmMwODQyZGQ2MjcwZC4uMTMyODk3NDA4Zjc0MTVkMzZlYmRhZjc1MTU0YWRl NDIwZmY3ZGI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA0LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCByZXBlYXRlZGx5IGF0 b21pemluZyBzdHJpbmcgaW4gbmVlZHNBcHBsZU1haWxQYWdpbmF0aW9uUXVpcmsoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2ODA2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCByZXBlYXRlZGx5 IGF0b21pemluZyBzdHJpbmcgaW4gbmVlZHNBcHBsZU1haWxQYWdpbmF0aW9uUXVpcmsoKSBhbmQg aW5zdGVhZAorICAgICAgICBsZXZlcmFnZSB0aGUgb3BlcmF0b3I9PShjb25zdCBBdG9taWNTdHJp bmcmLCBjb25zdCBjaGFyKikuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om5lZWRzQXBwbGVNYWlsUGFnaW5hdGlvblF1aXJrKToK KwogMjAxNi0wNC0yMCAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBI YW5nYWJsZSBwdW5jdHVhdGlvbiBtZWFzdXJlbWVudCB1c2luZyB0aGUgd3JvbmcgaW5kaWNlcy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggMGZm ZjAyZWQ3ODFjZjIyZDNhMzViYzNiY2Q4NWM4ZDZmMTk0NmU3ZC4uMzhhNDE0OGYxMWJkZWFiOGYx NTgxNmY1ZjFjMGZjMjEyNTY1OGQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrRmxvdy5jcHAKQEAgLTE2NDMsNyArMTY0Myw3IEBAIHN0YXRpYyBpbmxpbmUgYm9v bCBuZWVkc0FwcGxlTWFpbFBhZ2luYXRpb25RdWlyayhSb290SW5saW5lQm94JiBsaW5lQm94KQog ICAgIGlmICghcmVuZGVyZXIuZG9jdW1lbnQoKS5zZXR0aW5ncygpLT5hcHBsZU1haWxQYWdpbmF0 aW9uUXVpcmtFbmFibGVkKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGlmIChyZW5k ZXJlci5lbGVtZW50KCkgJiYgcmVuZGVyZXIuZWxlbWVudCgpLT5pZEZvclN0eWxlUmVzb2x1dGlv bigpID09IEF0b21pY1N0cmluZygibWVzc2FnZUNvbnRlbnRDb250YWluZXIiLCBBdG9taWNTdHJp bmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKSkKKyAgICBpZiAocmVuZGVyZXIuZWxlbWVudCgpICYm IHJlbmRlcmVyLmVsZW1lbnQoKS0+aWRGb3JTdHlsZVJlc29sdXRpb24oKSA9PSAibWVzc2FnZUNv bnRlbnRDb250YWluZXIiKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIHJldHVybiBmYWxz ZTsK 276847 2016-04-20 13:13:30 -0700 2016-04-20 14:06:44 -0700 Patch bug-156806-20160420131351.patch text/plain 1877 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRmNWM3MTZlOGFiM2E5 ZTNkMzAzZTc4NDJkZmMwODQyZGQ2MjcwZC4uMzIxMTQwMTc1OWIyNmFhNDZiZWM1NzAyNzdjNmVj OGY5YTQ4OTJkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA0LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggdW5kZXIgbmVlZHNB cHBsZU1haWxQYWdpbmF0aW9uUXVpcmsoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU2ODA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMzMyMzQ3 OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg Y2hlY2sgZm9yIGVsZW1lbnQoKS0+aGFzSUQoKSBiZWZvcmUgY2FsbGluZyBlbGVtZW50KCktPmlk Rm9yU3R5bGVSZXNvbHV0aW9uKCkKKyAgICAgICAgc28gdGhhdCB3ZSBkb24ndCBkZXJlZmVyZW5j ZSBhIHBvdGVudGlhbGx5IG51bGwgZWxlbWVudCgpLT5lbGVtZW50RGF0YSgpLgorICAgICAgICBB bHNvIHN0b3AgcmVwZWF0ZWRseSBhdG9taXppbmcgIm1lc3NhZ2VDb250ZW50Q29udGFpbmVyIiBh bmQgbGV2ZXJhZ2UKKyAgICAgICAgdGhlIG9wZXJhdG9yPT0oY29uc3QgQXRvbWljU3RyaW5nJiwg Y29uc3QgY2hhciopIGluc3RlYWQgZm9yIHBlcmZvcm1hbmNlLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpuZWVkc0FwcGxlTWFp bFBhZ2luYXRpb25RdWlyayk6CisKIDIwMTYtMDQtMjAgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBs ZS5jb20+CiAKICAgICAgICAgSGFuZ2FibGUgcHVuY3R1YXRpb24gbWVhc3VyZW1lbnQgdXNpbmcg dGhlIHdyb25nIGluZGljZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j a0Zsb3cuY3BwCmluZGV4IDBmZmYwMmVkNzgxY2YyMmQzYTM1YmMzYmNkODVjOGQ2ZjE5NDZlN2Qu LjY5NDIzODQwYTZjODM2ZmI3ODViMDc3ZTU5N2M1ZWQ5ZjA0MTQ1ZWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0xNjQzLDcgKzE2NDMsNyBA QCBzdGF0aWMgaW5saW5lIGJvb2wgbmVlZHNBcHBsZU1haWxQYWdpbmF0aW9uUXVpcmsoUm9vdElu bGluZUJveCYgbGluZUJveCkKICAgICBpZiAoIXJlbmRlcmVyLmRvY3VtZW50KCkuc2V0dGluZ3Mo KS0+YXBwbGVNYWlsUGFnaW5hdGlvblF1aXJrRW5hYmxlZCgpKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAKLSAgICBpZiAocmVuZGVyZXIuZWxlbWVudCgpICYmIHJlbmRlcmVyLmVsZW1lbnQoKS0+ aWRGb3JTdHlsZVJlc29sdXRpb24oKSA9PSBBdG9taWNTdHJpbmcoIm1lc3NhZ2VDb250ZW50Q29u dGFpbmVyIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpCisgICAgaWYgKHJl bmRlcmVyLmVsZW1lbnQoKSAmJiByZW5kZXJlci5lbGVtZW50KCktPmhhc0lEKCkgJiYgcmVuZGVy ZXIuZWxlbWVudCgpLT5pZEZvclN0eWxlUmVzb2x1dGlvbigpID09ICJtZXNzYWdlQ29udGVudENv bnRhaW5lciIpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgcmV0dXJuIGZhbHNlOwo=