<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>156802</bug_id>
          
          <creation_ts>2016-04-20 11:48:53 -0700</creation_ts>
          <short_desc>Unindent an unnecessary block in stringProtoFuncSplitFast().</short_desc>
          <delta_ts>2016-04-22 11:36:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>keith_miller</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1185486</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-04-20 11:48:53 -0700</bug_when>
    <thetext>In webkit.org/b/156013, I refactored stringProtoFunc into stringProtoFuncSplit.  In that patch, I left an unnecessary block of code in its original block (with FIXMEs) to keep the diff for that patch minimal.  Now that the patch for webkit.org/b/156013 has landed, I will unindent that block and remove the FIXMEs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1185487</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-04-20 11:50:35 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; In webkit.org/b/156013, I refactored stringProtoFunc into
&gt; stringProtoFuncSplit.  In that patch, I left an unnecessary block of code in
&gt; its original block (with FIXMEs) to keep the diff for that patch minimal. 
&gt; Now that the patch for webkit.org/b/156013 has landed, I will unindent that
&gt; block and remove the FIXMEs.

typo: /stringProtoFunc/stringProtoFuncSplit/ and /stringProtoFuncSplit/stringProtoFuncSplitFast/.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1185488</commentid>
    <comment_count>2</comment_count>
      <attachid>276838</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-04-20 11:55:41 -0700</bug_when>
    <thetext>Created attachment 276838
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1185501</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-04-20 12:11:22 -0700</bug_when>
    <thetext>Landed in r199780: &lt;http://trac.webkit.org/r199780&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1186340</commentid>
    <comment_count>4</comment_count>
      <attachid>276838</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-04-22 11:36:09 -0700</bug_when>
    <thetext>Comment on attachment 276838
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=276838&amp;action=review

&gt; Source/JavaScriptCore/runtime/StringPrototype.cpp:1191
&gt; +    String separator = separatorValue.toString(exec)-&gt;value(exec);

Seems we should always use toWTFString instead of writing it out like this.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>276838</attachid>
            <date>2016-04-20 11:55:41 -0700</date>
            <delta_ts>2016-04-20 11:57:49 -0700</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-156802.patch</filename>
            <type>text/plain</type>
            <size>9164</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5Nzc4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA
CisyMDE2LTA0LTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBV
bmluZGVudCBhbiB1bm5lY2Vzc2FyeSBibG9jayBpbiBzdHJpbmdQcm90b0Z1bmNTcGxpdEZhc3Qo
KS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Njgw
MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHdl
YmtpdC5vcmcvYi8xNTYwMTMsIEkgcmVmYWN0b3JlZCBzdHJpbmdQcm90b0Z1bmNTcGxpdCBpbnRv
CisgICAgICAgIHN0cmluZ1Byb3RvRnVuY1NwbGl0RmFzdC4gIEluIHRoYXQgcGF0Y2gsIEkgbGVm
dCBhbiB1bm5lY2Vzc2FyeSBibG9jayBvZiBjb2RlIGluCisgICAgICAgIGl0cyBvcmlnaW5hbCBi
bG9jayAod2l0aCBGSVhNRXMpIHRvIGtlZXAgdGhlIGRpZmYgZm9yIHRoYXQgcGF0Y2ggbWluaW1h
bC4gIE5vdworICAgICAgICB0aGF0IHRoZSBwYXRjaCBmb3Igd2Via2l0Lm9yZy9iLzE1NjAxMyBo
YXMgbGFuZGVkLCBJIHdpbGwgdW5pbmRlbnQgdGhhdCBibG9jayBhbmQKKyAgICAgICAgcmVtb3Zl
IHRoZSBGSVhNRXMuCisKKyAgICAgICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHA6Cisg
ICAgICAgIChKU0M6OnN0cmluZ1Byb3RvRnVuY1NwbGl0RmFzdCk6CisKIDIwMTYtMDQtMjAgIFNh
YW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBt
X3dyaXR0ZW5WYXJpYWJsZXMgZnJvbSB0aGUgcGFyc2VyIGFuZCByZWxhdGVkIGJpdHMKSW5kZXg6
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNw
cAkocmV2aXNpb24gMTk5Nzc3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3Ry
aW5nUHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE4OCw5MiArMTE4OCw5MCBAQCBF
bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIHN0cmluZ1Byb3RvCiAgICAgLy8gOS4gSWYgc2Vw
YXJhdG9yIGlzIGEgUmVnRXhwIG9iamVjdCAoaXRzIFtbQ2xhc3NdXSBpcyAiUmVnRXhwIiksIGxl
dCBSID0gc2VwYXJhdG9yOwogICAgIC8vICAgIG90aGVyd2lzZSBsZXQgUiA9IFRvU3RyaW5nKHNl
cGFyYXRvcikuCiAgICAgSlNWYWx1ZSBzZXBhcmF0b3JWYWx1ZSA9IGV4ZWMtPnVuY2hlY2tlZEFy
Z3VtZW50KDApOwotICAgIHsgLy8gRklYTUU6IEtlZXBpbmcgdGhpcyBpbmRlbnRhdGlvbiBoZXJl
IHRvIG1pbmltaXplIHRoZSBkaWZmLiBXaWxsIHVuaW5kZW50IGFuZCByZW1vdmUgdGhpcyBsYXRl
ci4KLSAgICAgICAgU3RyaW5nIHNlcGFyYXRvciA9IHNlcGFyYXRvclZhbHVlLnRvU3RyaW5nKGV4
ZWMpLT52YWx1ZShleGVjKTsKLSAgICAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQotICAg
ICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKKyAgICBTdHJp
bmcgc2VwYXJhdG9yID0gc2VwYXJhdG9yVmFsdWUudG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4ZWMp
OworICAgIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6
OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIAotICAgICAgICAvLyAxMC4gSWYgbGltID09IDAsIHJl
dHVybiBBLgotICAgICAgICBpZiAoIWxpbWl0KQotICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6
OmVuY29kZShyZXN1bHQpOwotCi0gICAgICAgIC8vIDExLiBJZiBzZXBhcmF0b3IgaXMgdW5kZWZp
bmVkLCB0aGVuCi0gICAgICAgIGlmIChzZXBhcmF0b3JWYWx1ZS5pc1VuZGVmaW5lZCgpKSB7Ci0g
ICAgICAgICAgICAvLyBhLiAgQ2FsbCB0aGUgW1tEZWZpbmVPd25Qcm9wZXJ0eV1dIGludGVybmFs
IG1ldGhvZCBvZiBBIHdpdGggYXJndW1lbnRzICIwIiwKLSAgICAgICAgICAgIHJlc3VsdC0+cHV0
RGlyZWN0SW5kZXgoZXhlYywgMCwganNTdHJpbmdXaXRoUmV1c2UoZXhlYywgdGhpc1ZhbHVlLCBp
bnB1dCkpOwotICAgICAgICAgICAgLy8gYi4gIFJldHVybiBBLgotICAgICAgICAgICAgcmV0dXJu
IEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwotICAgICAgICB9CisgICAgLy8gMTAuIElmIGxpbSA9
PSAwLCByZXR1cm4gQS4KKyAgICBpZiAoIWxpbWl0KQorICAgICAgICByZXR1cm4gSlNWYWx1ZTo6
ZW5jb2RlKHJlc3VsdCk7CiAKLSAgICAgICAgLy8gMTIuIElmIHMgPT0gMCwgdGhlbgotICAgICAg
ICBpZiAoaW5wdXQuaXNFbXB0eSgpKSB7Ci0gICAgICAgICAgICAvLyBhLiBMZXQgeiBiZSBTcGxp
dE1hdGNoKFMsIDAsIFIpIHdoZXJlIFMgaXMgaW5wdXQsIFIgaXMgc2VwYXJhdG9yLgotICAgICAg
ICAgICAgLy8gYi4gSWYgeiBpcyBub3QgZmFsc2UsIHJldHVybiBBLgotICAgICAgICAgICAgLy8g
Yy4gQ2FsbCBDcmVhdGVEYXRhUHJvcGVydHkoQSwgIjAiLCBTKS4KLSAgICAgICAgICAgIC8vIGQu
IFJldHVybiBBLgotICAgICAgICAgICAgaWYgKCFzZXBhcmF0b3IuaXNFbXB0eSgpKQotICAgICAg
ICAgICAgICAgIHJlc3VsdC0+cHV0RGlyZWN0SW5kZXgoZXhlYywgMCwganNTdHJpbmdXaXRoUmV1
c2UoZXhlYywgdGhpc1ZhbHVlLCBpbnB1dCkpOwotICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6
OmVuY29kZShyZXN1bHQpOwotICAgICAgICB9CisgICAgLy8gMTEuIElmIHNlcGFyYXRvciBpcyB1
bmRlZmluZWQsIHRoZW4KKyAgICBpZiAoc2VwYXJhdG9yVmFsdWUuaXNVbmRlZmluZWQoKSkgewor
ICAgICAgICAvLyBhLiBDYWxsIHRoZSBbW0RlZmluZU93blByb3BlcnR5XV0gaW50ZXJuYWwgbWV0
aG9kIG9mIEEgd2l0aCBhcmd1bWVudHMgIjAiLAorICAgICAgICByZXN1bHQtPnB1dERpcmVjdElu
ZGV4KGV4ZWMsIDAsIGpzU3RyaW5nV2l0aFJldXNlKGV4ZWMsIHRoaXNWYWx1ZSwgaW5wdXQpKTsK
KyAgICAgICAgLy8gYi4gUmV0dXJuIEEuCisgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo
cmVzdWx0KTsKKyAgICB9CiAKLSAgICAgICAgLy8gT3B0aW1pemVkIGNhc2UgZm9yIHNwbGl0dGlu
ZyBvbiB0aGUgZW1wdHkgc3RyaW5nLgotICAgICAgICBpZiAoc2VwYXJhdG9yLmlzRW1wdHkoKSkg
ewotICAgICAgICAgICAgbGltaXQgPSBzdGQ6Om1pbihsaW1pdCwgaW5wdXQubGVuZ3RoKCkpOwot
ICAgICAgICAgICAgLy8gWmVybyBsaW10L2lucHV0IGxlbmd0aCBoYW5kbGVkIGluIHN0ZXBzIDkv
MTEgcmVzcGVjdGl2ZWx5LCBhYm92ZS4KLSAgICAgICAgICAgIEFTU0VSVChsaW1pdCk7Ci0KLSAg
ICAgICAgICAgIGRvIHsKLSAgICAgICAgICAgICAgICByZXN1bHQtPnB1dERpcmVjdEluZGV4KGV4
ZWMsIHBvc2l0aW9uLCBqc1NpbmdsZUNoYXJhY3RlclN0cmluZyhleGVjLCBpbnB1dFtwb3NpdGlv
bl0pKTsKLSAgICAgICAgICAgIH0gd2hpbGUgKCsrcG9zaXRpb24gPCBsaW1pdCk7CisgICAgLy8g
MTIuIElmIHMgPT0gMCwgdGhlbgorICAgIGlmIChpbnB1dC5pc0VtcHR5KCkpIHsKKyAgICAgICAg
Ly8gYS4gTGV0IHogYmUgU3BsaXRNYXRjaChTLCAwLCBSKSB3aGVyZSBTIGlzIGlucHV0LCBSIGlz
IHNlcGFyYXRvci4KKyAgICAgICAgLy8gYi4gSWYgeiBpcyBub3QgZmFsc2UsIHJldHVybiBBLgor
ICAgICAgICAvLyBjLiBDYWxsIENyZWF0ZURhdGFQcm9wZXJ0eShBLCAiMCIsIFMpLgorICAgICAg
ICAvLyBkLiBSZXR1cm4gQS4KKyAgICAgICAgaWYgKCFzZXBhcmF0b3IuaXNFbXB0eSgpKQorICAg
ICAgICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVjLCAwLCBqc1N0cmluZ1dpdGhSZXVz
ZShleGVjLCB0aGlzVmFsdWUsIGlucHV0KSk7CisgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNv
ZGUocmVzdWx0KTsKKyAgICB9CiAKLSAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo
cmVzdWx0KTsKLSAgICAgICAgfQorICAgIC8vIE9wdGltaXplZCBjYXNlIGZvciBzcGxpdHRpbmcg
b24gdGhlIGVtcHR5IHN0cmluZy4KKyAgICBpZiAoc2VwYXJhdG9yLmlzRW1wdHkoKSkgeworICAg
ICAgICBsaW1pdCA9IHN0ZDo6bWluKGxpbWl0LCBpbnB1dC5sZW5ndGgoKSk7CisgICAgICAgIC8v
IFplcm8gbGltdC9pbnB1dCBsZW5ndGggaGFuZGxlZCBpbiBzdGVwcyA5LzExIHJlc3BlY3RpdmVs
eSwgYWJvdmUuCisgICAgICAgIEFTU0VSVChsaW1pdCk7CisKKyAgICAgICAgZG8geworICAgICAg
ICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVjLCBwb3NpdGlvbiwganNTaW5nbGVDaGFy
YWN0ZXJTdHJpbmcoZXhlYywgaW5wdXRbcG9zaXRpb25dKSk7CisgICAgICAgIH0gd2hpbGUgKCsr
cG9zaXRpb24gPCBsaW1pdCk7CisKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1
bHQpOworICAgIH0KKworICAgIC8vIDMgY2FzZXM6CisgICAgLy8gLXNlcGFyYXRvciBsZW5ndGgg
PT0gMSwgOCBiaXRzCisgICAgLy8gLXNlcGFyYXRvciBsZW5ndGggPT0gMSwgMTYgYml0cworICAg
IC8vIC1zZXBhcmF0b3IgbGVuZ3RoID4gMQorICAgIFN0cmluZ0ltcGwqIHN0cmluZ0ltcGwgPSBp
bnB1dC5pbXBsKCk7CisgICAgU3RyaW5nSW1wbCogc2VwYXJhdG9ySW1wbCA9IHNlcGFyYXRvci5p
bXBsKCk7CisgICAgc2l6ZV90IHNlcGFyYXRvckxlbmd0aCA9IHNlcGFyYXRvckltcGwtPmxlbmd0
aCgpOworCisgICAgaWYgKHNlcGFyYXRvckxlbmd0aCA9PSAxKSB7CisgICAgICAgIFVDaGFyIHNl
cGFyYXRvckNoYXJhY3RlcjsKKyAgICAgICAgaWYgKHNlcGFyYXRvckltcGwtPmlzOEJpdCgpKQor
ICAgICAgICAgICAgc2VwYXJhdG9yQ2hhcmFjdGVyID0gc2VwYXJhdG9ySW1wbC0+Y2hhcmFjdGVy
czgoKVswXTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgc2VwYXJhdG9yQ2hhcmFjdGVyID0g
c2VwYXJhdG9ySW1wbC0+Y2hhcmFjdGVyczE2KClbMF07CiAKLSAgICAgICAgLy8gMyBjYXNlczoK
LSAgICAgICAgLy8gLXNlcGFyYXRvciBsZW5ndGggPT0gMSwgOCBiaXRzCi0gICAgICAgIC8vIC1z
ZXBhcmF0b3IgbGVuZ3RoID09IDEsIDE2IGJpdHMKLSAgICAgICAgLy8gLXNlcGFyYXRvciBsZW5n
dGggPiAxCi0gICAgICAgIFN0cmluZ0ltcGwqIHN0cmluZ0ltcGwgPSBpbnB1dC5pbXBsKCk7Ci0g
ICAgICAgIFN0cmluZ0ltcGwqIHNlcGFyYXRvckltcGwgPSBzZXBhcmF0b3IuaW1wbCgpOwotICAg
ICAgICBzaXplX3Qgc2VwYXJhdG9yTGVuZ3RoID0gc2VwYXJhdG9ySW1wbC0+bGVuZ3RoKCk7Ci0K
LSAgICAgICAgaWYgKHNlcGFyYXRvckxlbmd0aCA9PSAxKSB7Ci0gICAgICAgICAgICBVQ2hhciBz
ZXBhcmF0b3JDaGFyYWN0ZXI7Ci0gICAgICAgICAgICBpZiAoc2VwYXJhdG9ySW1wbC0+aXM4Qml0
KCkpCi0gICAgICAgICAgICAgICAgc2VwYXJhdG9yQ2hhcmFjdGVyID0gc2VwYXJhdG9ySW1wbC0+
Y2hhcmFjdGVyczgoKVswXTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBzZXBh
cmF0b3JDaGFyYWN0ZXIgPSBzZXBhcmF0b3JJbXBsLT5jaGFyYWN0ZXJzMTYoKVswXTsKLQotICAg
ICAgICAgICAgaWYgKHN0cmluZ0ltcGwtPmlzOEJpdCgpKSB7Ci0gICAgICAgICAgICAgICAgaWYg
KHNwbGl0U3RyaW5nQnlPbmVDaGFyYWN0ZXJJbXBsPExDaGFyPihleGVjLCByZXN1bHQsIHRoaXNW
YWx1ZSwgaW5wdXQsIHN0cmluZ0ltcGwsIHNlcGFyYXRvckNoYXJhY3RlciwgcG9zaXRpb24sIHJl
c3VsdExlbmd0aCwgbGltaXQpKQotICAgICAgICAgICAgICAgICAgICByZXR1cm4gSlNWYWx1ZTo6
ZW5jb2RlKHJlc3VsdCk7Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIGlm
IChzcGxpdFN0cmluZ0J5T25lQ2hhcmFjdGVySW1wbDxVQ2hhcj4oZXhlYywgcmVzdWx0LCB0aGlz
VmFsdWUsIGlucHV0LCBzdHJpbmdJbXBsLCBzZXBhcmF0b3JDaGFyYWN0ZXIsIHBvc2l0aW9uLCBy
ZXN1bHRMZW5ndGgsIGxpbWl0KSkKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6
OmVuY29kZShyZXN1bHQpOwotICAgICAgICAgICAgfQorICAgICAgICBpZiAoc3RyaW5nSW1wbC0+
aXM4Qml0KCkpIHsKKyAgICAgICAgICAgIGlmIChzcGxpdFN0cmluZ0J5T25lQ2hhcmFjdGVySW1w
bDxMQ2hhcj4oZXhlYywgcmVzdWx0LCB0aGlzVmFsdWUsIGlucHV0LCBzdHJpbmdJbXBsLCBzZXBh
cmF0b3JDaGFyYWN0ZXIsIHBvc2l0aW9uLCByZXN1bHRMZW5ndGgsIGxpbWl0KSkKKyAgICAgICAg
ICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7CiAgICAgICAgIH0gZWxzZSB7
Ci0gICAgICAgICAgICAvLyAxMy4gTGV0IHEgPSBwLgotICAgICAgICAgICAgc2l6ZV90IG1hdGNo
UG9zaXRpb247Ci0gICAgICAgICAgICAvLyAxNC4gUmVwZWF0LCB3aGlsZSBxICE9IHMKLSAgICAg
ICAgICAgIC8vICAgYS4gbGV0IGUgYmUgU3BsaXRNYXRjaChTLCBxLCBSKS4KLSAgICAgICAgICAg
IC8vICAgYi4gSWYgZSBpcyBmYWlsdXJlLCB0aGVuIGxldCBxID0gcSsxLgotICAgICAgICAgICAg
Ly8gICBjLiBFbHNlLCBlIGlzIGFuIGludGVnZXIgaW5kZXggPD0gcy4KLSAgICAgICAgICAgIHdo
aWxlICgobWF0Y2hQb3NpdGlvbiA9IHN0cmluZ0ltcGwtPmZpbmQoc2VwYXJhdG9ySW1wbCwgcG9z
aXRpb24pKSAhPSBub3RGb3VuZCkgewotICAgICAgICAgICAgICAgIC8vIDEuIExldCBUIGJlIGEg
U3RyaW5nIHZhbHVlIGVxdWFsIHRvIHRoZSBzdWJzdHJpbmcgb2YgUyBjb25zaXN0aW5nIG9mIHRo
ZSBjaGFyYWN0ZXJzIGF0IHBvc2l0aW9ucyBwIChpbmNsdXNpdmUpCi0gICAgICAgICAgICAgICAg
Ly8gICAgdGhyb3VnaCBxIChleGNsdXNpdmUpLgotICAgICAgICAgICAgICAgIC8vIDIuIENhbGwg
Q3JlYXRlRGF0YVByb3BlcnR5KEEsIFRvU3RyaW5nKGxlbmd0aEEpLCBUKS4KLSAgICAgICAgICAg
ICAgICByZXN1bHQtPnB1dERpcmVjdEluZGV4KGV4ZWMsIHJlc3VsdExlbmd0aCwganNTdWJzdHJp
bmcoZXhlYywgdGhpc1ZhbHVlLCBpbnB1dCwgcG9zaXRpb24sIG1hdGNoUG9zaXRpb24gLSBwb3Np
dGlvbikpOwotICAgICAgICAgICAgICAgIC8vIDMuIEluY3JlbWVudCBsZW5ndGhBIGJ5IDEuCi0g
ICAgICAgICAgICAgICAgLy8gNC4gSWYgbGVuZ3RoQSA9PSBsaW0sIHJldHVybiBBLgotICAgICAg
ICAgICAgICAgIGlmICgrK3Jlc3VsdExlbmd0aCA9PSBsaW1pdCkKLSAgICAgICAgICAgICAgICAg
ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwotCi0gICAgICAgICAgICAgICAgLy8g
NS4gTGV0IHAgPSBlLgotICAgICAgICAgICAgICAgIC8vIDYuIExldCBxID0gcC4KLSAgICAgICAg
ICAgICAgICBwb3NpdGlvbiA9IG1hdGNoUG9zaXRpb24gKyBzZXBhcmF0b3IubGVuZ3RoKCk7Ci0g
ICAgICAgICAgICB9CisgICAgICAgICAgICBpZiAoc3BsaXRTdHJpbmdCeU9uZUNoYXJhY3Rlcklt
cGw8VUNoYXI+KGV4ZWMsIHJlc3VsdCwgdGhpc1ZhbHVlLCBpbnB1dCwgc3RyaW5nSW1wbCwgc2Vw
YXJhdG9yQ2hhcmFjdGVyLCBwb3NpdGlvbiwgcmVzdWx0TGVuZ3RoLCBsaW1pdCkpCisgICAgICAg
ICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwogICAgICAgICB9Ci0gICAg
fSAvLyBGSVhNRTogS2VlcGluZyB0aGlzIGluZGVudGF0aW9uIGhlcmUgdG8gbWluaW1pemUgdGhl
IGRpZmYuIFdpbGwgdW5pbmRlbnQgYW5kIHJlbW92ZSB0aGlzIGxhdGVyLgorICAgIH0gZWxzZSB7
CisgICAgICAgIC8vIDEzLiBMZXQgcSA9IHAuCisgICAgICAgIHNpemVfdCBtYXRjaFBvc2l0aW9u
OworICAgICAgICAvLyAxNC4gUmVwZWF0LCB3aGlsZSBxICE9IHMKKyAgICAgICAgLy8gICBhLiBs
ZXQgZSBiZSBTcGxpdE1hdGNoKFMsIHEsIFIpLgorICAgICAgICAvLyAgIGIuIElmIGUgaXMgZmFp
bHVyZSwgdGhlbiBsZXQgcSA9IHErMS4KKyAgICAgICAgLy8gICBjLiBFbHNlLCBlIGlzIGFuIGlu
dGVnZXIgaW5kZXggPD0gcy4KKyAgICAgICAgd2hpbGUgKChtYXRjaFBvc2l0aW9uID0gc3RyaW5n
SW1wbC0+ZmluZChzZXBhcmF0b3JJbXBsLCBwb3NpdGlvbikpICE9IG5vdEZvdW5kKSB7CisgICAg
ICAgICAgICAvLyAxLiBMZXQgVCBiZSBhIFN0cmluZyB2YWx1ZSBlcXVhbCB0byB0aGUgc3Vic3Ry
aW5nIG9mIFMgY29uc2lzdGluZyBvZiB0aGUgY2hhcmFjdGVycyBhdCBwb3NpdGlvbnMgcCAoaW5j
bHVzaXZlKQorICAgICAgICAgICAgLy8gICAgdGhyb3VnaCBxIChleGNsdXNpdmUpLgorICAgICAg
ICAgICAgLy8gMi4gQ2FsbCBDcmVhdGVEYXRhUHJvcGVydHkoQSwgVG9TdHJpbmcobGVuZ3RoQSks
IFQpLgorICAgICAgICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVjLCByZXN1bHRMZW5n
dGgsIGpzU3Vic3RyaW5nKGV4ZWMsIHRoaXNWYWx1ZSwgaW5wdXQsIHBvc2l0aW9uLCBtYXRjaFBv
c2l0aW9uIC0gcG9zaXRpb24pKTsKKyAgICAgICAgICAgIC8vIDMuIEluY3JlbWVudCBsZW5ndGhB
IGJ5IDEuCisgICAgICAgICAgICAvLyA0LiBJZiBsZW5ndGhBID09IGxpbSwgcmV0dXJuIEEuCisg
ICAgICAgICAgICBpZiAoKytyZXN1bHRMZW5ndGggPT0gbGltaXQpCisgICAgICAgICAgICAgICAg
cmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOworCisgICAgICAgICAgICAvLyA1LiBMZXQg
cCA9IGUuCisgICAgICAgICAgICAvLyA2LiBMZXQgcSA9IHAuCisgICAgICAgICAgICBwb3NpdGlv
biA9IG1hdGNoUG9zaXRpb24gKyBzZXBhcmF0b3IubGVuZ3RoKCk7CisgICAgICAgIH0KKyAgICB9
CiAKICAgICAvLyAxNS4gTGV0IFQgYmUgYSBTdHJpbmcgdmFsdWUgZXF1YWwgdG8gdGhlIHN1YnN0
cmluZyBvZiBTIGNvbnNpc3Rpbmcgb2YgdGhlIGNoYXJhY3RlcnMgYXQgcG9zaXRpb25zIHAgKGlu
Y2x1c2l2ZSkKICAgICAvLyAgICAgdGhyb3VnaCBzIChleGNsdXNpdmUpLgo=
</data>
<flag name="review"
          id="301104"
          type_id="1"
          status="+"
          setter="fpizlo"
    />
          </attachment>
      

    </bug>

</bugzilla>