156801 2016-04-20 11:39:00 -0700 Anchor element 'ping' property should only apply to http/https destinations 2016-04-22 13:57:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=156747 InRadar P2 Normal --- 1 bfulgham bfulgham ap beidson bfulgham cdumez commit-queue japhet mike webkit-bug-importer oldest_to_newest 1185481 0 bfulgham 2016-04-20 11:39:00 -0700 The HTML5 specification <https://developers.whatwg.org/links.html#ping> indicates: "The ping attribute, if present, gives the URLs of the resources that are interested in being notified if the user follows the hyperlink. The value must be a set of space-separated tokens, each of which must be a valid non-empty URL." Although the specification indicates that it must be a "valid non-empty URL", it doesn't really make sense to support anything besides http/https destinations. We should tighten up WebKit to ignore other protocols. 1185482 1 webkit-bug-importer 2016-04-20 11:40:06 -0700 <rdar://problem/25834419> 1185619 2 276870 bfulgham 2016-04-20 17:05:11 -0700 Created attachment 276870 Patch 1185849 3 276938 bfulgham 2016-04-21 11:08:26 -0700 Created attachment 276938 Patch 1185857 4 276938 cdumez 2016-04-21 11:20:59 -0700 Comment on attachment 276938 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276938&action=review > Source/WebCore/ChangeLog:14 > + Tested by http/tests/navigation/ping-attribute tests. Then why weren't this rebaselined? 1186277 5 bfulgham 2016-04-22 09:40:39 -0700 (In reply to comment #4) > Comment on attachment 276938 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=276938&action=review > > > Source/WebCore/ChangeLog:14 > > + Tested by http/tests/navigation/ping-attribute tests. > > Then why weren't this rebaselined? It just confirms expected behavior still works. WebKitTestRunner doesn't have a way to test that local files have not been read. 1186297 6 276938 cdumez 2016-04-22 10:21:28 -0700 Comment on attachment 276938 Patch r=me 1186415 7 276938 bfulgham 2016-04-22 13:57:02 -0700 Comment on attachment 276938 Patch Clearing flags on attachment: 276938 Committed r199900: <http://trac.webkit.org/changeset/199900> 1186416 8 bfulgham 2016-04-22 13:57:06 -0700 All reviewed patches have been landed. Closing bug. 276870 2016-04-20 17:05:11 -0700 2016-04-21 11:08:22 -0700 Patch bug-156801-20160420170532.patch text/plain 1453 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTc5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA0LTIwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFuY2hvciBlbGVtZW50ICdw aW5nJyBwcm9wZXJ0eSBzaG91bGQgb25seSBhcHBseSB0byBodHRwL2h0dHBzIGRlc3RpbmF0aW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2ODAx CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTgzNDQxOT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0ZWQgYnkgaHR0cC90ZXN0cy9uYXZpZ2F0 aW9uL3BpbmctYXR0cmlidXRlIHRlc3RzLgorCisgICAgICAgICogbG9hZGVyL1BpbmdMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UGluZ0xvYWRlcjo6c2VuZFBpbmcpOiBJZ25vcmUgcmVx dWVzdHMgdG8gcGluZyBhbnl0aGluZyBvdXRzaWRlIHRoZQorICAgICAgICBmYW1pbHkgb2YgSFRU UCBwcm90b2NvbHMgKGh0dHAvaHR0cHMpLgorCiAyMDE2LTA0LTIwICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgR2V0IHJpZCBvZiBhIGNvdXBsZSBvZiB1 c2VzIG9mIEFwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlOjpzaW5nbGV0b24oKQpJbmRleDogU291cmNl L1dlYkNvcmUvbG9hZGVyL1BpbmdMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2xvYWRlci9QaW5nTG9hZGVyLmNwcAkocmV2aXNpb24gMTk5Nzc5KQorKysgU291cmNlL1dl YkNvcmUvbG9hZGVyL1BpbmdMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2ICs5Miw5 IEBAIHZvaWQgUGluZ0xvYWRlcjo6bG9hZEltYWdlKEZyYW1lJiBmcmFtZSwKIC8vIGh0dHA6Ly93 d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL2xpbmtz Lmh0bWwjaHlwZXJsaW5rLWF1ZGl0aW5nCiB2b2lkIFBpbmdMb2FkZXI6OnNlbmRQaW5nKEZyYW1l JiBmcmFtZSwgY29uc3QgVVJMJiBwaW5nVVJMLCBjb25zdCBVUkwmIGRlc3RpbmF0aW9uVVJMKQog eworICAgIGlmICghcGluZ1VSTC5wcm90b2NvbElzSW5IVFRQRmFtaWx5KCkpCisgICAgICAgIHJl dHVybjsKKwogICAgIFJlc291cmNlUmVxdWVzdCByZXF1ZXN0KHBpbmdVUkwpOwogICAgIAogI2lm IEVOQUJMRShDT05URU5UX0VYVEVOU0lPTlMpCg== 276938 2016-04-21 11:08:26 -0700 2016-04-22 13:57:02 -0700 Patch bug-156801-20160421110848.patch text/plain 1795 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTgxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA0LTIxICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFuY2hvciBlbGVtZW50ICdw aW5nJyBwcm9wZXJ0eSBzaG91bGQgb25seSBhcHBseSB0byBodHRwL2h0dHBzIGRlc3RpbmF0aW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2ODAx CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTgzNDQxOT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYWtlIGFkdmFudGFnZSBvZiB0aGUgaHlwZXJs aW5rIGF1ZGl0aW5nIGxhbmd1YWdlICJVQXMgbWF5IGVpdGhlciBpZ25vcmUgdGhlCisgICAgICAg IHBpbmcgYXR0cmlidXRlIGFsdG9nZXRoZXIsIG9yIHNlbGVjdGl2ZWx5IGlnbm9yZSBVUkxzIGlu IHRoZSBsaXN0IChlLmcuIGlnbm9yaW5nCisgICAgICAgIGFueSB0aGlyZC1wYXJ0eSBVUkxzKSIg dG8gcmVzdHJpY3QgcGluZ3MgdG8gaHR0cC9odHRwcyB0YXJnZXRzLiBGb3IgZGV0YWlscywgc2Vl CisgICAgICAgIDxodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9zZW1hbnRp Y3MuaHRtbCNoeXBlcmxpbmstYXVkaXRpbmc+LgorCisgICAgICAgIFRlc3RlZCBieSBodHRwL3Rl c3RzL25hdmlnYXRpb24vcGluZy1hdHRyaWJ1dGUgdGVzdHMuCisKKyAgICAgICAgKiBsb2FkZXIv UGluZ0xvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQaW5nTG9hZGVyOjpzZW5kUGluZyk6 IElnbm9yZSByZXF1ZXN0cyB0byBwaW5nIGFueXRoaW5nIG91dHNpZGUgdGhlCisgICAgICAgIGZh bWlseSBvZiBIVFRQIHByb3RvY29scyAoaHR0cC9odHRwcykuCisKIDIwMTYtMDQtMjEgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBEcm9wIFtVc2VQb2ludGVyc0V2 ZW5Gb3JOb25OdWxsYWJsZU9iamVjdEFyZ3VtZW50c10gZnJvbSBSYW5nZQpJbmRleDogU291cmNl L1dlYkNvcmUvbG9hZGVyL1BpbmdMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2xvYWRlci9QaW5nTG9hZGVyLmNwcAkocmV2aXNpb24gMTk5ODE3KQorKysgU291cmNlL1dl YkNvcmUvbG9hZGVyL1BpbmdMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2ICs5Miw5 IEBAIHZvaWQgUGluZ0xvYWRlcjo6bG9hZEltYWdlKEZyYW1lJiBmcmFtZSwKIC8vIGh0dHA6Ly93 d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL2xpbmtz Lmh0bWwjaHlwZXJsaW5rLWF1ZGl0aW5nCiB2b2lkIFBpbmdMb2FkZXI6OnNlbmRQaW5nKEZyYW1l JiBmcmFtZSwgY29uc3QgVVJMJiBwaW5nVVJMLCBjb25zdCBVUkwmIGRlc3RpbmF0aW9uVVJMKQog eworICAgIGlmICghcGluZ1VSTC5wcm90b2NvbElzSW5IVFRQRmFtaWx5KCkpCisgICAgICAgIHJl dHVybjsKKwogICAgIFJlc291cmNlUmVxdWVzdCByZXF1ZXN0KHBpbmdVUkwpOwogICAgIAogI2lm IEVOQUJMRShDT05URU5UX0VYVEVOU0lPTlMpCg==