156767 2016-04-19 16:11:30 -0700 Replace $vm.printValue() with $vm.value(). 2016-04-19 16:32:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1185212 0 mark.lam 2016-04-19 16:11:30 -0700 When debugging with $vm, this change allows us to do this: $vm.print("myObj = " + myObj + "\n"); ... instead of having to do this: $vm.print("myObj = "); $vm.printValue(myObj); $vm.print("\n"); 1185220 1 mark.lam 2016-04-19 16:17:51 -0700 (In reply to comment #0) > When debugging with $vm, this change allows us to do this: > > $vm.print("myObj = " + myObj + "\n"); I meant this change allows us to do this: $vm.print("myObj = " + $vm.value(myObj) + "\n"); 1185222 2 276772 mark.lam 2016-04-19 16:19:50 -0700 Created attachment 276772 proposed patch. 1185228 3 mark.lam 2016-04-19 16:32:11 -0700 Thanks for the review. Landed in r199745: <http://trac.webkit.org/r199745>. 276772 2016-04-19 16:19:50 -0700 2016-04-19 16:21:53 -0700 proposed patch. bug-156767.patch text/plain 2536 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5NzQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDE2LTA0LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXBsYWNlICR2bS5wcmludFZhbHVlKCkgd2l0aCAkdm0udmFsdWUoKS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Njc2NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gZGVidWdnaW5nIHdpdGggJHZt LCB0aGlzIGNoYW5nZSBhbGxvd3MgdXMgdG8gZG8gdGhpczoKKworICAgICAgICAgICAgJHZtLnBy aW50KCJteU9iaiA9ICIgKyAkdm0udmFsdWUobXlPYmopICsgIlxuIik7CisKKyAgICAgICAgLi4u IGluc3RlYWQgb2YgaGF2aW5nIHRvIGRvIHRoaXM6CisKKyAgICAgICAgICAgICR2bS5wcmludCgi bXlPYmogPSAiKTsKKyAgICAgICAgICAgICR2bS5wcmludFZhbHVlKG15T2JqKTsKKyAgICAgICAg ICAgICR2bS5wcmludCgiXG4iKTsKKworICAgICAgICAqIHRvb2xzL0pTRG9sbGFyVk1Qcm90b3R5 cGUuY3BwOgorICAgICAgICAoSlNDOjpKU0RvbGxhclZNUHJvdG90eXBlOjpwcmludFZhbHVlKToK KyAgICAgICAgKEpTQzo6ZnVuY3Rpb25WYWx1ZSk6CisgICAgICAgIChKU0M6OkpTRG9sbGFyVk1Q cm90b3R5cGU6OmZpbmlzaENyZWF0aW9uKToKKyAgICAgICAgKEpTQzo6ZnVuY3Rpb25QcmludFZh bHVlKTogRGVsZXRlZC4KKwogMjAxNi0wNC0xOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEVuYWJsZSBzZXBhcmF0ZWQgaGVhcCBieSBkZWZhdWx0IG9uIGlvcwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNUHJv dG90eXBlLmNwcAkocmV2aXNpb24gMTk5NzQ0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rv b2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3 IEBACiAjaW5jbHVkZSAiSlNGdW5jdGlvbi5oIgogI2luY2x1ZGUgIlN0YWNrVmlzaXRvci5oIgog I2luY2x1ZGUgPHd0Zi9EYXRhTG9nLmg+CisjaW5jbHVkZSA8d3RmL1N0cmluZ1ByaW50U3RyZWFt Lmg+CiAKIG5hbWVzcGFjZSBKU0MgewogCkBAIC0zODgsMTQgKzM4OSwxNiBAQCB2b2lkIEpTRG9s bGFyVk1Qcm90b3R5cGU6OnByaW50VmFsdWUoSlNWCiAgICAgZGF0YUxvZyh2YWx1ZSk7CiB9CiAK LXN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uUHJpbnRWYWx1ZShF eGVjU3RhdGUqIGV4ZWMpCitzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5j dGlvblZhbHVlKEV4ZWNTdGF0ZSogZXhlYykKIHsKKyAgICBXVEY6OlN0cmluZ1ByaW50U3RyZWFt IHN0cmVhbTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZXhlYy0+YXJndW1lbnRDb3Vu dCgpOyArK2kpIHsKICAgICAgICAgaWYgKGkpCi0gICAgICAgICAgICBkYXRhTG9nKCIgIik7Ci0g ICAgICAgIGRhdGFMb2coZXhlYy0+dW5jaGVja2VkQXJndW1lbnQoaSkpOworICAgICAgICAgICAg c3RyZWFtLnByaW50KCIsICIpOworICAgICAgICBzdHJlYW0ucHJpbnQoZXhlYy0+dW5jaGVja2Vk QXJndW1lbnQoaSkpOwogICAgIH0KLSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZp bmVkKCkpOworICAgIAorICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNTdHJpbmcoZXhlYywg c3RyZWFtLnRvU3RyaW5nKCkpKTsKIH0KIAogdm9pZCBKU0RvbGxhclZNUHJvdG90eXBlOjpmaW5p c2hDcmVhdGlvbihWTSYgdm0sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCkBAIC00MjAs NyArNDIzLDcgQEAgdm9pZCBKU0RvbGxhclZNUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbgogICAg IGFkZEZ1bmN0aW9uKHZtLCBnbG9iYWxPYmplY3QsICJwcmludENhbGxGcmFtZSIsIGZ1bmN0aW9u UHJpbnRDYWxsRnJhbWUsIDApOwogICAgIGFkZEZ1bmN0aW9uKHZtLCBnbG9iYWxPYmplY3QsICJw cmludFN0YWNrIiwgZnVuY3Rpb25QcmludFN0YWNrLCAwKTsKIAotICAgIGFkZEZ1bmN0aW9uKHZt LCBnbG9iYWxPYmplY3QsICJwcmludFZhbHVlIiwgZnVuY3Rpb25QcmludFZhbHVlLCAxKTsKKyAg ICBhZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAidmFsdWUiLCBmdW5jdGlvblZhbHVlLCAx KTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==