156737 2016-04-19 02:42:37 -0700 Calling then on promise in Workers may crash in Debug builds 2016-09-01 01:28:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=153781 P2 Normal --- 1 youennf youennf ap bburg calvaris cgarcia commit-queue fpizlo joepeck msaboff ryanhaddad sam oldest_to_newest 1184973 0 youennf 2016-04-19 02:42:37 -0700 After studying bug 153781, it seems that the test causing crashes in Worker is the last one in LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.js. It basically does a lot of promise.then(...).then(...). 1184974 1 youennf 2016-04-19 02:43:23 -0700 The following test sample crashes sometimes (not very often) on Mac and GTK when run through rwt with the following options "--debug -f --iterations=1000" <!DOCTYPE html> <meta charset="utf-8"> <div id="title">Testing promise chaining in workers. This test passes if not crashing.</div> <div id="log"></div> <script> var worker = new Worker(window.URL.createObjectURL(new Blob( ["Promise.resolve().then();\n", "postMessage('done');"], { "type" : "text\/javascript" }))); worker.onmessage = function() { document.getElementById("log").innerHTML = "PASS" if (window.testRunner) testRunner.notifyDone(); }; if (window.testRunner) { testRunner.dumpAsText(); testRunner.waitUntilDone(); } </script> The log is similar to the one in bug 153781: For GTK: STDERR: ASSERTION FAILED: !exec->hadException() STDERR: ../../Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp(67) : void WebCore::JSGlobalObjectCallback::call() STDERR: 1 0x7f2202ca87ad /localHome/youenn/WebKit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f2202ca87ad] STDERR: 2 0x7f22094c8e4d /localHome/youenn/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::JSGlobalObjectCallback::call()+0x143) [0x7f22094c8e4d] STDERR: 3 0x7f22094c8680 /localHome/youenn/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x5680680) [0x7f22094c8680] STDERR: 4 0x7f22094c89b4 /localHome/youenn/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x56809b4) [0x7f22094c89b4] STDERR: 5 0x7f22093e5c27 /localHome/youenn/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(std::function<void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) const+0x49) [0x7f22093e5c27] STDERR: 6 0x7f22093e5b6f /localHome/youenn/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::ScriptExecutionContext::Task::performTask(WebCore::ScriptExecutionContext&)+0x23) [0x7f22093e5b6f] STDERR: 7 0x7f220a61b3fb /localHome/youenn/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::WorkerRunLoop::Task::performTask(WebCore::WorkerRunLoop const&, WebCore::WorkerGlobalScope*)+0x6d) [0x7f220a61b3fb] For MAC: ASSERTION FAILED: !exec->hadException() /Users/youenn/Documents/WebKit/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp(91) : void WebCore::JSGlobalObjectCallback::call() 1 0x11209c821 WTFCrash 2 0x1189d27ac WebCore::JSGlobalObjectCallback::call() 3 0x1189cef71 WebCore::JSGlobalObjectTask::JSGlobalObjectTask(WebCore::JSDOMGlobalObject*, WTF::PassRefPtr<JSC::Microtask>)::$_0::operator()(WebCore::ScriptExecutionContext&) const 4 0x1189cef3d _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZN7WebCore18JSGlobalObjectTaskC1EPNS3_17JSDOMGlobalObjectEN3WTF10PassRefPtrIN3JSC9MicrotaskEEEE3$_0RNS3_22ScriptExecutionContextEEEEvDpOT_ 5 0x1189ceda9 std::__1::__function::__func<WebCore::JSGlobalObjectTask::JSGlobalObjectTask(WebCore::JSDOMGlobalObject*, WTF::PassRefPtr<JSC::Microtask>)::$_0, std::__1::allocator<WebCore::JSGlobalObjectTask::JSGlobalObjectTask(WebCore::JSDOMGlobalObject*, WTF::PassRefPtr<JSC::Microtask>)::$_0>, void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) 6 0x116f98b08 std::__1::function<void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) const 1184975 2 youennf 2016-04-19 02:46:03 -0700 It appears that the job executed is the call of "promiseReactionJob", a JS built-in function defined in Source/JavaScriptCore/builtin/PromiseOperations.js Any idea on the issue? 1191498 3 youennf 2016-05-10 06:52:07 -0700 Digging a little bit further, the issue seems related to the web worker being asked to stop while the web worker is still wanting to run promiseReactionJob. Requesting the web worker triggers the watch dog. An exception is then sometimes hit either just before executing promiseReactionJob (in Interpreter::executeCall) or as part of op_watchdog. 1217860 4 youennf 2016-08-05 05:35:37 -0700 I am not able to reproduce this error anymore. Related to promises and Workers, I am sometimes hitting the following assertion: 6 ASSERTION FAILED: promise.inherits(JSPromise::info()) 7 /Users/youenn/Apple/Safari/OpenSource/Source/JavaScriptCore/runtime/JSPromiseDeferred.cpp(63) : static JSC::JSPromiseDeferred *JSC::JSPromiseDeferred::create(JSC::ExecState *, JSC::JSGlobalObject *) 8 1 0x109dd01ad WTFCrash 9 2 0x10992b97e JSC::JSPromiseDeferred::create(JSC::ExecState*, JSC::JSGlobalObject*) 10 3 0x10d19bf95 WebCore::callPromiseFunction(JSC::ExecState&, long long (*)(JSC::ExecState*, JSC::JSPromiseDeferred*)) 11 4 0x10d87f0bc WebCore::jsWorkerGlobalScopePrototypeFunctionFetchRequest(JSC::ExecState*) 12 5 0x5be8827ae8c8 13 6 0x5be8828a28e7 14 7 0x1099f334b llint_entry 15 8 0x5be8828968b3 16 9 0x1099ec2ce vmEntryToJavaScript 17 10 0x1097df7d7 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 18 11 0x109766d37 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 19 12 0x109022838 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 20 13 0x109022a1b JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 21 14 0x1098ce40b JSC::JSJobMicrotask::run(JSC::ExecState*) 22 15 0x10d2aba77 WebCore::JSGlobalObjectCallback::call() 23 16 0x10d2ab931 WebCore::JSGlobalObjectTask::JSGlobalObjectTask(WebCore::JSDOMGlobalObject*, WTF::Ref<JSC::Microtask>&&)::$_0::operator()(WebCore::ScriptExecutionContext&) const 24 17 0x10d2ab7d4 WTF::Function<void (WebCore::ScriptExecutionContext&)>::CallableWrapper<WebCore::JSGlobalObjectTask::JSGlobalObjectTask(WebCore::JSDOMGlobalObject*, WTF::Ref<JSC::Microtask>&&)::$_0>::call(WebCore::ScriptExecutionContext&) 25 18 0x10c87b551 WTF::Function<void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) const 26 19 0x10c8669fd WebCore::ScriptExecutionContext::Task::performTask(WebCore::ScriptExecutionContext&) 27 20 0x10e7e0619 WebCore::WorkerRunLoop::Task::performTask(WebCore::WorkerRunLoop const&, WebCore::WorkerGlobalScope*) 28 21 0x10e7df78b WebCore::WorkerRunLoop::runInMode(WebCore::WorkerGlobalScope*, WebCore::ModePredicate const&, WebCore::WorkerRunLoop::WaitMode) 29 22 0x10e7df2f6 WebCore::WorkerRunLoop::run(WebCore::WorkerGlobalScope*) 30 23 0x10e7e7930 WebCore::WorkerThread::runEventLoop() 31 24 0x10c7d82a8 WebCore::DedicatedWorkerThread::runEventLoop() 32 25 0x10e7e774d WebCore::WorkerThread::workerThread() 33 26 0x10e7e72f5 WebCore::WorkerThread::workerThreadStart(void*) 34 27 0x109e397e9 WTF::createThread(void (*)(void*), void*, char const*)::$_0::operator()() const 35 28 0x109e397bd void std::__1::__invoke_void_return_wrapper<void>::__call<WTF::createThread(void (*)(void*), void*, char const*)::$_0&>(WTF::createThread(void (*)(void*), void*, char const*)::$_0&&&) 36 29 0x109e39769 std::__1::__function::__func<WTF::createThread(void (*)(void*), void*, char const*)::$_0, std::__1::allocator<WTF::createThread(void (*)(void*), void*, char const*)::$_0>, void ()>::operator()() 37 30 0x109448faa std::__1::function<void ()>::operator()() const 38 31 0x109e38407 WTF::threadEntryPoint(void*) 39 LEAK: 1 WebProcessPool 40 LEAK: 1 WebPageProxy 1225283 5 youennf 2016-09-01 00:51:26 -0700 It might be the case that https://bugs.webkit.org/show_bug.cgi?id=161426 fixed the issue. I will try reenabling fetch tests on debug bots. 1225286 6 287608 youennf 2016-09-01 00:57:09 -0700 Created attachment 287608 Unskipping fetch api debug tests 1225290 7 287608 commit-queue 2016-09-01 01:28:36 -0700 Comment on attachment 287608 Unskipping fetch api debug tests Clearing flags on attachment: 287608 Committed r205284: <http://trac.webkit.org/changeset/205284> 1225291 8 commit-queue 2016-09-01 01:28:41 -0700 All reviewed patches have been landed. Closing bug. 287608 2016-09-01 00:57:09 -0700 2016-09-01 01:28:36 -0700 Unskipping fetch api debug tests bug-156737-20160901095455.patch text/plain 4045 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1Mjc5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTI4NDc0YTVkMDY2YzU1ZWFlNDc1 ZmZjMzNjNDU0MDNlZTdmZjA2Ni4uNTIzNTYzZTg5YzNmMTU5YTdjNmZjZTBlMTY2ZDNkZWFlZjQ5 YmViMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA5LTAxICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDYWxsaW5nIHRoZW4gb24gcHJvbWlzZSBpbiBX b3JrZXJzIG1heSBjcmFzaCBpbiBEZWJ1ZyBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjczNworCisgICAgICAgIFVucmV2aWV3ZWQuCisK KyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOiBBY3RpdmF0aW5nIHByZXZpb3VzbHkgc2tpcHBl ZCBmZXRjaCBhcGkgdGVzdHMgaW4gRGVidWcgYm90cworCiAyMDE2LTA4LTMxICBaYWxhbiBCdWp0 YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIWZsb3ct PmxheWVyKCkgJiYgIWZsb3ctPmlzSW5saW5lRWxlbWVudENvbnRpbnVhdGlvbigpIGluIFdlYkNv cmU6OlJlbmRlckJsb2NrOjphZGRDb250aW51YXRpb25XaXRoT3V0bGluZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggZTdhYWM2Njg2MTY4YjQ5ZWFjY2QwM2FmNTQ4MTE3MGJmNGVmNTVjYi4uNDdiZWZh Y2YwNjlmMzQ1MDNlNTEzMGQ1NGJhYWE5YTE2Zjg4OTI0MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBA IC01MDMsMzMgKzUwMyw2IEBAIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gv YXBpL3JlcXVlc3QvcmVxdWVzdC1jYWNoZS5odG1sIFsgU2tpcCBdCiAKIHdlYmtpdC5vcmcvYi8x NjExNzYgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvdXJsL3VybC1z ZXR0ZXJzLmh0bWwgWyBTa2lwIF0KIAotWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvZmV0Y2gvYXBpL2NvcnMvY29ycy1iYXNpYy13b3JrZXIuaHRtbCBbIFNraXAgXQot WyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2NvcnMv Y29ycy1jb29raWVzLXdvcmtlci5odG1sIFsgU2tpcCBdCi1bIERlYnVnIF0gaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvY29ycy9jb3JzLWZpbHRlcmluZy13b3JrZXIu aHRtbCBbIFNraXAgXQotWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv ZmV0Y2gvYXBpL2NvcnMvY29ycy1tdWx0aXBsZS1vcmlnaW5zLXdvcmtlci5odG1sIFsgU2tpcCBd Ci1bIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvY29y cy9jb3JzLW5vLXByZWZsaWdodC13b3JrZXIuaHRtbCBbIFNraXAgXQotWyBEZWJ1ZyBdIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2NvcnMvY29ycy1vcmlnaW4td29y a2VyLmh0bWwgWyBTa2lwIF0KLVsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2ZldGNoL2FwaS9jb3JzL2NvcnMtcHJlZmxpZ2h0LXJlZGlyZWN0LXdvcmtlci5odG1sIFsg U2tpcCBdCi1bIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9h cGkvY29ycy9jb3JzLXByZWZsaWdodC1yZWZlcnJlci13b3JrZXIuaHRtbCBbIFNraXAgXQotWyBE ZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2NvcnMvY29y cy1wcmVmbGlnaHQtc3RhdHVzLXdvcmtlci5odG1sIFsgU2tpcCBdCi1bIERlYnVnIF0gaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvY29ycy9jb3JzLXByZWZsaWdodC13 b3JrZXIuaHRtbCBbIFNraXAgXQotWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvZmV0Y2gvYXBpL2NvcnMvY29ycy1yZWRpcmVjdC1jcmVkZW50aWFscy13b3JrZXIuaHRt bCBbIFNraXAgXQotWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0 Y2gvYXBpL2NvcnMvY29ycy1yZWRpcmVjdC13b3JrZXIuaHRtbCBbIFNraXAgXQotWyBEZWJ1ZyBd IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2NvcnMvY29ycy1yZWRp cmVjdC1wcmVmbGlnaHQtd29ya2VyLmh0bWwgWyBTa2lwIF0KLVsgRGVidWcgXSBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9jcmVkZW50aWFscy9hdXRoZW50aWNhdGlv bi1iYXNpYy13b3JrZXIuaHRtbCBbIFNraXAgXQotWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2NyZWRlbnRpYWxzL2Nvb2tpZXMtd29ya2VyLmh0bWwg WyBTa2lwIF0KLVsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNo L2FwaS9wb2xpY2llcy9jc3AtYmxvY2tlZC13b3JrZXIuaHRtbCBbIFNraXAgXQotWyBEZWJ1ZyBd IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL3BvbGljaWVzL3JlZmVy cmVyLW5vLXJlZmVycmVyLXdvcmtlci5odG1sIFsgU2tpcCBdCi1bIERlYnVnIF0gaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvcG9saWNpZXMvcmVmZXJyZXItb3JpZ2lu LXdvcmtlci5odG1sIFsgU2tpcCBdCi1bIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9mZXRjaC9hcGkvcG9saWNpZXMvcmVmZXJyZXItdW5zYWZlLXVybC13b3JrZXIuaHRt bCBbIFNraXAgXQotWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0 Y2gvYXBpL3JlZGlyZWN0L3JlZGlyZWN0LWNvdW50LXdvcmtlci5odG1sIFsgU2tpcCBdCi1bIERl YnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvcmVkaXJlY3Qv cmVkaXJlY3QtbG9jYXRpb24td29ya2VyLmh0bWwgWyBTa2lwIF0KLVsgRGVidWcgXSBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9yZWRpcmVjdC9yZWRpcmVjdC1tZXRo b2Qtd29ya2VyLmh0bWwgWyBTa2lwIF0KLVsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2ZldGNoL2FwaS9yZWRpcmVjdC9yZWRpcmVjdC1tb2RlLXdvcmtlci5odG1sIFsg U2tpcCBdCi1bIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9h cGkvcmVkaXJlY3QvcmVkaXJlY3Qtb3JpZ2luLXdvcmtlci5odG1sIFsgU2tpcCBdCi1bIERlYnVn IF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9ub3NuaWZmL3dvcmtlci5o dG1sIFsgU2tpcCBdCi13ZWJraXQub3JnL2IvMTYwNTEwIFsgRGVidWcgXSBodHRwL3Rlc3RzL2Zl dGNoL2ZldGNoLWluLXdvcmtlci1jcmFzaC5odG1sIFsgQ3Jhc2ggXQotCiB3ZWJraXQub3JnL2Iv MTU3MDY4IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvbm9zbmlmZi9pbXBv cnRzY3JpcHRzLmh0bWwgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xNTcxNDUgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9ub3NuaWZmL3N0eWxlc2hlZXQuaHRtbCBbIEZhaWx1 cmUgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTYxMzEyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvaHRtbC9zZW1hbnRpY3MvZG9jdW1lbnQtbWV0YWRhdGEvdGhlLWxpbmstZWxlbWVudC9k b2N1bWVudC13aXRob3V0LWJyb3dzaW5nLWNvbnRleHQuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCg==