156735 2016-04-18 23:04:46 -0700 [EFL] Fix broken layout and perf tests since r199658 2017-03-11 10:38:44 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 156622 1 gyuyoung.kim gyuyoung.kim lucas.de.marchi mcatanzaro oldest_to_newest 1184927 0 gyuyoung.kim 2016-04-18 23:04:46 -0700 If EFL port calls InitializeWebKit2() before platformInitialize(), layout and perf tests are broken on EFL port. 1184930 1 276698 gyuyoung.kim 2016-04-18 23:06:56 -0700 Created attachment 276698 Patch 1184944 2 276698 cgarcia 2016-04-19 00:15:21 -0700 Comment on attachment 276698 Patch Do you know why are the crashes happening? If we understand the problem, we can try to properly fix this instead of adding platform ifdefs. For example, we could split platformInitialize in pre/post methods, and then GTK+ would implement only the post and EFL could move what needs to be done before InitializeWebKit2 to the pre method. I'll roll the patch out while we figure out what's wrong a how to properly fix it. 1184946 3 gyuyoung.kim 2016-04-19 00:18:21 -0700 (In reply to comment #2) > Comment on attachment 276698 [details] > Patch > > Do you know why are the crashes happening? If we understand the problem, we > can try to properly fix this instead of adding platform ifdefs. For example, > we could split platformInitialize in pre/post methods, and then GTK+ would > implement only the post and EFL could move what needs to be done before > InitializeWebKit2 to the pre method. I'll roll the patch out while we figure > out what's wrong a how to properly fix it. Thank you for reverting it. I don't know it yet. Let me try to check why EFL can't call it before platformInitialize when I free. 1286384 4 mcatanzaro 2017-03-11 10:38:44 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 276698 2016-04-18 23:06:56 -0700 2016-04-19 00:15:21 -0700 Patch bug-156735-20160419150714.patch text/plain 1557 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODk3N2RkMjVmZjNiNTQy ZGZmZmVmNWQ3ZmM3NTE5NjBlNzk1NjAyMC4uZjUzODI3ZDhkNGQwNWY3Zjg3NWJkZDU4MThjZDQ3 OGI4NDAwOTI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA0LTE4ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXSBGaXgg YnJva2VuIGxheW91dCBhbmQgcGVyZiB0ZXN0cyBzaW5jZSByMTk5NjU4CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY3MzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC91bml4L0NoaWxkUHJv Y2Vzc01haW4uaDogQ2FsbCBJbml0aWFsaXplV2ViS2l0MigpIGFmdGVyIHBsYXRmb3JtSW5pdGlh bGl6ZSgpIG9ubHkgZm9yIEVGTCBwb3J0LgorICAgICAgICAoV2ViS2l0OjpDaGlsZFByb2Nlc3NN YWluKToKKwogMjAxNi0wNC0xOCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAg ICAgICAgTmV3IFNQSSB0byBleHBvcnQgYSBkaWN0aW9uYXJ5IG9mIHJ1bnRpbWUgZmVhdHVyZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC91bml4L0NoaWxkUHJvY2Vzc01haW4u aCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC91bml4L0NoaWxkUHJvY2Vzc01haW4uaAppbmRleCBh Y2NjNzY0YzIyYzgxNTExN2EyMGM5YmE3MDJmZTNiMDhkYTVmYWRmLi41NDEzODU4MTY4NTdiNmM5 NGE3Zjk4MjlmMjhlM2YwNjU2MmVlMzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvdW5peC9DaGlsZFByb2Nlc3NNYWluLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL3Vu aXgvQ2hpbGRQcm9jZXNzTWFpbi5oCkBAIC00OSwxMSArNDksMTkgQEAgaW50IENoaWxkUHJvY2Vz c01haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogewogICAgIENoaWxkUHJvY2Vzc01haW5UeXBl IGNoaWxkTWFpbjsKIAorI2lmICFQTEFURk9STShFRkwpCiAgICAgSW5pdGlhbGl6ZVdlYktpdDIo KTsKKyNlbmRpZgogCiAgICAgaWYgKCFjaGlsZE1haW4ucGxhdGZvcm1Jbml0aWFsaXplKCkpCiAg ICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7CiAKKyNpZiBQTEFURk9STShFRkwpCisgICAgLy8g RklYTUU6IElmIEVGTCBwb3J0IGNhbGxzIEluaXRpYWxpemVXZWJLaXQyKCkgYmVmb3JlIHBsYXRm b3JtSW5pdGlhbGl6ZSgpLAorICAgIC8vIGxheW91dCBhbmQgcGVyZiB0ZXN0cyBhcmUgYnJva2Vu IG9uIEVGTCBwb3J0LgorICAgIEluaXRpYWxpemVXZWJLaXQyKCk7CisjZW5kaWYKKwogICAgIGlm ICghY2hpbGRNYWluLnBhcnNlQ29tbWFuZExpbmUoYXJnYywgYXJndikpCiAgICAgICAgIHJldHVy biBFWElUX0ZBSUxVUkU7CiAK