156729 2016-04-18 21:56:45 -0700 REGRESSION (r199635) Web Inspector: Percentages in Heap Allocations view are too large 2016-04-19 05:34:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1184911 0 joepeck 2016-04-18 21:56:45 -0700 * SUMMARY Percentages in Heap Allocations view are too large. Number.prototype.percentageString changed to use Number.prototype.toLocaleString's "percent" style and required a callsite change. However not all callsites were updated. 1184912 1 webkit-bug-importer 2016-04-18 21:57:06 -0700 <rdar://problem/25796002> 1184913 2 276693 joepeck 2016-04-18 21:59:59 -0700 Created attachment 276693 [PATCH] Proposed Fix 1184996 3 276693 commit-queue 2016-04-19 05:34:16 -0700 Comment on attachment 276693 [PATCH] Proposed Fix Clearing flags on attachment: 276693 Committed r199721: <http://trac.webkit.org/changeset/199721> 1184997 4 commit-queue 2016-04-19 05:34:19 -0700 All reviewed patches have been landed. Closing bug. 276693 2016-04-18 21:59:59 -0700 2016-04-19 05:34:16 -0700 [PATCH] Proposed Fix percentage-string.patch text/plain 2070 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVjYTI4NzguLmQzZjcwOTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA0LTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE5OTYzNSkg V2ViIEluc3BlY3RvcjogUGVyY2VudGFnZXMgaW4gSGVhcCBBbGxvY2F0aW9ucyB2aWV3IGFyZSB0 b28gbGFyZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1NjcyOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjU3OTYwMDI+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L0hlYXBTbmFwc2hvdEluc3RhbmNlRGF0YUdyaWROb2RlLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkhlYXBTbmFwc2hvdEluc3RhbmNlRGF0YUdyaWROb2RlLnByb3RvdHlwZS5jcmVhdGVDZWxs Q29udGVudCk6CisgICAgICAgIEZpeCBjYWxsc2l0ZSB0aGF0IGZhaWxlZCB0byBiZSB1cGRhdGVk IG9uY2UgcGVyY2VudGFnZVN0cmluZworICAgICAgICByZXF1aXJlZCAwLi4xIGlucHV0IGluc3Rl YWQgb2YgMC4uMTAwLgorCiAyMDE2LTA0LTE4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOYXZpZ2F0aW9uU2lkZWJhclBhbmVs IGRvZXMgYSBsb3Qgb2Ygc3R5bGUgcmVjYWxjIGFuZCBsYXlvdXQgb24gYnVzeSBzaXRlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcFNu YXBzaG90SW5zdGFuY2VEYXRhR3JpZE5vZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9IZWFwU25hcHNob3RJbnN0YW5jZURhdGFHcmlkTm9kZS5qcwppbmRl eCBkYzhjY2NjLi42NTBkNjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9IZWFwU25hcHNob3RJbnN0YW5jZURhdGFHcmlkTm9kZS5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwU25hcHNob3RJ bnN0YW5jZURhdGFHcmlkTm9kZS5qcwpAQCAtMTExLDEwICsxMTEsMTAgQEAgV2ViSW5zcGVjdG9y LkhlYXBTbmFwc2hvdEluc3RhbmNlRGF0YUdyaWROb2RlID0gY2xhc3MgSGVhcFNuYXBzaG90SW5z dGFuY2VEYXRhR3IKICAgICAgICAgICAgIGxldCBzaXplRWxlbWVudCA9IGZyYWdtZW50LmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKSk7CiAgICAgICAgICAgICBzaXpl RWxlbWVudC5jbGFzc0xpc3QuYWRkKCJzaXplIik7CiAgICAgICAgICAgICBzaXplRWxlbWVudC50 ZXh0Q29udGVudCA9IE51bWJlci5ieXRlc1RvU3RyaW5nKHNpemUpOwotICAgICAgICAgICAgbGV0 IHBlcmNlbnQgPSAoc2l6ZSAvIHRoaXMuX3RyZWUuX2hlYXBTbmFwc2hvdC50b3RhbFNpemUpICog MTAwOworICAgICAgICAgICAgbGV0IGZyYWN0aW9uID0gc2l6ZSAvIHRoaXMuX3RyZWUuX2hlYXBT bmFwc2hvdC50b3RhbFNpemU7CiAgICAgICAgICAgICBsZXQgcGVyY2VudEVsZW1lbnQgPSBmcmFn bWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIikpOwogICAgICAg ICAgICAgcGVyY2VudEVsZW1lbnQuY2xhc3NMaXN0LmFkZCgicGVyY2VudGFnZSIpOwotICAgICAg ICAgICAgcGVyY2VudEVsZW1lbnQudGV4dENvbnRlbnQgPSBOdW1iZXIucGVyY2VudGFnZVN0cmlu ZyhwZXJjZW50KTsKKyAgICAgICAgICAgIHBlcmNlbnRFbGVtZW50LnRleHRDb250ZW50ID0gTnVt YmVyLnBlcmNlbnRhZ2VTdHJpbmcoZnJhY3Rpb24pOwogICAgICAgICAgICAgcmV0dXJuIGZyYWdt ZW50OwogICAgICAgICB9CiAK