156723 2016-04-18 17:13:42 -0700 Context menu items related to fullscreen should be specific to standard fullscreen 2016-04-19 10:59:06 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan oldest_to_newest 1184863 0 adachan 2016-04-18 17:13:42 -0700 Context menu items related to fullscreen should be specific to standard fullscreen. Right now the code uses HTMLMediaElement::isFullscreen() to check whether it should display "Enter Full Screen" or "Exit Full Screen", which could return true for other fullscreen modes. We should use a more specific check since the action of "Enter Full Screen" is going to standard full screen. <rdar://problem/25452632> 1184865 1 276682 adachan 2016-04-18 17:23:11 -0700 Created attachment 276682 Patch 1185076 2 adachan 2016-04-19 10:59:06 -0700 Committed: http://trac.webkit.org/changeset/199733 276682 2016-04-18 17:23:11 -0700 2016-04-18 19:57:27 -0700 Patch bug-156723-20160418172329.patch text/plain 4562 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFlNTY2ZmQ2ZDBmODk0 OGY5NzAwMGZkODhjN2QxZWMyYmVmNDk5OS4uNGQ4NjkxZWMwOGU1NjUwNjA1ODljMjk4Zjk3ZWQ0 NTE5YWZkMDA4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTA0LTE4ICBBZGEg Q2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIENvbnRleHQgbWVudSBpdGVtcyBy ZWxhdGVkIHRvIGZ1bGxzY3JlZW4gc2hvdWxkIGJlIHNwZWNpZmljIHRvIHN0YW5kYXJkIGZ1bGxz Y3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NjcyMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjU0NTI2MzI+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW50cm9kdWNlIEhUTUxNZWRpYUVsZW1l bnQ6OmlzU3RhbmRhcmRGdWxsc2NyZWVuKCkgdGhhdCB0aGUgSGl0VGVzdFJlc3VsdCBjb2RlIGNh biB1c2UKKyAgICAgICAgd2hlbiBoYW5kbGluZyB0aGUgdmFsaWRhdGlvbiBhbmQgc2VsZWN0aW9u IG9mIGZ1bGxzY3JlZW4tcmVsYXRlZCBjb250ZXh0IG1lbnUgaXRlbXMuCisKKyAgICAgICAgKiBo dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxl bWVudDo6aXNTdGFuZGFyZEZ1bGxzY3JlZW4pOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6dG9nZ2xlU3RhbmRhcmRGdWxsc2NyZWVuU3RhdGUpOgorICAgICAgICBSZW5hbWVk IHRvIG1ha2UgaXQgY2xlYXIgdGhhdCBpdCdzIGZvciB0b2dnbGluZyBzdGFuZGFyZCBmdWxsc2Ny ZWVuLiBDYWxsIHRoZSBuZXcKKyAgICAgICAgSFRNTE1lZGlhRWxlbWVudDo6aXNTdGFuZGFyZEZ1 bGxzY3JlZW4oKS4KKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKyAgICAgICAg KiByZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXRUZXN0 UmVzdWx0OjptZWRpYUlzSW5GdWxsc2NyZWVuKToKKyAgICAgICAgVXNlIEhUTUxNZWRpYUVsZW1l bnQ6OmlzU3RhbmRhcmRGdWxsc2NyZWVuKCkuCisgICAgICAgIChXZWJDb3JlOjpIaXRUZXN0UmVz dWx0Ojp0b2dnbGVNZWRpYUZ1bGxzY3JlZW5TdGF0ZSk6CisgICAgICAgIENhbGwgdGhlIHJlbmFt ZWQgSFRNTE1lZGlhRWxlbWVudDo6dG9nZ2xlU3RhbmRhcmRGdWxsc2NyZWVuU3RhdGUoKS4KKwog MjAxNi0wNC0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtX SzJdW2lPU10gT25seSBhZGp1c3QgbmV0d29yayByZXNwb25zZXMnIE1JTUUgdHlwZSBmb3IgUXVp Y2tMb29rIGluIHRoZSBjb250ZXh0IG9mIGEgbWFpbiByZXNvdXJjZSBsb2FkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA2M2IzMWRlMDE3MjdmYzRhNmI1Njg2 OGQ5MGIxMGU0M2U0NTIwMWRlLi4xNWYxY2Q4N2E4M2I3ODZmZTA1MjU2MDAzMDllNTQ5MzQ0Yzcw YTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTUzMTIs MTEgKzUzMTIsMjEgQEAgYm9vbCBIVE1MTWVkaWFFbGVtZW50Ojppc0Z1bGxzY3JlZW4oKSBjb25z dAogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp0b2dnbGVG dWxsc2NyZWVuU3RhdGUoKQorYm9vbCBIVE1MTWVkaWFFbGVtZW50Ojppc1N0YW5kYXJkRnVsbHNj cmVlbigpIGNvbnN0CiB7Ci0gICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6dG9nZ2xl RnVsbHNjcmVlblN0YXRlKCVwKSAtIGlzRnVsbHNjcmVlbigpIGlzICVzIiwgdGhpcywgYm9vbFN0 cmluZyhpc0Z1bGxzY3JlZW4oKSkpOworI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAgICBp ZiAoZG9jdW1lbnQoKS53ZWJraXRJc0Z1bGxTY3JlZW4oKSAmJiBkb2N1bWVudCgpLndlYmtpdEN1 cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpID09IHRoaXMpCisgICAgICAgIHJldHVybiB0cnVlOwor I2VuZGlmCisKKyAgICByZXR1cm4gbV92aWRlb0Z1bGxzY3JlZW5Nb2RlID09IFZpZGVvRnVsbHNj cmVlbk1vZGVTdGFuZGFyZDsKK30KKwordm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp0b2dnbGVTdGFu ZGFyZEZ1bGxzY3JlZW5TdGF0ZSgpCit7CisgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVu dDo6dG9nZ2xlU3RhbmRhcmRGdWxsc2NyZWVuU3RhdGUoJXApIC0gaXNTdGFuZGFyZEZ1bGxzY3Jl ZW4oKSBpcyAlcyIsIHRoaXMsIGJvb2xTdHJpbmcoaXNTdGFuZGFyZEZ1bGxzY3JlZW4oKSkpOwog ICAgIAotICAgIGlmIChpc0Z1bGxzY3JlZW4oKSkKKyAgICBpZiAoaXNTdGFuZGFyZEZ1bGxzY3Jl ZW4oKSkKICAgICAgICAgZXhpdEZ1bGxzY3JlZW4oKTsKICAgICBlbHNlCiAgICAgICAgIGVudGVy RnVsbHNjcmVlbigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAppbmRleCBk MTIwMWY2MDhjMjFkZmE1ZDVlNDg1YzYzMzk1ZjliYjE5NjllMWViLi5mZjg5ZmRlNTc0MmZjYTEz ZmIxYmYwYjc4ZjNmMjYyNjk5N2IyMDc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuaApAQCAtMzU4LDcgKzM1OCw4IEBAIHB1YmxpYzoKICAgICBib29sIGhhc1NpbmdsZVNl Y3VyaXR5T3JpZ2luKCkgY29uc3QgeyByZXR1cm4gIW1fcGxheWVyIHx8IG1fcGxheWVyLT5oYXNT aW5nbGVTZWN1cml0eU9yaWdpbigpOyB9CiAgICAgCiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBp c0Z1bGxzY3JlZW4oKSBjb25zdCBvdmVycmlkZTsKLSAgICB2b2lkIHRvZ2dsZUZ1bGxzY3JlZW5T dGF0ZSgpOworICAgIGJvb2wgaXNTdGFuZGFyZEZ1bGxzY3JlZW4oKSBjb25zdDsKKyAgICB2b2lk IHRvZ2dsZVN0YW5kYXJkRnVsbHNjcmVlblN0YXRlKCk7CiAKICAgICB1c2luZyBNZWRpYVBsYXll ckVudW1zOjpWaWRlb0Z1bGxzY3JlZW5Nb2RlOwogICAgIFZpZGVvRnVsbHNjcmVlbk1vZGUgZnVs bHNjcmVlbk1vZGUoKSBjb25zdCB7IHJldHVybiBtX3ZpZGVvRnVsbHNjcmVlbk1vZGU7IH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcAppbmRleCA5NzQ5OGU4MWY5 OTU2NmMyNTQ2MDVkYmY0OTAyMzE0Yzk4NjA2OGU4Li42NDBkMTM4MzE0YTYzYThmZjRhNDFhOWEx MjIyNWE1ODIwZmU1OTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0 VGVzdFJlc3VsdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXN1 bHQuY3BwCkBAIC00NDcsNyArNDQ3LDcgQEAgYm9vbCBIaXRUZXN0UmVzdWx0OjptZWRpYUlzSW5G dWxsc2NyZWVuKCkgY29uc3QKIHsKICNpZiBFTkFCTEUoVklERU8pCiAgICAgaWYgKEhUTUxNZWRp YUVsZW1lbnQqIG1lZGlhRWxlbWVudCA9IHRoaXMtPm1lZGlhRWxlbWVudCgpKQotICAgICAgICBy ZXR1cm4gbWVkaWFFbGVtZW50LT5pc1ZpZGVvKCkgJiYgbWVkaWFFbGVtZW50LT5pc0Z1bGxzY3Jl ZW4oKTsKKyAgICAgICAgcmV0dXJuIG1lZGlhRWxlbWVudC0+aXNWaWRlbygpICYmIG1lZGlhRWxl bWVudC0+aXNTdGFuZGFyZEZ1bGxzY3JlZW4oKTsKICNlbmRpZgogICAgIHJldHVybiBmYWxzZTsK IH0KQEAgLTQ1OCw3ICs0NTgsNyBAQCB2b2lkIEhpdFRlc3RSZXN1bHQ6OnRvZ2dsZU1lZGlhRnVs bHNjcmVlblN0YXRlKCkgY29uc3QKICAgICBpZiAoSFRNTE1lZGlhRWxlbWVudCogbWVkaWFFbGVt ZW50ID0gdGhpcy0+bWVkaWFFbGVtZW50KCkpIHsKICAgICAgICAgaWYgKG1lZGlhRWxlbWVudC0+ aXNWaWRlbygpICYmIG1lZGlhRWxlbWVudC0+c3VwcG9ydHNGdWxsc2NyZWVuKEhUTUxNZWRpYUVs ZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZVN0YW5kYXJkKSkgewogICAgICAgICAgICAg VXNlckdlc3R1cmVJbmRpY2F0b3IgaW5kaWNhdG9yKERlZmluaXRlbHlQcm9jZXNzaW5nVXNlckdl c3R1cmUsICZtZWRpYUVsZW1lbnQtPmRvY3VtZW50KCkpOwotICAgICAgICAgICAgbWVkaWFFbGVt ZW50LT50b2dnbGVGdWxsc2NyZWVuU3RhdGUoKTsKKyAgICAgICAgICAgIG1lZGlhRWxlbWVudC0+ dG9nZ2xlU3RhbmRhcmRGdWxsc2NyZWVuU3RhdGUoKTsKICAgICAgICAgfQogICAgIH0KICNlbmRp Zgo=