156705 2016-04-18 09:11:18 -0700 [iOS] don't toggle playback when media engine rate changes 2016-04-18 13:51:02 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1184693 0 eric.carlson 2016-04-18 09:11:18 -0700 Don't send Play and Pause commands to HTMLMediaElement when the media engine's internal state changes while playing to AppleTV, this will cause a "pause" to rebuffed to stop playback. 1184694 1 webkit-bug-importer 2016-04-18 09:12:24 -0700 <rdar://problem/25779175> 1184786 2 eric.carlson 2016-04-18 13:22:03 -0700 (In reply to comment #0) > Don't send Play and Pause commands to HTMLMediaElement when the media > engine's internal state changes while playing to AppleTV, this will cause a > "pause" to rebuffed to stop playback. I meant to write: Don't *always* send ... 1184791 3 276661 eric.carlson 2016-04-18 13:29:23 -0700 Created attachment 276661 Proposed patch. 1184803 4 276661 eric.carlson 2016-04-18 13:50:52 -0700 Comment on attachment 276661 Proposed patch. Committed r199687: http://trac.webkit.org/changeset/199687 276661 2016-04-18 13:29:23 -0700 2016-04-18 13:51:02 -0700 Proposed patch. airplay_rate_change_patch_1.txt text/plain 2210 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTY4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA0LTE4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGRvbid0IHRv Z2dsZSBwbGF5YmFjayB3aGVuIG1lZGlhIGVuZ2luZSByYXRlIGNoYW5nZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjcwNQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMjU3NzkxNzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVy UHJpdmF0ZUFWRm91bmRhdGlvbjo6cmF0ZUNoYW5nZWQpOiBEb24ndCBzZW5kIHRoZSBwbGF5L3Bh dXNlIGNvbW1hbmQKKyAgICAgICAgICB1bmxlc3MgdGhlIHBsYXllciBpdGVtIHN0YXRlIGlzID49 IE1lZGlhUGxheWVyQVZQbGF5ZXJJdGVtU3RhdHVzUGxheWJhY2tCdWZmZXJGdWxsIGFuZAorICAg ICAgICAgIHRoZSByYXRlIGNoYW5nZSBpcyB1bmV4cGVjdGVkLgorCiAyMDE2LTA0LTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl1baU9TXSBPbmx5IGFk anVzdCBuZXR3b3JrIHJlc3BvbnNlcycgTUlNRSB0eXBlIGZvciBRdWlja0xvb2sgaW4gdGhlIGNv bnRleHQgb2YgYSBtYWluIHJlc291cmNlIGxvYWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCShyZXZpc2lvbiAxOTk2 NjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjE3LDgg KzYyMiwxNCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6bWV0CiB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6cmF0ZUNoYW5nZWQoKQogewogI2lmIEVO QUJMRShXSVJFTEVTU19QTEFZQkFDS19UQVJHRVQpICYmIFBMQVRGT1JNKElPUykKLSAgICBpZiAo aXNDdXJyZW50UGxheWJhY2tUYXJnZXRXaXJlbGVzcygpKQotICAgICAgICBtX3BsYXllci0+aGFu ZGxlUGxheWJhY2tDb21tYW5kKHJhdGUoKSA/IFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpQbGF5Q29t bWFuZCA6IFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpQYXVzZUNvbW1hbmQpOworICAgIExPRyhNZWRp YSwgIk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6cmF0ZUNoYW5nZWQoJXApIC0gcmF0 ZSA9ICVmLCByZXF1ZXN0ZWQgcmF0ZSA9ICVmLCBpdGVtIHN0YXR1cyA9ICVpIiwgdGhpcywgcmF0 ZSgpLCByZXF1ZXN0ZWRSYXRlKCksIHBsYXllckl0ZW1TdGF0dXMoKSk7CisgICAgaWYgKGlzQ3Vy cmVudFBsYXliYWNrVGFyZ2V0V2lyZWxlc3MoKSAmJiBwbGF5ZXJJdGVtU3RhdHVzKCkgPj0gTWVk aWFQbGF5ZXJBVlBsYXllckl0ZW1TdGF0dXNQbGF5YmFja0J1ZmZlckZ1bGwpIHsKKyAgICAgICAg ZG91YmxlIHJhdGUgPSB0aGlzLT5yYXRlKCk7CisgICAgICAgIGlmIChyYXRlICE9IHJlcXVlc3Rl ZFJhdGUoKSkgeworICAgICAgICAgICAgbV9wbGF5ZXItPmhhbmRsZVBsYXliYWNrQ29tbWFuZChy YXRlID8gUGxhdGZvcm1NZWRpYVNlc3Npb246OlBsYXlDb21tYW5kIDogUGxhdGZvcm1NZWRpYVNl c3Npb246OlBhdXNlQ29tbWFuZCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAg ICB9CiAjZW5kaWYKIAogICAgIG1fcGxheWVyLT5yYXRlQ2hhbmdlZCgpOwo=