156704 2016-04-18 08:46:49 -0700 Web Inspector: NavigationSidebarPanel does a lot of style recalc and layout on busy sites 2016-04-18 10:29:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1184685 0 timothy 2016-04-18 08:46:49 -0700 The NavigationSidebarPanel code for showing and hiding the bottom border when there is overflow is pretty aggressive. We can tone it down and still get the right effect. 1184686 1 webkit-bug-importer 2016-04-18 08:47:31 -0700 <rdar://problem/25778744> 1184687 2 276642 timothy 2016-04-18 08:51:46 -0700 Created attachment 276642 Patch 1184697 3 276642 bburg 2016-04-18 09:33:27 -0700 Comment on attachment 276642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276642&action=review r=me > Source/WebInspectorUI/ChangeLog:13 > + Use _updateContentOverflowShadowVisibilitySoon is more places so the style recalc Nit: 'in more places' 1184723 4 276642 timothy 2016-04-18 10:29:46 -0700 Comment on attachment 276642 Patch https://trac.webkit.org/changeset/199678 276642 2016-04-18 08:51:46 -0700 2016-04-18 10:29:46 -0700 Patch bug-156704-20160418085207.patch text/plain 3003 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZjY0MDdhNzA4ZDE2MjI1MGY2MzNlMzNkMDg3NGM0M2M0MTYyOTMyLi5lNmQxNDZjZTY2OWNiODNk ZDRjMmQxZTUxOTIwNWJmNDEzNjYzYWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNi0wNC0xOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmF2aWdhdGlvblNpZGViYXJQYW5lbCBkb2Vz IGEgbG90IG9mIHN0eWxlIHJlY2FsbCBhbmQgbGF5b3V0IG9uIGJ1c3kgc2l0ZXMKKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NzA0CisgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzI1Nzc4NzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFy UGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5lbCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUu X3RyZWVFbGVtZW50RGlzY2xvc3VyZURpZENoYW5nZSk6CisgICAgICAgIFVzZSBfdXBkYXRlQ29u dGVudE92ZXJmbG93U2hhZG93VmlzaWJpbGl0eVNvb24gaXMgbW9yZSBwbGFjZXMgc28gdGhlIHN0 eWxlIHJlY2FsYworICAgICAgICBhbmQgbGF5b3V0IGNoYW5nZXMgYXJlIGNvYWxlc2NlZCBpbnRv IG9uZSBhY3Rpb24gYWZ0ZXIgYWxsIHJhcGlkIGZpcmUgY2FsbHMuCisKKzIwMTYtMDQtMTggIFRp bW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IERhdGFiYXNlIHF1ZXJ5IHJlc3VsdCBEYXRhR3JpZHMgaGF2ZSBtaXNhbGlnbmVkIGhlYWRl ciBjb2x1bW5zCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NjcwMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKaW5kZXggZjlk MmMwMGJlMjYwN2E1M2M0MjMxMTNmZmUxMGI3Yjc1NjcwZjFlZi4uODRjNTM0N2NkZWJhOWE4NWM3 OTYzYzczNTQ4OGU2NzI1M2YwNGYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBh bmVsLmpzCkBAIC0zMyw3ICszMyw3IEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBh bmVsID0gY2xhc3MgTmF2aWdhdGlvblNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluCiAKICAgICAg ICAgdGhpcy5fdmlzaWJsZUNvbnRlbnRUcmVlT3V0bGluZXMgPSBuZXcgU2V0OwogCi0gICAgICAg IHRoaXMuY29udGVudFZpZXcuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJzY3JvbGwiLCB0aGlz Ll91cGRhdGVDb250ZW50T3ZlcmZsb3dTaGFkb3dWaXNpYmlsaXR5LmJpbmQodGhpcykpOworICAg ICAgICB0aGlzLmNvbnRlbnRWaWV3LmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigic2Nyb2xsIiwg dGhpcy5fdXBkYXRlQ29udGVudE92ZXJmbG93U2hhZG93VmlzaWJpbGl0eVNvb24uYmluZCh0aGlz KSk7CiAKICAgICAgICAgdGhpcy5fY29udGVudFRyZWVPdXRsaW5lID0gdGhpcy5jcmVhdGVDb250 ZW50VHJlZU91dGxpbmUodHJ1ZSk7CiAgICAgICAgIHRoaXMuX3NlbGVjdGVkQ29udGVudFRyZWVP dXRsaW5lID0gbnVsbDsKQEAgLTUzLDcgKzUzLDcgQEAgV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25T aWRlYmFyUGFuZWwgPSBjbGFzcyBOYXZpZ2F0aW9uU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW4K ICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl90b3BPdmVyZmxvd1No YWRvd0VsZW1lbnQpOwogICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5fYm91bmRVcGRhdGVDb250 ZW50T3ZlcmZsb3dTaGFkb3dWaXNpYmlsaXR5ID0gdGhpcy5fdXBkYXRlQ29udGVudE92ZXJmbG93 U2hhZG93VmlzaWJpbGl0eS5iaW5kKHRoaXMpOworICAgICAgICB0aGlzLl9ib3VuZFVwZGF0ZUNv bnRlbnRPdmVyZmxvd1NoYWRvd1Zpc2liaWxpdHkgPSB0aGlzLl91cGRhdGVDb250ZW50T3ZlcmZs b3dTaGFkb3dWaXNpYmlsaXR5U29vbi5iaW5kKHRoaXMpOwogICAgICAgICB3aW5kb3cuYWRkRXZl bnRMaXN0ZW5lcigicmVzaXplIiwgdGhpcy5fYm91bmRVcGRhdGVDb250ZW50T3ZlcmZsb3dTaGFk b3dWaXNpYmlsaXR5KTsKIAogICAgICAgICB0aGlzLl9maWx0ZXJzU2V0dGluZyA9IG5ldyBXZWJJ bnNwZWN0b3IuU2V0dGluZyhpZGVudGlmaWVyICsgIi1uYXZpZ2F0aW9uLXNpZGViYXItZmlsdGVy cyIsIHt9KTsKQEAgLTY0Niw3ICs2NDYsNyBAQCBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGVi YXJQYW5lbCA9IGNsYXNzIE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbgogCiAg ICAgX3RyZWVFbGVtZW50RGlzY2xvc3VyZURpZENoYW5nZShldmVudCkKICAgICB7Ci0gICAgICAg IHRoaXMuX3VwZGF0ZUNvbnRlbnRPdmVyZmxvd1NoYWRvd1Zpc2liaWxpdHkoKTsKKyAgICAgICAg dGhpcy5fdXBkYXRlQ29udGVudE92ZXJmbG93U2hhZG93VmlzaWJpbGl0eVNvb24oKTsKICAgICB9 CiAKICAgICBfdHJlZVNlbGVjdGlvbkRpZENoYW5nZShldmVudCkK