156696 2016-04-18 07:52:04 -0700 Web Inspector: Fix the debounce function 2016-04-18 13:43:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1184651 0 timothy 2016-04-18 07:52:04 -0700 It puts the symbol on the bound function, not the original. 1184652 1 webkit-bug-importer 2016-04-18 07:52:19 -0700 <rdar://problem/25778133> 1184668 2 276638 timothy 2016-04-18 08:15:43 -0700 Created attachment 276638 Patch 1184689 3 276638 bburg 2016-04-18 08:53:44 -0700 Comment on attachment 276638 Patch r=me Could you include a short description of how to use this function? I had to go over to underscore.js to confirm what I thought was going on. 1184721 4 timothy 2016-04-18 10:29:07 -0700 https://trac.webkit.org/changeset/199676 1184800 5 276638 joepeck 2016-04-18 13:43:38 -0700 Comment on attachment 276638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276638&action=review > Source/WebInspectorUI/UserInterface/Base/Utilities.js:1210 > - let callback = this.bind(thisObject); > - return function() { > - clearTimeout(callback[debounceSymbol]); > + return () => { > + clearTimeout(this[debounceSymbol]); > + > let args = arguments; > - callback[debounceSymbol] = setTimeout(() => { > - callback.apply(null, args); > + this[debounceSymbol] = setTimeout(() => { > + this.apply(thisObject, args); > }, delay); > }; I don't think this works. Because the "arguments" here are not the correct arguments. Looking back at the original bug: https://bugs.webkit.org/show_bug.cgi?id=152655 Maybe this can be reduced to: value: function(delay, thisObject) { return (...args) => { clearTimeout(this[debounceSymbol]); this[debounceSymbol] = setTimeout(this.bind(thisObject), delay, ...args); } } We could add a unit-test for this. 276638 2016-04-18 08:15:43 -0700 2016-04-18 10:29:14 -0700 Patch bug-156696-20160418081603.patch text/plain 2096 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl MTM5MTQ4NTVmNTk4NGRiOWI0ZjRhNWVkNzEwOTc5NDkyN2IzNTEwLi43ODMxNjhiMjU1Y2I2YTYz YTE0ZTBkMWRkY2ZlZDEyMzc4NGZkZTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNi0wNC0xOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IHRoZSBkZWJvdW5jZSBmdW5jdGlvbgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY2OTYK KyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjU3NzgxMzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMu anM6CisgICAgICAgIChGdW5jdGlvbi5wcm90b3R5cGUuZGVib3VuY2UpOiBTdG9yZSB0aGUgdGlt ZW91dCBvbiB0aGUgb3JpZ2luYWwgZnVuY3Rpb24gaW5zdGVhZAorICAgICAgICBvZiB0aGUgYm91 bmQgZnVuY3Rpb24uIEFsc28gc2ltcGxpZnkgdGhlIGltcGxlbWVudGF0aW9uIHdpdGggYXJyb3cg ZnVuY3Rpb25zCisgICAgICAgIGFuZCBlbGltaW5hdGUgdGhlIGJpbmQgYWx0b2dldGhlci4KKwog MjAxNi0wNC0xNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogQWRvcHQgTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0cmluZyBGb3Ig QWxsIFNpemVzIGFuZCBUaW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcwppbmRleCA2MjJkM2ZmZDU1MmUyNzY2ZmFmZDg2 NGUwNzAyZWIwYjJjY2U2MjY5Li4yNDlmZDIwN2NmMmVhYzViYTU3OTA5YzYzMmM3ZDk3ZGU0ODdm MzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNl L1V0aWxpdGllcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL1V0aWxpdGllcy5qcwpAQCAtMTE5NSwxNiArMTE5NSwxNyBAQCBPYmplY3QuZGVmaW5lUHJv cGVydHkoQXJyYXkucHJvdG90eXBlLCAiYmluYXJ5SW5kZXhPZiIsCiAKIChmdW5jdGlvbigpIHsK ICAgICBjb25zdCBkZWJvdW5jZVN5bWJvbCA9IFN5bWJvbCgiZnVuY3Rpb24tZGVib3VuY2UtdGlt ZW91dCIpOworCiAgICAgT2JqZWN0LmRlZmluZVByb3BlcnR5KEZ1bmN0aW9uLnByb3RvdHlwZSwg ImRlYm91bmNlIiwKICAgICB7CiAgICAgICAgIHZhbHVlOiBmdW5jdGlvbihkZWxheSwgdGhpc09i amVjdCkKICAgICAgICAgewotICAgICAgICAgICAgbGV0IGNhbGxiYWNrID0gdGhpcy5iaW5kKHRo aXNPYmplY3QpOwotICAgICAgICAgICAgcmV0dXJuIGZ1bmN0aW9uKCkgewotICAgICAgICAgICAg ICAgIGNsZWFyVGltZW91dChjYWxsYmFja1tkZWJvdW5jZVN5bWJvbF0pOworICAgICAgICAgICAg cmV0dXJuICgpID0+IHsKKyAgICAgICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpc1tkZWJvdW5j ZVN5bWJvbF0pOworCiAgICAgICAgICAgICAgICAgbGV0IGFyZ3MgPSBhcmd1bWVudHM7Ci0gICAg ICAgICAgICAgICAgY2FsbGJhY2tbZGVib3VuY2VTeW1ib2xdID0gc2V0VGltZW91dCgoKSA9PiB7 Ci0gICAgICAgICAgICAgICAgICAgIGNhbGxiYWNrLmFwcGx5KG51bGwsIGFyZ3MpOworICAgICAg ICAgICAgICAgIHRoaXNbZGVib3VuY2VTeW1ib2xdID0gc2V0VGltZW91dCgoKSA9PiB7CisgICAg ICAgICAgICAgICAgICAgIHRoaXMuYXBwbHkodGhpc09iamVjdCwgYXJncyk7CiAgICAgICAgICAg ICAgICAgfSwgZGVsYXkpOwogICAgICAgICAgICAgfTsKICAgICAgICAgfQo=