<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>15668</bug_id>
          
          <creation_ts>2007-10-24 12:18:13 -0700</creation_ts>
          <short_desc>build-webkit (and other build scripts) should hide setenv commands by default</short_desc>
          <delta_ts>2022-12-06 14:19:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>ap</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>emw</cc>
    
    <cc>mjs</cc>
    
    <cc>mrowe</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>59358</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2007-10-24 12:18:13 -0700</bug_when>
    <thetext>build-webkit (and other build scripts) should hit setenv commands by default

*most* of the XCode build output is useless setenv commands (duplicated for each call to gcc).  build-webkit should grep out this setenv output in a default &quot;not quite so loud&quot; mode. :)

I would do it, but I don&apos;t see a slick way of calling system and piping the output through grep. I think the way we&apos;ll have to do it is two open2() calls which pipe the output of xcodebuild to grep and the on to STDERR/STDOUT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59362</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-10-24 13:20:04 -0700</bug_when>
    <thetext>The setenv commands are not duplicated for each call to gcc as you claim.  I believe they&apos;re printed once for each non-compile phase, or something to that effect.  If you implement this, please make it easy to disable this filtering as I often use build-webkit to check the values of the Xcode configuration variables, rather than make which always filters them out and is not easily configurable like build-webkit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59389</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-10-24 19:24:08 -0700</bug_when>
    <thetext>What&apos;s wrong with doing this?

build-webkit | grep -v setenv</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1917023</commentid>
    <comment_count>3</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-12-06 14:08:00 -0800</bug_when>
    <thetext>@ap - This enhancement is still applicable or we can close this? Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1917034</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-12-06 14:19:10 -0800</bug_when>
    <thetext>People who want this behavior typically pipe through filter-build-webkit. 

And yes, as Mark pointed out, these are not duplicated, and are in fact often useful.

It&apos;s the typical &quot;make it quiet except when I actually want to see everything&quot; problem, and I think that the best way to resolve this is by sticking to what Xcode does by default, and letting people use filter-build-webkit when desired.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>