156646 2016-04-15 14:55:01 -0700 Animometer test could report a NaN 2016-04-15 18:03:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jonlee jonlee dino sabouhallawa simon.fraser oldest_to_newest 1184236 0 jonlee 2016-04-15 14:55:01 -0700 Fix occasional NaN reporting 1184238 1 276515 jonlee 2016-04-15 15:01:47 -0700 Created attachment 276515 Patch 1184246 2 276515 sabouhallawa 2016-04-15 15:26:48 -0700 Comment on attachment 276515 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276515&action=review Looks good to me. Unofficial r=me. > PerformanceTests/ChangeLog:13 > + This occurs because we never get out of the first tier, so this._lastTierComplexity is undefined. Nit: stray white space. 1184299 3 jonlee 2016-04-15 18:03:29 -0700 Committed r199616: <http://trac.webkit.org/changeset/199616> 276515 2016-04-15 15:01:47 -0700 2016-04-15 15:03:24 -0700 Patch bug-156646-20160415150201.patch text/plain 3146 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NTY2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0FuaW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21haW4uanMgYi9QZXJmb3JtYW5jZVRlc3RzL0Fu aW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21haW4uanMKaW5kZXggNDVhNjQ5MWZlNGFiMWJkY2M3 NDNhZjAwMmFiMTRmOGZlZGY1MjYwZC4uZTE0ZWQ1OTE4N2E1MDg1NWZmZjYwZDhmM2FhMzdmZjc3 MWY0Y2QyMCAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL3Jl c291cmNlcy9tYWluLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90ZXN0cy9y ZXNvdXJjZXMvbWFpbi5qcwpAQCAtNDEzLDEwICs0MTMsMTEgQEAgUmFtcENvbnRyb2xsZXIgPSBV dGlsaXRpZXMuY3JlYXRlU3ViY2xhc3MoQ29udHJvbGxlciwKICAgICAgICAgICAgIHRoaXMuX3Bv c3NpYmxlTWluaW11bUNvbXBsZXhpdHkgPSB0aGlzLl9taW5pbXVtQ29tcGxleGl0eTsKICAgICAg ICAgICAgIHRoaXMuX21pbmltdW1Db21wbGV4aXR5RXN0aW1hdG9yLnNhbXBsZSh0aGlzLl9taW5p bXVtQ29tcGxleGl0eSk7CiAKLSAgICAgICAgICAgIC8vIFNvbWV0aW1lcyB0aGlzIGxhc3QgdGll ciB3aWxsIGRyb3AgdGhlIGZyYW1lIGxlbmd0aCB3ZWxsIGJlbG93IHRoZSB0aHJlc2hvbGQKLSAg ICAgICAgICAgIC8vIEF2b2lkIGdvaW5nIGRvd24gdGhhdCBmYXIgc2luY2UgaXQgbWVhbnMgZmV3 ZXIgbWVhc3VyZW1lbnRzIGFyZSB0YWtlbiBpbiB0aGUgNjAgZnBzIGFyZWEKLSAgICAgICAgICAg IC8vIEludGVycG9sYXRlIGEgbWF4aW11bSBjb21wbGV4aXR5IHRoYXQgZ2V0cyB1cyBhcm91bmQg dGhlIGxvd2VzdCB0aHJlc2hvbGQKLSAgICAgICAgICAgIGlmICh0aGlzLl9sYXN0VGllckNvbXBs ZXhpdHkgIT0gY3VycmVudENvbXBsZXhpdHkpCisgICAgICAgICAgICAvLyBTb21ldGltZXMgdGhp cyBsYXN0IHRpZXIgd2lsbCBkcm9wIHRoZSBmcmFtZSBsZW5ndGggd2VsbCBiZWxvdyB0aGUgdGhy ZXNob2xkLgorICAgICAgICAgICAgLy8gQXZvaWQgZ29pbmcgZG93biB0aGF0IGZhciBzaW5jZSBp dCBtZWFucyBmZXdlciBtZWFzdXJlbWVudHMgYXJlIHRha2VuIGluIHRoZSA2MCBmcHMgYXJlYS4K KyAgICAgICAgICAgIC8vIEludGVycG9sYXRlIGEgbWF4aW11bSBjb21wbGV4aXR5IHRoYXQgZ2V0 cyB1cyBhcm91bmQgdGhlIGxvd2VzdCB0aHJlc2hvbGQuCisgICAgICAgICAgICAvLyBBdm9pZCBk b2luZyB0aGlzIGNhbGN1bGF0aW9uIGlmIHdlIG5ldmVyIGdldCBvdXQgb2YgdGhlIGZpcnN0IHRp ZXIgKHdoZXJlIHRoaXMuX2xhc3RUaWVyQ29tcGxleGl0eSBpcyB1bmRlZmluZWQpLgorICAgICAg ICAgICAgaWYgKHRoaXMuX2xhc3RUaWVyQ29tcGxleGl0eSAmJiB0aGlzLl9sYXN0VGllckNvbXBs ZXhpdHkgIT0gY3VycmVudENvbXBsZXhpdHkpCiAgICAgICAgICAgICAgICAgdGhpcy5fbWF4aW11 bUNvbXBsZXhpdHkgPSBNYXRoLmZsb29yKFV0aWxpdGllcy5sZXJwKFV0aWxpdGllcy5wcm9ncmVz c1ZhbHVlKHRoaXMuZnJhbWVMZW5ndGhTbG93ZXN0VGhyZXNob2xkLCB0aGlzLl9sYXN0VGllckZy YW1lTGVuZ3RoLCBjdXJyZW50RnJhbWVMZW5ndGgpLCB0aGlzLl9sYXN0VGllckNvbXBsZXhpdHks IGN1cnJlbnRDb21wbGV4aXR5KSk7CiAgICAgICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAg ICAvLyBJZiB0aGUgYnJvd3NlciBpcyBjYXBhYmxlIG9mIGhhbmRsaW5nIHRoZSBtb3N0IGNvbXBs ZXggdmVyc2lvbiBvZiB0aGUgdGVzdCwgdXNlIHRoYXQKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNl VGVzdHMvQ2hhbmdlTG9nIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODE0NTM3 ZWY4NTA1NzMwODFjNWFmMzE0ZTc4ZTVmY2EwNWVjOWE3MC4uODdlN2FjYmZhMmJkZGEzMGM2MjE1 NjIwYWI4ZDljOTVkYzU3MGNjZiAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VM b2cKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAx Ni0wNC0xNSAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CisKKyAgICAgICAgQW5pbW9tZXRl ciB0ZXN0IGNvdWxkIHJlcG9ydCBhIE5hTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NjQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBBbmltb21ldGVyL3Rlc3RzL3Jlc291cmNlcy9tYWluLmpzOgor ICAgICAgICAoZGlkRmluaXNoSW50ZXJ2YWwpOiBUaGUgcmFtcCBjb250cm9sbGVyIGhhcyBhIGZp cnN0IHBoYXNlIHdoZXJlIGl0IHJhbXBzIHVwIHRoZSBjb21wbGV4aXR5IGFuZAorICAgICAgICBy ZWFjdHMgYmFzZWQgb24gaG93IHdlbGwgdGhlIHN5c3RlbSBoYW5kbGVzIHRoZSBsb2FkLiBUaGUg YXNzdW1wdGlvbiB3YXMgdGhhdCBpdCB3b3VsZCBoYW5kbGUgYXQgbGVhc3QKKyAgICAgICAgMSBw YXJ0aWNsZSBlYXNpbHkuIFRoYXQgaXMgbm90IGFsd2F5cyB0aGUgY2FzZS4gQXMgYSByZXN1bHQs IGFuIGludGVycG9sYXRpb24gY2FsY3VsYXRpb24gY291bGQKKyAgICAgICAgZW5kIHVwIHNldHRp bmcgYW4gdXBwZXIgYm91bmQgb2YgTmFOLgorICAgICAgICAgICAgICAgIFRoaXMgb2NjdXJzIGJl Y2F1c2Ugd2UgbmV2ZXIgZ2V0IG91dCBvZiB0aGUgZmlyc3QgdGllciwgc28gdGhpcy5fbGFzdFRp ZXJDb21wbGV4aXR5IGlzIHVuZGVmaW5lZC4KKyAgICAgICAgTm93IHRoYXQgd2UgZ3VhcmFudGVl IGEgbWluaW11bSBjb21wbGV4aXR5IG9mIDEsIG1vZGlmeSB0aGUgY29uZGl0aW9uYWwgdG8gY2hl Y2sgZm9yIHRoaXMuX2xhc3RUaWVyQ29tcGxleGl0eQorICAgICAgICBiZWZvcmUgaW50ZXJwb2xh dGluZyB0aGUgdXBwZXIgYm91bmQgb2YgdGhlIGZpcnN0IHJhbXAuIEluIHRoZSBjYXNlIHdoZXJl IHRoZSBzeXN0ZW0gc3RydWdnbGVzIHdpdGgKKyAgICAgICAgMSBwYXJ0aWNsZSwgc2V0IGl0IHRv IGN1cnJlbnRDb21wbGV4aXR5LgorCiAyMDE2LTA0LTA5ICBKb24gTGVlICA8am9ubGVlQGFwcGxl LmNvbT4KIAogICAgICAgICBVcGRhdGUgQW5pbW9tZXRlciB0byBhY2NvbW1vZGF0ZSBkaWZmZXJl bnQgc2NyZWVucwo=