156614 2016-04-14 17:16:09 -0700 Some GuardMalloc bots are not happy when running many parallel processes 2016-04-27 16:55:46 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=157108 InRadar P2 Normal --- 1 ap ap commit-queue glenn lforschler oldest_to_newest 1183960 0 ap 2016-04-14 17:16:09 -0700 Some 12-core machines run into lots of timeouts when running 18 WebKitTestRunners (24 virtual cores * 0.75, which is a quotient for WebKit2). I'm not really sure why it's a problem with GuardMalloc while it's not a problem with regular builds. We definitely have enough RAM for all. But it seems like bringing the number further down to 12 doesn't reduce performance anyway. rdar://problem/24711525 1183962 1 276452 ap 2016-04-14 17:20:39 -0700 Created attachment 276452 proposed fix 1183986 2 276452 ddkilzer 2016-04-14 20:46:40 -0700 Comment on attachment 276452 proposed fix r=me 1183993 3 276452 commit-queue 2016-04-14 21:37:34 -0700 Comment on attachment 276452 proposed fix Clearing flags on attachment: 276452 Committed r199573: <http://trac.webkit.org/changeset/199573> 1183994 4 commit-queue 2016-04-14 21:37:37 -0700 All reviewed patches have been landed. Closing bug. 276452 2016-04-14 17:20:39 -0700 2016-04-14 21:37:34 -0700 proposed fix GuardMalloc.txt text/plain 1754 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5OTU2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTA0LTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFNvbWUgR3VhcmRNYWxsb2MgYm90cyBhcmUgbm90IGhhcHB5IHdoZW4gcnVu bmluZyBtYW55IHBhcmFsbGVsIHByb2Nlc3NlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NjE0CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI0NzEx NTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5OiAoTWFjUG9ydC5kZWZhdWx0X2NoaWxkX3Byb2Nl c3Nlcyk6CisKIDIwMTYtMDQtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KIAogICAgICAgICBBbm90aGVyIGJ1aWxkIGZpeCBhdHRlbXB0LgpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L21hYy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3BvcnQvbWFjLnB5CShyZXZpc2lvbiAxOTk1MzcpCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3BvcnQvbWFjLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsNyArMTU1LDEyIEBAIGNs YXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICAgICAgc2hvdWxkX3Rocm90dGxlX2Zvcl93azIg PSBzZWxmLmdldF9vcHRpb24oJ3dlYmtpdF90ZXN0X3J1bm5lcicpIGFuZCBkZWZhdWx0X2NvdW50 ID4gNAogICAgICAgICAjIFdlIGFsc28gd2FudCB0byB0aHJvdHRsZSBmb3IgbGVha3MgYm90cy4K ICAgICAgICAgaWYgc2hvdWxkX3Rocm90dGxlX2Zvcl93azIgb3Igc2VsZi5nZXRfb3B0aW9uKCds ZWFrcycpOgotICAgICAgICAgICAgZGVmYXVsdF9jb3VudCA9IGludCguNzUgKiBkZWZhdWx0X2Nv dW50KQorICAgICAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdndWFyZF9tYWxsb2MnKToKKyAg ICAgICAgICAgICAgICAjIFNvbWUgMTIgY29yZSBNYWNzIGdldCBhIGxvdCBvZiB0ZXN0cyB0aW1l IG91dCB3aGVuIHJ1bm5pbmcgMTggV2ViS2l0VGVzdFJ1bm5lciBwcm9jZXNzZXMgKGl0J3Mgbm90 IGNsZWFyIHdoYXQgdGhpcyBkZXBlbmRzIG9uKS4KKyAgICAgICAgICAgICAgICAjIFJ1bm5pbmcg MTIgcHJvY2Vzc2VzIHJlc29sdmVzIHRoaXMsIGFuZCBkb2Vzbid0IHNlZW0gdG8gaW50cm9kdWNl IGEgbWVhc3VyYWJsZSBwZXJmb3JtYW5jZSBkZWdyYWRhdGlvbiBvbiBvdGhlciBtYWNoaW5lcy4K KyAgICAgICAgICAgICAgICBkZWZhdWx0X2NvdW50ID0gaW50KC41ICogZGVmYXVsdF9jb3VudCkK KyAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgZGVmYXVsdF9jb3VudCA9IGludCgu NzUgKiBkZWZhdWx0X2NvdW50KQogCiAgICAgICAgICMgTWFrZSBzdXJlIHdlIGhhdmUgZW5vdWdo IHJhbSB0byBzdXBwb3J0IHRoYXQgbWFueSBpbnN0YW5jZXM6CiAgICAgICAgIHRvdGFsX21lbW9y eSA9IHNlbGYuaG9zdC5wbGF0Zm9ybS50b3RhbF9ieXRlc19tZW1vcnkoKQo=