156609 2016-04-14 16:12:52 -0700 REGRESSION (r158956): Remove vestigial range code in FileReaderLoader class after removing ENABLE(STREAM) 2016-04-14 17:23:24 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 123667 1 ddkilzer ddkilzer bfulgham commit-queue darin dbates gyuyoung.kim kling oldest_to_newest 1183932 0 ddkilzer 2016-04-14 16:12:52 -0700 This code was left behind when ENABLE(STREAM) was removed in November 2013. 1183935 1 276446 ddkilzer 2016-04-14 16:14:43 -0700 Created attachment 276446 Patch v1 1183936 2 ddkilzer 2016-04-14 16:15:32 -0700 Here's where the code was removed for Bug 123667: Committed r158956: <http://trac.webkit.org/changeset/158956> 1183944 3 276446 bfulgham 2016-04-14 16:33:01 -0700 Comment on attachment 276446 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=276446&action=review This looks good. r=me. > Source/WebCore/fileapi/FileReaderLoader.cpp:-65 > - , m_rangeEnd(0) I would be tempted to convert these to C++11 initializers, but you don't need to do that for this change. 1183963 4 276446 commit-queue 2016-04-14 17:23:19 -0700 Comment on attachment 276446 Patch v1 Clearing flags on attachment: 276446 Committed r199569: <http://trac.webkit.org/changeset/199569> 1183964 5 commit-queue 2016-04-14 17:23:24 -0700 All reviewed patches have been landed. Closing bug. 276446 2016-04-14 16:14:43 -0700 2016-04-14 17:23:19 -0700 Patch v1 bug-156609-20160414161455.patch text/plain 3180 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFhZDUwMjUzZTk5NzRm MTg5YjQ5MTBiY2NmMjk0ZTZmNDQ1ZWE1NC4uMmI1YTg5NWU5YTA2MDdjMGU5ODUyMmJjMDcyZWU0 OWI1NzVhOGZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA0LTE0ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE1 ODk1Nik6IFJlbW92ZSB2ZXN0aWdpYWwgcmFuZ2UgY29kZSBpbiBGaWxlUmVhZGVyTG9hZGVyIGNs YXNzIGFmdGVyIHJlbW92aW5nIEVOQUJMRShTVFJFQU0pCisgICAgICAgIDxodHRwOi8vd2Via2l0 Lm9yZy9iLzE1NjYwOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIGNvZGUgd2FzIGxlZnQgYmVoaW5kIHdoZW4gRU5BQkxFKFNUUkVBTSkgd2Fz IHJlbW92ZWQgaW4KKyAgICAgICAgTm92ZW1iZXIgMjAxMy4KKworICAgICAgICAqIGZpbGVhcGkv RmlsZVJlYWRlckxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGaWxlUmVhZGVyTG9hZGVy OjpGaWxlUmVhZGVyTG9hZGVyKTogUmVtb3ZlCisgICAgICAgIGluaXRpYWxpemVycy4KKyAgICAg ICAgKFdlYkNvcmU6OkZpbGVSZWFkZXJMb2FkZXI6OnN0YXJ0KTogUmVtb3ZlIGNvZGUgdGhhdCB1 c2VzCisgICAgICAgIG1faGFzUmFuZ2UsIHdoaWNoIGlzIGFsd2F5cyBmYWxzZS4KKyAgICAgICAg KFdlYkNvcmU6OkZpbGVSZWFkZXJMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6IERpdHRvLgor ICAgICAgICAqIGZpbGVhcGkvRmlsZVJlYWRlckxvYWRlci5oOgorICAgICAgICAoV2ViQ29yZTo6 RmlsZVJlYWRlckxvYWRlcik6IFJlbW92ZSB1bnVzZWQgaW5zdGFuY2UgdmFyaWFibGVzLgorCiAy MDE2LTA0LTE0ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtjc3MtZ3JpZF0gSW1wbGVtZW50IENTU0dyaWRUZW1wbGF0ZUFyZWFzVmFsdWU6OmVx dWFscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlUmVhZGVyTG9hZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvRmlsZVJlYWRlckxvYWRlci5jcHAKaW5kZXgg NDdjYWFiMWUyOTMwM2FkODI2OTllNzI0NzQxYzcyYTJkZDVjOTY3ZC4uYzg3MzVjNzgzZjM1ODVk MTI3MzhkZTdkMDdiYWUzOTRiYjRlZWJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmls ZWFwaS9GaWxlUmVhZGVyTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0Zp bGVSZWFkZXJMb2FkZXIuY3BwCkBAIC02MCw5ICs2MCw2IEBAIEZpbGVSZWFkZXJMb2FkZXI6OkZp bGVSZWFkZXJMb2FkZXIoUmVhZFR5cGUgcmVhZFR5cGUsIEZpbGVSZWFkZXJMb2FkZXJDbGllbnQq IGNsCiAgICAgLCBtX3ZhcmlhYmxlTGVuZ3RoKGZhbHNlKQogICAgICwgbV9ieXRlc0xvYWRlZCgw KQogICAgICwgbV90b3RhbEJ5dGVzKDApCi0gICAgLCBtX2hhc1JhbmdlKGZhbHNlKQotICAgICwg bV9yYW5nZVN0YXJ0KDApCi0gICAgLCBtX3JhbmdlRW5kKDApCiAgICAgLCBtX2Vycm9yQ29kZSgw KQogewogfQpAQCAtODcsOCArODQsNiBAQCB2b2lkIEZpbGVSZWFkZXJMb2FkZXI6OnN0YXJ0KFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIEJsbwogICAgIC8v IENvbnN0cnVjdCBhbmQgbG9hZCB0aGUgcmVxdWVzdC4KICAgICBSZXNvdXJjZVJlcXVlc3QgcmVx dWVzdChtX3VybEZvclJlYWRpbmcpOwogICAgIHJlcXVlc3Quc2V0SFRUUE1ldGhvZCgiR0VUIik7 Ci0gICAgaWYgKG1faGFzUmFuZ2UpCi0gICAgICAgIHJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxk KEhUVFBIZWFkZXJOYW1lOjpSYW5nZSwgU3RyaW5nOjpmb3JtYXQoImJ5dGVzPSVkLSVkIiwgbV9y YW5nZVN0YXJ0LCBtX3JhbmdlRW5kKSk7CiAKICAgICBUaHJlYWRhYmxlTG9hZGVyT3B0aW9ucyBv cHRpb25zOwogICAgIG9wdGlvbnMuc2V0U2VuZExvYWRDYWxsYmFja3MoU2VuZENhbGxiYWNrcyk7 CkBAIC0xNDIsMTAgKzEzNyw3IEBAIHZvaWQgRmlsZVJlYWRlckxvYWRlcjo6ZGlkUmVjZWl2ZVJl c3BvbnNlKHVuc2lnbmVkIGxvbmcsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmCiAgICAgLy8gQSBu ZWdhdGl2ZSB2YWx1ZSBtZWFucyB0aGF0IHRoZSBjb250ZW50IGxlbmd0aCB3YXNuJ3Qgc3BlY2lm aWVkLCBzbyB0aGUgYnVmZmVyIHdpbGwgbmVlZCB0byBiZSBkeW5hbWljYWxseSBncm93bi4KICAg ICBpZiAobGVuZ3RoIDwgMCkgewogICAgICAgICBtX3ZhcmlhYmxlTGVuZ3RoID0gdHJ1ZTsKLSAg ICAgICAgaWYgKG1faGFzUmFuZ2UpCi0gICAgICAgICAgICBsZW5ndGggPSAxICsgbV9yYW5nZUVu ZCAtIG1fcmFuZ2VTdGFydDsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgbGVuZ3RoID0gZGVm YXVsdEJ1ZmZlckxlbmd0aDsKKyAgICAgICAgbGVuZ3RoID0gZGVmYXVsdEJ1ZmZlckxlbmd0aDsK ICAgICB9CiAKICAgICAvLyBDaGVjayB0aGF0IHdlIGNhbiBjYXN0IHRvIHVuc2lnbmVkIHNpbmNl IHdlIGhhdmUgdG8gZG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvRmlsZVJl YWRlckxvYWRlci5oIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlUmVhZGVyTG9hZGVyLmgK aW5kZXggMGJkZjA4Yzg4ZTczNTIwZjA4N2MxYjlkMDQ2ZmJkODFiMjQ2ZTk2NS4uMDgzNmUzODBj N2M1ZWQ1Y2IxNGI0MmNkMjg3ZTJkMjgwZWM4M2EyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZmlsZWFwaS9GaWxlUmVhZGVyTG9hZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZmlsZWFw aS9GaWxlUmVhZGVyTG9hZGVyLmgKQEAgLTExNCwxMCArMTE0LDYgQEAgcHJpdmF0ZToKICAgICB1 bnNpZ25lZCBtX2J5dGVzTG9hZGVkOwogICAgIHVuc2lnbmVkIG1fdG90YWxCeXRlczsKIAotICAg IGJvb2wgbV9oYXNSYW5nZTsKLSAgICB1bnNpZ25lZCBtX3JhbmdlU3RhcnQ7Ci0gICAgdW5zaWdu ZWQgbV9yYW5nZUVuZDsKLQogICAgIGludCBtX2Vycm9yQ29kZTsKIH07CiAK