156606 2016-04-14 16:01:12 -0700 [COCOA] Do not unnecessarily initialize ResourceResponse::m_httpVersion as part of common fields 2016-04-15 09:44:08 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen ap commit-queue darin oldest_to_newest 1183921 0 cdumez 2016-04-14 16:01:12 -0700 Do not unnecessarily initialize ResourceResponse::m_httpVersion as part of common fields. We currently initialize m_httpVersion when calling platformLazyInit(CommonFieldsOnly) even though this is not a common field. The corresponding getter/setter in HTTPResponseBase, call lazyInit(AllFields). 1183923 1 276445 cdumez 2016-04-14 16:03:19 -0700 Created attachment 276445 Patch 1184096 2 276445 commit-queue 2016-04-15 09:44:04 -0700 Comment on attachment 276445 Patch Clearing flags on attachment: 276445 Committed r199591: <http://trac.webkit.org/changeset/199591> 1184097 3 commit-queue 2016-04-15 09:44:08 -0700 All reviewed patches have been landed. Closing bug. 276445 2016-04-14 16:03:19 -0700 2016-04-15 09:44:04 -0700 Patch bug-156606-20160414160332.patch text/plain 4180 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExYzY0NTAyYzRiMmM3 ZTA2ZTdiYWQ5NjYyMDEzYTIxZDBjMGY5ZC4uY2E5OWMzZDIyYmQ3ZjQ3YzE0MGU3Yjg1ZTNhYWI4 NTU0ZDE4YTQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA0LTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NPQ09BXSBEbyBub3QgdW5u ZWNlc3NhcmlseSBpbml0aWFsaXplIFJlc291cmNlUmVzcG9uc2U6Om1faHR0cFZlcnNpb24gYXMg cGFydCBvZiBjb21tb24gZmllbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTY2MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBEbyBub3QgdW5uZWNlc3NhcmlseSBpbml0aWFsaXplIFJlc291cmNlUmVz cG9uc2U6Om1faHR0cFZlcnNpb24gYXMgcGFydCBvZiBjb21tb24gZmllbGRzLgorCisgICAgICAg IFdlIHByZXZpb3VzbHkgaW5pdGlhbGl6ZWQgbV9odHRwVmVyc2lvbiB3aGVuIGNhbGxpbmcgcGxh dGZvcm1MYXp5SW5pdChDb21tb25GaWVsZHNPbmx5KSwKKyAgICAgICAgZXZlbiB0aG91Z2ggdGhp cyBpcyBub3QgYSBjb21tb24gZmllbGQuIFRoZSBjb3JyZXNwb25kaW5nIGdldHRlci9zZXR0ZXIg aW4KKyAgICAgICAgSFRUUFJlc3BvbnNlQmFzZSBjYWxsIGxhenlJbml0KEFsbEZpZWxkcykuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUxhenlJbml0KToK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1Jlc291cmNlUmVzcG9uc2VDb2NvYS5t bToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtTGF6eUluaXQp OgorCiAyMDE2LTA0LTE0ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgQWxsb3cgbGlzdGJveCBjb250ZW50IGFuZCBzY3JvbGxiYXIgdG8gaW50cnVkZSBw YWRkaW5nIGFyZWEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAKaW5kZXggZjcxNWJmMjM3ZWQzYzUz OGVhZmJlYzZjY2JlZTViZGJmYzU2ZDhhYi4uZTgyYWIzYTk5ZjRiNDk5ZjEzZjFhYjEwYTAwNmUz NDYwODI4NWJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j Zi9SZXNvdXJjZVJlc3BvbnNlQ0ZOZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcApAQCAtODYsNyArODYsNiBAQCB2 b2lkIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtTGF6eUluaXQoSW5pdExldmVsIGluaXRMZXZl bCkKIAogICAgICAgICBDRkhUVFBNZXNzYWdlUmVmIGh0dHBSZXNwb25zZSA9IENGVVJMUmVzcG9u c2VHZXRIVFRQUmVzcG9uc2UobV9jZlJlc3BvbnNlLmdldCgpKTsKICAgICAgICAgaWYgKGh0dHBS ZXNwb25zZSkgewotICAgICAgICAgICAgbV9odHRwVmVyc2lvbiA9IFN0cmluZyhhZG9wdENGKENG SFRUUE1lc3NhZ2VDb3B5VmVyc2lvbihodHRwUmVzcG9uc2UpKS5nZXQoKSkuY29udmVydFRvQVND SUlVcHBlcmNhc2UoKTsKICAgICAgICAgICAgIG1faHR0cFN0YXR1c0NvZGUgPSBDRkhUVFBNZXNz YWdlR2V0UmVzcG9uc2VTdGF0dXNDb2RlKGh0dHBSZXNwb25zZSk7CiAgICAgICAgICAgICAKICAg ICAgICAgICAgIGlmIChpbml0TGV2ZWwgPCBBbGxGaWVsZHMpIHsKQEAgLTEwNCw2ICsxMDMsOCBA QCB2b2lkIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtTGF6eUluaXQoSW5pdExldmVsIGluaXRM ZXZlbCkKICAgICBpZiAobV9pbml0TGV2ZWwgPCBBbGxGaWVsZHMgJiYgaW5pdExldmVsID09IEFs bEZpZWxkcykgewogICAgICAgICBDRkhUVFBNZXNzYWdlUmVmIGh0dHBSZXNwb25zZSA9IENGVVJM UmVzcG9uc2VHZXRIVFRQUmVzcG9uc2UobV9jZlJlc3BvbnNlLmdldCgpKTsKICAgICAgICAgaWYg KGh0dHBSZXNwb25zZSkgeworICAgICAgICAgICAgbV9odHRwVmVyc2lvbiA9IFN0cmluZyhhZG9w dENGKENGSFRUUE1lc3NhZ2VDb3B5VmVyc2lvbihodHRwUmVzcG9uc2UpKS5nZXQoKSkuY29udmVy dFRvQVNDSUlVcHBlcmNhc2UoKTsKKwogICAgICAgICAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVm PiBzdGF0dXNMaW5lID0gYWRvcHRDRihDRkhUVFBNZXNzYWdlQ29weVJlc3BvbnNlU3RhdHVzTGlu ZShodHRwUmVzcG9uc2UpKTsKICAgICAgICAgICAgIG1faHR0cFN0YXR1c1RleHQgPSBleHRyYWN0 UmVhc29uUGhyYXNlRnJvbUhUVFBTdGF0dXNMaW5lKHN0YXR1c0xpbmUuZ2V0KCkpOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1Jlc291cmNlUmVz cG9uc2VDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVz b3VyY2VSZXNwb25zZUNvY29hLm1tCmluZGV4IGU3YmU0MWRmYjc1ZDUyYjM2MDM3OTgyYzIyNWZj MGQwMzQxZDBlNmMuLmZmOWIzNjRhNDBhNWYwNTIzNjY3ZTIzMzE0YzA3M2MwOWE5OTgwOTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVzb3VyY2VS ZXNwb25zZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29j b2EvUmVzb3VyY2VSZXNwb25zZUNvY29hLm1tCkBAIC0xODYsOCArMTg2LDYgQEAgdm9pZCBSZXNv dXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUxhenlJbml0KEluaXRMZXZlbCBpbml0TGV2ZWwpCiAgICAg ICAgIGlmIChbbV9uc1Jlc3BvbnNlLmdldCgpIGlzS2luZE9mQ2xhc3M6W05TSFRUUFVSTFJlc3Bv bnNlIGNsYXNzXV0pIHsKICAgICAgICAgICAgIE5TSFRUUFVSTFJlc3BvbnNlICpodHRwUmVzcG9u c2UgPSAoTlNIVFRQVVJMUmVzcG9uc2UgKiltX25zUmVzcG9uc2UuZ2V0KCk7CiAKLSAgICAgICAg ICAgIENGSFRUUE1lc3NhZ2VSZWYgbWVzc2FnZVJlZiA9IENGVVJMUmVzcG9uc2VHZXRIVFRQUmVz cG9uc2UoW2h0dHBSZXNwb25zZSBfQ0ZVUkxSZXNwb25zZV0pOwotICAgICAgICAgICAgbV9odHRw VmVyc2lvbiA9IFN0cmluZyhhZG9wdENGKENGSFRUUE1lc3NhZ2VDb3B5VmVyc2lvbihtZXNzYWdl UmVmKSkuZ2V0KCkpLmNvbnZlcnRUb0FTQ0lJVXBwZXJjYXNlKCk7CiAgICAgICAgICAgICBtX2h0 dHBTdGF0dXNDb2RlID0gW2h0dHBSZXNwb25zZSBzdGF0dXNDb2RlXTsKICAgICAgICAgICAgIAog ICAgICAgICAgICAgaWYgKGluaXRMZXZlbCA8IEFsbEZpZWxkcykgewpAQCAtMjEzLDYgKzIxMSw5 IEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdChJbml0TGV2ZWwgaW5p dExldmVsKQogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIG1faHR0cFN0YXR1c1Rl eHQgPSBBdG9taWNTdHJpbmcoIk9LIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJh bCk7CiAKKyAgICAgICAgICAgIENGSFRUUE1lc3NhZ2VSZWYgbWVzc2FnZVJlZiA9IENGVVJMUmVz cG9uc2VHZXRIVFRQUmVzcG9uc2UoW2h0dHBSZXNwb25zZSBfQ0ZVUkxSZXNwb25zZV0pOworICAg ICAgICAgICAgbV9odHRwVmVyc2lvbiA9IFN0cmluZyhhZG9wdENGKENGSFRUUE1lc3NhZ2VDb3B5 VmVyc2lvbihtZXNzYWdlUmVmKSkuZ2V0KCkpLmNvbnZlcnRUb0FTQ0lJVXBwZXJjYXNlKCk7CisK ICAgICAgICAgICAgIE5TRGljdGlvbmFyeSAqaGVhZGVycyA9IFtodHRwUmVzcG9uc2UgYWxsSGVh ZGVyRmllbGRzXTsKICAgICAgICAgICAgIGZvciAoTlNTdHJpbmcgKm5hbWUgaW4gaGVhZGVycykK ICAgICAgICAgICAgICAgICBtX2h0dHBIZWFkZXJGaWVsZHMuc2V0KG5hbWUsIFtoZWFkZXJzIG9i amVjdEZvcktleTpuYW1lXSk7Cg==