156600 2016-04-14 14:33:41 -0700 Web Inspector: Add a JavaScript Formatting test for template strings 2016-04-14 14:46:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1183865 0 joepeck 2016-04-14 14:33:41 -0700 * SUMMARY Add a JavaScript Formatting test for template strings. I just saw some code that looked absolutely horrible in the old pretty printer. Fortunately the new pretty printer handles it correctly, but we had no test coverage! 1183866 1 276430 joepeck 2016-04-14 14:34:23 -0700 Created attachment 276430 [PATCH] Proposed Fix 1183874 2 276430 bburg 2016-04-14 14:38:01 -0700 Comment on attachment 276430 [PATCH] Proposed Fix rs=me 1183876 3 276430 bburg 2016-04-14 14:38:27 -0700 Comment on attachment 276430 [PATCH] Proposed Fix GTK / EFL are unrelated. 1183879 4 276430 commit-queue 2016-04-14 14:46:10 -0700 Comment on attachment 276430 [PATCH] Proposed Fix Clearing flags on attachment: 276430 Committed r199556: <http://trac.webkit.org/changeset/199556> 1183880 5 commit-queue 2016-04-14 14:46:14 -0700 All reviewed patches have been landed. Closing bug. 276430 2016-04-14 14:34:23 -0700 2016-04-14 14:46:10 -0700 [PATCH] Proposed Fix pretty-template.patch text/plain 4469 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMGRlMTFhLi42NzdlODAzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDQt MTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBBZGQgYSBKYXZhU2NyaXB0IEZvcm1hdHRpbmcgdGVzdCBmb3IgdGVtcGxhdGUg c3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU2NjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZm9ybWF0dGluZy9mb3JtYXR0aW5nLWphdmFzY3JpcHQtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGluc3BlY3Rvci9mb3JtYXR0aW5nL2Zvcm1hdHRpbmctamF2YXNjcmlwdC5o dG1sOgorICAgICAgICAqIGluc3BlY3Rvci9mb3JtYXR0aW5nL3Jlc291cmNlcy9qYXZhc2NyaXB0 LXRlc3RzL3RlbXBsYXRlLXN0cmluZ3MtZXhwZWN0ZWQuanM6IEFkZGVkLgorICAgICAgICAqIGlu c3BlY3Rvci9mb3JtYXR0aW5nL3Jlc291cmNlcy9qYXZhc2NyaXB0LXRlc3RzL3RlbXBsYXRlLXN0 cmluZ3MuanM6IEFkZGVkLgorCiAyMDE2LTA0LTE0ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmpl Y3RBcmd1bWVudHMgZnJvbSBJbnRlcm5hbHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9mb3JtYXR0aW5nL2Zvcm1hdHRpbmctamF2YXNjcmlwdC1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvZm9ybWF0dGluZy9mb3JtYXR0aW5nLWphdmFzY3JpcHQtZXhwZWN0 ZWQudHh0CmluZGV4IDQ4NTE4M2EuLjI1ZjE5OTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lu c3BlY3Rvci9mb3JtYXR0aW5nL2Zvcm1hdHRpbmctamF2YXNjcmlwdC1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Zvcm1hdHRpbmcvZm9ybWF0dGluZy1qYXZhc2NyaXB0 LWV4cGVjdGVkLnR4dApAQCAtNTYsNiArNTYsOSBAQCBQQVNTCiAtLSBSdW5uaW5nIHRlc3QgY2Fz ZTogRXNwcmltYUZvcm1hdHRlci5KYXZhU2NyaXB0LnN3aXRjaC1jYXNlLWRlZmF1bHQuanMKIFBB U1MKIAorLS0gUnVubmluZyB0ZXN0IGNhc2U6IEVzcHJpbWFGb3JtYXR0ZXIuSmF2YVNjcmlwdC50 ZW1wbGF0ZS1zdHJpbmdzLmpzCitQQVNTCisKIC0tIFJ1bm5pbmcgdGVzdCBjYXNlOiBFc3ByaW1h Rm9ybWF0dGVyLkphdmFTY3JpcHQudGVybmFyeS1leHByZXNzaW9ucy5qcwogUEFTUwogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZm9ybWF0dGluZy9mb3JtYXR0aW5nLWphdmFz Y3JpcHQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9mb3JtYXR0aW5nL2Zvcm1hdHRpbmct amF2YXNjcmlwdC5odG1sCmluZGV4IDhiYTViMTAuLmVjNGY4N2EgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2luc3BlY3Rvci9mb3JtYXR0aW5nL2Zvcm1hdHRpbmctamF2YXNjcmlwdC5odG1sCisr KyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9mb3JtYXR0aW5nL2Zvcm1hdHRpbmctamF2YXNjcmlw dC5odG1sCkBAIC0yNyw2ICsyNyw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAicmVzb3Vy Y2VzL2phdmFzY3JpcHQtdGVzdHMvc2FtcGxlLW5vcm1hbC11dGlsaXRpZXMuanMiLAogICAgICAg ICAicmVzb3VyY2VzL2phdmFzY3JpcHQtdGVzdHMvc2FtcGxlLXdlYmluc3BlY3Rvci1vYmplY3Qu anMiLAogICAgICAgICAicmVzb3VyY2VzL2phdmFzY3JpcHQtdGVzdHMvc3dpdGNoLWNhc2UtZGVm YXVsdC5qcyIsCisgICAgICAgICJyZXNvdXJjZXMvamF2YXNjcmlwdC10ZXN0cy90ZW1wbGF0ZS1z dHJpbmdzLmpzIiwKICAgICAgICAgInJlc291cmNlcy9qYXZhc2NyaXB0LXRlc3RzL3Rlcm5hcnkt ZXhwcmVzc2lvbnMuanMiLAogICAgICAgICAicmVzb3VyY2VzL2phdmFzY3JpcHQtdGVzdHMvdGhy b3ctc3RhdGVtZW50LmpzIiwKICAgICAgICAgInJlc291cmNlcy9qYXZhc2NyaXB0LXRlc3RzL3Ry eS1jYXRjaC1maW5hbGx5LXN0YXRlbWVudHMuanMiLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2Zvcm1hdHRpbmcvcmVzb3VyY2VzL2phdmFzY3JpcHQtdGVzdHMvdGVtcGxhdGUt c3RyaW5ncy1leHBlY3RlZC5qcyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9mb3JtYXR0aW5nL3Jl c291cmNlcy9qYXZhc2NyaXB0LXRlc3RzL3RlbXBsYXRlLXN0cmluZ3MtZXhwZWN0ZWQuanMKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2M1NjA2YgotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9mb3JtYXR0aW5nL3Jlc291cmNlcy9qYXZhc2NyaXB0 LXRlc3RzL3RlbXBsYXRlLXN0cmluZ3MtZXhwZWN0ZWQuanMKQEAgLTAsMCArMSwxMCBAQAorYHRl bXBsYXRlIHN0cmluZ2AKK2AkezEgKyAxfWAKK2AkezEgKyAxfWAKK2BiZWZvcmUgJHsxICsgMX0g YWZ0ZXJgCitgYmVmb3JlICR7YG5lc3RlZCAkezEgKyAxfWB9IGFmdGVyYAorYGJlZm9yZSAke2Bu ZXN0ZWQgJHsxICsgMX1gfSBhZnRlcmAKKwordGFnYHRhZ2dlZCB0ZW1wbGF0ZSBzdHJpbmdgCit0 YWdgdGFnZ2VkIHRlbXBsYXRlIHN0cmluZ2AKK3RhZ2BiZWZvcmUgJHsxICsgMX0gYWZ0ZXJgCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZm9ybWF0dGluZy9yZXNvdXJjZXMvamF2 YXNjcmlwdC10ZXN0cy90ZW1wbGF0ZS1zdHJpbmdzLmpzIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2Zvcm1hdHRpbmcvcmVzb3VyY2VzL2phdmFzY3JpcHQtdGVzdHMvdGVtcGxhdGUtc3RyaW5ncy5q cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi44Y2M1ZDE2Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Zvcm1hdHRpbmcvcmVzb3VyY2VzL2phdmFz Y3JpcHQtdGVzdHMvdGVtcGxhdGUtc3RyaW5ncy5qcwpAQCAtMCwwICsxLDEwIEBACitgdGVtcGxh dGUgc3RyaW5nYAorYCR7MSsxfWAKK2AkeyAgMSAgKyAgMSAgfWAKK2BiZWZvcmUgJHsxKzF9IGFm dGVyYAorYGJlZm9yZSAke2BuZXN0ZWQgJHsxKzF9YH0gYWZ0ZXJgCitgYmVmb3JlICR7YG5lc3Rl ZCAkezErMX1gfSBhZnRlcmAKKwordGFnYHRhZ2dlZCB0ZW1wbGF0ZSBzdHJpbmdgCit0YWcgYHRh Z2dlZCB0ZW1wbGF0ZSBzdHJpbmdgIAordGFnYGJlZm9yZSAkezErMX0gYWZ0ZXJgCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwppbmRleCBjOWUwMjBkLi5iMmI1MzhkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0wNC0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBhIEphdmFTY3Jp cHQgRm9ybWF0dGluZyB0ZXN0IGZvciB0ZW1wbGF0ZSBzdHJpbmdzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY2MDAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRvb2xzL0Zvcm1hdHRpbmcvaW5kZXgu aHRtbDoKKwogMjAxNi0wNC0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogV2ViIEluc3BlY3RvcjogUmVtb3RlIGluc3Bl Y3RvciBkb2Vzbid0IHdvcmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Ub29s cy9Gb3JtYXR0aW5nL2luZGV4Lmh0bWwgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVG9vbHMvRm9y bWF0dGluZy9pbmRleC5odG1sCmluZGV4IGM0MGU1NmQuLjQyMTgyNjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Ub29scy9Gb3JtYXR0aW5nL2luZGV4Lmh0bWwKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1Rvb2xzL0Zvcm1hdHRpbmcvaW5kZXguaHRtbApAQCAtNjEsNiAr NjEsNyBAQAogICAgICAgICAiZ2VuZXJhdG9ycy5qcyIsCiAgICAgICAgICJjb21tZW50cy1hbmQt cHJlc2VydmUtbmV3bGluZXMuanMiLAogICAgICAgICAiY29tbWVudHMtb25seS5qcyIsCisgICAg ICAgICJ0ZW1wbGF0ZS1zdHJpbmdzLmpzIiwKICAgICAgICAgInNhbXBsZS13ZWJpbnNwZWN0b3It b2JqZWN0LmpzIiwKICAgICAgICAgInNhbXBsZS1ub3JtYWwtdXRpbGl0aWVzLmpzIiwKICAgICAg ICAgInNhbXBsZS1qcXVlcnkuanMiLAo=