15659 2007-10-24 04:05:06 -0700 InlineTextBox does not setStrokeStyle() as needed 2009-02-23 12:15:06 -0800 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) All All RESOLVED FIXED P2 Normal --- 1 alp webkit-unassigned oleg.sukhodolsky oldest_to_newest 59326 0 alp 2007-10-24 04:05:06 -0700 InlineTextBox should setStrokeStyle(SolidStroke) where appropriate, otherwise the old StrokeStyle will be used when drawing underlines for text. Due to a bug in GraphicsContextCG (which fills rectangles to draw line strokes), this bug does not affect CG graphics, but does affect GraphicsContextCairo. 59327 1 16834 alp 2007-10-24 04:07:11 -0700 Created attachment 16834 Call context->setStrokeStyle(SolidStroke) I've just added context->setStrokeStyle(SolidStroke) in a few places as proof of concept. This may not cover all cases, and needs testing against the Mac port. 110616 2 manyoso 2009-02-23 12:15:06 -0800 This was fixed with r41152 I believe although the workaround in GraphicsContextCairo should probably be removed. 16834 2007-10-24 04:07:11 -0700 2007-10-24 04:07:11 -0700 Call context->setStrokeStyle(SolidStroke) text-box.patch text/plain 1232 alp SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCShyZXZpc2lvbiAyNjk0OSkKKysr IFdlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MDUsNiArMjA1LDggQEAKICAgICBpZiAobW9kZSAmIGNUZXh0RmlsbCAmJiBmaWxsQ29sb3IgIT0g Y29udGV4dC0+ZmlsbENvbG9yKCkpCiAgICAgICAgIGNvbnRleHQtPnNldEZpbGxDb2xvcihmaWxs Q29sb3IpOwogCisgICAgY29udGV4dC0+c2V0U3Ryb2tlU3R5bGUoU29saWRTdHJva2UpOworCiAg ICAgaWYgKG1vZGUgJiBjVGV4dFN0cm9rZSkgewogICAgICAgICBpZiAoc3Ryb2tlQ29sb3IgIT0g Y29udGV4dC0+c3Ryb2tlQ29sb3IoKSkKICAgICAgICAgICAgIGNvbnRleHQtPnNldFN0cm9rZUNv bG9yKHN0cm9rZUNvbG9yKTsKQEAgLTU1Nyw2ICs1NTksNyBAQAogICAgIAogICAgIC8vIFVzZSBh IHNwZWNpYWwgZnVuY3Rpb24gZm9yIHVuZGVybGluZXMgdG8gZ2V0IHRoZSBwb3NpdGlvbmluZyBl eGFjdGx5IHJpZ2h0LgogICAgIGJvb2wgaXNQcmludGluZyA9IHRleHRPYmplY3QoKS0+ZG9jdW1l bnQoKS0+cHJpbnRpbmcoKTsKKyAgICBjb250ZXh0LT5zZXRTdHJva2VTdHlsZShTb2xpZFN0cm9r ZSk7CiAgICAgY29udGV4dC0+c2V0U3Ryb2tlVGhpY2tuZXNzKDEuMGYpOyAvLyBGSVhNRTogV2Ug c2hvdWxkIGltcHJvdmUgdGhpcyBydWxlIGFuZCBub3QgYWx3YXlzIGp1c3QgYXNzdW1lIDEuCiAg ICAgaWYgKGRlY28gJiBVTkRFUkxJTkUpIHsKICAgICAgICAgY29udGV4dC0+c2V0U3Ryb2tlQ29s b3IodW5kZXJsaW5lKTsKQEAgLTc2Myw2ICs3NjYsNyBAQAogICAgICAgICBsaW5lVGhpY2tuZXNz ID0gMjsKIAogICAgIGN0eC0+c2V0U3Ryb2tlQ29sb3IodW5kZXJsaW5lLmNvbG9yKTsKKyAgICBj dHgtPnNldFN0cm9rZVN0eWxlKFNvbGlkU3Ryb2tlKTsKICAgICBjdHgtPnNldFN0cm9rZVRoaWNr bmVzcyhsaW5lVGhpY2tuZXNzKTsKICAgICBjdHgtPmRyYXdMaW5lRm9yVGV4dChJbnRQb2ludCh0 eCArIHN0YXJ0LCB0eSArIG1faGVpZ2h0IC0gbGluZVRoaWNrbmVzcyksIHdpZHRoLCB0ZXh0T2Jq ZWN0KCktPmRvY3VtZW50KCktPnByaW50aW5nKCkpOwogfQo=